From 01cf5d3e9d42317d027d3be09744a3f2058cb9a3 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Wolfgang=20Hu=C3=9F?= <wolle.huss@pjannto.com>
Date: Fri, 27 Sep 2019 09:11:08 +0200
Subject: [PATCH] Add logic for hover and little delay for open menu if not
 updated

---
 .../NotificationMenu/NotificationMenu.vue     | 87 +++++++++++++------
 webapp/constants/notifications.js             |  4 +-
 2 files changed, 62 insertions(+), 29 deletions(-)

diff --git a/webapp/components/notifications/NotificationMenu/NotificationMenu.vue b/webapp/components/notifications/NotificationMenu/NotificationMenu.vue
index 5413d8edd..cbf3c7a38 100644
--- a/webapp/components/notifications/NotificationMenu/NotificationMenu.vue
+++ b/webapp/components/notifications/NotificationMenu/NotificationMenu.vue
@@ -1,37 +1,37 @@
 <template>
-  <div
-    v-if="totalNotificationsCount === 0"
-    class="notifications-menu-pointer"
-    @click.prevent="updateNotifications"
-  >
-    <ds-button class="notifications-menu" disabled icon="bell">
-      {{ unreadNotificationsCount }}
-    </ds-button>
-  </div>
-  <dropdown v-else class="notifications-menu" :placement="placement">
-    <template slot="default" slot-scope="{ toggleMenu }">
-      <ds-button
-        primary
-        icon="bell"
-        @click.prevent="
-          updateNotifications()
-          toggleMenu()
-        "
-      >
+  <div class="notifications-menu-pointer" @mouseover="hoverActive" @mouseleave="hover = false">
+    <!-- Wolle <div
+      v-if="totalNotificationsCount === 0"
+      class="notifications-menu-pointer"
+      @click.prevent="updateNotifications"
+    > -->
+    <div v-if="totalNotificationsCount === 0" class="notifications-menu-pointer" @click.prevent="">
+      <ds-button class="notifications-menu" disabled icon="bell">
         {{ unreadNotificationsCount }}
       </ds-button>
-    </template>
-    <template slot="popover">
-      <div class="notifications-menu-popover">
-        <notification-list :notifications="displayedNotifications" @markAsRead="markAsRead" />
-      </div>
-    </template>
-  </dropdown>
+    </div>
+    <dropdown v-else class="notifications-menu" :placement="placement">
+      <template slot="default" slot-scope="{ toggleMenu }">
+        <ds-button primary icon="bell" @click.prevent="callToggleMenu(toggleMenu)">
+          {{ unreadNotificationsCount }}
+        </ds-button>
+      </template>
+      <template slot="popover">
+        <div class="notifications-menu-popover">
+          <notification-list :notifications="displayedNotifications" @markAsRead="markAsRead" />
+        </div>
+      </template>
+    </dropdown>
+  </div>
 </template>
 
 <script>
 import Dropdown from '~/components/Dropdown'
-import { NOTIFICATIONS_POLL_INTERVAL } from '~/constants/notifications'
+import {
+  NOTIFICATIONS_POLL_INTERVAL,
+  NOTIFICATIONS_UPDATE_CHECK_INTERVAL,
+  NOTIFICATIONS_MENU_OPEN_LATEST_INTERVAL,
+} from '~/constants/notifications'
 import { notificationQuery, markAsReadMutation } from '~/graphql/User'
 import NotificationList from '../NotificationList/NotificationList'
 
@@ -45,13 +45,21 @@ export default {
     return {
       displayedNotifications: [],
       notifications: [],
+      updateOn: false,
+      updateTicks: 0,
+      updateMenuReference: null,
+      hover: false,
     }
   },
   props: {
     placement: { type: String },
   },
   methods: {
-    async updateNotifications() {
+    updateNotifications() {
+      if (this.updateOn) return
+
+      console.log('hover updateNotifications')
+      this.updateOn = true
       try {
         this.$apollo.queries.notifications.refetch()
       } catch (err) {
@@ -75,6 +83,28 @@ export default {
         throw new Error(err)
       }
     },
+    hoverActive() {
+      if (this.hover) return
+
+      this.hover = true
+      this.updateNotifications()
+    },
+    callToggleMenu(toggleMenu) {
+      // Wolle this.updateNotifications()
+      if (this.updateMenuReference) return
+
+      this.updateTicks = 0
+      this.updateMenuReference = setInterval(() => {
+        console.log('check for update: ', this.updateOn, this.updateTicks)
+
+        if (!this.updateOn || NOTIFICATIONS_MENU_OPEN_LATEST_INTERVAL <= this.updateTicks) {
+          console.log('toggleMenu')
+          toggleMenu()
+          clearInterval(this.updateMenuReference)
+          this.updateMenuReference = null
+        } else this.updateTicks += NOTIFICATIONS_UPDATE_CHECK_INTERVAL
+      }, NOTIFICATIONS_UPDATE_CHECK_INTERVAL)
+    },
     equalNotification(a, b) {
       return a.from.id === b.from.id && a.createdAt === b.createdAt && a.reason === b.reason
     },
@@ -106,6 +136,7 @@ export default {
           return !this.displayedNotifications.find(oldN => this.equalNotification(newN, oldN))
         })
         this.displayedNotifications = newNotifications.concat(this.displayedNotifications)
+        this.updateOn = false
         return data.notifications
       },
     },
diff --git a/webapp/constants/notifications.js b/webapp/constants/notifications.js
index 3e88e7b92..8e9974ce0 100644
--- a/webapp/constants/notifications.js
+++ b/webapp/constants/notifications.js
@@ -1 +1,3 @@
-export const NOTIFICATIONS_POLL_INTERVAL = '60000'
+export const NOTIFICATIONS_POLL_INTERVAL = 60000
+export const NOTIFICATIONS_UPDATE_CHECK_INTERVAL = 100
+export const NOTIFICATIONS_MENU_OPEN_LATEST_INTERVAL = 2000