IT4Change/Ocelot-Social
3
0
Fork 0
mirror of https://github.com/IT4Change/Ocelot-Social.git synced 2025-12-13 07:45:56 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix bug UpdateComment, Fix styling on Comment

Browse Source 
- There was a bug that updates to comments were not being displayed
because of a v-show... https://vuejs.org/v2/guide/conditional.html#v-if-vs-v-show
Basically, what it says that is important for this bug is
"v-if...ensures that event listeners and child components inside the
conditional block are properly destroyed and re-created during toggles"

- Since we are using the editor to display comments in ContentViewer, we
need to set the min-height to 0px

- Co-authored-by: Alina Beck <alina.beck@mail.com>
- Co-authored-by: Robert Schäfer <git@roschaefer.de>
This commit is contained in:
mattwr18 2019-09-25 13:39:18 +02:00
parent db9810b436
commit 0f40df7cb4
2 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
webapp/components/Comment/Comment.vue
View File

@ -11,7 +11,7 @@
</div> </div>
<div v-else :class="{ comment: true, 'disabled-content': comment.deleted || comment.disabled }"> <div v-else :class="{ comment: true, 'disabled-content': comment.deleted || comment.disabled }">
<ds-card :id="`commentId-${comment.id}`"> <ds-card :id="`commentId-${comment.id}`">
<ds-space margin-bottom="small" margin-top="base"> <ds-space margin-bottom="small" margin-top="small">
<hc-user :user="author" :date-time="comment.createdAt" /> <hc-user :user="author" :date-time="comment.createdAt" />
<!-- Content Menu (can open Modals) --> <!-- Content Menu (can open Modals) -->
<client-only> <client-only>
@ -37,7 +37,7 @@
@collapse="isCollapsed = true" @collapse="isCollapsed = true"
/> />
</div> </div>
<div v-show="!openEditCommentMenu"> <div v-else>
<content-viewer <content-viewer
v-if="$filters.removeHtml(comment.content).length < 180" v-if="$filters.removeHtml(comment.content).length < 180"
:content="comment.content" :content="comment.content"

4
webapp/pages/post/_id/_slug/index.vue
View File

@ -189,6 +189,10 @@ export default {
margin-top: $space-small; margin-top: $space-small;
position: relative; position: relative;
} }
.ProseMirror {
min-height: 0px;
}
} }
.ds-card-image { .ds-card-image {