From 0fca14a29e1a1c33334edb2ad848cc92ce0ef4de Mon Sep 17 00:00:00 2001 From: roschaefer Date: Thu, 5 Sep 2019 11:52:19 +0200 Subject: [PATCH] Fix nullpointer issues It seems that `this.$apollo.queries.Post` can be undefined sometimes. Honestly I don't know why but I could imagine that it might happen on subpages and when the cypress test triggers the infinite loader, we face this bug. --- webapp/pages/index.vue | 11 ++++------- webapp/pages/profile/_id/_slug.vue | 5 ++++- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/webapp/pages/index.vue b/webapp/pages/index.vue index e34a22373..09270f936 100644 --- a/webapp/pages/index.vue +++ b/webapp/pages/index.vue @@ -125,12 +125,6 @@ export default { return this.$apollo.loading || (this.posts && this.posts.length > 0) }, }, - watch: { - postsFilter() { - this.offset = 0 - this.posts = [] - }, - }, methods: { toggleOnlySorting(x) { this.offset = 0 @@ -149,8 +143,11 @@ export default { }).href }, showMoreContributions() { + const { Post: PostQuery } = this.$apollo.queries + if (!PostQuery) return // seems this can be undefined on subpages + this.offset += this.pageSize - this.$apollo.queries.Post.fetchMore({ + PostQuery.fetchMore({ variables: { offset: this.offset, filter: this.finalFilters, diff --git a/webapp/pages/profile/_id/_slug.vue b/webapp/pages/profile/_id/_slug.vue index 996d4477d..edefe6be0 100644 --- a/webapp/pages/profile/_id/_slug.vue +++ b/webapp/pages/profile/_id/_slug.vue @@ -363,8 +363,11 @@ export default { this.$apollo.queries.User.refetch() }, showMoreContributions() { + const { Post: PostQuery } = this.$apollo.queries + if (!PostQuery) return // seems this can be undefined on subpages + this.offset += this.pageSize - this.$apollo.queries.Post.fetchMore({ + PostQuery.fetchMore({ variables: { offset: this.offset, filter: this.filter,