From 1b84ccbdfac06672e3ce7793434b67a8f8235871 Mon Sep 17 00:00:00 2001 From: Matt Rider Date: Mon, 29 Apr 2019 12:19:27 -0300 Subject: [PATCH] Update to allow single character comments or greater --- backend/src/resolvers/comments.js | 4 ++-- backend/src/resolvers/comments.spec.js | 8 ++++---- webapp/components/CommentForm/index.vue | 2 +- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/backend/src/resolvers/comments.js b/backend/src/resolvers/comments.js index 899338644..97b99f4ab 100644 --- a/backend/src/resolvers/comments.js +++ b/backend/src/resolvers/comments.js @@ -1,7 +1,7 @@ import { neo4jgraphql } from 'neo4j-graphql-js' import { UserInputError } from 'apollo-server' -const COMMENT_MIN_LENGTH = 3 +const COMMENT_MIN_LENGTH = 1 export default { Query: { CommentByPost: async (object, params, context, resolveInfo) => { @@ -28,7 +28,7 @@ export default { const content = params.content.replace(/<(?:.|\n)*?>/gm, '').trim() if (!params.content || content.length < COMMENT_MIN_LENGTH) { - throw new UserInputError(`Comment must be at least ${COMMENT_MIN_LENGTH} characters long!`) + throw new UserInputError(`Comment must be at least ${COMMENT_MIN_LENGTH} character long!`) } const { postId } = params delete params.postId diff --git a/backend/src/resolvers/comments.spec.js b/backend/src/resolvers/comments.spec.js index eb4e39633..34a18d807 100644 --- a/backend/src/resolvers/comments.spec.js +++ b/backend/src/resolvers/comments.spec.js @@ -65,17 +65,17 @@ describe('CreateComment', () => { } await expect(client.request(mutation, variables)) - .rejects.toThrow('Comment must be at least 3 characters long!') + .rejects.toThrow('Comment must be at least 1 character long!') }) - it('throws an error if a comment is less than 3 characters', async () => { + it('throws an error if a comment does not contain a single character', async () => { variables = { postId: 'p1', - content: '

ab

' + content: '

' } await expect(client.request(mutation, variables)) - .rejects.toThrow('Comment must be at least 3 characters long!') + .rejects.toThrow('Comment must be at least 1 character long!') }) }) }) diff --git a/webapp/components/CommentForm/index.vue b/webapp/components/CommentForm/index.vue index 3c73300c2..fdb1761dc 100644 --- a/webapp/components/CommentForm/index.vue +++ b/webapp/components/CommentForm/index.vue @@ -64,7 +64,7 @@ export default { methods: { updateEditorContent(value) { const content = value.replace(/<(?:.|\n)*?>/gm, '').trim() - if (content.length < 3) { + if (content.length < 1) { this.disabled = true } else { this.disabled = false