Refactor shout/unshout mutations

- Remove unrecommended auto-commit transactions from code base
- Favor transaction functions

backend/src/schema/resolvers/shout.js

@@ -1,3 +1,5 @@
+import log from './helpers/databaseLogger'
+
 export default {
   Mutation: {
     shout: async (_object, params, context, _resolveInfo) => {
@@ -5,22 +7,24 @@ export default {
 
       const session = context.driver.session()
       try {
-        const transactionRes = await session.run(
+        const shoutWriteTxResultPromise = session.writeTransaction(async transaction => {
-          `MATCH (node {id: $id})<-[:WROTE]-(userWritten:User), (user:User {id: $userId})
+          const shoutTransactionResponse = await transaction.run(
-          WHERE $type IN labels(node) AND NOT userWritten.id = $userId
+            `
-          MERGE (user)-[relation:SHOUTED{createdAt:toString(datetime())}]->(node)
+              MATCH (node {id: $id})<-[:WROTE]-(userWritten:User), (user:User {id: $userId})
-          RETURN COUNT(relation) > 0 as isShouted`,
+              WHERE $type IN labels(node) AND NOT userWritten.id = $userId
-          {
+              MERGE (user)-[relation:SHOUTED{createdAt:toString(datetime())}]->(node)
-            id,
+              RETURN COUNT(relation) > 0 as isShouted
-            type,
+            `,
-            userId: context.user.id,
+            {
-          },
+              id,
-        )
+              type,
-
+              userId: context.user.id,
-        const [isShouted] = transactionRes.records.map(record => {
+            },
-          return record.get('isShouted')
+          )
+          log(shoutTransactionResponse)
+          return shoutTransactionResponse.records.map(record => record.get('isShouted'))
         })
-
+        const [isShouted] = await shoutWriteTxResultPromise
         return isShouted
       } finally {
         session.close()
@@ -31,20 +35,24 @@ export default {
       const { id, type } = params
       const session = context.driver.session()
       try {
-        const transactionRes = await session.run(
+        const unshoutWriteTxResultPromise = session.writeTransaction(async transaction => {
-          `MATCH (user:User {id: $userId})-[relation:SHOUTED]->(node {id: $id})
+          const unshoutTransactionResponse = await transaction.run(
-          WHERE $type IN labels(node)
+            `
-          DELETE relation
+              MATCH (user:User {id: $userId})-[relation:SHOUTED]->(node {id: $id})
-          RETURN COUNT(relation) > 0 as isShouted`,
+              WHERE $type IN labels(node)
-          {
+              DELETE relation
-            id,
+              RETURN COUNT(relation) > 0 as isShouted
-            type,
+            `,
-            userId: context.user.id,
+            {
-          },
+              id,
-        )
+              type,
-        const [isShouted] = transactionRes.records.map(record => {
+              userId: context.user.id,
-          return record.get('isShouted')
+            },
+          )
+          log(unshoutTransactionResponse)
+          return unshoutTransactionResponse.records.map(record => record.get('isShouted'))
         })
+        const [isShouted] = await unshoutWriteTxResultPromise
         return isShouted
       } finally {
         session.close()