From 8e7a9644c0014a03fdbd4cd557e40ab8cb57e3ff Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Robert=20Sch=C3=A4fer?= Date: Sat, 8 Dec 2018 12:40:34 +0100 Subject: [PATCH 1/2] Split development config from production config in `docker-compose.yml` and `docker-compose.override.yml`. This should speed up builds e.g. on Travis CI, which does not need to sync folders or run `yarn run dev` if the docker image was built recently. Also it should make the build more reliable as it behaves more similar to our deployment. --- docker-compose.override.yml | 11 +++++++++++ docker-compose.yml | 8 ++------ 2 files changed, 13 insertions(+), 6 deletions(-) create mode 100644 docker-compose.override.yml diff --git a/docker-compose.override.yml b/docker-compose.override.yml new file mode 100644 index 000000000..1f35305b6 --- /dev/null +++ b/docker-compose.override.yml @@ -0,0 +1,11 @@ +version: '3.7' + +services: + webapp: + volumes: + - .:/HC-WebApp + - node_modules:/HC-WebApp/node_modules + command: yarn run dev + +volumes: + node_modules: diff --git a/docker-compose.yml b/docker-compose.yml index af6ad1cb7..f7c697889 100644 --- a/docker-compose.yml +++ b/docker-compose.yml @@ -2,17 +2,13 @@ version: '3.7' services: webapp: - build: - context: . + image: humanconnection/nitro-web:latest + build: . ports: - 3000:3000 - 8080:8080 networks: - hc-network - volumes: - - .:/HC-WebApp - - node_modules:/HC-WebApp/node_modules - command: yarn run dev environment: - HOST=0.0.0.0 - BACKEND_URL=http://backend:4000 From 7f389e493917ce1ef5f055d9e92e51dd3bd3a85a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Robert=20Sch=C3=A4fer?= Date: Sat, 8 Dec 2018 15:44:20 +0100 Subject: [PATCH 2/2] Fix wrong folder name --- docker-compose.override.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docker-compose.override.yml b/docker-compose.override.yml index 1f35305b6..bf4d42841 100644 --- a/docker-compose.override.yml +++ b/docker-compose.override.yml @@ -3,8 +3,8 @@ version: '3.7' services: webapp: volumes: - - .:/HC-WebApp - - node_modules:/HC-WebApp/node_modules + - .:/nitro-web + - node_modules:/nitro-web/node_modules command: yarn run dev volumes: