fix migrations (#8390)

async migrations should not call next() Co-authored-by: mahula <lenzmath@posteo.de>
2025-12-12 23:35:52 +00:00 · 2025-04-16 11:08:30 +02:00 · 2025-04-16 11:08:30 +02:00 · 5d154bcb85
commit 5d154bcb85
parent 3ff328ff2f
14 changed files with 2 additions and 31 deletions
--- a/backend/src/db/migrate/template.ts
+++ b/backend/src/db/migrate/template.ts
@ -11,7 +11,6 @@ export async function up(next) {
    // Implement your migration here.
    await transaction.run(``)
    await transaction.commit()
-    next()
  } catch (error) {
    // eslint-disable-next-line no-console
    console.log(error)
@ -33,7 +32,6 @@ export async function down(next) {
    // Implement your migration here.
    await transaction.run(``)
    await transaction.commit()
-    next()
  } catch (error) {
    // eslint-disable-next-line no-console
    console.log(error)
--- a/backend/src/db/migrations/1613589876420-null_mutation.ts
+++ b/backend/src/db/migrations/1613589876420-null_mutation.ts
@ -1,9 +1,5 @@
 'use strict'

-export async function up(next) {
-  next()
-}
+export async function up(next) {}

-export async function down(next) {
-  next()
-}
+export async function down(next) {}
--- a/backend/src/db/migrations/1614023644903-add-clickedCount-to-posts.ts
+++ b/backend/src/db/migrations/1614023644903-add-clickedCount-to-posts.ts
@ -15,7 +15,6 @@ export async function up(next) {
        SET p.clickedCount = 0
    `)
    await transaction.commit()
-    next()
  } catch (error) {
    // eslint-disable-next-line no-console
    console.log(error)
@ -39,7 +38,6 @@ export async function down(next) {
        REMOVE p.clickedCount
    `)
    await transaction.commit()
-    next()
  } catch (error) {
    // eslint-disable-next-line no-console
    console.log(error)
--- a/backend/src/db/migrations/1614177130817-add-viewedTeaserCount-to-posts.ts
+++ b/backend/src/db/migrations/1614177130817-add-viewedTeaserCount-to-posts.ts
@ -15,7 +15,6 @@ export async function up(next) {
        SET p.viewedTeaserCount = 0
    `)
    await transaction.commit()
-    next()
  } catch (error) {
    // eslint-disable-next-line no-console
    console.log(error)
@ -39,7 +38,6 @@ export async function down(next) {
        REMOVE p.viewedTeaserCount
    `)
    await transaction.commit()
-    next()
  } catch (error) {
    // eslint-disable-next-line no-console
    console.log(error)
--- a/backend/src/db/migrations/20210506150512-add-donations-node.ts
+++ b/backend/src/db/migrations/20210506150512-add-donations-node.ts
@ -27,7 +27,6 @@ export async function up(next) {
      { donationId },
    )
    await transaction.commit()
-    next()
  } catch (error) {
    // eslint-disable-next-line no-console
    console.log(error)
@ -53,7 +52,6 @@ export async function down(next) {
        RETURN donationInfo
    `)
    await transaction.commit()
-    next()
  } catch (error) {
    // eslint-disable-next-line no-console
    console.log(error)
--- a/backend/src/db/migrations/20210923140939-add-sendNotificationEmails-property-to-all-users.ts
+++ b/backend/src/db/migrations/20210923140939-add-sendNotificationEmails-property-to-all-users.ts
@ -17,7 +17,6 @@ export async function up(next) {
      `,
    )
    await transaction.commit()
-    next()
  } catch (error) {
    // eslint-disable-next-line no-console
    console.log(error)
@ -45,7 +44,6 @@ export async function down(next) {
      `,
    )
    await transaction.commit()
-    next()
  } catch (error) {
    // eslint-disable-next-line no-console
    console.log(error)
--- a/backend/src/db/migrations/20220803060819-create_fulltext_indices_and_unique_keys_for_groups.ts
+++ b/backend/src/db/migrations/20220803060819-create_fulltext_indices_and_unique_keys_for_groups.ts
@ -26,7 +26,6 @@ export async function up(next) {
    `)
    */
    await transaction.commit()
-    next()
  } catch (error) {
    // eslint-disable-next-line no-console
    console.log(error)
@ -59,7 +58,6 @@ export async function down(next) {
    `)
    await transaction.commit()
    */
-    next()
  } catch (error) {
    // eslint-disable-next-line no-console
    console.log(error)
--- a/backend/src/db/migrations/20230320130345-fulltext-search-indexes.ts
+++ b/backend/src/db/migrations/20230320130345-fulltext-search-indexes.ts
@ -34,7 +34,6 @@ export async function up(next) {
    )
    await transaction.commit()
    */
-    next()
  } catch (error) {
    // eslint-disable-next-line no-console
    console.log(error)
@ -60,7 +59,6 @@ export async function down(next) {
    await transaction.run(`CALL db.index.fulltext.drop("tag_fulltext_search")`)
    await transaction.commit()
    */
-    next()
  } catch (error) {
    // eslint-disable-next-line no-console
    console.log(error)
--- a/backend/src/db/migrations/20230329150329-article-label-for-posts.ts
+++ b/backend/src/db/migrations/20230329150329-article-label-for-posts.ts
@ -14,7 +14,6 @@ export async function up(next) {
      RETURN post
    `)
    await transaction.commit()
-    next()
  } catch (error) {
    // eslint-disable-next-line no-console
    console.log(error)
@ -39,7 +38,6 @@ export async function down(next) {
      RETURN post
    `)
    await transaction.commit()
-    next()
  } catch (error) {
    // eslint-disable-next-line no-console
    console.log(error)
--- a/backend/src/db/migrations/20230608130637-add-postType-property.ts
+++ b/backend/src/db/migrations/20230608130637-add-postType-property.ts
@ -14,7 +14,6 @@ export async function up(next) {
      RETURN post
    `)
    await transaction.commit()
-    next()
  } catch (error) {
    // eslint-disable-next-line no-console
    console.log(error)
@ -39,7 +38,6 @@ export async function down(next) {
      RETURN post
    `)
    await transaction.commit()
-    next()
  } catch (error) {
    // eslint-disable-next-line no-console
    console.log(error)
--- a/backend/src/db/migrations/20231017141022-fix-event-dates.ts
+++ b/backend/src/db/migrations/20231017141022-fix-event-dates.ts
@ -34,7 +34,6 @@ export async function up(next) {
      `)
    }
    await transaction.commit()
-    next()
  } catch (error) {
    // eslint-disable-next-line no-console
    console.log(error)
@ -54,7 +53,6 @@ export async function down(next) {

  try {
    // No sense in running this down
-    next()
  } catch (error) {
    // eslint-disable-next-line no-console
    console.log(error)
--- a/backend/src/db/migrations/20250331130323-author-observes-own-post.ts
+++ b/backend/src/db/migrations/20250331130323-author-observes-own-post.ts
@ -21,7 +21,6 @@ export async function up(next) {
      RETURN post
    `)
    await transaction.commit()
-    next()
  } catch (error) {
    // eslint-disable-next-line no-console
    console.log(error)
@ -47,7 +46,6 @@ export async function down(next) {
      RETURN p
    `)
    await transaction.commit()
-    next()
  } catch (error) {
    // eslint-disable-next-line no-console
    console.log(error)
--- a/backend/src/db/migrations/20250331140313-commenter-observes-post.ts
+++ b/backend/src/db/migrations/20250331140313-commenter-observes-post.ts
@ -21,7 +21,6 @@ export async function up(next) {
      RETURN post
    `)
    await transaction.commit()
-    next()
  } catch (error) {
    // eslint-disable-next-line no-console
    console.log(error)
@ -48,7 +47,6 @@ export async function down(next) {
      RETURN p
    `)
    await transaction.commit()
-    next()
  } catch (error) {
    // eslint-disable-next-line no-console
    console.log(error)
--- a/backend/src/db/migrations/20250405030454-email-notification-settings.ts
+++ b/backend/src/db/migrations/20250405030454-email-notification-settings.ts
@ -22,7 +22,6 @@ export async function up(next) {
      REMOVE user.sendNotificationEmails
    `)
    await transaction.commit()
-    next()
  } catch (error) {
    // eslint-disable-next-line no-console
    console.log(error)