From 7b0209b484ec43a4922edbe4fd659c9f993e0467 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Wolfgang=20Hu=C3=9F?= <wolle.huss@pjannto.com>
Date: Thu, 18 Nov 2021 09:37:37 +0100
Subject: [PATCH] Test e-mail templates, finish signupTemplate

---
 .../helpers/email/templateBuilder.spec.js     | 28 +++++++++++--------
 1 file changed, 17 insertions(+), 11 deletions(-)

diff --git a/backend/src/middleware/helpers/email/templateBuilder.spec.js b/backend/src/middleware/helpers/email/templateBuilder.spec.js
index 459a87b3d..3761ccc8a 100644
--- a/backend/src/middleware/helpers/email/templateBuilder.spec.js
+++ b/backend/src/middleware/helpers/email/templateBuilder.spec.js
@@ -9,9 +9,10 @@ import {
 } from './templateBuilder'
 
 const welcomeImageUrl = new URL(logosWebapp.LOGO_WELCOME_PATH, CONFIG.CLIENT_URI)
+const supportUrl = CONFIG.SUPPORT_URL
 let actionUrl, name, settingsUrl
 
-const signupTemplateData = (_locale) => ({
+const signupTemplateData = () => ({
   email: 'test@example.org',
   variables: {
     nonce: '12345',
@@ -26,7 +27,7 @@ const notificationTemplateData = (locale) => ({
     },
   },
 })
-const testEmailData = (emailTemplate, templateBuilder, templateData, _locale, individuals) => {
+const testEmailData = (emailTemplate, templateBuilder, templateData, individuals) => {
   if (!emailTemplate) {
     emailTemplate = templateBuilder(templateData)
   }
@@ -39,13 +40,18 @@ const testEmailData = (emailTemplate, templateBuilder, templateData, _locale, in
   if (individuals.name) {
     expect(emailTemplate.html).toEqual(expect.stringContaining(individuals.name))
   }
-  expect(emailTemplate.html).toEqual(expect.stringContaining(individuals.actionUrl.toString()))
+  if (individuals.actionUrl) {
+    expect(emailTemplate.html).toEqual(expect.stringContaining(individuals.actionUrl.toString()))
+  }
   expect(emailTemplate.html).toEqual(expect.stringContaining(CONFIG.ORGANIZATION_URL))
   expect(emailTemplate.html).toEqual(expect.stringContaining(CONFIG.APPLICATION_NAME))
   if (individuals.settingsUrl) {
     expect(emailTemplate.html).toEqual(expect.stringContaining(individuals.settingsUrl.toString()))
   }
   expect(emailTemplate.html).toEqual(expect.stringContaining(individuals.content))
+  if (individuals.supportUrl) {
+    expect(emailTemplate.html).toEqual(expect.stringContaining(individuals.supportUrl.toString()))
+  }
   return emailTemplate
 }
 
@@ -63,19 +69,19 @@ describe('templateBuilder', () => {
       it('e-mail is build with all data', () => {
         const actionUrl = new URL('/registration', CONFIG.CLIENT_URI)
         const theSignupTemplateData = signupTemplateData()
-
+        // locale: en
         let content = "Thank you for joining our cause – it's awesome to have you on board."
-        const emailTemplate = testEmailData(null, signupTemplate, theSignupTemplateData, 'en', {
+        const emailTemplate = testEmailData(null, signupTemplate, theSignupTemplateData, {
           actionUrl,
           content,
+          supportUrl,
         })
-
+        // locale: de
         content = 'Danke, dass Du dich angemeldet hast – wir freuen uns, Dich dabei zu haben.'
-        testEmailData(emailTemplate, signupTemplate, theSignupTemplateData, 'de', {
-          actionUrl,
+        testEmailData(emailTemplate, signupTemplate, theSignupTemplateData, {
           content,
         })
-
+        // test additional
         expect(emailTemplate.html).toEqual(
           expect.stringContaining(theSignupTemplateData.variables.nonce),
         )
@@ -106,7 +112,7 @@ describe('templateBuilder', () => {
       it('e-mail is build with all data', () => {
         const subject = `${CONFIG.APPLICATION_NAME} – Notification`
         const content = 'You received at least one notification. Click on this button to view them:'
-        testEmailData(null, notificationTemplate, notificationTemplateData('en'), 'en', {
+        testEmailData(null, notificationTemplate, notificationTemplateData('en'), {
           subject,
           actionUrl,
           name,
@@ -120,7 +126,7 @@ describe('templateBuilder', () => {
       it('e-mail is build with all data', async () => {
         const subject = `${CONFIG.APPLICATION_NAME} – Benachrichtigung`
         const content = `Du hast mindestens eine Benachrichtigung erhalten. Klick auf diesen Button, um sie anzusehen:`
-        testEmailData(null, notificationTemplate, notificationTemplateData('de'), 'de', {
+        testEmailData(null, notificationTemplate, notificationTemplateData('de'), {
           subject,
           actionUrl,
           name,