From 2f9b338d3a841a1c7e340c6f262354a2fc356ece Mon Sep 17 00:00:00 2001 From: "dependabot-preview[bot]" Date: Mon, 3 Jun 2019 22:32:19 +0000 Subject: [PATCH 001/105] Bump tiptap from 1.20.1 to 1.21.0 in /webapp Bumps [tiptap](https://github.com/scrumpy/tiptap) from 1.20.1 to 1.21.0. - [Release notes](https://github.com/scrumpy/tiptap/releases) - [Commits](https://github.com/scrumpy/tiptap/compare/tiptap@1.20.1...tiptap@1.21.0) --- webapp/package.json | 2 +- webapp/yarn.lock | 39 ++++----------------------------------- 2 files changed, 5 insertions(+), 36 deletions(-) diff --git a/webapp/package.json b/webapp/package.json index a06ff5c7d..0c82bef0e 100644 --- a/webapp/package.json +++ b/webapp/package.json @@ -69,7 +69,7 @@ "nuxt-env": "~0.1.0", "stack-utils": "^1.0.2", "string-hash": "^1.1.3", - "tiptap": "1.20.1", + "tiptap": "1.21.0", "tiptap-extensions": "1.20.2", "v-tooltip": "~2.0.2", "vue-count-to": "~1.0.13", diff --git a/webapp/yarn.lock b/webapp/yarn.lock index 1d9fe2e7e..46a25db85 100644 --- a/webapp/yarn.lock +++ b/webapp/yarn.lock @@ -9014,7 +9014,7 @@ prosemirror-state@^1.0.0, prosemirror-state@^1.2.2, prosemirror-state@^1.2.3: prosemirror-model "^1.0.0" prosemirror-transform "^1.0.0" -prosemirror-tables@^0.8.0, prosemirror-tables@^0.8.1: +prosemirror-tables@^0.8.1: version "0.8.1" resolved "https://registry.yarnpkg.com/prosemirror-tables/-/prosemirror-tables-0.8.1.tgz#ea99ad4effec99dd4e2fdb0b33cce4d2547eed83" integrity sha512-6eY8I+NkyrXAQ1gmYkKo7XDLZaj0iGutdc/zT0+VMY15IzgBINwcRP62+miaCTuneLTKufMYzfUB37NjGJaetw== @@ -9032,17 +9032,12 @@ prosemirror-transform@^1.0.0, prosemirror-transform@^1.1.0, prosemirror-transfor dependencies: prosemirror-model "^1.0.0" -prosemirror-utils@^0.8.2: - version "0.8.2" - resolved "https://registry.yarnpkg.com/prosemirror-utils/-/prosemirror-utils-0.8.2.tgz#e0e4a47cd45b1cff3d84464446d9f92adf4a558b" - integrity sha512-jNIj3/eREx4x2FU6pFEUDmdVmtoRBuLA6JTjgNum/84Nf+Ns+Y9l0Q//R8EL/Qm/5J5xTg5/s+hmQkXaHY+ilA== - prosemirror-utils@^0.9.0: version "0.9.0" resolved "https://registry.yarnpkg.com/prosemirror-utils/-/prosemirror-utils-0.9.0.tgz#3ab616c94ccd61fcb18968f0d5aa273a9f1f28e4" integrity sha512-YcvmHcq7phbn+OagJSvmne92qZG9dOVfb3zfuA1HuyWUif3hUDt2Yfu299BHqVkEkUCF6FN7Gi9folDQntMhxA== -prosemirror-view@^1.0.0, prosemirror-view@^1.1.0, prosemirror-view@^1.9.6, prosemirror-view@^1.9.8: +prosemirror-view@^1.0.0, prosemirror-view@^1.1.0, prosemirror-view@^1.9.8: version "1.9.8" resolved "https://registry.yarnpkg.com/prosemirror-view/-/prosemirror-view-1.9.8.tgz#47b961204a0b2e8ff87370c270d4f82598e81273" integrity sha512-yS4yrqxydvi7ddz9VFLeJgbfVd5g3/bMcRxb1PbWtG0i9OrPSsiHaEBJHLVeTbraGqRlAu+tbNLakO7RhUhp1w== @@ -10562,7 +10557,7 @@ tippy.js@^4.3.1: dependencies: popper.js "^1.14.7" -tiptap-commands@^1.10.5, tiptap-commands@^1.10.6: +tiptap-commands@^1.10.6: version "1.10.6" resolved "https://registry.yarnpkg.com/tiptap-commands/-/tiptap-commands-1.10.6.tgz#46f972aacbc8d175248ab7ed7e6183ebc6cc72ed" integrity sha512-62GrTo3Mmev3AmN0rFDa0gzUFQyN9yTjpuH6xMTo0OqMx6iTluqxdiROB2Hc+9qVCHj6qFwJIG4t8jPrYiuKuw== @@ -10593,16 +10588,6 @@ tiptap-extensions@1.20.2: tiptap "^1.21.0" tiptap-commands "^1.10.6" -tiptap-utils@^1.5.3: - version "1.5.3" - resolved "https://registry.yarnpkg.com/tiptap-utils/-/tiptap-utils-1.5.3.tgz#7d4518a84eb6bfb10c98b19c901ca59123865f61" - integrity sha512-025uF1acJ7jLuA9dnKIxp8TQelyQ0uJqtT1jlziT8UslwZT5pKzwDsNkadFbnEBp6O9wfLZH0TuUtAUDmuq0VA== - dependencies: - prosemirror-model "^1.7.0" - prosemirror-state "^1.2.3" - prosemirror-tables "^0.8.0" - prosemirror-utils "^0.8.2" - tiptap-utils@^1.5.4: version "1.5.4" resolved "https://registry.yarnpkg.com/tiptap-utils/-/tiptap-utils-1.5.4.tgz#c64b65d305ee70793376c9cec1da242ebf6e1884" @@ -10613,23 +10598,7 @@ tiptap-utils@^1.5.4: prosemirror-tables "^0.8.1" prosemirror-utils "^0.9.0" -tiptap@1.20.1: - version "1.20.1" - resolved "https://registry.yarnpkg.com/tiptap/-/tiptap-1.20.1.tgz#d10fd0cd73a96bbb1f2d581da02ceda38fa8695b" - integrity sha512-uVGxPknq+cQH0G8yyCHvo8p3jPMLZMnkLeFjcrTyiY9PXl6XsSJwOjtIg4GXnIyCcfz2jWI5mhJGzCD26cdJGA== - dependencies: - prosemirror-commands "^1.0.8" - prosemirror-dropcursor "^1.1.1" - prosemirror-gapcursor "^1.0.3" - prosemirror-inputrules "^1.0.4" - prosemirror-keymap "^1.0.1" - prosemirror-model "^1.7.0" - prosemirror-state "^1.2.3" - prosemirror-view "^1.9.6" - tiptap-commands "^1.10.5" - tiptap-utils "^1.5.3" - -tiptap@^1.21.0: +tiptap@1.21.0, tiptap@^1.21.0: version "1.21.0" resolved "https://registry.yarnpkg.com/tiptap/-/tiptap-1.21.0.tgz#4d8c1365c611e41c8d4f3d7aa195ddaf891e605b" integrity sha512-MoOj/8OPMlmoAotIZjAIlUZ59yMMR83xReOw2rGjqbFOooncoY1rLEBp0xz5oe5FLYqoe8dKb+kzOoFERqckVQ== From 8cd62078f2cf90313a82ab0c245ff271bad65958 Mon Sep 17 00:00:00 2001 From: Matt Rider Date: Tue, 4 Jun 2019 21:24:02 -0300 Subject: [PATCH 002/105] Start DeleteAccount functionality --- .../DeleteAccount/DeleteAccount.vue | 71 +++++++++++++++++++ webapp/locales/en.json | 2 +- webapp/pages/settings.vue | 12 ++-- webapp/pages/settings/delete-account.vue | 8 +-- 4 files changed, 80 insertions(+), 13 deletions(-) create mode 100644 webapp/components/DeleteAccount/DeleteAccount.vue diff --git a/webapp/components/DeleteAccount/DeleteAccount.vue b/webapp/components/DeleteAccount/DeleteAccount.vue new file mode 100644 index 000000000..b73142a52 --- /dev/null +++ b/webapp/components/DeleteAccount/DeleteAccount.vue @@ -0,0 +1,71 @@ + + + diff --git a/webapp/locales/en.json b/webapp/locales/en.json index 8330f97b2..3520f0d56 100644 --- a/webapp/locales/en.json +++ b/webapp/locales/en.json @@ -71,7 +71,7 @@ "name": "Download Data" }, "delete": { - "name": "Delete Account" + "name": "Delete my User Account" }, "organizations": { "name": "My Organizations" diff --git a/webapp/pages/settings.vue b/webapp/pages/settings.vue index f6745cdf3..a273b8b63 100644 --- a/webapp/pages/settings.vue +++ b/webapp/pages/settings.vue @@ -1,8 +1,6 @@ diff --git a/webapp/pages/profile/_id/_slug.vue b/webapp/pages/profile/_id/_slug.vue index c92cdae52..49d76f252 100644 --- a/webapp/pages/profile/_id/_slug.vue +++ b/webapp/pages/profile/_id/_slug.vue @@ -12,13 +12,12 @@ > - + @@ -241,7 +240,6 @@ import HcEmpty from '~/components/Empty.vue' import ContentMenu from '~/components/ContentMenu' import HcUpload from '~/components/Upload' import HcAvatar from '~/components/Avatar/Avatar.vue' -import PostMutationHelpers from '~/mixins/PostMutationHelpers' export default { components: { @@ -256,7 +254,6 @@ export default { ContentMenu, HcUpload, }, - mixins: [PostMutationHelpers], transition: { name: 'slide-up', mode: 'out-in', @@ -267,35 +264,6 @@ export default { voted: false, page: 1, pageSize: 6, - modalsData: { - delete: { - titel: () => { - this.$t('delete.contribution.title') - }, - message: () => { - const name = this.$filters.truncate(this.name, 30) - return this.$t(`delete.contribution.message`, { name }) - }, - buttons: { - confirm: { - icon: 'trash', - text: () => { - this.$t('delete.submit') - }, - callback: this.deletePostCallback, - }, - cancel: { - icon: 'close', - text: () => { - this.$t('delete.cancel') - }, - callback: () => {}, - }, - }, - }, - disableCallbacks: { confirmCallback: () => {}, cancelCallback: () => {} }, - reportCallbacks: { confirmCallback: () => {}, cancelCallback: () => {} }, - }, } }, computed: { From 70aa77bd2eb8b5d9a390ee4cfb7a4bce3e533f15 Mon Sep 17 00:00:00 2001 From: Matt Rider Date: Fri, 7 Jun 2019 13:37:59 -0300 Subject: [PATCH 017/105] Get user deletion working from UI --- .../DeleteAccount/DeleteAccount.vue | 41 +++++++++++++++---- webapp/locales/en.json | 3 +- webapp/pages/post/_id/_slug/index.vue | 6 +-- 3 files changed, 37 insertions(+), 13 deletions(-) diff --git a/webapp/components/DeleteAccount/DeleteAccount.vue b/webapp/components/DeleteAccount/DeleteAccount.vue index dd03da648..d7e102d28 100644 --- a/webapp/components/DeleteAccount/DeleteAccount.vue +++ b/webapp/components/DeleteAccount/DeleteAccount.vue @@ -59,7 +59,12 @@ - + {{ $t('settings.delete.name') }} @@ -71,6 +76,7 @@ diff --git a/webapp/components/PostHelpers.js b/webapp/components/PostHelpers.js new file mode 100644 index 000000000..df2064bfc --- /dev/null +++ b/webapp/components/PostHelpers.js @@ -0,0 +1,42 @@ +import gql from 'graphql-tag' + +export default { + postMenuModalsData: (postNameShort, confirmCallback) => { + return { + delete: { + titleIdent: 'delete.contribution.title', + messageIdent: 'delete.contribution.message', + messageParams: { + name: postNameShort, + }, + buttons: { + confirm: { + icon: 'trash', + textIdent: 'delete.submit', + callback: confirmCallback, + }, + cancel: { + icon: 'close', + textIdent: 'delete.cancel', + callback: () => {}, + }, + }, + }, + } + }, + deletePostMutationData(postId) { + var gqlMutation = gql` + mutation($id: ID!) { + DeletePost(id: $id) { + id + } + } + ` + return { + mutation: gqlMutation, + variables: { + id: postId, + }, + } + }, +} diff --git a/webapp/mixins/PostMutationHelpers.js b/webapp/mixins/PostMutationHelpers.js deleted file mode 100644 index 68e4c73b8..000000000 --- a/webapp/mixins/PostMutationHelpers.js +++ /dev/null @@ -1,61 +0,0 @@ -import gql from 'graphql-tag' - -export default { - data() { - return { - menuModalsData: { - delete: { - titleIdent: 'delete.contribution.title', - messageIdent: 'delete.contribution.message', - messageParams: { - // "this.post" is not defined at the beginning … - name: this.post ? this.$filters.truncate(this.post.title, 30) : '', - }, - buttons: { - confirm: { - icon: 'trash', - textIdent: 'delete.submit', - callback: this.deletePostCallback, - }, - cancel: { - icon: 'close', - textIdent: 'delete.cancel', - callback: () => {}, - }, - }, - }, - }, - } - }, - methods: { - async deletePostCallback(postDisplayType = 'list') { - try { - var gqlMutation = gql` - mutation($id: ID!) { - DeletePost(id: $id) { - id - } - } - ` - await this.$apollo.mutate({ - mutation: gqlMutation, - variables: { - id: this.post.id, - }, - }) - this.$toast.success(this.$t('delete.contribution.success')) - switch (postDisplayType) { - case 'list': - this.$emit('deletePost') - break - default: - // case 'page': - this.$router.history.push('/') // Single page type: Redirect to index (main) page - break - } - } catch (err) { - this.$toast.error(err.message) - } - }, - }, -} diff --git a/webapp/pages/post/_id/_slug/index.spec.js b/webapp/pages/post/_id/_slug/index.spec.js index 5bf4ea168..8a073ac6e 100644 --- a/webapp/pages/post/_id/_slug/index.spec.js +++ b/webapp/pages/post/_id/_slug/index.spec.js @@ -56,7 +56,7 @@ describe('PostSlug', () => { beforeEach(jest.useFakeTimers) - describe('test mixin "PostMutationHelpers"', () => { + describe('test "PostHelpers"', () => { beforeEach(() => { wrapper = Wrapper() wrapper.setData({ diff --git a/webapp/pages/post/_id/_slug/index.vue b/webapp/pages/post/_id/_slug/index.vue index 4d703ff7e..63b0713c5 100644 --- a/webapp/pages/post/_id/_slug/index.vue +++ b/webapp/pages/post/_id/_slug/index.vue @@ -13,7 +13,7 @@ placement="bottom-end" resource-type="contribution" :resource="post" - :modalsData="menuModalsDataPage()" + :modalsData="menuModalsData" :is-owner="isAuthor(post.author.id)" /> @@ -71,7 +71,7 @@ import HcUser from '~/components/User' import HcShoutButton from '~/components/ShoutButton.vue' import HcCommentForm from '~/components/comments/CommentForm' import HcCommentList from '~/components/comments/CommentList' -import PostMutationHelpers from '~/mixins/PostMutationHelpers' +import PostHelpers from '~/components/PostHelpers' export default { name: 'PostSlug', @@ -88,7 +88,6 @@ export default { HcCommentForm, HcCommentList, }, - mixins: [PostMutationHelpers], head() { return { title: this.title, @@ -210,14 +209,27 @@ export default { this.ready = true }, 50) }, + computed: { + // "this.post" may not always be defined at the beginning … + menuModalsData() { + return PostHelpers.postMenuModalsData( + this.post ? this.$filters.truncate(this.post.title, 30) : '', + this.deletePostCallback, + ) + }, + }, methods: { isAuthor(id) { return this.$store.getters['auth/user'].id === id }, - menuModalsDataPage() { - const locMenuModalsData = this.menuModalsData - locMenuModalsData.delete.buttons.confirm.callback = () => this.deletePostCallback('page') - return locMenuModalsData + async deletePostCallback() { + try { + await this.$apollo.mutate(PostHelpers.deletePostMutationData(this.post.id)) + this.$toast.success(this.$t('delete.contribution.success')) + this.$router.history.push('/') // Redirect to index (main) page + } catch (err) { + this.$toast.error(err.message) + } }, }, } diff --git a/webapp/pages/profile/_id/_slug.spec.js b/webapp/pages/profile/_id/_slug.spec.js index d79f9b885..ddebe50f6 100644 --- a/webapp/pages/profile/_id/_slug.spec.js +++ b/webapp/pages/profile/_id/_slug.spec.js @@ -46,7 +46,7 @@ describe('ProfileSlug', () => { beforeEach(jest.useFakeTimers) - describe('test mixin "PostMutationHelpers"', () => { + describe('test "PostHelpers"', () => { beforeEach(() => { wrapper = Wrapper() }) @@ -60,7 +60,7 @@ describe('ProfileSlug', () => { beforeEach(jest.runAllTimers) it('emits "deletePost"', () => { - expect(wrapper.emitted().deletePost.length).toBe(1) + expect(wrapper.emitted().deletePost).toHaveLength(1) }) it('does not go to index (main) page', () => { From ebe951f05ba350f46c04447070f8f151375311f5 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Robert=20Sch=C3=A4fer?= Date: Wed, 12 Jun 2019 10:43:44 +0200 Subject: [PATCH 045/105] Update tiptap to 1.21.0 --- webapp/package.json | 2 +- webapp/yarn.lock | 37 +++++++++++-------------------------- 2 files changed, 12 insertions(+), 27 deletions(-) diff --git a/webapp/package.json b/webapp/package.json index e230839f5..7662a1f7a 100644 --- a/webapp/package.json +++ b/webapp/package.json @@ -69,7 +69,7 @@ "nuxt-env": "~0.1.0", "stack-utils": "^1.0.2", "string-hash": "^1.1.3", - "tiptap": "1.20.1", + "tiptap": "1.21.0", "tiptap-extensions": "1.21.0", "v-tooltip": "~2.0.2", "vue-count-to": "~1.0.13", diff --git a/webapp/yarn.lock b/webapp/yarn.lock index dc5df4b79..c85e962d7 100644 --- a/webapp/yarn.lock +++ b/webapp/yarn.lock @@ -9020,7 +9020,7 @@ prosemirror-state@^1.0.0, prosemirror-state@^1.2.2, prosemirror-state@^1.2.3: prosemirror-model "^1.0.0" prosemirror-transform "^1.0.0" -prosemirror-tables@^0.8.0, prosemirror-tables@^0.8.1: +prosemirror-tables@^0.8.1: version "0.8.1" resolved "https://registry.yarnpkg.com/prosemirror-tables/-/prosemirror-tables-0.8.1.tgz#ea99ad4effec99dd4e2fdb0b33cce4d2547eed83" integrity sha512-6eY8I+NkyrXAQ1gmYkKo7XDLZaj0iGutdc/zT0+VMY15IzgBINwcRP62+miaCTuneLTKufMYzfUB37NjGJaetw== @@ -9038,17 +9038,12 @@ prosemirror-transform@^1.0.0, prosemirror-transform@^1.1.0, prosemirror-transfor dependencies: prosemirror-model "^1.0.0" -prosemirror-utils@^0.8.2: - version "0.8.2" - resolved "https://registry.yarnpkg.com/prosemirror-utils/-/prosemirror-utils-0.8.2.tgz#e0e4a47cd45b1cff3d84464446d9f92adf4a558b" - integrity sha512-jNIj3/eREx4x2FU6pFEUDmdVmtoRBuLA6JTjgNum/84Nf+Ns+Y9l0Q//R8EL/Qm/5J5xTg5/s+hmQkXaHY+ilA== - prosemirror-utils@^0.9.0: version "0.9.0" resolved "https://registry.yarnpkg.com/prosemirror-utils/-/prosemirror-utils-0.9.0.tgz#3ab616c94ccd61fcb18968f0d5aa273a9f1f28e4" integrity sha512-YcvmHcq7phbn+OagJSvmne92qZG9dOVfb3zfuA1HuyWUif3hUDt2Yfu299BHqVkEkUCF6FN7Gi9folDQntMhxA== -prosemirror-view@^1.0.0, prosemirror-view@^1.1.0, prosemirror-view@^1.9.6, prosemirror-view@^1.9.8: +prosemirror-view@^1.0.0, prosemirror-view@^1.1.0, prosemirror-view@^1.9.8: version "1.9.8" resolved "https://registry.yarnpkg.com/prosemirror-view/-/prosemirror-view-1.9.8.tgz#47b961204a0b2e8ff87370c270d4f82598e81273" integrity sha512-yS4yrqxydvi7ddz9VFLeJgbfVd5g3/bMcRxb1PbWtG0i9OrPSsiHaEBJHLVeTbraGqRlAu+tbNLakO7RhUhp1w== @@ -10568,7 +10563,7 @@ tippy.js@^4.3.2: dependencies: popper.js "^1.14.7" -tiptap-commands@^1.10.5, tiptap-commands@^1.10.7: +tiptap-commands@^1.10.6, tiptap-commands@^1.10.7: version "1.10.7" resolved "https://registry.yarnpkg.com/tiptap-commands/-/tiptap-commands-1.10.7.tgz#c177f875e8a90e05171fdd441190b4b7a769bd27" integrity sha512-Ij62dHkYvOFUcaj+xlbahhoqcY8bFIEho6fXKrxcjjtGzS2DyJnvXmWN6Ow65uZWXkf5Zf8ae6XnYNaKqP3Pyg== @@ -10599,17 +10594,7 @@ tiptap-extensions@1.21.0: tiptap "^1.21.1" tiptap-commands "^1.10.7" -tiptap-utils@^1.5.3: - version "1.5.3" - resolved "https://registry.yarnpkg.com/tiptap-utils/-/tiptap-utils-1.5.3.tgz#7d4518a84eb6bfb10c98b19c901ca59123865f61" - integrity sha512-025uF1acJ7jLuA9dnKIxp8TQelyQ0uJqtT1jlziT8UslwZT5pKzwDsNkadFbnEBp6O9wfLZH0TuUtAUDmuq0VA== - dependencies: - prosemirror-model "^1.7.0" - prosemirror-state "^1.2.3" - prosemirror-tables "^0.8.0" - prosemirror-utils "^0.8.2" - -tiptap-utils@^1.5.5: +tiptap-utils@^1.5.4, tiptap-utils@^1.5.5: version "1.5.5" resolved "https://registry.yarnpkg.com/tiptap-utils/-/tiptap-utils-1.5.5.tgz#f06c70f0319d9215433b3466b6ece369a078de0f" integrity sha512-lnaCmIIkyK050qfsPeMDjoTW0sTqBHxfw1h2GXaX5Nr6JF4VQe0izgf2MI6LCd3PKecJBoW4ce5lNkDpV99+WA== @@ -10619,10 +10604,10 @@ tiptap-utils@^1.5.5: prosemirror-tables "^0.8.1" prosemirror-utils "^0.9.0" -tiptap@1.20.1: - version "1.20.1" - resolved "https://registry.yarnpkg.com/tiptap/-/tiptap-1.20.1.tgz#d10fd0cd73a96bbb1f2d581da02ceda38fa8695b" - integrity sha512-uVGxPknq+cQH0G8yyCHvo8p3jPMLZMnkLeFjcrTyiY9PXl6XsSJwOjtIg4GXnIyCcfz2jWI5mhJGzCD26cdJGA== +tiptap@1.21.0: + version "1.21.0" + resolved "https://registry.yarnpkg.com/tiptap/-/tiptap-1.21.0.tgz#4d8c1365c611e41c8d4f3d7aa195ddaf891e605b" + integrity sha512-MoOj/8OPMlmoAotIZjAIlUZ59yMMR83xReOw2rGjqbFOooncoY1rLEBp0xz5oe5FLYqoe8dKb+kzOoFERqckVQ== dependencies: prosemirror-commands "^1.0.8" prosemirror-dropcursor "^1.1.1" @@ -10631,9 +10616,9 @@ tiptap@1.20.1: prosemirror-keymap "^1.0.1" prosemirror-model "^1.7.0" prosemirror-state "^1.2.3" - prosemirror-view "^1.9.6" - tiptap-commands "^1.10.5" - tiptap-utils "^1.5.3" + prosemirror-view "^1.9.8" + tiptap-commands "^1.10.6" + tiptap-utils "^1.5.4" tiptap@^1.21.1: version "1.21.1" From dba719ea1c8f0ef93fbca9a3c8dd570953febdd2 Mon Sep 17 00:00:00 2001 From: senderfm Date: Wed, 12 Jun 2019 12:54:33 +0200 Subject: [PATCH 046/105] english translation changes undone. --- webapp/locales/en.json | 2 +- webapp/locales/es.json | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/webapp/locales/en.json b/webapp/locales/en.json index fe17f7b48..54b9e598e 100644 --- a/webapp/locales/en.json +++ b/webapp/locales/en.json @@ -14,7 +14,7 @@ "hello": "Hello" }, "editor": { - "placeholder": "Write something inspiring..." + "placeholder": "Leave your inspirational thoughts..." }, "profile": { "name": "My Profile", diff --git a/webapp/locales/es.json b/webapp/locales/es.json index bdff69850..af9c21c3f 100644 --- a/webapp/locales/es.json +++ b/webapp/locales/es.json @@ -38,7 +38,7 @@ "failed": "no encontró nada" }, "settings": { - "name": "Ajustes", + "name": "Configuración", "data": { "name": "Sus datos", "labelName": "Su nombre", From 8eb089d21806aa04b745b57d94cb520e994f69c6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Wolfgang=20Hu=C3=9F?= Date: Wed, 12 Jun 2019 15:58:23 +0200 Subject: [PATCH 047/105] Rename event deletePost to removePostFromList Co-Authored-By: mattwr18 --- webapp/components/Modal/DeleteModal.spec.js | 2 +- webapp/components/PostCard/index.vue | 4 +- webapp/components/PostHelpers.js | 2 +- webapp/pages/index.vue | 2 +- webapp/pages/post/_id/_slug/index.vue | 2 +- webapp/pages/post/_id/_slug/more-info.vue | 23 +++---- webapp/pages/profile/_id/_slug.vue | 71 +++++++++++---------- 7 files changed, 52 insertions(+), 54 deletions(-) diff --git a/webapp/components/Modal/DeleteModal.spec.js b/webapp/components/Modal/DeleteModal.spec.js index c5e9df001..3401d5ba3 100644 --- a/webapp/components/Modal/DeleteModal.spec.js +++ b/webapp/components/Modal/DeleteModal.spec.js @@ -164,7 +164,7 @@ describe('DeleteModal.vue', () => { expect(propsData.callbacks.confirm).toHaveBeenCalledTimes(1) }) it('emits close', () => { - expect(wrapper.emitted().close).toBeTruthy() + expect(wrapper.emitted().close).toHaveLength(1) }) it('resets success', () => { diff --git a/webapp/components/PostCard/index.vue b/webapp/components/PostCard/index.vue index 96e1f5d72..383f879bd 100644 --- a/webapp/components/PostCard/index.vue +++ b/webapp/components/PostCard/index.vue @@ -103,8 +103,8 @@ export default { return this.user.id === this.post.author.id }, menuModalsData() { - // "this.post" may not always be defined at the beginning … return PostHelpers.postMenuModalsData( + // "this.post" may not always be defined at the beginning … this.post ? this.$filters.truncate(this.post.title, 30) : '', this.deletePostCallback, ) @@ -115,7 +115,7 @@ export default { try { await this.$apollo.mutate(PostHelpers.deletePostMutationData(this.post.id)) this.$toast.success(this.$t('delete.contribution.success')) - this.$emit('deletePost') + this.$emit('removePostFromList') } catch (err) { this.$toast.error(err.message) } diff --git a/webapp/components/PostHelpers.js b/webapp/components/PostHelpers.js index df2064bfc..4a30e6a22 100644 --- a/webapp/components/PostHelpers.js +++ b/webapp/components/PostHelpers.js @@ -1,7 +1,7 @@ import gql from 'graphql-tag' export default { - postMenuModalsData: (postNameShort, confirmCallback) => { + postMenuModalsData(postNameShort, confirmCallback) { return { delete: { titleIdent: 'delete.contribution.title', diff --git a/webapp/pages/index.vue b/webapp/pages/index.vue index d8becf206..10a64ee0f 100644 --- a/webapp/pages/index.vue +++ b/webapp/pages/index.vue @@ -9,7 +9,7 @@ :key="post.id" :post="post" :width="{ base: '100%', xs: '100%', md: '50%', xl: '33%' }" - @deletePost="deletePost(index, post.id)" + @removePostFromList="deletePost(index, post.id)" /> diff --git a/webapp/pages/post/_id/_slug/index.vue b/webapp/pages/post/_id/_slug/index.vue index 63b0713c5..899950514 100644 --- a/webapp/pages/post/_id/_slug/index.vue +++ b/webapp/pages/post/_id/_slug/index.vue @@ -210,9 +210,9 @@ export default { }, 50) }, computed: { - // "this.post" may not always be defined at the beginning … menuModalsData() { return PostHelpers.postMenuModalsData( + // "this.post" may not always be defined at the beginning … this.post ? this.$filters.truncate(this.post.title, 30) : '', this.deletePostCallback, ) diff --git a/webapp/pages/post/_id/_slug/more-info.vue b/webapp/pages/post/_id/_slug/more-info.vue index 1cb93ae6c..00de48730 100644 --- a/webapp/pages/post/_id/_slug/more-info.vue +++ b/webapp/pages/post/_id/_slug/more-info.vue @@ -1,13 +1,10 @@ - + Wer folgt {{ userName | truncate(15) }}? @@ -101,13 +102,14 @@ - + - - und {{ user.followedByCount - user.followedBy.length }} weitere - + und {{ user.followedByCount - user.followedBy.length }} weitere