From 80729394586e6923cde23f8480e75dd4d5dcedad Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Robert=20Sch=C3=A4fer?= Date: Wed, 6 Mar 2019 17:21:49 +0100 Subject: [PATCH] Tiny performance improvement --- src/resolvers/moderation.js | 4 ++-- src/resolvers/moderation.spec.js | 21 ++++++++------------- 2 files changed, 10 insertions(+), 15 deletions(-) diff --git a/src/resolvers/moderation.js b/src/resolvers/moderation.js index 10046dd03..db44790b9 100644 --- a/src/resolvers/moderation.js +++ b/src/resolvers/moderation.js @@ -17,8 +17,8 @@ export default { enable: async (object, params, { user, driver }) => { const { resource: { id } } = params const cypher = ` - MATCH (p {id: $id})<-[d:DISABLED]-() - SET p.disabled = false + MATCH (r {id: $id})<-[d:DISABLED]-() + SET r.disabled = false DELETE d ` const session = driver.session() diff --git a/src/resolvers/moderation.spec.js b/src/resolvers/moderation.spec.js index 6107074ef..c1d4a75fe 100644 --- a/src/resolvers/moderation.spec.js +++ b/src/resolvers/moderation.spec.js @@ -92,12 +92,10 @@ describe('disable', () => { setup.createResource = async () => { await factory.create('User', { id: 'u45', email: 'commenter@example.org', password: '1234' }) await factory.authenticateAs({ email: 'commenter@example.org', password: '1234' }) - await factory.create('Post', { - id: 'p3' - }) - await factory.create('Comment', { - id: 'c47' - }) + await Promise.all([ + factory.create('Post', { id: 'p3' }), + factory.create('Comment', { id: 'c47' }) + ]) await Promise.all([ factory.relate('Comment', 'Author', { from: 'u45', to: 'c47' }), factory.relate('Comment', 'Post', { from: 'c47', to: 'p3' }) @@ -251,13 +249,10 @@ describe('enable', () => { setup.createResource = async () => { await factory.create('User', { id: 'u123', email: 'author@example.org', password: '1234' }) await factory.authenticateAs({ email: 'author@example.org', password: '1234' }) - await factory.create('Post', { - id: 'p9' // that's the ID we will look for - }) - - await factory.create('Comment', { - id: 'c456' - }) + await Promise.all([ + factory.create('Post', { id: 'p9' }), + factory.create('Comment', { id: 'c456' }) + ]) await Promise.all([ factory.relate('Comment', 'Author', { from: 'u123', to: 'c456' }), factory.relate('Comment', 'Post', { from: 'c456', to: 'p9' })