From 932572049be2f1dbee246d5c49f7d417797b8d0d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Wolfgang=20Hu=C3=9F?= Date: Thu, 27 Oct 2022 12:27:51 +0200 Subject: [PATCH] Fix not correct working change of slug in group settings --- backend/src/middleware/sluggifyMiddleware.js | 8 +------- webapp/components/Group/GroupForm.vue | 4 ++-- 2 files changed, 3 insertions(+), 9 deletions(-) diff --git a/backend/src/middleware/sluggifyMiddleware.js b/backend/src/middleware/sluggifyMiddleware.js index 5ef2944be..bbe47c9aa 100644 --- a/backend/src/middleware/sluggifyMiddleware.js +++ b/backend/src/middleware/sluggifyMiddleware.js @@ -30,18 +30,12 @@ export default { args.slug = args.slug || (await uniqueSlug(args.name, isUniqueFor(context, 'Group'))) return resolve(root, args, context, info) }, - UpdateGroup: async (resolve, root, args, context, info) => { - if (args.name) { - args.slug = args.slug || (await uniqueSlug(args.name, isUniqueFor(context, 'Group'))) - } - return resolve(root, args, context, info) - }, CreatePost: async (resolve, root, args, context, info) => { args.slug = args.slug || (await uniqueSlug(args.title, isUniqueFor(context, 'Post'))) return resolve(root, args, context, info) }, UpdatePost: async (resolve, root, args, context, info) => { - // TODO: is this absolutely correct, see condition in 'UpdateGroup' above? may it works accidentally, because args.slug is always send? + // TODO: is this absolutely correct? what happens if "args.title" is not defined? may it works accidentally, because "args.title" or "args.slug" is always send? args.slug = args.slug || (await uniqueSlug(args.title, isUniqueFor(context, 'Post'))) return resolve(root, args, context, info) }, diff --git a/webapp/components/Group/GroupForm.vue b/webapp/components/Group/GroupForm.vue index 6604a56d5..7b0f7840c 100644 --- a/webapp/components/Group/GroupForm.vue +++ b/webapp/components/Group/GroupForm.vue @@ -333,10 +333,10 @@ export default { this.$refs.groupForm.update('description', value) }, submit() { - const { name, about, description, groupType, actionRadius, /* locationName, */ categoryIds } = - this.formData + const { name, slug, about, description, groupType, actionRadius, categoryIds } = this.formData const variables = { name, + slug, about, description, groupType,