From 8dff7496c0a3edb32d50755b0d625d4ec880260d Mon Sep 17 00:00:00 2001 From: roschaefer Date: Tue, 15 Oct 2019 14:17:36 +0200 Subject: [PATCH 01/10] refactor: create LoginForm component I moved most code in pages/login.vue to a separate LoginForm component. The intention is to have a separate vue storybook for the LoginForm component. --- webapp/components/LoginForm/LoginForm.vue | 129 ++++++++++++++++++++++ webapp/pages/login.vue | 121 +------------------- 2 files changed, 134 insertions(+), 116 deletions(-) create mode 100644 webapp/components/LoginForm/LoginForm.vue diff --git a/webapp/components/LoginForm/LoginForm.vue b/webapp/components/LoginForm/LoginForm.vue new file mode 100644 index 000000000..d72b5befe --- /dev/null +++ b/webapp/components/LoginForm/LoginForm.vue @@ -0,0 +1,129 @@ + + + + + diff --git a/webapp/pages/login.vue b/webapp/pages/login.vue index 971754870..e969fe46f 100644 --- a/webapp/pages/login.vue +++ b/webapp/pages/login.vue @@ -1,138 +1,27 @@ - - From fced9ce4353a7ef459c7a7f81df1024764a7cf27 Mon Sep 17 00:00:00 2001 From: roschaefer Date: Tue, 15 Oct 2019 14:19:26 +0200 Subject: [PATCH 02/10] refactor: remove `ready` quickfix in LoginForm According to the code comments this is a quick fix to avoid a visible re-arrangement of elements in the browser. To be honest: I would rather have the visible re-arrangement than this obscure quickfix. Everything that's visible and annoying will be fixed. Everything we just hide, we will forget. --- webapp/components/LoginForm/LoginForm.vue | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/webapp/components/LoginForm/LoginForm.vue b/webapp/components/LoginForm/LoginForm.vue index d72b5befe..0eb0d4be9 100644 --- a/webapp/components/LoginForm/LoginForm.vue +++ b/webapp/components/LoginForm/LoginForm.vue @@ -1,5 +1,5 @@