IT4Change/Ocelot-Social
3
0
Fork 0
mirror of https://github.com/IT4Change/Ocelot-Social.git synced 2025-12-13 07:45:56 +00:00
Code Issues Packages Projects Releases Wiki Activity

Change the behaviour how notifications get created

Browse Source 
I think it makes more sense to update an existing notification in place.
Ie. if there was already a notification, just mark it as unread so it
ends up in the recipient's notification list again.
This commit is contained in:
roschaefer 2019-08-30 10:40:53 +02:00
parent 66b12090a7
commit 994ab43950
1 changed files with 15 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
backend/src/middleware/notifications/notificationsMiddleware.spec.js
View File

@ -83,9 +83,11 @@ describe('notifications', () => {
from {
__typename
... on Post {
id
content
}
... on Comment {
id
content
}
}
@ -161,6 +163,7 @@ describe('notifications', () => {
reason: 'comment_on_post',
from: {
__typename: 'Comment',
id: 'c47',
content: commentContent,
},
},
@ -250,6 +253,7 @@ describe('notifications', () => {
reason: 'mentioned_in_post',
from: {
__typename: 'Post',
id: 'p47',
content: expectedContent,
},
},
@ -267,7 +271,7 @@ describe('notifications', () => {
).resolves.toEqual(expected)
})
describe('many times', () => {
describe('updates the post and mentions me again', () => {
const updatePostAction = async () => {
const updatedContent = `
One more mention to
@ -296,7 +300,7 @@ describe('notifications', () => {
authenticatedUser = await notifiedUser.toJson()
}
it('creates exactly one more notification', async () => {
it('creates no duplicate notification for the same resource', async () => {
await createPostAction()
await updatePostAction()
const expectedContent =
@ -309,14 +313,7 @@ describe('notifications', () => {
reason: 'mentioned_in_post',
from: {
__typename: 'Post',
content: expectedContent,
},
},
{
read: false,
reason: 'mentioned_in_post',
from: {
__typename: 'Post',
id: 'p47',
content: expectedContent,
},
},
@ -334,6 +331,13 @@ describe('notifications', () => {
})
})
describe('if the notification was marked as read earlier', () => {
describe('but the next mentioning happens after the notification was marked as read', () => {
it.todo('sets the `read` attribute to false again')
it.todo('updates the `createdAt` attribute')
})
})
describe('but the author of the post blocked me', () => {
beforeEach(async () => {
await postAuthor.relateTo(notifiedUser, 'blocked')
@ -386,6 +390,7 @@ describe('notifications', () => {
reason: 'mentioned_in_comment',
from: {
__typename: 'Comment',
id: 'c47',
content: commentContent,
},
},