From b4c92ec29afb551d80f747300e3bcc4972803c0f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Robert=20Sch=C3=A4fer?= Date: Sat, 8 Dec 2018 13:17:43 +0100 Subject: [PATCH] Remove xip.io hack After we proxy API requests through the server-side-rendered frontend there is no need to use xip.io anymore. However, if you "join" services to a named network at arbitrary times, the DNS of docker-compose only works if you assign a name to the container. Thus I left `backend` as a container name. --- docker-compose.override.yml | 1 - docker-compose.yml | 1 + 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/docker-compose.override.yml b/docker-compose.override.yml index 70e2fe389..ef8ce7706 100644 --- a/docker-compose.override.yml +++ b/docker-compose.override.yml @@ -2,7 +2,6 @@ version: "3.7" services: backend: - container_name: backend.127.0.0.1.xip.io volumes: - .:/nitro-backend - /nitro-backend/node_modules diff --git a/docker-compose.yml b/docker-compose.yml index 71ea7355c..311a34acc 100644 --- a/docker-compose.yml +++ b/docker-compose.yml @@ -2,6 +2,7 @@ version: "3.7" services: backend: + container_name: backend image: humanconnection/nitro-backend:latest build: . networks: