From b7ca8a426ba56240dea4ea4199fc205640fc1c56 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Robert=20Sch=C3=A4fer?= <git@roschaefer.de>
Date: Sun, 10 Mar 2019 13:38:17 +0100
Subject: [PATCH] Render modals in a closed state and hide

I found out that when you umount the modals completely you don't get the
nice hide effect of `<ds-modal>`. It should be safe to still have all
modals in the DOM.
---
 components/Modal.spec.js | 10 +++++-----
 components/Modal.vue     |  1 -
 2 files changed, 5 insertions(+), 6 deletions(-)

diff --git a/components/Modal.spec.js b/components/Modal.spec.js
index 799ab2a41..5c9d57c27 100644
--- a/components/Modal.spec.js
+++ b/components/Modal.spec.js
@@ -54,9 +54,9 @@ describe('Modal.vue', () => {
   describe('shallowMount', () => {
     const Wrapper = createWrapper(shallowMount)
 
-    it('renders nothing', () => {
+    it('renders all modals as closed', () => {
       wrapper = Wrapper()
-      expect(wrapper.isEmpty()).toBe(true)
+      expect(wrapper.find(DisableModal).vm.isOpen).toBe(false)
     })
 
     describe('store/modal holds data to disable', () => {
@@ -84,10 +84,10 @@ describe('Modal.vue', () => {
         })
       })
 
-      describe('click cancel', () => {
-        it('empties wrapper', () => {
+      describe('child component emits close', () => {
+        it('close DisableModal', () => {
           wrapper.find(DisableModal).vm.$emit('close')
-          expect(wrapper.isEmpty()).toBe(true)
+          expect(wrapper.find(DisableModal).vm.isOpen).toBe(false)
         })
       })
     })
diff --git a/components/Modal.vue b/components/Modal.vue
index 7b50ddd5d..e73c94ce2 100644
--- a/components/Modal.vue
+++ b/components/Modal.vue
@@ -1,7 +1,6 @@
 <template>
   <div class="modal-wrapper">
     <disable-modal
-      v-if="open === 'disable'"
       :is-open="open === 'disable'"
       :resource="data"
       @close="close"