From b8037b6e1f4098f4c02f7385b8c10c03cf53ec2d Mon Sep 17 00:00:00 2001 From: ogerly Date: Tue, 8 Oct 2019 20:29:41 +0200 Subject: [PATCH] fix lint --- .../schema/resolvers/embeds/findProvider.js | 5 +- .../components/Embed/EmbedComponent.spec.js | 112 +++++++++--------- 2 files changed, 56 insertions(+), 61 deletions(-) diff --git a/backend/src/schema/resolvers/embeds/findProvider.js b/backend/src/schema/resolvers/embeds/findProvider.js index 4742935b7..a4240895f 100644 --- a/backend/src/schema/resolvers/embeds/findProvider.js +++ b/backend/src/schema/resolvers/embeds/findProvider.js @@ -2,10 +2,7 @@ import fs from 'fs' import path from 'path' import minimatch from 'minimatch' -let oEmbedProvidersFile = fs.readFileSync( - path.join(__dirname, './providers.json'), - 'utf8', -) +let oEmbedProvidersFile = fs.readFileSync(path.join(__dirname, './providers.json'), 'utf8') // some providers allow a format parameter // we need JSON diff --git a/webapp/components/Embed/EmbedComponent.spec.js b/webapp/components/Embed/EmbedComponent.spec.js index b4fbe6a60..0f7c6f4e1 100644 --- a/webapp/components/Embed/EmbedComponent.spec.js +++ b/webapp/components/Embed/EmbedComponent.spec.js @@ -68,8 +68,6 @@ describe('EmbedComponent.vue', () => { selector: '.embed-preview-image--clickable', }) }) - - }) describe('given a href with embed html', () => { @@ -94,67 +92,67 @@ describe('EmbedComponent.vue', () => { ) }) - describe('onEmbed returned embed data with html', () => { - beforeEach(() => { - propsData.embedData = { - __typename: 'Embed', - type: 'video', - title: 'Baby Loves Cat', - author: 'Merkley Family', - publisher: 'YouTube', - date: '2015-08-16T00:00:00.000Z', - description: - 'She’s incapable of controlling her limbs when her kitty is around. The obsession grows every day. Ps. That’s a sleep sack she’s in. Not a starfish outfit. Al...', - url: someUrl, - image: 'https://i.ytimg.com/vi/qkdXAtO40Fo/maxresdefault.jpg', - audio: null, - video: null, - lang: 'de', - sources: ['resource', 'oembed'], - html: - '', - } - wrapper = Wrapper({ propsData }) - }) + describe('onEmbed returned embed data with html', () => { + beforeEach(() => { + propsData.embedData = { + __typename: 'Embed', + type: 'video', + title: 'Baby Loves Cat', + author: 'Merkley Family', + publisher: 'YouTube', + date: '2015-08-16T00:00:00.000Z', + description: + 'She’s incapable of controlling her limbs when her kitty is around. The obsession grows every day. Ps. That’s a sleep sack she’s in. Not a starfish outfit. Al...', + url: someUrl, + image: 'https://i.ytimg.com/vi/qkdXAtO40Fo/maxresdefault.jpg', + audio: null, + video: null, + lang: 'de', + sources: ['resource', 'oembed'], + html: + '', + } + wrapper = Wrapper({ propsData }) + }) - it('shows a simple link when a user closes the embed preview', () => { - wrapper.find('.embed-close-button').trigger('click') - expect(wrapper.vm.showLinkOnly).toBe(true) - }) + it('shows a simple link when a user closes the embed preview', () => { + wrapper.find('.embed-close-button').trigger('click') + expect(wrapper.vm.showLinkOnly).toBe(true) + }) - it('opens the data privacy overlay when a user clicks on the preview image', () => { - wrapper.find('.embed-preview-image--clickable').trigger('click') - expect(wrapper.vm.showOverlay).toBe(true) - }) + it('opens the data privacy overlay when a user clicks on the preview image', () => { + wrapper.find('.embed-preview-image--clickable').trigger('click') + expect(wrapper.vm.showOverlay).toBe(true) + }) - it("click show iframe, but don't select to change setting permanetly", () => { - wrapper.setData({ showOverlay: true }) - wrapper.find('.ds-button-primary').trigger('click') - expect(wrapper.vm.showEmbed).toBe(true) - expect(wrapper.vm.checkedAlwaysAllowEmbeds).toBe(false) - }) + it("click show iframe, but don't select to change setting permanetly", () => { + wrapper.setData({ showOverlay: true }) + wrapper.find('.ds-button-primary').trigger('click') + expect(wrapper.vm.showEmbed).toBe(true) + expect(wrapper.vm.checkedAlwaysAllowEmbeds).toBe(false) + }) - it('click show iframe and change setting permanetly', () => { - wrapper.setData({ showOverlay: true }) - wrapper.find('input[type=checkbox]').trigger('click') - wrapper.find('.ds-button-primary').trigger('click') - expect(wrapper.vm.showEmbed).toBe(true) - expect(wrapper.vm.checkedAlwaysAllowEmbeds).toBe(true) - }) + it('click show iframe and change setting permanetly', () => { + wrapper.setData({ showOverlay: true }) + wrapper.find('input[type=checkbox]').trigger('click') + wrapper.find('.ds-button-primary').trigger('click') + expect(wrapper.vm.showEmbed).toBe(true) + expect(wrapper.vm.checkedAlwaysAllowEmbeds).toBe(true) + }) - it('click cancel do not show iframe', () => { - wrapper.setData({ showOverlay: true }) - wrapper.find('.ds-button-ghost').trigger('click') - expect(wrapper.vm.showOverlay).toBe(false) - expect(wrapper.vm.showEmbed).toBe(false) - }) + it('click cancel do not show iframe', () => { + wrapper.setData({ showOverlay: true }) + wrapper.find('.ds-button-ghost').trigger('click') + expect(wrapper.vm.showOverlay).toBe(false) + expect(wrapper.vm.showEmbed).toBe(false) + }) - it('show only iframe if allowEmbedIframes true', () => { - wrapper.setData({ allowEmbedIframes: true }) - expect(wrapper.find('.embed-html')).toEqual({ selector: '.embed-html' }) - expect(wrapper.find('.embed-preview-image--clickable')).toEqual({}) + it('show only iframe if allowEmbedIframes true', () => { + wrapper.setData({ allowEmbedIframes: true }) + expect(wrapper.find('.embed-html')).toEqual({ selector: '.embed-html' }) + expect(wrapper.find('.embed-preview-image--clickable')).toEqual({}) + }) }) }) - }) }) -}) \ No newline at end of file +})