From be9dbdbb76674d413eda77e0fe68dd688cf4aa21 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Wolfgang=20Hu=C3=9F?= <wolle.huss@pjannto.com>
Date: Tue, 4 Oct 2022 11:04:50 +0200
Subject: [PATCH] Refine component 'my-social-media' in webapp

---
 webapp/graphql/SocialMedia.js             | 40 +++++++++++
 webapp/pages/settings/my-social-media.vue | 85 ++++++++++-------------
 2 files changed, 75 insertions(+), 50 deletions(-)
 create mode 100644 webapp/graphql/SocialMedia.js

diff --git a/webapp/graphql/SocialMedia.js b/webapp/graphql/SocialMedia.js
new file mode 100644
index 000000000..62b08859a
--- /dev/null
+++ b/webapp/graphql/SocialMedia.js
@@ -0,0 +1,40 @@
+import gql from 'graphql-tag'
+
+// ------ mutations
+
+export const createSocialMediaMutation = () => {
+  return gql`
+    mutation ($url: String!) {
+      CreateSocialMedia(url: $url) {
+        id
+        url
+      }
+    }
+  `
+}
+
+export const updateSocialMediaMutation = () => {
+  return gql`
+    mutation ($id: ID!, $url: String!) {
+      UpdateSocialMedia(id: $id, url: $url) {
+        id
+        url
+      }
+    }
+  `
+}
+
+export const deleteSocialMediaMutation = () => {
+  return gql`
+    mutation ($id: ID!) {
+      DeleteSocialMedia(id: $id) {
+        id
+        url
+      }
+    }
+  `
+}
+
+// ------ queries
+
+// put the queries here
diff --git a/webapp/pages/settings/my-social-media.vue b/webapp/pages/settings/my-social-media.vue
index 7572ebf0b..aa303e74c 100644
--- a/webapp/pages/settings/my-social-media.vue
+++ b/webapp/pages/settings/my-social-media.vue
@@ -7,26 +7,8 @@
       :useItems="socialMediaLinks"
       :defaultItem="{ url: '' }"
       :namePropertyKey="'url'"
-      :texts="{
-        addButton: $t('settings.social-media.submit'),
-        addNew: $t('settings.social-media.add-new-link'),
-        deleteModal: {
-          titleIdent: 'settings.social-media.delete-modal.title',
-          messageIdent: 'settings.social-media.delete-modal.message',
-          confirm: {
-            icon: 'trash',
-            buttonTextIdent: 'settings.social-media.delete-modal.confirm-button',
-          },
-        },
-        edit: $t('settings.social-media.edit-link'),
-      }"
-      :callbacks="{
-        handleInput: () => {},
-        handleInputValid,
-        edit: callbackEditSocialMedia,
-        submit: handleSubmitSocialMedia,
-        delete: callbackDeleteSocialMedia,
-      }"
+      :texts="mySomethingListTexts"
+      :callbacks="mySomethingListCallbacks"
     >
       <template #list-item="{ item }">
         <social-media-list-item :item="item" />
@@ -46,35 +28,14 @@
 <script>
 import { mapGetters, mapMutations } from 'vuex'
 import unionBy from 'lodash/unionBy'
-import gql from 'graphql-tag'
+import {
+  createSocialMediaMutation,
+  updateSocialMediaMutation,
+  deleteSocialMediaMutation,
+} from '~/graphql/SocialMedia.js'
 import MySomethingList from '~/components/_new/features/MySomethingList/MySomethingList.vue'
 import SocialMediaListItem from '~/components/_new/features/SocialMedia/SocialMediaListItem.vue'
 
-const createSocialMediaMutation = gql`
-  mutation($url: String!) {
-    CreateSocialMedia(url: $url) {
-      id
-      url
-    }
-  }
-`
-const updateSocialMediaMutation = gql`
-  mutation($id: ID!, $url: String!) {
-    UpdateSocialMedia(id: $id, url: $url) {
-      id
-      url
-    }
-  }
-`
-const deleteSocialMediaMutation = gql`
-  mutation($id: ID!) {
-    DeleteSocialMedia(id: $id) {
-      id
-      url
-    }
-  }
-`
-
 export default {
   components: {
     MySomethingList,
@@ -115,6 +76,30 @@ export default {
         return { id, url, favicon }
       })
     },
+    mySomethingListTexts() {
+      return {
+        addButton: this.$t('settings.social-media.submit'),
+        addNew: this.$t('settings.social-media.add-new-link'),
+        deleteModal: {
+          titleIdent: 'settings.social-media.delete-modal.title',
+          messageIdent: 'settings.social-media.delete-modal.message',
+          confirm: {
+            icon: 'trash',
+            buttonTextIdent: 'settings.social-media.delete-modal.confirm-button',
+          },
+        },
+        edit: this.$t('settings.social-media.edit-link'),
+      }
+    },
+    mySomethingListCallbacks() {
+      return {
+        handleInput: () => {},
+        handleInputValid: this.handleInputValid,
+        edit: this.callbackEditSocialMedia,
+        submit: this.handleSubmitSocialMedia,
+        delete: this.callbackDeleteSocialMedia,
+      }
+    },
   },
   methods: {
     ...mapMutations({
@@ -131,7 +116,7 @@ export default {
       thisList.formData.socialMediaUrl = link.url
       // try to set focus on link edit field
       // thisList.$refs.socialMediaUrl.$el.focus()
-      // !!! Check for existenz
+      // !!! check for existence
       // this.$scopedSlots.default()[0].context.$refs
       // thisList.$scopedSlots['edit-item']()[0].$el.focus()
       // console.log(thisList.$scopedSlots['edit-item']()[0].context.$refs)
@@ -149,11 +134,11 @@ export default {
 
       let mutation, variables, successMessage
       if (isCreation) {
-        mutation = createSocialMediaMutation
+        mutation = createSocialMediaMutation()
         variables = { url: item.url }
         successMessage = thisList.$t('settings.social-media.successAdd')
       } else {
-        mutation = updateSocialMediaMutation
+        mutation = updateSocialMediaMutation()
         variables = { id: item.id, url: item.url }
         successMessage = thisList.$t('settings.data.success')
       }
@@ -183,7 +168,7 @@ export default {
     async callbackDeleteSocialMedia(thisList, item) {
       try {
         await thisList.$apollo.mutate({
-          mutation: deleteSocialMediaMutation,
+          mutation: deleteSocialMediaMutation(),
           variables: {
             id: item.id,
           },