From bf571988158fa0b22d3fe3d5653d373f5bfca021 Mon Sep 17 00:00:00 2001
From: aonomike <aonomike@gmail.com>
Date: Thu, 9 May 2019 02:27:03 +0300
Subject: [PATCH] Refactor code based on comments from PR review

---
 webapp/components/Badges.vue              | 7 +------
 webapp/components/Empty.vue               | 7 ++-----
 webapp/pages/settings/my-social-media.vue | 5 +----
 3 files changed, 4 insertions(+), 15 deletions(-)

diff --git a/webapp/components/Badges.vue b/webapp/components/Badges.vue
index 9c7689aca..b28412abe 100644
--- a/webapp/components/Badges.vue
+++ b/webapp/components/Badges.vue
@@ -12,7 +12,7 @@
     >
       <hc-image
         :title="badge.key"
-        :image-props="imageProps(badge.icon)"
+        :image-props="{ src: badge.icon}"
         class="hc-badge"
       />
     </div>
@@ -30,11 +30,6 @@ export default {
       type: Array,
       default: () => []
     }
-  },
-  methods: {
-    imageProps(icon) {
-      return { src: icon }
-    }
   }
 }
 </script>
diff --git a/webapp/components/Empty.vue b/webapp/components/Empty.vue
index 7f818e2f7..f8608c965 100644
--- a/webapp/components/Empty.vue
+++ b/webapp/components/Empty.vue
@@ -58,11 +58,8 @@ export default {
     }
   },
   computed: {
-    iconPath() {
-      return `/img/empty/${this.icon}.svg`
-    },
-    imageProps: {
-      src: iconPath
+    imageProps() {
+      return { src: `/img/empty/${this.icon}.svg` }
     }
   }
 }
diff --git a/webapp/pages/settings/my-social-media.vue b/webapp/pages/settings/my-social-media.vue
index f991305a6..a7b954182 100644
--- a/webapp/pages/settings/my-social-media.vue
+++ b/webapp/pages/settings/my-social-media.vue
@@ -12,7 +12,7 @@
         >
           <a :href="link.url">
             <hc-image
-              :image-props="imageProps(link.favicon)"
+              :image-props="{ src: link.favicon }"
               alt="Social Media link"
               width="16"
               height="16"
@@ -105,9 +105,6 @@ export default {
           this.$toast.success(this.$t('settings.social-media.success')),
           (this.value = '')
         )
-    },
-    imageProps(favicon) {
-      return { src: favicon }
     }
   }
 }