From c1d9766f391587a5995e1daf4e52c6241c8dec12 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Wolfgang=20Hu=C3=9F?= Date: Thu, 1 Jun 2023 19:31:21 +0200 Subject: [PATCH] Replace 'setOrder' by 'toggleOrder' --- webapp/components/FilterMenu/EventsByFilter.vue | 4 ++-- webapp/components/FilterMenu/OrderByFilter.vue | 4 ++-- webapp/mixins/filterMenuMixin.js | 3 --- 3 files changed, 4 insertions(+), 7 deletions(-) diff --git a/webapp/components/FilterMenu/EventsByFilter.vue b/webapp/components/FilterMenu/EventsByFilter.vue index 553b19815..3d0531e51 100644 --- a/webapp/components/FilterMenu/EventsByFilter.vue +++ b/webapp/components/FilterMenu/EventsByFilter.vue @@ -7,7 +7,7 @@ :label="$t('filter-menu.ended.all.label')" :filled="eventsEnded === ''" :title="$t('filter-menu.ended.all.hint')" - @click="setEventsEnded('')" + @click="toggleEventsEnded('')" data-test="all-button" /> @@ -17,7 +17,7 @@ :label="$t('filter-menu.ended.onlyEnded.label')" :filled="eventsEnded === 'eventStart_gte'" :title="$t('filter-menu.ended.onlyEnded.hint')" - @click="setEventsEnded('eventStart_gte')" + @click="toggleEventsEnded('eventStart_gte')" data-test="not-ended-button" /> diff --git a/webapp/components/FilterMenu/OrderByFilter.vue b/webapp/components/FilterMenu/OrderByFilter.vue index d431de50c..279c2600a 100644 --- a/webapp/components/FilterMenu/OrderByFilter.vue +++ b/webapp/components/FilterMenu/OrderByFilter.vue @@ -7,7 +7,7 @@ :label="buttonLabel('desc')" :filled="orderBy === orderedDesc" :title="buttonTitle('desc')" - @click="setOrder(orderedDesc)" + @click="toggleOrder(orderedDesc)" data-test="newest-button" /> @@ -17,7 +17,7 @@ :label="buttonLabel('asc')" :filled="orderBy === orderedAsc" :title="buttonTitle('asc')" - @click="setOrder(orderedAsc)" + @click="toggleOrder(orderedAsc)" data-test="oldest-button" /> diff --git a/webapp/mixins/filterMenuMixin.js b/webapp/mixins/filterMenuMixin.js index eeb69f349..9c59770ae 100644 --- a/webapp/mixins/filterMenuMixin.js +++ b/webapp/mixins/filterMenuMixin.js @@ -21,8 +21,5 @@ export default { toggleEventsEnded: 'posts/TOGGLE_EVENTS_ENDED', toggleOrder: 'posts/TOGGLE_ORDER', }), - setOrder(newOrder) { - this.toggleOrder(newOrder) - }, }, }