From c8c71a52c67e7be517dc31150dd17e9c0a7f615a Mon Sep 17 00:00:00 2001
From: mattwr18 <mattwr18@gmail.com>
Date: Fri, 31 Jan 2020 13:09:37 +0100
Subject: [PATCH] Follow @Tirokk PR review suggestions

- Favor lowercase for words in a sentence after the first
- Use exclamation marks for successful actions that use a toastr
- place events at the end of the list on components
- place class above events
- it would be nice to come to a consensus based on best practices, like
  I had a doubt and places the class definition below the props, is that
what others do?
---
 webapp/components/Comment/Comment.vue         | 6 +++---
 webapp/components/CommentList/CommentList.vue | 4 ++--
 webapp/locales/de.json                        | 2 +-
 webapp/locales/en.json                        | 4 ++--
 4 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/webapp/components/Comment/Comment.vue b/webapp/components/Comment/Comment.vue
index 0f37dae5d..5c47a3656 100644
--- a/webapp/components/Comment/Comment.vue
+++ b/webapp/components/Comment/Comment.vue
@@ -57,11 +57,11 @@
       <base-button
         :title="this.$t('post.comment.reply')"
         icon="level-down"
-        @click.prevent="reply"
-        v-scroll-to="'.editor'"
-        circle
         class="reply-button"
+        circle
         size="small"
+        v-scroll-to="'.editor'"
+        @click.prevent="reply"
       ></base-button>
     </ds-card>
   </div>
diff --git a/webapp/components/CommentList/CommentList.vue b/webapp/components/CommentList/CommentList.vue
index 9a72e0073..ef6e3b096 100644
--- a/webapp/components/CommentList/CommentList.vue
+++ b/webapp/components/CommentList/CommentList.vue
@@ -7,16 +7,16 @@
     <ds-space margin-bottom="large" />
     <div v-if="post.comments && post.comments.length" id="comments" class="comments">
       <comment
-        @reply="reply"
         v-for="comment in post.comments"
         :key="comment.id"
         :comment="comment"
         :post="post"
         :routeHash="routeHash"
+        class="comment-tag"
         @deleteComment="updateCommentList"
         @updateComment="updateCommentList"
         @toggleNewCommentForm="toggleNewCommentForm"
-        class="comment-tag"
+        @reply="reply"
       />
     </div>
   </div>
diff --git a/webapp/locales/de.json b/webapp/locales/de.json
index 0c11c8d13..d552d51ba 100644
--- a/webapp/locales/de.json
+++ b/webapp/locales/de.json
@@ -279,7 +279,7 @@
         },
         "comment": {
             "submit": "Kommentiere",
-            "submitted": "Kommentar Gesendet",
+            "submitted": "Kommentar gesendet!",
             "updated": "Änderungen gespeichert",
             "reply": "Antworten"
         },
diff --git a/webapp/locales/en.json b/webapp/locales/en.json
index 7804bcbfc..d15614ecc 100644
--- a/webapp/locales/en.json
+++ b/webapp/locales/en.json
@@ -444,8 +444,8 @@
     },
     "comment": {
       "submit": "Comment",
-      "submitted": "Comment Submitted",
-      "updated": "Changes Saved",
+      "submitted": "Comment submitted!",
+      "updated": "Changes saved!",
       "reply": "Reply"
     },
     "edited": "edited"