From d81c38c4e3ba693be7d4f9b342c739ebc4486ccc Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Robert=20Sch=C3=A4fer?= <git@roschaefer.de>
Date: Sat, 20 Jul 2019 15:54:59 +0200
Subject: [PATCH] Remove obscure `embed` attribute and remove cache

The cache is a possible memory leak: It grows over time and never gets
cleaned.
---
 .../src/schema/resolvers/embeds/scraper.js    | 22 -------------------
 backend/src/schema/types/embed.gql            |  1 -
 2 files changed, 23 deletions(-)

diff --git a/backend/src/schema/resolvers/embeds/scraper.js b/backend/src/schema/resolvers/embeds/scraper.js
index bd6a7557c..2a953902a 100644
--- a/backend/src/schema/resolvers/embeds/scraper.js
+++ b/backend/src/schema/resolvers/embeds/scraper.js
@@ -31,9 +31,6 @@ const metascraper = Metascraper([
   // require('./rules/metascraper-embed')()
 ])
 
-// quick in memory cache
-let cache = {}
-
 let oEmbedProviders = []
 const getEmbedProviders = async () => {
   let providers = await request('https://oembed.com/providers.json')
@@ -92,12 +89,6 @@ export default async function scrape(targetUrl) {
     targetUrl.hostname = 'youtube.com'
   }
 
-  if (cache[targetUrl]) {
-    return cache[targetUrl]
-  }
-
-  const url = new URL(targetUrl)
-
   let meta = {}
   let embed = {}
 
@@ -137,18 +128,5 @@ export default async function scrape(targetUrl) {
     throw new ApolloError('Not found', 'NOT_FOUND')
   }
 
-  // fix youtube start parameter
-  const YouTubeStartParam = url.searchParams.t || url.searchParams.start
-  if (output.publisher === 'YouTube' && YouTubeStartParam) {
-    output.embed = output.embed.replace(
-      '?feature=oembed',
-      `?feature=oembed&start=${YouTubeStartParam}`,
-    )
-    output.url += `&start=${YouTubeStartParam}`
-  }
-
-  // write to cache
-  cache[targetUrl] = output
-
   return output
 }
diff --git a/backend/src/schema/types/embed.gql b/backend/src/schema/types/embed.gql
index e7108d3ef..5d40e0b52 100644
--- a/backend/src/schema/types/embed.gql
+++ b/backend/src/schema/types/embed.gql
@@ -11,7 +11,6 @@ type Embed {
   video: String
   lang: String
   logo: String
-  embed: String
   sources: [String]
 }