From 34145cfa061512f889151b8c1f196ce67304e1b0 Mon Sep 17 00:00:00 2001 From: mahula Date: Mon, 17 Jul 2023 13:10:28 +0200 Subject: [PATCH 01/20] fix typo --- .github/workflows/test-backend.yml | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/.github/workflows/test-backend.yml b/.github/workflows/test-backend.yml index 84d87c770..d144928e8 100644 --- a/.github/workflows/test-backend.yml +++ b/.github/workflows/test-backend.yml @@ -13,7 +13,7 @@ jobs: steps: - uses: actions/checkout@v3.3.0 - - name: Check for frontend file changes + - name: Check for backend file changes uses: dorny/paths-filter@v2.11.1 id: changes with: @@ -93,11 +93,11 @@ jobs: - name: Load Docker Image run: docker load < /tmp/neo4j.tar - - name: Download Docker Image (Backend) - uses: actions/download-artifact@v3 - with: - name: docker-backend-test - path: /tmp + # - name: Download Docker Image (Backend) + # uses: actions/download-artifact@v3 + # with: + # name: docker-backend-test + # path: /tmp - name: Load Docker Image run: docker load < /tmp/backend.tar From b15148b985ec0df4a89203dca620ce58a2cf9e04 Mon Sep 17 00:00:00 2001 From: mahula Date: Mon, 17 Jul 2023 13:18:35 +0200 Subject: [PATCH 02/20] replace artefact upload by caching in neo4j build test job --- .github/workflows/test-backend.yml | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/.github/workflows/test-backend.yml b/.github/workflows/test-backend.yml index d144928e8..e6bc213fe 100644 --- a/.github/workflows/test-backend.yml +++ b/.github/workflows/test-backend.yml @@ -35,11 +35,16 @@ jobs: docker build --target community -t "ocelotsocialnetwork/neo4j-community:test" neo4j/ docker save "ocelotsocialnetwork/neo4j-community:test" > /tmp/neo4j.tar - - name: Upload Artifact - uses: actions/upload-artifact@v3 + - name: Get pr number + id: pr + uses: 8BitJonny/gh-get-current-pr@2.2.0 + + - name: Cache docker images + id: cache-neo4j + uses: actions/cache/save@v3.3.1 with: - name: docker-neo4j-image path: /tmp/neo4j.tar + key: backend-neo4j-cache-pr${{ steps.pr.outputs.number }} build_test_backend: name: Docker Build Test - Backend @@ -53,13 +58,13 @@ jobs: - name: backend | Build 'test' image run: | docker build --target test -t "ocelotsocialnetwork/backend:test" backend/ - docker save "ocelotsocialnetwork/backend:test" > /tmp/backend.tar + docker save "ocelotsocialnetwork/backend:test" > /tmp/images/backend.tar - name: Upload Artifact uses: actions/upload-artifact@v3 with: name: docker-backend-test - path: /tmp/backend.tar + path: /tmp/images/backend.tar lint_backend: name: Lint Backend From 7e171fb5218911810459f1936c47245818809b42 Mon Sep 17 00:00:00 2001 From: mahula Date: Mon, 17 Jul 2023 13:21:02 +0200 Subject: [PATCH 03/20] replace artefact upload by caching in backend build test job --- .github/workflows/test-backend.yml | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/.github/workflows/test-backend.yml b/.github/workflows/test-backend.yml index e6bc213fe..c484dc702 100644 --- a/.github/workflows/test-backend.yml +++ b/.github/workflows/test-backend.yml @@ -58,13 +58,18 @@ jobs: - name: backend | Build 'test' image run: | docker build --target test -t "ocelotsocialnetwork/backend:test" backend/ - docker save "ocelotsocialnetwork/backend:test" > /tmp/images/backend.tar + docker save "ocelotsocialnetwork/backend:test" > /tmp/backend.tar - - name: Upload Artifact - uses: actions/upload-artifact@v3 + - name: Get pr number + id: pr + uses: 8BitJonny/gh-get-current-pr@2.2.0 + + - name: Cache docker images + id: cache-backend + uses: actions/cache/save@v3.3.1 with: - name: docker-backend-test - path: /tmp/images/backend.tar + path: /tmp/backend.tar + key: backend-cache-pr${{ steps.pr.outputs.number }} lint_backend: name: Lint Backend From 4ec4b3659041be9b250b8cbc4c977f5ed18a2734 Mon Sep 17 00:00:00 2001 From: mahula Date: Mon, 17 Jul 2023 13:57:53 +0200 Subject: [PATCH 04/20] replace artefact download by caching in backend unit test job --- .github/workflows/test-backend.yml | 46 ++++++++++++++---------------- 1 file changed, 22 insertions(+), 24 deletions(-) diff --git a/.github/workflows/test-backend.yml b/.github/workflows/test-backend.yml index c484dc702..c90d0e1ea 100644 --- a/.github/workflows/test-backend.yml +++ b/.github/workflows/test-backend.yml @@ -10,6 +10,7 @@ jobs: outputs: backend: ${{ steps.changes.outputs.backend }} docker: ${{ steps.changes.outputs.docker }} + pr-number: ${{ steps.pr.outputs.number }} steps: - uses: actions/checkout@v3.3.0 @@ -21,6 +22,10 @@ jobs: filters: .github/file-filters.yml list-files: shell + - name: Get pr number + id: pr + uses: 8BitJonny/gh-get-current-pr@2.2.0 + build_test_neo4j: name: Docker Build Test - Neo4J if: needs.files-changed.outputs.backend == 'true' || needs.files-changed.outputs.docker == 'true' @@ -34,17 +39,13 @@ jobs: run: | docker build --target community -t "ocelotsocialnetwork/neo4j-community:test" neo4j/ docker save "ocelotsocialnetwork/neo4j-community:test" > /tmp/neo4j.tar - - - name: Get pr number - id: pr - uses: 8BitJonny/gh-get-current-pr@2.2.0 - name: Cache docker images id: cache-neo4j uses: actions/cache/save@v3.3.1 with: path: /tmp/neo4j.tar - key: backend-neo4j-cache-pr${{ steps.pr.outputs.number }} + key: backend-neo4j-cache-pr${{ needs.files-changed.outputs.pr-number }} build_test_backend: name: Docker Build Test - Backend @@ -59,17 +60,13 @@ jobs: run: | docker build --target test -t "ocelotsocialnetwork/backend:test" backend/ docker save "ocelotsocialnetwork/backend:test" > /tmp/backend.tar - - - name: Get pr number - id: pr - uses: 8BitJonny/gh-get-current-pr@2.2.0 - name: Cache docker images id: cache-backend uses: actions/cache/save@v3.3.1 with: path: /tmp/backend.tar - key: backend-cache-pr${{ steps.pr.outputs.number }} + key: backend-cache-pr${{ needs.files-changed.outputs.pr-number }} lint_backend: name: Lint Backend @@ -94,23 +91,24 @@ jobs: - name: Checkout code uses: actions/checkout@v3 - - name: Download Docker Image (Neo4J) - uses: actions/download-artifact@v3 + - name: Restore Neo4J cache + uses: actions/cache/restore@v3.3.1 with: - name: docker-neo4j-image - path: /tmp + path: /tmp/neo4j.tar + key: backend-neo4j-cache-pr${{ needs.files-changed.outputs.pr-number }} + fail-on-cache-miss: true - - name: Load Docker Image - run: docker load < /tmp/neo4j.tar + - name: Restore Backend cache + uses: actions/cache/restore@v3.3.1 + with: + path: /tmp/backend.tar + key: backend-cache-pr${{ needs.files-changed.outputs.pr-number }} + fail-on-cache-miss: true - # - name: Download Docker Image (Backend) - # uses: actions/download-artifact@v3 - # with: - # name: docker-backend-test - # path: /tmp - - - name: Load Docker Image - run: docker load < /tmp/backend.tar + - name: Load Docker Images + run: | + docker load < /tmp/neo4j.tar + docker load < /tmp/backend.tar - name: backend | copy env files webapp run: cp webapp/.env.template webapp/.env From 89719b3cdad35b2de700fe869dc98c85b2de6cf3 Mon Sep 17 00:00:00 2001 From: mahula Date: Mon, 17 Jul 2023 14:01:14 +0200 Subject: [PATCH 05/20] merge env copy steps into single step --- .github/workflows/test-backend.yml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/test-backend.yml b/.github/workflows/test-backend.yml index c90d0e1ea..e293f3e99 100644 --- a/.github/workflows/test-backend.yml +++ b/.github/workflows/test-backend.yml @@ -110,10 +110,10 @@ jobs: docker load < /tmp/neo4j.tar docker load < /tmp/backend.tar - - name: backend | copy env files webapp - run: cp webapp/.env.template webapp/.env - - name: backend | copy env files backend - run: cp backend/.env.template backend/.env + - name: backend | copy env files + run: | + cp webapp/.env.template webapp/.env + cp backend/.env.template backend/.env - name: backend | docker-compose run: docker-compose -f docker-compose.yml -f docker-compose.test.yml up --detach --no-deps neo4j backend From e44c3493e2a7bde4583d2efb88f0929ebfc1a232 Mon Sep 17 00:00:00 2001 From: mahula Date: Mon, 17 Jul 2023 14:29:00 +0200 Subject: [PATCH 06/20] add backend test worfkflow file to file filter --- .github/file-filters.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/file-filters.yml b/.github/file-filters.yml index d7f9cb6c0..1c2f4fc62 100644 --- a/.github/file-filters.yml +++ b/.github/file-filters.yml @@ -1,4 +1,5 @@ backend: &backend + - '.github/workflows/test-backend.yml' - 'backend/**/*' - 'neo4j/**/*' From f7e8d85b5f59c34dd00b2b427fd12cda53a1a37a Mon Sep 17 00:00:00 2001 From: mahula Date: Mon, 17 Jul 2023 14:29:35 +0200 Subject: [PATCH 07/20] add webapp test worfkflow file to file filter --- .github/file-filters.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/file-filters.yml b/.github/file-filters.yml index 1c2f4fc62..8d2d93fac 100644 --- a/.github/file-filters.yml +++ b/.github/file-filters.yml @@ -7,4 +7,5 @@ docker: &docker - 'docker-compose.*' webapp: &webapp + - '.github/workflows/test-webapp.yml' - 'webapp/**/*' From ced4996f4769bae5821e70b42a7dcadf4cfa6fc5 Mon Sep 17 00:00:00 2001 From: Ulf Gebhardt Date: Mon, 17 Jul 2023 14:55:57 +0200 Subject: [PATCH 08/20] implement chatMessageAdded subscription --- backend/src/schema/resolvers/messages.ts | 18 +++++++++++++- backend/src/schema/types/type/Message.gql | 4 ++++ backend/src/server.ts | 2 +- webapp/components/Chat/Chat.vue | 29 ++++++++++++++++++++++- webapp/graphql/Messages.js | 26 ++++++++++++++++++++ 5 files changed, 76 insertions(+), 3 deletions(-) diff --git a/backend/src/schema/resolvers/messages.ts b/backend/src/schema/resolvers/messages.ts index ececd65a6..f363f9a44 100644 --- a/backend/src/schema/resolvers/messages.ts +++ b/backend/src/schema/resolvers/messages.ts @@ -1,9 +1,21 @@ import { neo4jgraphql } from 'neo4j-graphql-js' import Resolver from './helpers/Resolver' import RoomResolver from './rooms' -import { pubsub, ROOM_COUNT_UPDATED } from '../../server' +import { pubsub, ROOM_COUNT_UPDATED, CHAT_MESSAGE_ADDED } from '../../server' +import { withFilter } from 'graphql-subscriptions' export default { + Subscription: { + chatMessageAdded: { + subscribe: withFilter( + () => pubsub.asyncIterator(CHAT_MESSAGE_ADDED), + (payload, variables) => { + console.log('chatMessageAdded', payload, variables) + return true // payload.user.id === variables.userId + }, + ), + }, + }, Query: { Message: async (object, params, context, resolveInfo) => { const { roomId } = params @@ -91,6 +103,10 @@ export default { // send subscriptions await pubsub.publish(ROOM_COUNT_UPDATED, { roomCountUpdated, user: message.otherUser }) + await pubsub.publish(CHAT_MESSAGE_ADDED, { + chatMessageAdded: message, + user: message.otherUser, + }) return message }) diff --git a/backend/src/schema/types/type/Message.gql b/backend/src/schema/types/type/Message.gql index 671c5523a..e15a27d91 100644 --- a/backend/src/schema/types/type/Message.gql +++ b/backend/src/schema/types/type/Message.gql @@ -45,3 +45,7 @@ type Query { orderBy: [_MessageOrdering] ): [Message] } + +type Subscription { + chatMessageAdded(userId: ID!): Message +} diff --git a/backend/src/server.ts b/backend/src/server.ts index feceeb9eb..0522f5fc8 100644 --- a/backend/src/server.ts +++ b/backend/src/server.ts @@ -14,7 +14,7 @@ import bodyParser from 'body-parser' import { graphqlUploadExpress } from 'graphql-upload' export const NOTIFICATION_ADDED = 'NOTIFICATION_ADDED' -// export const CHAT_MESSAGE_ADDED = 'CHAT_MESSAGE_ADDED' +export const CHAT_MESSAGE_ADDED = 'CHAT_MESSAGE_ADDED' export const ROOM_COUNT_UPDATED = 'ROOM_COUNT_UPDATED' const { REDIS_DOMAIN, REDIS_PORT, REDIS_PASSWORD } = CONFIG let prodPubsub, devPubsub diff --git a/webapp/components/Chat/Chat.vue b/webapp/components/Chat/Chat.vue index dd39e7bcd..1e4636e8b 100644 --- a/webapp/components/Chat/Chat.vue +++ b/webapp/components/Chat/Chat.vue @@ -61,7 +61,7 @@