diff --git a/backend/Dockerfile b/backend/Dockerfile index 72b9973e7..250ee845b 100644 --- a/backend/Dockerfile +++ b/backend/Dockerfile @@ -1,4 +1,4 @@ -FROM node:12.9-alpine as base +FROM node:12.10.0-alpine as base LABEL Description="Backend of the Social Network Human-Connection.org" Vendor="Human Connection gGmbH" Version="0.0.1" Maintainer="Human Connection gGmbH (developer@human-connection.org)" EXPOSE 4000 diff --git a/backend/package.json b/backend/package.json index 454ab16d9..9c8f2403c 100644 --- a/backend/package.json +++ b/backend/package.json @@ -120,7 +120,7 @@ "eslint-config-prettier": "~6.2.0", "eslint-config-standard": "~14.1.0", "eslint-plugin-import": "~2.18.2", - "eslint-plugin-jest": "~22.16.0", + "eslint-plugin-jest": "~22.17.0", "eslint-plugin-node": "~10.0.0", "eslint-plugin-prettier": "~3.1.0", "eslint-plugin-promise": "~4.2.1", diff --git a/backend/src/middleware/index.js b/backend/src/middleware/index.js index 7774ccc15..1dd630ebc 100644 --- a/backend/src/middleware/index.js +++ b/backend/src/middleware/index.js @@ -2,7 +2,7 @@ import { applyMiddleware } from 'graphql-middleware' import CONFIG from './../config' import activityPub from './activityPubMiddleware' -import softDelete from './softDeleteMiddleware' +import softDelete from './softDelete/softDeleteMiddleware' import sluggify from './sluggifyMiddleware' import excerpt from './excerptMiddleware' import dateTime from './dateTimeMiddleware' diff --git a/backend/src/middleware/nodes/locations.js b/backend/src/middleware/nodes/locations.js index d7abb90ff..a90d8c0d7 100644 --- a/backend/src/middleware/nodes/locations.js +++ b/backend/src/middleware/nodes/locations.js @@ -1,9 +1,12 @@ import request from 'request' import { UserInputError } from 'apollo-server' import isEmpty from 'lodash/isEmpty' +import Debug from 'debug' import asyncForEach from '../../helpers/asyncForEach' import CONFIG from './../../config' +const debug = Debug('human-connection:location') + const fetch = url => { return new Promise((resolve, reject) => { request(url, function(error, response, body) { @@ -59,6 +62,7 @@ const createOrUpdateLocations = async (userId, locationName, driver) => { if (isEmpty(locationName)) { return } + const res = await fetch( `https://api.mapbox.com/geocoding/v5/mapbox.places/${encodeURIComponent( locationName, @@ -67,6 +71,8 @@ const createOrUpdateLocations = async (userId, locationName, driver) => { )}`, ) + debug(res) + if (!res || !res.features || !res.features[0]) { throw new UserInputError('locationName is invalid') } diff --git a/backend/src/middleware/softDeleteMiddleware.js b/backend/src/middleware/softDelete/softDeleteMiddleware.js similarity index 100% rename from backend/src/middleware/softDeleteMiddleware.js rename to backend/src/middleware/softDelete/softDeleteMiddleware.js diff --git a/backend/src/middleware/softDeleteMiddleware.spec.js b/backend/src/middleware/softDelete/softDeleteMiddleware.spec.js similarity index 98% rename from backend/src/middleware/softDeleteMiddleware.spec.js rename to backend/src/middleware/softDelete/softDeleteMiddleware.spec.js index a749de819..5b04abebd 100644 --- a/backend/src/middleware/softDeleteMiddleware.spec.js +++ b/backend/src/middleware/softDelete/softDeleteMiddleware.spec.js @@ -1,7 +1,7 @@ -import Factory from '../seed/factories' -import { gql } from '../jest/helpers' -import { neode as getNeode, getDriver } from '../bootstrap/neo4j' -import createServer from '../server' +import Factory from '../../seed/factories' +import { gql } from '../../jest/helpers' +import { neode as getNeode, getDriver } from '../../bootstrap/neo4j' +import createServer from '../../server' import { createTestClient } from 'apollo-server-testing' const factory = Factory() diff --git a/backend/src/schema/resolvers/registration.spec.js b/backend/src/schema/resolvers/registration.spec.js index 8e33bf314..d9c05fde6 100644 --- a/backend/src/schema/resolvers/registration.spec.js +++ b/backend/src/schema/resolvers/registration.spec.js @@ -1,18 +1,33 @@ -import { GraphQLClient } from 'graphql-request' import Factory from '../../seed/factories' -import { host, login } from '../../jest/helpers' -import { neode } from '../../bootstrap/neo4j' +import { gql } from '../../jest/helpers' +import { getDriver, neode as getNeode } from '../../bootstrap/neo4j' +import createServer from '../../server' +import { createTestClient } from 'apollo-server-testing' -let factory -let client +const factory = Factory() +const neode = getNeode() + +let mutate +let authenticatedUser +let user let variables -let action -let userParams -const instance = neode() +const driver = getDriver() beforeEach(async () => { variables = {} - factory = Factory() +}) + +beforeAll(() => { + const { server } = createServer({ + context: () => { + return { + driver, + neode, + user: authenticatedUser, + } + }, + }) + mutate = createTestClient(server).mutate }) afterEach(async () => { @@ -20,83 +35,77 @@ afterEach(async () => { }) describe('CreateInvitationCode', () => { - const mutation = `mutation { CreateInvitationCode { token } }` + const mutation = gql` + mutation { + CreateInvitationCode { + token + } + } + ` - it('throws Authorization error', async () => { - const client = new GraphQLClient(host) - await expect(client.request(mutation)).rejects.toThrow('Not Authorised!') + describe('unauthenticated', () => { + beforeEach(() => { + authenticatedUser = null + }) + + it('throws Authorization error', async () => { + await expect(mutate({ mutation })).resolves.toMatchObject({ + errors: [{ message: 'Not Authorised!' }], + }) + }) }) describe('authenticated', () => { beforeEach(async () => { - userParams = { + user = await factory.create('User', { id: 'i123', name: 'Inviter', email: 'inviter@example.org', password: '1234', termsAndConditionsAgreedVersion: '0.0.1', - } - action = async () => { - const factory = Factory() - await factory.create('User', userParams) - const headers = await login(userParams) - client = new GraphQLClient(host, { headers }) - return client.request(mutation) - } + }) + authenticatedUser = await user.toJson() }) it('resolves', async () => { - await expect(action()).resolves.toEqual({ - CreateInvitationCode: { token: expect.any(String) }, + await expect(mutate({ mutation })).resolves.toMatchObject({ + data: { CreateInvitationCode: { token: expect.any(String) } }, }) }) it('creates an InvitationCode with a `createdAt` attribute', async () => { - await action() - const codes = await instance.all('InvitationCode') + await mutate({ mutation }) + const codes = await neode.all('InvitationCode') const invitation = await codes.first().toJson() expect(invitation.createdAt).toBeTruthy() expect(Date.parse(invitation.createdAt)).toEqual(expect.any(Number)) }) it('relates inviting User to InvitationCode', async () => { - await action() - const result = await instance.cypher( + await mutate({ mutation }) + const result = await neode.cypher( 'MATCH(code:InvitationCode)<-[:GENERATED]-(user:User) RETURN user', ) - const inviter = instance.hydrateFirst(result, 'user', instance.model('User')) + const inviter = neode.hydrateFirst(result, 'user', neode.model('User')) await expect(inviter.toJson()).resolves.toEqual(expect.objectContaining({ name: 'Inviter' })) }) describe('who has invited a lot of users already', () => { - beforeEach(() => { - action = async () => { - const factory = Factory() - await factory.create('User', userParams) - const headers = await login(userParams) - client = new GraphQLClient(host, { headers }) - await Promise.all( - [1, 2, 3].map(() => { - return client.request(mutation) - }), - ) - return client.request(mutation, variables) - } + beforeEach(async () => { + await Promise.all([mutate({ mutation }), mutate({ mutation }), mutate({ mutation })]) }) describe('as ordinary `user`', () => { it('throws `Not Authorised` because of maximum number of invitations', async () => { - await expect(action()).rejects.toThrow('Not Authorised') + await expect(mutate({ mutation })).resolves.toMatchObject({ + errors: [{ message: 'Not Authorised!' }], + }) }) - it('creates no additional invitation codes', async done => { - try { - await action() - } catch (e) { - const invitationCodes = await instance.all('InvitationCode') - await expect(invitationCodes.toJson()).resolves.toHaveLength(3) - done() - } + it('creates no additional invitation codes', async () => { + await mutate({ mutation }) + const invitationCodes = await neode.all('InvitationCode') + await expect(invitationCodes.toJson()).resolves.toHaveLength(3) }) }) @@ -118,132 +127,144 @@ describe('CreateInvitationCode', () => { }) describe('SignupByInvitation', () => { - const mutation = `mutation($email: String!, $token: String!) { - SignupByInvitation(email: $email, token: $token) { email } - }` - - beforeEach(() => { - client = new GraphQLClient(host) - action = async () => { - return client.request(mutation, variables) + const mutation = gql` + mutation($email: String!, $token: String!) { + SignupByInvitation(email: $email, token: $token) { + email + } } - }) + ` describe('with valid email but invalid InvitationCode', () => { beforeEach(() => { - variables.email = 'any-email@example.org' - variables.token = 'wut?' + variables = { + ...variables, + email: 'any-email@example.org', + token: 'wut?', + } }) it('throws UserInputError', async () => { - await expect(action()).rejects.toThrow('Invitation code already used or does not exist.') - }) - }) - - describe('with valid InvitationCode', () => { - beforeEach(async () => { - const inviterParams = { - name: 'Inviter', - email: 'inviter@example.org', - password: '1234', - } - const factory = Factory() - await factory.create('User', inviterParams) - const headersOfInviter = await login(inviterParams) - const anotherClient = new GraphQLClient(host, { headers: headersOfInviter }) - const invitationMutation = `mutation { CreateInvitationCode { token } }` - const { - CreateInvitationCode: { token }, - } = await anotherClient.request(invitationMutation) - variables.token = token + await expect(mutate({ mutation, variables })).resolves.toMatchObject({ + errors: [{ message: 'UserInputError: Invitation code already used or does not exist.' }], + }) }) - describe('given an invalid email', () => { - beforeEach(() => { - variables.email = 'someuser' - }) - - it('throws `email is not a valid email`', async () => { - await expect(action()).rejects.toThrow('"email" must be a valid email') - }) - - it('creates no additional EmailAddress node', async done => { - try { - await action() - } catch (e) { - let emailAddresses = await instance.all('EmailAddress') - emailAddresses = await emailAddresses.toJson - expect(emailAddresses).toHaveLength(0) - done() + describe('with valid InvitationCode', () => { + beforeEach(async () => { + const inviter = await factory.create('User', { + name: 'Inviter', + email: 'inviter@example.org', + password: '1234', + }) + authenticatedUser = await inviter.toJson() + const invitationMutation = gql` + mutation { + CreateInvitationCode { + token + } + } + ` + const { + data: { + CreateInvitationCode: { token }, + }, + } = await mutate({ mutation: invitationMutation }) + authenticatedUser = null + variables = { + ...variables, + token, } }) - }) - describe('given a valid email', () => { - beforeEach(() => { - variables.email = 'someUser@example.org' - }) + describe('given an invalid email', () => { + beforeEach(() => { + variables = { ...variables, email: 'someuser' } + }) - it('resolves', async () => { - await expect(action()).resolves.toEqual({ - SignupByInvitation: { email: 'someuser@example.org' }, + it('throws `email is not a valid email`', async () => { + await expect(mutate({ mutation, variables })).resolves.toMatchObject({ + errors: [{ message: expect.stringContaining('"email" must be a valid email') }], + }) + }) + + it('creates no additional EmailAddress node', async () => { + let emailAddresses = await neode.all('EmailAddress') + emailAddresses = await emailAddresses.toJson() + expect(emailAddresses).toHaveLength(1) + await mutate({ mutation, variables }) + emailAddresses = await neode.all('EmailAddress') + emailAddresses = await emailAddresses.toJson() + expect(emailAddresses).toHaveLength(1) }) }) - describe('creates a EmailAddress node', () => { - it('with a `createdAt` attribute', async () => { - await action() - let emailAddress = await instance.first('EmailAddress', { email: 'someuser@example.org' }) - emailAddress = await emailAddress.toJson() - expect(emailAddress.createdAt).toBeTruthy() - expect(Date.parse(emailAddress.createdAt)).toEqual(expect.any(Number)) + describe('given a valid email', () => { + beforeEach(() => { + variables = { ...variables, email: 'someUser@example.org' } }) - it('with a cryptographic `nonce`', async () => { - await action() - let emailAddress = await instance.first('EmailAddress', { email: 'someuser@example.org' }) - emailAddress = await emailAddress.toJson() - expect(emailAddress.nonce).toEqual(expect.any(String)) - }) - - it('connects inviter through invitation code', async () => { - await action() - const result = await instance.cypher( - 'MATCH(inviter:User)-[:GENERATED]->(:InvitationCode)-[:ACTIVATED]->(email:EmailAddress {email: {email}}) RETURN inviter', - { email: 'someuser@example.org' }, - ) - const inviter = instance.hydrateFirst(result, 'inviter', instance.model('User')) - await expect(inviter.toJson()).resolves.toEqual( - expect.objectContaining({ name: 'Inviter' }), - ) - }) - - describe('using the same InvitationCode twice', () => { - it('rejects because codes can be used only once', async done => { - await action() - try { - variables.email = 'yetanotheremail@example.org' - await action() - } catch (e) { - expect(e.message).toMatch(/Invitation code already used/) - done() - } + it('resolves', async () => { + await expect(mutate({ mutation, variables })).resolves.toMatchObject({ + data: { SignupByInvitation: { email: 'someuser@example.org' } }, }) }) - describe('if a user account with the given email already exists', () => { - beforeEach(async () => { - await factory.create('User', { email: 'someuser@example.org' }) + describe('creates a EmailAddress node', () => { + it('with a `createdAt` attribute', async () => { + await mutate({ mutation, variables }) + let emailAddress = await neode.first('EmailAddress', { email: 'someuser@example.org' }) + emailAddress = await emailAddress.toJson() + expect(emailAddress.createdAt).toBeTruthy() + expect(Date.parse(emailAddress.createdAt)).toEqual(expect.any(Number)) }) - it('throws unique violation error', async () => { - await expect(action()).rejects.toThrow('User account with this email already exists.') + it('with a cryptographic `nonce`', async () => { + await mutate({ mutation, variables }) + let emailAddress = await neode.first('EmailAddress', { email: 'someuser@example.org' }) + emailAddress = await emailAddress.toJson() + expect(emailAddress.nonce).toEqual(expect.any(String)) }) - }) - describe('if the EmailAddress already exists but without user account', () => { - // shall we re-send the registration email? - it.todo('decide what to do') + it('connects inviter through invitation code', async () => { + await mutate({ mutation, variables }) + const result = await neode.cypher( + 'MATCH(inviter:User)-[:GENERATED]->(:InvitationCode)-[:ACTIVATED]->(email:EmailAddress {email: {email}}) RETURN inviter', + { email: 'someuser@example.org' }, + ) + const inviter = neode.hydrateFirst(result, 'inviter', neode.model('User')) + await expect(inviter.toJson()).resolves.toEqual( + expect.objectContaining({ name: 'Inviter' }), + ) + }) + + describe('using the same InvitationCode twice', () => { + it('rejects because codes can be used only once', async () => { + await mutate({ mutation, variables }) + variables = { ...variables, email: 'yetanotheremail@example.org' } + await expect(mutate({ mutation, variables })).resolves.toMatchObject({ + errors: [ + { message: 'UserInputError: Invitation code already used or does not exist.' }, + ], + }) + }) + }) + + describe('if a user account with the given email already exists', () => { + beforeEach(async () => { + await factory.create('User', { email: 'someuser@example.org' }) + }) + + it('throws unique violation error', async () => { + await expect(mutate({ mutation, variables })).resolves.toMatchObject({ + errors: [{ message: 'User account with this email already exists.' }], + }) + }) + }) + + describe('if the EmailAddress already exists but without user account', () => { + it.todo('shall we re-send the registration email?') + }) }) }) }) @@ -251,61 +272,79 @@ describe('SignupByInvitation', () => { }) describe('Signup', () => { - const mutation = `mutation($email: String!) { - Signup(email: $email) { email } - }` - - it('throws AuthorizationError', async () => { - client = new GraphQLClient(host) - await expect( - client.request(mutation, { email: 'get-me-a-user-account@example.org' }), - ).rejects.toThrow('Not Authorised') + const mutation = gql` + mutation($email: String!) { + Signup(email: $email) { + email + } + } + ` + beforeEach(() => { + variables = { ...variables, email: 'someuser@example.org' } }) - describe('as admin', () => { - beforeEach(async () => { - userParams = { - role: 'admin', - email: 'admin@example.org', - password: '1234', - } - variables.email = 'someuser@example.org' - const factory = Factory() - await factory.create('User', userParams) - const headers = await login(userParams) - client = new GraphQLClient(host, { headers }) - action = async () => { - return client.request(mutation, variables) - } + describe('unauthenticated', () => { + beforeEach(() => { + authenticatedUser = null }) - it('is allowed to signup users by email', async () => { - await expect(action()).resolves.toEqual({ Signup: { email: 'someuser@example.org' } }) + it('throws AuthorizationError', async () => { + await expect(mutate({ mutation, variables })).resolves.toMatchObject({ + errors: [{ message: 'Not Authorised!' }], + }) }) - it('creates a Signup with a cryptographic `nonce`', async () => { - await action() - let emailAddress = await instance.first('EmailAddress', { email: 'someuser@example.org' }) - emailAddress = await emailAddress.toJson() - expect(emailAddress.nonce).toEqual(expect.any(String)) + describe('as admin', () => { + beforeEach(async () => { + const admin = await factory.create('User', { + role: 'admin', + email: 'admin@example.org', + password: '1234', + }) + authenticatedUser = await admin.toJson() + }) + + it('is allowed to signup users by email', async () => { + await expect(mutate({ mutation, variables })).resolves.toMatchObject({ + data: { Signup: { email: 'someuser@example.org' } }, + }) + }) + + it('creates a Signup with a cryptographic `nonce`', async () => { + await mutate({ mutation, variables }) + let emailAddress = await neode.first('EmailAddress', { email: 'someuser@example.org' }) + emailAddress = await emailAddress.toJson() + expect(emailAddress.nonce).toEqual(expect.any(String)) + }) }) }) }) describe('SignupVerification', () => { - const mutation = ` - mutation($name: String!, $password: String!, $email: String!, $nonce: String!, $termsAndConditionsAgreedVersion: String!) { - SignupVerification(name: $name, password: $password, email: $email, nonce: $nonce, termsAndConditionsAgreedVersion: $termsAndConditionsAgreedVersion) { - id - termsAndConditionsAgreedVersion - } + const mutation = gql` + mutation( + $name: String! + $password: String! + $email: String! + $nonce: String! + $termsAndConditionsAgreedVersion: String! + ) { + SignupVerification( + name: $name + password: $password + email: $email + nonce: $nonce + termsAndConditionsAgreedVersion: $termsAndConditionsAgreedVersion + ) { + id + termsAndConditionsAgreedVersion } - ` + } + ` describe('given valid password and email', () => { - let variables - beforeEach(async () => { variables = { + ...variables, nonce: '123456', name: 'John Doe', password: '123', @@ -316,15 +355,15 @@ describe('SignupVerification', () => { describe('unauthenticated', () => { beforeEach(async () => { - client = new GraphQLClient(host) + authenticatedUser = null }) describe('EmailAddress exists, but is already related to a user account', () => { beforeEach(async () => { const { email, nonce } = variables const [emailAddress, user] = await Promise.all([ - instance.model('EmailAddress').create({ email, nonce }), - instance + neode.model('EmailAddress').create({ email, nonce }), + neode .model('User') .create({ name: 'Somebody', password: '1234', email: 'john@example.org' }), ]) @@ -333,13 +372,13 @@ describe('SignupVerification', () => { describe('sending a valid nonce', () => { beforeEach(() => { - variables.nonce = '123456' + variables = { ...variables, nonce: '123456' } }) it('rejects', async () => { - await expect(client.request(mutation, variables)).rejects.toThrow( - 'Invalid email or nonce', - ) + await expect(mutate({ mutation, variables })).resolves.toMatchObject({ + errors: [{ message: 'Invalid email or nonce' }], + }) }) }) }) @@ -350,22 +389,23 @@ describe('SignupVerification', () => { email: 'john@example.org', nonce: '123456', } - await instance.model('EmailAddress').create(args) + await neode.model('EmailAddress').create(args) }) describe('sending a valid nonce', () => { it('creates a user account', async () => { - const expected = { - SignupVerification: expect.objectContaining({ - id: expect.any(String), - }), - } - await expect(client.request(mutation, variables)).resolves.toEqual(expected) + await expect(mutate({ mutation, variables })).resolves.toMatchObject({ + data: { + SignupVerification: expect.objectContaining({ + id: expect.any(String), + }), + }, + }) }) it('sets `verifiedAt` attribute of EmailAddress', async () => { - await client.request(mutation, variables) - const email = await instance.first('EmailAddress', { email: 'john@example.org' }) + await mutate({ mutation, variables }) + const email = await neode.first('EmailAddress', { email: 'john@example.org' }) await expect(email.toJson()).resolves.toEqual( expect.objectContaining({ verifiedAt: expect.any(String), @@ -378,8 +418,8 @@ describe('SignupVerification', () => { MATCH(email:EmailAddress)-[:BELONGS_TO]->(u:User {name: {name}}) RETURN email ` - await client.request(mutation, variables) - const { records: emails } = await instance.cypher(cypher, { name: 'John Doe' }) + await mutate({ mutation, variables }) + const { records: emails } = await neode.cypher(cypher, { name: 'John Doe' }) expect(emails).toHaveLength(1) }) @@ -388,39 +428,38 @@ describe('SignupVerification', () => { MATCH(email:EmailAddress)<-[:PRIMARY_EMAIL]-(u:User {name: {name}}) RETURN email ` - await client.request(mutation, variables) - const { records: emails } = await instance.cypher(cypher, { name: 'John Doe' }) + await mutate({ mutation, variables }) + const { records: emails } = await neode.cypher(cypher, { name: 'John Doe' }) expect(emails).toHaveLength(1) }) it('is version of terms and conditions saved correctly', async () => { - const expected = { - SignupVerification: expect.objectContaining({ - termsAndConditionsAgreedVersion: '0.0.1', - }), - } - await expect(client.request(mutation, variables)).resolves.toEqual(expected) + await expect(mutate({ mutation, variables })).resolves.toMatchObject({ + data: { + SignupVerification: expect.objectContaining({ + termsAndConditionsAgreedVersion: '0.0.1', + }), + }, + }) }) it('rejects if version of terms and conditions has wrong format', async () => { - await expect( - client.request(mutation, { - ...variables, - termsAndConditionsAgreedVersion: 'invalid version format', - }), - ).rejects.toThrow('Invalid version format!') + variables = { ...variables, termsAndConditionsAgreedVersion: 'invalid version format' } + await expect(mutate({ mutation, variables })).resolves.toMatchObject({ + errors: [{ message: 'Invalid version format!' }], + }) }) }) describe('sending invalid nonce', () => { beforeEach(() => { - variables.nonce = 'wut2' + variables = { ...variables, nonce: 'wut2' } }) it('rejects', async () => { - await expect(client.request(mutation, variables)).rejects.toThrow( - 'Invalid email or nonce', - ) + await expect(mutate({ mutation, variables })).resolves.toMatchObject({ + errors: [{ message: 'Invalid email or nonce' }], + }) }) }) }) diff --git a/backend/src/schema/resolvers/statistics.js b/backend/src/schema/resolvers/statistics.js index db6e205d2..466c1ef70 100644 --- a/backend/src/schema/resolvers/statistics.js +++ b/backend/src/schema/resolvers/statistics.js @@ -1,68 +1,37 @@ -export const query = (cypher, session) => { - return new Promise((resolve, reject) => { - const data = [] - session.run(cypher).subscribe({ - onNext: function(record) { - const item = {} - record.keys.forEach(key => { - item[key] = record.get(key) - }) - data.push(item) - }, - onCompleted: function() { - session.close() - resolve(data) - }, - onError: function(error) { - reject(error) - }, - }) - }) -} -const queryOne = (cypher, session) => { - return new Promise((resolve, reject) => { - query(cypher, session) - .then(res => { - resolve(res.length ? res.pop() : {}) - }) - .catch(err => { - reject(err) - }) - }) -} - export default { Query: { statistics: async (parent, args, { driver, user }) => { - return new Promise(resolve => { - const session = driver.session() - const queries = { - countUsers: - 'MATCH (r:User) WHERE r.deleted <> true OR NOT exists(r.deleted) RETURN COUNT(r) AS countUsers', - countPosts: - 'MATCH (r:Post) WHERE r.deleted <> true OR NOT exists(r.deleted) RETURN COUNT(r) AS countPosts', - countComments: - 'MATCH (r:Comment) WHERE r.deleted <> true OR NOT exists(r.deleted) RETURN COUNT(r) AS countComments', - countNotifications: 'MATCH ()-[r:NOTIFIED]->() RETURN COUNT(r) AS countNotifications', - countInvites: 'MATCH (r:InvitationCode) RETURN COUNT(r) AS countInvites', - countFollows: 'MATCH (:User)-[r:FOLLOWS]->(:User) RETURN COUNT(r) AS countFollows', - countShouts: 'MATCH (:User)-[r:SHOUTED]->(:Post) RETURN COUNT(r) AS countShouts', + const session = driver.session() + const response = {} + try { + const mapping = { + countUsers: 'User', + countPosts: 'Post', + countComments: 'Comment', + countNotifications: 'NOTIFIED', + countInvites: 'InvitationCode', + countFollows: 'FOLLOWS', + countShouts: 'SHOUTED', } - const data = { - countUsers: queryOne(queries.countUsers, session).then(res => res.countUsers.low), - countPosts: queryOne(queries.countPosts, session).then(res => res.countPosts.low), - countComments: queryOne(queries.countComments, session).then( - res => res.countComments.low, - ), - countNotifications: queryOne(queries.countNotifications, session).then( - res => res.countNotifications.low, - ), - countInvites: queryOne(queries.countInvites, session).then(res => res.countInvites.low), - countFollows: queryOne(queries.countFollows, session).then(res => res.countFollows.low), - countShouts: queryOne(queries.countShouts, session).then(res => res.countShouts.low), - } - resolve(data) - }) + const cypher = ` + CALL apoc.meta.stats() YIELD labels, relTypesCount + RETURN labels, relTypesCount + ` + const result = await session.run(cypher) + const [statistics] = await result.records.map(record => { + return { + ...record.get('labels'), + ...record.get('relTypesCount'), + } + }) + Object.keys(mapping).forEach(key => { + const stat = statistics[mapping[key]] + response[key] = stat ? stat.toNumber() : 0 + }) + } finally { + session.close() + } + return response }, }, } diff --git a/backend/src/schema/types/schema.gql b/backend/src/schema/types/schema.gql index 7aa04ea57..eb78cabfe 100644 --- a/backend/src/schema/types/schema.gql +++ b/backend/src/schema/types/schema.gql @@ -2,8 +2,6 @@ type Query { isLoggedIn: Boolean! # Get the currently logged in User based on the given JWT Token currentUser: User - # Get the latest Network Statistics - statistics: Statistics! findPosts(query: String!, limit: Int = 10, filter: _PostFilter): [Post]! @cypher( statement: """ @@ -39,16 +37,6 @@ type Mutation { unfollow(id: ID!, type: FollowTypeEnum): Boolean! } -type Statistics { - countUsers: Int! - countPosts: Int! - countComments: Int! - countNotifications: Int! - countInvites: Int! - countFollows: Int! - countShouts: Int! -} - type Report { id: ID! submitter: User @relation(name: "REPORTED", direction: "IN") diff --git a/backend/src/schema/types/type/Statistics.gql b/backend/src/schema/types/type/Statistics.gql new file mode 100644 index 000000000..3963a3e50 --- /dev/null +++ b/backend/src/schema/types/type/Statistics.gql @@ -0,0 +1,14 @@ +type Query { + statistics: Statistics! +} + +type Statistics { + countUsers: Int! + countPosts: Int! + countComments: Int! + countNotifications: Int! + countInvites: Int! + countFollows: Int! + countShouts: Int! +} + diff --git a/backend/yarn.lock b/backend/yarn.lock index 2bf269e86..b6f9d363a 100644 --- a/backend/yarn.lock +++ b/backend/yarn.lock @@ -3336,10 +3336,10 @@ eslint-plugin-import@~2.18.2: read-pkg-up "^2.0.0" resolve "^1.11.0" -eslint-plugin-jest@~22.16.0: - version "22.16.0" - resolved "https://registry.yarnpkg.com/eslint-plugin-jest/-/eslint-plugin-jest-22.16.0.tgz#30c4e0e9dc331beb2e7369b70dd1363690c1ce05" - integrity sha512-eBtSCDhO1k7g3sULX/fuRK+upFQ7s548rrBtxDyM1fSoY7dTWp/wICjrJcDZKVsW7tsFfH22SG+ZaxG5BZodIg== +eslint-plugin-jest@~22.17.0: + version "22.17.0" + resolved "https://registry.yarnpkg.com/eslint-plugin-jest/-/eslint-plugin-jest-22.17.0.tgz#dc170ec8369cd1bff9c5dd8589344e3f73c88cf6" + integrity sha512-WT4DP4RoGBhIQjv+5D0FM20fAdAUstfYAf/mkufLNTojsfgzc5/IYW22cIg/Q4QBavAZsROQlqppiWDpFZDS8Q== dependencies: "@typescript-eslint/experimental-utils" "^1.13.0" diff --git a/neo4j/Dockerfile b/neo4j/Dockerfile index 1cfa04507..fcd53fa04 100644 --- a/neo4j/Dockerfile +++ b/neo4j/Dockerfile @@ -1,4 +1,4 @@ -FROM neo4j:3.5.8 +FROM neo4j:3.5.9 LABEL Description="Neo4J database of the Social Network Human-Connection.org with preinstalled database constraints and indices" Vendor="Human Connection gGmbH" Version="0.0.1" Maintainer="Human Connection gGmbH (developer@human-connection.org)" ARG BUILD_COMMIT diff --git a/webapp/Dockerfile b/webapp/Dockerfile index 4b219d2fe..cf9c4c698 100644 --- a/webapp/Dockerfile +++ b/webapp/Dockerfile @@ -1,4 +1,4 @@ -FROM node:12.9-alpine as base +FROM node:12.10.0-alpine as base LABEL Description="Web Frontend of the Social Network Human-Connection.org" Vendor="Human-Connection gGmbH" Version="0.0.1" Maintainer="Human-Connection gGmbH (developer@human-connection.org)" EXPOSE 3000 diff --git a/webapp/components/Comment.vue b/webapp/components/Comment.vue index 3b2170661..7547927eb 100644 --- a/webapp/components/Comment.vue +++ b/webapp/components/Comment.vue @@ -59,7 +59,7 @@ - diff --git a/webapp/pages/moderation/index.vue b/webapp/pages/moderation/index.vue index e6b8532fc..9988ebc7a 100644 --- a/webapp/pages/moderation/index.vue +++ b/webapp/pages/moderation/index.vue @@ -1,8 +1,6 @@