From fd1e2c91fd0d39094c1719f98f195e58468b3c4a Mon Sep 17 00:00:00 2001
From: mattwr18 <mattwr18@gmail.com>
Date: Thu, 12 Dec 2019 18:48:56 +0100
Subject: [PATCH] Refactor to consolidate UpdateUser mutations

---
 webapp/components/LocaleSwitch/LocaleSwitch.vue | 12 +++---------
 webapp/components/Upload/index.vue              | 12 +++---------
 webapp/graphql/User.js                          |  7 +++++++
 webapp/pages/terms-and-conditions-confirm.vue   | 14 ++++----------
 4 files changed, 17 insertions(+), 28 deletions(-)

diff --git a/webapp/components/LocaleSwitch/LocaleSwitch.vue b/webapp/components/LocaleSwitch/LocaleSwitch.vue
index 564de20f7..156af4cb0 100644
--- a/webapp/components/LocaleSwitch/LocaleSwitch.vue
+++ b/webapp/components/LocaleSwitch/LocaleSwitch.vue
@@ -33,12 +33,12 @@
 </template>
 
 <script>
-import gql from 'graphql-tag'
 import Dropdown from '~/components/Dropdown'
 import find from 'lodash/find'
 import orderBy from 'lodash/orderBy'
 import locales from '~/locales'
 import { mapGetters, mapMutations } from 'vuex'
+import { updateUserMutation } from '~/graphql/User.js'
 
 export default {
   components: {
@@ -87,16 +87,10 @@ export default {
       if (!this.currentUser || !this.currentUser.id) return null
       try {
         await this.$apollo.mutate({
-          mutation: gql`
-            mutation($id: ID!, $locale: String) {
-              UpdateUser(id: $id, locale: $locale) {
-                id
-                locale
-              }
-            }
-          `,
+          mutation: updateUserMutation(),
           variables: {
             id: this.currentUser.id,
+            name: this.currentUser.name,
             locale: this.$i18n.locale(),
           },
           update: (store, { data: { UpdateUser } }) => {
diff --git a/webapp/components/Upload/index.vue b/webapp/components/Upload/index.vue
index 64a6ce891..3b2106971 100644
--- a/webapp/components/Upload/index.vue
+++ b/webapp/components/Upload/index.vue
@@ -21,7 +21,7 @@
 </template>
 <script>
 import vueDropzone from 'nuxt-dropzone'
-import gql from 'graphql-tag'
+import { updateUserMutation } from '~/graphql/User.js'
 
 export default {
   components: {
@@ -62,17 +62,11 @@ export default {
       const avatarUpload = file[0]
       this.$apollo
         .mutate({
-          mutation: gql`
-            mutation($id: ID!, $avatarUpload: Upload) {
-              UpdateUser(id: $id, avatarUpload: $avatarUpload) {
-                id
-                avatar
-              }
-            }
-          `,
+          mutation: updateUserMutation(),
           variables: {
             avatarUpload,
             id: this.user.id,
+            name: this.user.name,
           },
         })
         .then(() => {
diff --git a/webapp/graphql/User.js b/webapp/graphql/User.js
index 8570db999..60366ff73 100644
--- a/webapp/graphql/User.js
+++ b/webapp/graphql/User.js
@@ -149,7 +149,10 @@ export const updateUserMutation = () => {
       $locationName: String
       $about: String
       $allowEmbedIframes: Boolean
+      $showShoutsPublicly: Boolean
       $locale: String
+      $termsAndConditionsAgreedVersion: String
+      $avatarUpload: Upload
     ) {
       UpdateUser(
         id: $id
@@ -160,6 +163,8 @@ export const updateUserMutation = () => {
         allowEmbedIframes: $allowEmbedIframes
         showShoutsPublicly: $showShoutsPublicly
         locale: $locale
+        termsAndConditionsAgreedVersion: $termsAndConditionsAgreedVersion
+        avatarUpload: $avatarUpload
       ) {
         id
         slug
@@ -169,6 +174,8 @@ export const updateUserMutation = () => {
         allowEmbedIframes
         showShoutsPublicly
         locale
+        termsAndConditionsAgreedVersion
+        avatar
       }
     }
   `
diff --git a/webapp/pages/terms-and-conditions-confirm.vue b/webapp/pages/terms-and-conditions-confirm.vue
index 09e40ac7c..9a0c89821 100644
--- a/webapp/pages/terms-and-conditions-confirm.vue
+++ b/webapp/pages/terms-and-conditions-confirm.vue
@@ -24,17 +24,10 @@
 </template>
 
 <script>
-import gql from 'graphql-tag'
 import { mapGetters, mapMutations } from 'vuex'
 import { VERSION } from '~/constants/terms-and-conditions-version.js'
-const mutation = gql`
-  mutation($id: ID!, $termsAndConditionsAgreedVersion: String) {
-    UpdateUser(id: $id, termsAndConditionsAgreedVersion: $termsAndConditionsAgreedVersion) {
-      id
-      termsAndConditionsAgreedVersion
-    }
-  }
-`
+import { updateUserMutation } from '~/graphql/User.js'
+
 export default {
   layout: 'default',
   head() {
@@ -74,9 +67,10 @@ export default {
     async submit() {
       try {
         await this.$apollo.mutate({
-          mutation,
+          mutation: updateUserMutation(),
           variables: {
             id: this.currentUser.id,
+            name: this.currentUser.name,
             termsAndConditionsAgreedVersion: VERSION,
           },
           update: (store, { data: { UpdateUser } }) => {