Robert Schäfer
055b79bfe2
RemoveLinks is better suited as a filter
...
Unfortunately with `v-html` you cannot use filters directly in
handlebars.
See: https://github.com/nuxt/nuxt.js/issues/231
I also fixed the tests even **without** mocking vue-filters.js plugin 👍
2019-04-17 01:54:53 +02:00
Matt Rider
9bc0c0f92c
Add tests, create comments only when authenticated
2019-04-16 20:31:34 -03:00
Robert Schäfer
e595135e9d
Display post.createdAt along with Notification
2019-04-17 01:18:53 +02:00
Robert Schäfer
f5afdf2435
Merge Notification with NotificationPostCard
...
cc @mattwr18 Please don't see this as a revert of your work. Your
structure of the `notification-post-card` component was helpful and showed
the redundancy with `hc-post-card`. I reused a lot of the code, but
because I merged both components it now *looks* as if I authored all the code.
2019-04-17 01:10:17 +02:00
Matt Rider
dfef4fe05f
Add custom resolver, update factories
2019-04-16 19:48:59 -03:00
Robert Schäfer
055cb2f349
Merge remote-tracking branch 'origin/master' into 347-display_notifications
2019-04-17 00:08:51 +02:00
Robert Schäfer
00046a5429
Remove obsolete href method
2019-04-17 00:08:39 +02:00
Robert Schäfer
c4577aa3e8
Move mixins to the right place
2019-04-17 00:08:39 +02:00
Robert Schäfer
4f2e70e871
Refactor and harden PostCard component
2019-04-17 00:08:21 +02:00
Robert Schäfer
128480fd0e
Implement first test for Notification
...
Fixed a bug along the way `(post.contentExcerpt == null)`
2019-04-17 00:08:21 +02:00
Robert Schäfer
af60ad39a4
Follow directory layout
2019-04-17 00:08:21 +02:00
dependabot[bot]
0fe1bcb982
Bump tiptap-extensions from 1.14.0 to 1.15.0 in /webapp
...
Bumps [tiptap-extensions](https://github.com/scrumpy/tiptap ) from 1.14.0 to 1.15.0.
- [Release notes](https://github.com/scrumpy/tiptap/releases )
- [Commits](https://github.com/scrumpy/tiptap/compare/tiptap-extensions@1.14.0...tiptap-extensions@1.15.0 )
Signed-off-by: dependabot[bot] <support@dependabot.com>
2019-04-17 00:08:21 +02:00
Robert Schäfer
9ed204fa72
Open mentioning link in new tab
...
This will help some people not to loose data after accidently clicking
on the user @-mentioning.
2019-04-17 00:08:21 +02:00
Robert Schäfer
fe551ece47
Create notifications on UpdatePost, too
...
Note that we don't create duplicate notifications. I made use of the behaviour
of XSS-middleware: It removes all css classes from `<a>` anchors. Because
notifications rely on a css class `mention` which gets removed in a later
middleware, this gives us a nice behaviour for re-notifications without creating
duplicates. The downside is that it creates dependencies between middlewares and
it's not that obvious at all.
cc @mattwr18 @ulfgebhardt @appinteractive @Tirokk
2019-04-17 00:08:21 +02:00
Robert Schäfer
f86e98b32e
Implement right order of notifications middleware
2019-04-17 00:08:21 +02:00
Robert Schäfer
4a6ef3f9f6
Implement parsing of mention links
2019-04-17 00:08:21 +02:00
Robert Schäfer
cd2bbbef30
Change backend test to parse html not plain text
2019-04-17 00:08:21 +02:00
Robert Schäfer
c050bddf4e
Follow component directory strucutre in backend
2019-04-17 00:08:21 +02:00
Robert Schäfer
dd1d86e02c
Use slugs instead of names for mentions
2019-04-17 00:08:21 +02:00
Robert Schäfer
25bef85683
Order users by name
2019-04-17 00:08:21 +02:00
Robert Schäfer
d885fd1beb
Move ContributionForm in dedicated folder
2019-04-17 00:08:21 +02:00
Robert Schäfer
fcafb4e105
Fix lint
2019-04-17 00:08:21 +02:00
Robert Schäfer
bf18754b4d
Customize Mention node based on Superclass
2019-04-17 00:08:21 +02:00
Robert Schäfer
b5f60369a5
Follow file naming convention
...
All components should consist of a folder with these three files:
```
README.d
index.vue
spec.js
```
When you import components, omit the `index.vue`. That helps to `git
grep` for component names.
2019-04-17 00:08:21 +02:00
Robert Schäfer
4d9c6c5b1c
Pass entire user collection to Editor
2019-04-17 00:08:21 +02:00
Robert Schäfer
7d3b1ea3cc
Copy+paste from tiptap example
...
See https://github.com/scrumpy/tiptap/blob/master/examples/Components/Routes/Suggestions/index.vue
2019-04-17 00:08:21 +02:00
Robert Schäfer
3be83ca7d0
Convenience: Run seeds from root folder
2019-04-17 00:08:21 +02:00
Robert Schäfer
5f456fe752
Scaffold test for Editor.vue
2019-04-17 00:08:21 +02:00
Robert Schäfer
1fc76e0c4e
Get rid of annoying lint error screen
...
@appinteractive we have `yarn run lint` on our build server. I would say
this is enough to enforce linting. I get slowed down a little during
development. Instead of runing `yarn run lint --fix` every time I save, I
would like to `yarn run lint --fix` all in one before I commit.
2019-04-17 00:08:21 +02:00
Robert Schäfer
b42863a890
Follow suggestions by @mattwr18
2019-04-16 22:21:28 +02:00
Robert Schäfer
ab0d10a5d9
Merge remote-tracking branch 'origin/master' into 447-generate_mentioning_link_in_editor
2019-04-16 22:15:20 +02:00
Robert Schäfer
7ce375e435
Merge pull request #473 from Human-Connection/dependabot/npm_and_yarn/webapp/tiptap-extensions-1.15.0
...
Bump tiptap-extensions from 1.14.0 to 1.15.0 in /webapp
2019-04-16 22:13:00 +02:00
Robert Schäfer
e247d25aee
Open mentioning link in new tab
...
This will help some people not to loose data after accidently clicking
on the user @-mentioning.
2019-04-16 22:11:07 +02:00
Robert Schäfer
65f96c2b28
Create notifications on UpdatePost, too
...
Note that we don't create duplicate notifications. I made use of the behaviour
of XSS-middleware: It removes all css classes from `<a>` anchors. Because
notifications rely on a css class `mention` which gets removed in a later
middleware, this gives us a nice behaviour for re-notifications without creating
duplicates. The downside is that it creates dependencies between middlewares and
it's not that obvious at all.
cc @mattwr18 @ulfgebhardt @appinteractive @Tirokk
2019-04-16 22:11:07 +02:00
Matt Rider
674cdddfc3
Add Editor, cancel/submit buttons for comments
...
- to PagesPost_id_slugIndex.vue
- handle simple comment creation using auto-generated resolver
Co-authored-by: Joseph "Kachulio" Ngugi <jngugi88@gmail.com>
2019-04-16 13:45:07 -03:00
Robert Schäfer
aa3762a095
Implement right order of notifications middleware
2019-04-16 17:48:42 +02:00
Robert Schäfer
b2d72ae74a
Implement parsing of mention links
2019-04-16 16:05:09 +02:00
Robert Schäfer
f30da038d9
Change backend test to parse html not plain text
2019-04-16 11:21:38 +02:00
Robert Schäfer
23a461d16e
Follow component directory strucutre in backend
2019-04-16 11:13:40 +02:00
dependabot[bot]
0468d9972c
Bump tiptap-extensions from 1.14.0 to 1.15.0 in /webapp
...
Bumps [tiptap-extensions](https://github.com/scrumpy/tiptap ) from 1.14.0 to 1.15.0.
- [Release notes](https://github.com/scrumpy/tiptap/releases )
- [Commits](https://github.com/scrumpy/tiptap/compare/tiptap-extensions@1.14.0...tiptap-extensions@1.15.0 )
Signed-off-by: dependabot[bot] <support@dependabot.com>
2019-04-16 04:55:13 +00:00
dependabot[bot]
974c088f42
Bump nuxt from 2.6.1 to 2.6.2 in /webapp
...
Bumps [nuxt](https://github.com/nuxt/nuxt.js ) from 2.6.1 to 2.6.2.
- [Release notes](https://github.com/nuxt/nuxt.js/releases )
- [Changelog](https://github.com/nuxt/nuxt.js/blob/dev/RELEASE_PLAN.md )
- [Commits](https://github.com/nuxt/nuxt.js/compare/v2.6.1...v2.6.2 )
Signed-off-by: dependabot[bot] <support@dependabot.com>
2019-04-16 04:54:38 +00:00
Robert Schäfer
f5cf3d9b68
Use slugs instead of names for mentions
2019-04-16 02:08:29 +02:00
Matt Rider
faf25f5e45
Rename mentions feature
...
- to use mentions instead of mentionings
2019-04-15 20:58:15 -03:00
Robert Schäfer
7492e6b8c3
Order users by name
2019-04-16 01:39:47 +02:00
Robert Schäfer
4efb834599
Move ContributionForm in dedicated folder
2019-04-16 01:39:47 +02:00
Robert Schäfer
b21df879c6
Fix lint
2019-04-16 01:39:47 +02:00
Robert Schäfer
d87a0d5694
Customize Mention node based on Superclass
2019-04-16 01:39:47 +02:00
Robert Schäfer
b70e5be8b1
Follow file naming convention
...
All components should consist of a folder with these three files:
```
README.d
index.vue
spec.js
```
When you import components, omit the `index.vue`. That helps to `git
grep` for component names.
2019-04-16 01:39:47 +02:00
Robert Schäfer
f760f37186
Pass entire user collection to Editor
2019-04-16 01:39:47 +02:00
Robert Schäfer
2529c62137
Copy+paste from tiptap example
...
See https://github.com/scrumpy/tiptap/blob/master/examples/Components/Routes/Suggestions/index.vue
2019-04-16 01:39:47 +02:00