mattwr18
18ab7186f5
Favor transaction functions over auto-commit
2019-12-11 18:53:08 +01:00
mattwr18
b1c5c4dbf9
Avoid testing third-party code
...
- This test, though I understand why it was added, is not necessary in
my opinion. It's more difficult to get this test to pass since we don't
call session.run, we call session.writeTransaction which has a callback
that calls transaction.run...
- I think we don't need to test that our third party library does what
it was added to do... they have their own tests, which can be found here
@roschaefer , which I think are sufficient https://github.com/validatorjs/validator.js/blob/master/test/sanitizers.js
- We can always add another type of test, if you feel necessary, maybe
an e2e?
2019-12-11 18:44:01 +01:00
mattwr18
3c6932e21a
Update passwordReset resolver/spec
2019-12-11 18:43:36 +01:00
mattwr18
d39e702e70
Update exisitingEmailAddress
2019-12-11 18:19:40 +01:00
mattwr18
b583b02fb4
Update createPasswordReset helper function
...
- the test is broken, can you have a look @roschaefer??
- I tried to get it to work, but it's complicated with multiple
promises... I'm ok if we remove this test as well as it's only testing
that normalizeEmail works as it's supposed to... but that hopefully is
tested on the side of the validator library
2019-12-11 17:57:25 +01:00
mattwr18
c871ec2632
Refactor validationMiddleware
2019-12-11 16:29:20 +01:00
mattwr18
cc0a33ec7d
Use transaction function in isUniqueFor
2019-12-11 13:26:18 +01:00
mattwr18
73a5b394d6
Refactor isAuthor to use transaction function
2019-12-11 12:56:49 +01:00
mattwr18
ca9c58c06b
Add errors undefined to tests
...
- helps with debugging
2019-12-11 12:50:46 +01:00
mattwr18
760fd01715
Finish refactor of notifications resolver
2019-12-11 11:06:44 +01:00
mattwr18
79d23cc6de
Merge branch 'master' of github.com:Human-Connection/Human-Connection into 2412-favor-transaction-function
2019-12-11 10:56:42 +01:00
roschaefer
cc7cd6b8b0
Fix backend tests
2019-12-10 18:13:34 +01:00
mattwr18
4f0df2f28f
Remove disable from query request
...
- we removed it, prevent null pointer error
2019-12-10 18:09:32 +01:00
mattwr18
0a50a02f88
Follow @roschaefer suggestion/remove guard clauses
2019-12-10 18:09:32 +01:00
mattwr18
12236c9324
Convert to transaction function/refactor
...
- update incorrect variables
2019-12-10 18:09:32 +01:00
roschaefer
3beef5e3fb
Reduce database statements in notifications
2019-12-10 18:09:32 +01:00
roschaefer
b2ccc1b61e
Better debugging
2019-12-10 18:09:32 +01:00
mattwr18
b232b038ec
Merge pull request #2455 from Human-Connection/dependabot/npm_and_yarn/backend/babel/preset-env-7.7.6
...
build(deps-dev): bump @babel/preset-env from 7.7.4 to 7.7.6 in /backend
2019-12-10 14:41:18 +01:00
mattwr18
097afbf764
Merge pull request #2458 from Human-Connection/dependabot/npm_and_yarn/backend/babel/cli-7.7.5
...
build(deps-dev): bump @babel/cli from 7.7.4 to 7.7.5 in /backend
2019-12-10 14:41:01 +01:00
mattwr18
1d7a728ea3
Merge pull request #2473 from Human-Connection/dependabot/npm_and_yarn/backend/sentry/node-5.10.2
...
build(deps): bump @sentry/node from 5.10.1 to 5.10.2 in /backend
2019-12-10 14:30:25 +01:00
mattwr18
2633597f7d
Merge pull request #2474 from Human-Connection/dependabot/npm_and_yarn/backend/eslint-plugin-import-2.19.1
...
build(deps-dev): bump eslint-plugin-import from 2.18.2 to 2.19.1 in /backend
2019-12-10 14:29:42 +01:00
mattwr18
4af63ee0aa
Merge pull request #2404 from Human-Connection/get_rid_of_inconsistency_with_setup_neode
...
Get rid of inconsistency with neode setup
2019-12-10 11:04:35 +01:00
dependabot-preview[bot]
9d992897f0
build(deps-dev): bump eslint-plugin-import in /backend
...
Bumps [eslint-plugin-import](https://github.com/benmosher/eslint-plugin-import ) from 2.18.2 to 2.19.1.
- [Release notes](https://github.com/benmosher/eslint-plugin-import/releases )
- [Changelog](https://github.com/benmosher/eslint-plugin-import/blob/master/CHANGELOG.md )
- [Commits](https://github.com/benmosher/eslint-plugin-import/compare/v2.18.2...v2.19.1 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-12-10 04:19:26 +00:00
dependabot-preview[bot]
d112b33577
build(deps): bump @sentry/node from 5.10.1 to 5.10.2 in /backend
...
Bumps [@sentry/node](https://github.com/getsentry/sentry-javascript ) from 5.10.1 to 5.10.2.
- [Release notes](https://github.com/getsentry/sentry-javascript/releases )
- [Changelog](https://github.com/getsentry/sentry-javascript/blob/master/CHANGELOG.md )
- [Commits](https://github.com/getsentry/sentry-javascript/compare/5.10.1...5.10.2 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-12-10 04:18:54 +00:00
Robert Schäfer
6dd435a4d1
Merge pull request #2456 from Human-Connection/dependabot/npm_and_yarn/backend/nodemailer-6.4.1
...
build(deps): bump nodemailer from 6.4.0 to 6.4.1 in /backend
2019-12-09 22:18:44 +01:00
dependabot-preview[bot]
be8b712bb9
build(deps-dev): bump @babel/preset-env from 7.7.4 to 7.7.6 in /backend
...
Bumps [@babel/preset-env](https://github.com/babel/babel ) from 7.7.4 to 7.7.6.
- [Release notes](https://github.com/babel/babel/releases )
- [Changelog](https://github.com/babel/babel/blob/master/CHANGELOG.md )
- [Commits](https://github.com/babel/babel/compare/v7.7.4...v7.7.6 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-12-09 21:18:27 +00:00
Robert Schäfer
1fb442db07
Merge branch 'master' into dependabot/npm_and_yarn/backend/babel/cli-7.7.5
2019-12-09 22:18:15 +01:00
Robert Schäfer
e3fcb9adbd
Merge pull request #2460 from Human-Connection/dependabot/npm_and_yarn/backend/babel/core-7.7.5
...
build(deps-dev): bump @babel/core from 7.7.4 to 7.7.5 in /backend
2019-12-09 22:17:16 +01:00
roschaefer
5271337b49
Reduce the number of database calls even more
2019-12-09 18:49:27 +01:00
mattwr18
79c6bd5c20
Paginate moderations page without losing filtering
...
Co-authored-by: Tirokk <wolle.huss@pjannto.com>
2019-12-09 16:37:04 +01:00
dependabot-preview[bot]
065e55c9be
build(deps-dev): bump @babel/core from 7.7.4 to 7.7.5 in /backend
...
Bumps [@babel/core](https://github.com/babel/babel ) from 7.7.4 to 7.7.5.
- [Release notes](https://github.com/babel/babel/releases )
- [Changelog](https://github.com/babel/babel/blob/master/CHANGELOG.md )
- [Commits](https://github.com/babel/babel/compare/v7.7.4...v7.7.5 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-12-09 04:20:46 +00:00
dependabot-preview[bot]
ec69dde031
build(deps-dev): bump @babel/cli from 7.7.4 to 7.7.5 in /backend
...
Bumps [@babel/cli](https://github.com/babel/babel ) from 7.7.4 to 7.7.5.
- [Release notes](https://github.com/babel/babel/releases )
- [Changelog](https://github.com/babel/babel/blob/master/CHANGELOG.md )
- [Commits](https://github.com/babel/babel/compare/v7.7.4...v7.7.5 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-12-09 04:20:21 +00:00
dependabot-preview[bot]
82fcc0d414
build(deps): bump nodemailer from 6.4.0 to 6.4.1 in /backend
...
Bumps [nodemailer](https://github.com/nodemailer/nodemailer ) from 6.4.0 to 6.4.1.
- [Release notes](https://github.com/nodemailer/nodemailer/releases )
- [Changelog](https://github.com/nodemailer/nodemailer/blob/master/CHANGELOG.md )
- [Commits](https://github.com/nodemailer/nodemailer/compare/v6.4.0...v6.4.1 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-12-09 04:19:30 +00:00
mattwr18
3bc944b06d
Finish refactoring posts resolver
2019-12-06 18:56:20 +01:00
mattwr18
6ed435364c
Start updating posts resolver
2019-12-06 18:29:50 +01:00
mattwr18
6f4ee5f3b7
Refactor resolver/spec
...
- favor transaction functions
- add errors undefined, clean up specs
2019-12-06 17:48:34 +01:00
mattwr18
0e757cf94f
Refactor to fix test, DRY out code
2019-12-06 17:48:14 +01:00
mattwr18
a1acd48821
Use verbose variables
2019-12-06 14:56:14 +01:00
mattwr18
da150e0b27
Refactor notificationsMiddleware
...
- Use transaction functions
- extract validations into validationsMiddleware
- break notifyUsers into notifyUsersOfMention/notifyUsersOfComment
2019-12-06 14:48:32 +01:00
Robert Schäfer
65988ea0a1
Merge pull request #2304 from Human-Connection/dependabot/npm_and_yarn/backend/metascraper-5.8.9
...
build(deps): bump metascraper from 5.8.8 to 5.8.9 in /backend
2019-12-06 13:49:23 +01:00
Robert Schäfer
714da96a54
Merge pull request #2303 from Human-Connection/dependabot/npm_and_yarn/backend/metascraper-video-5.8.9
...
build(deps): bump metascraper-video from 5.8.7 to 5.8.9 in /backend
2019-12-06 13:49:11 +01:00
mattwr18
132951c525
Update handleContentDataOfPost to return post
...
- fix tests, functionality
2019-12-06 13:03:05 +01:00
Robert Schäfer
8e9e0be333
Merge pull request #2440 from Human-Connection/dependabot/npm_and_yarn/backend/neo4j-graphql-js-2.10.0
...
build(deps): bump neo4j-graphql-js from 2.9.3 to 2.10.0 in /backend
2019-12-06 12:37:33 +01:00
Robert Schäfer
a3251710fa
Update backend/src/schema/resolvers/users/blockedUsers.spec.js
...
Co-Authored-By: mattwr18 <mattwr18@gmail.com>
2019-12-06 12:34:33 +01:00
Robert Schäfer
df22f2a5b4
Update backend/src/middleware/hashtags/hashtagsMiddleware.spec.js
...
Co-Authored-By: mattwr18 <mattwr18@gmail.com>
2019-12-06 12:34:24 +01:00
mattwr18
8a06e9bb25
Merge pull request #2436 from Human-Connection/dependabot/npm_and_yarn/backend/sentry/node-5.10.1
...
build(deps): bump @sentry/node from 5.10.0 to 5.10.1 in /backend
2019-12-06 10:44:33 +01:00
mattwr18
0671a0cdf4
Merge pull request #2439 from Human-Connection/dependabot/npm_and_yarn/backend/apollo-server-testing-2.9.13
...
build(deps-dev): bump apollo-server-testing from 2.9.12 to 2.9.13 in /backend
2019-12-06 10:43:55 +01:00
mattwr18
e020c3bfdb
Merge pull request #2441 from Human-Connection/dependabot/npm_and_yarn/backend/apollo-server-2.9.13
...
build(deps): bump apollo-server from 2.9.12 to 2.9.13 in /backend
2019-12-06 10:39:24 +01:00
dependabot-preview[bot]
5ee362e411
build(deps): bump apollo-server from 2.9.12 to 2.9.13 in /backend
...
Bumps [apollo-server](https://github.com/apollographql/apollo-server ) from 2.9.12 to 2.9.13.
- [Release notes](https://github.com/apollographql/apollo-server/releases )
- [Changelog](https://github.com/apollographql/apollo-server/blob/master/CHANGELOG.md )
- [Commits](https://github.com/apollographql/apollo-server/compare/apollo-server@2.9.12...apollo-server@2.9.13 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-12-06 04:20:20 +00:00
dependabot-preview[bot]
c0d9fed9eb
build(deps): bump neo4j-graphql-js from 2.9.3 to 2.10.0 in /backend
...
Bumps [neo4j-graphql-js](https://github.com/neo4j-graphql/neo4j-graphql-js ) from 2.9.3 to 2.10.0.
- [Release notes](https://github.com/neo4j-graphql/neo4j-graphql-js/releases )
- [Changelog](https://github.com/neo4j-graphql/neo4j-graphql-js/blob/master/CHANGELOG.md )
- [Commits](https://github.com/neo4j-graphql/neo4j-graphql-js/commits )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-12-06 04:19:37 +00:00