ogerly
588ca43464
Title character increased from 64 to 100
2019-10-09 09:09:44 +02:00
roschaefer
99db1338c1
docs: add storybook section for edit information
2019-10-04 01:05:39 +02:00
roschaefer
3912b21ea2
refactor: use named slot for additional text
...
@mattwr18 I can see odd behaviour of the EDITED marker on mobile: The
text would just overlap.
The current behaviour has its flaws, e.g. if you have a long text it
won't wrap but overflow the comment card. But putting the additional
text into a named slot is certainly better than adding some nodes next
to the `<hc-user>` component.
2019-10-04 01:00:31 +02:00
mattwr18
a5e3c52e1d
Show that a Post/Comment has been edited
2019-10-03 12:01:04 +02:00
roschaefer
8c13234af9
Handle edge case
...
It might be that people try to register email addresses that they don't own. Then if the actual owner tries to add this email address, she should not get a unique constraint violation. Instead the email will be re-used.
Is this a security issue? Because we re-use the nonce? 🤔
2019-10-02 00:54:01 +02:00
Robert Schäfer
b31126c391
Merge pull request #1701 from Human-Connection/1273-fix-post-page-nav
...
fix the bug with scrolling post comments into view
2019-10-01 23:17:53 +02:00
roschaefer
08e73747bd
refactor: set global defaults of vue-scrollto
2019-10-01 17:51:16 +02:00
roschaefer
db1bcdd3d2
refactor: register vue-scrollto in nuxt.config.js
...
This will allow us to use this.$scrollTo in components. I'm now also
using this in the mixin. With so many `this`s it gets horribly
difficult to properly test the mixin in isolation. So I decided to test
the mixin on the component directly.
2019-10-01 17:25:28 +02:00
roschaefer
9da40c4895
fix: avoid many scrollTo calls for n components
...
Thank you @vbelolapotkov for pointing out the flaws here:
https://github.com/Human-Connection/Human-Connection/pull/1756#discussion_r329361572
So here is my attempt to fix it:
* Install `vue-scrollto` which relies on `requestAnimationFrame`
- apparently this is better on Safari and IE? 🤔
- Mocking out entire modules is easier in jest:
https://jestjs.io/docs/en/bypassing-module-mocks
* Require `checkAnchor` to be implemented on the component
2019-10-01 11:55:18 +02:00
roschaefer
0e2a0af7bf
feat: no primary button for unread notifications
...
@Tirokk if find this better, because a primary button always wants to be
clicked.
2019-09-30 17:24:57 +02:00
Wolfgang Huß
9a4187a6af
Remove update on hover and click by Roberts suggestion
2019-09-30 10:15:56 +02:00
Wolfgang Huß
e24d08f35b
Follow Roberts sorting suggestion
2019-09-30 10:06:51 +02:00
Vasily Belolapotkov
2c705a8680
sync with master to resolve merge conflicts
2019-09-29 20:33:39 +03:00
roschaefer
57598df228
refactor: re-use @vbelolapotkov's solution
...
If we make this a mixin, we can re-use the same solution for e.g. the
comment. If sb. notifies you, the browser automatically scrolls to the
comment in which you have been mentioned.
2019-09-29 14:28:38 +02:00
Wolfgang Huß
5cdd358731
Implement click update again, because of mobile has no hover
...
But I prevent multiple triggered updates for 10 seconds.
2019-09-27 16:53:48 +02:00
Wolfgang Huß
1543aa4510
Refactored error reporting
2019-09-27 16:11:25 +02:00
Wolfgang Huß
1f8cc9ef15
Sorted notifications after concatenation by Roberts suggestion
2019-09-27 16:11:25 +02:00
Wolfgang Huß
a57d228c40
Remove update on click
2019-09-27 16:11:25 +02:00
Wolfgang Huß
01cf5d3e9d
Add logic for hover and little delay for open menu if not updated
2019-09-27 16:11:25 +02:00
Wolfgang Huß
0c25b013db
Followed in big parts Roberts suggestions
2019-09-27 16:11:25 +02:00
Wolfgang Huß
a667d5cd85
Update webapp/components/notifications/NotificationMenu/NotificationMenu.vue
...
Changed to `NOTIFICATIONS_POLL_INTERVAL`
Co-Authored-By: Robert Schäfer <git@roschaefer.de>
2019-09-27 16:11:25 +02:00
mattwr18
99dafcda64
Reduce complexity of notifications watcher
...
- Co-authored-by: @Tirokk <wolle.huss@pjannto.com>
2019-09-27 16:11:25 +02:00
Wolfgang Huß
7727707d49
Followed some of Roberts suggestions and a bit more
2019-09-27 16:11:25 +02:00
Wolfgang Huß
87abcf8237
Implement this.$apollo.queries.notifications.refetch()
2019-09-27 16:11:25 +02:00
Wolfgang Huß
f4c8dec6d5
Update webapp/components/notifications/NotificationMenu/NotificationMenu.vue
...
Co-Authored-By: Robert Schäfer <git@roschaefer.de>
2019-09-27 16:11:25 +02:00
Wolfgang Huß
9d884d6fdc
Update webapp/components/notifications/NotificationMenu/NotificationMenu.vue
...
Co-Authored-By: Robert Schäfer <git@roschaefer.de>
2019-09-27 16:11:25 +02:00
Wolfgang Huß
21cd33bcf7
Update webapp/components/notifications/NotificationMenu/NotificationMenu.vue
...
Co-Authored-By: Robert Schäfer <git@roschaefer.de>
2019-09-27 16:11:25 +02:00
Wolfgang Huß
72011fbe27
Update webapp/components/notifications/NotificationMenu/NotificationMenu.vue
...
Co-Authored-By: Robert Schäfer <git@roschaefer.de>
2019-09-27 16:11:25 +02:00
Wolfgang Huß
597ec9d109
Update webapp/components/notifications/NotificationMenu/NotificationMenu.spec.js
...
Co-Authored-By: Robert Schäfer <git@roschaefer.de>
2019-09-27 16:11:25 +02:00
Wolfgang Huß
d1444619ab
Give the test more sence
2019-09-27 16:11:25 +02:00
Wolfgang Huß
da5c63e97d
Rewrite the toggleMenu call
2019-09-27 16:11:25 +02:00
Wolfgang Huß
5b6f816ae1
Update notifications menu on click
2019-09-27 16:11:25 +02:00
Wolfgang Huß
92fcaea452
Distinguish between totalNotifications and unreadNotifications
2019-09-27 16:11:25 +02:00
Wolfgang Huß
fb41d0064d
Update webapp/components/notifications/NotificationMenu/NotificationMenu.vue
...
Co-Authored-By: mattwr18 <mattwr18@gmail.com>
2019-09-27 16:11:25 +02:00
Wolfgang Huß
433a555fd4
Update webapp/components/notifications/NotificationMenu/NotificationMenu.vue
...
Co-Authored-By: mattwr18 <mattwr18@gmail.com>
2019-09-27 16:11:24 +02:00
Wolfgang Huß
ca8bb9e434
Added timing as constant
2019-09-27 16:11:24 +02:00
Wolfgang Huß
f968c12ccf
Implement updating by time and add new ones to the list
2019-09-27 16:11:24 +02:00
Wolfgang Huß
73cc068469
Fix lost translation
2019-09-27 16:11:24 +02:00
mattwr18
0f40df7cb4
Fix bug UpdateComment, Fix styling on Comment
...
- There was a bug that updates to comments were not being displayed
because of a v-show... https://vuejs.org/v2/guide/conditional.html#v-if-vs-v-show
Basically, what it says that is important for this bug is
"v-if...ensures that event listeners and child components inside the
conditional block are properly destroyed and re-created during toggles"
- Since we are using the editor to display comments in ContentViewer, we
need to set the min-height to 0px
- Co-authored-by: Alina Beck <alina.beck@mail.com>
- Co-authored-by: Robert Schäfer <git@roschaefer.de>
2019-09-25 13:39:18 +02:00
Vasily Belolapotkov
e1751347fc
fix failing client tests
2019-09-25 10:32:35 +03:00
mattwr18
766c670269
Fix import path
2019-09-25 08:26:24 +02:00
mattwr18
ee99673cec
Add Comment story, add spacing above user info
2019-09-25 08:26:24 +02:00
roschaefer
59232cefe7
Remove repeating labels from emote button
...
Our dear @Hardy-Peaceglobal mentioned that when he had a look on the app
on my mobile.
2019-09-24 11:59:44 +02:00
Vasily Belolapotkov
50feeed8bf
fix the bug with scrolling post comments into view
2019-09-24 12:47:42 +03:00
mattwr18
5e35fd6546
Merge pull request #1689 from Human-Connection/1659-remove-sleep-icon
...
Remove sleep icon from comments list
2019-09-24 10:59:29 +02:00
Alina Beck
a85fab04b6
remove failing test because specs have changed
2019-09-23 22:38:13 +01:00
roschaefer
bafc530366
Bugfix create user page - missing submit buttons
2019-09-23 22:15:53 +02:00
Alina Beck
3026b923e0
use translated title for comment list
2019-09-23 21:08:20 +01:00
Alina Beck
7104896150
remove sleep icon from comment list
2019-09-23 20:46:41 +01:00
roschaefer
353b846124
Fix #1631
...
I don't have time to really test this right now, feel free to do that
before merge.
2019-09-23 15:04:33 +02:00