ALau2088
8a8ed5131e
refactor backend and add UI
2019-05-24 08:03:39 -07:00
Robert Schäfer
81a26e14ff
Fix test case, move spec to the right location
...
@ulfgebhardt : The reason why the test case was failing is pretty
obvious. You forgot to create a user that you want to update. If there
is no user to update, then you get an empty response.
@ulfgebhardt : I moved the spec also in the right directory. You're
testing resolvers, so that's where I moved the `.spec` file.
2019-05-10 17:34:05 +02:00
Robert Schäfer
47d7c615a5
Refactoring: Put all data validations in one place
...
@ulfgebhardt @mattwr18 @tirokk
Here's how I imagined the data validation middleware. If we roll our own
input validations I would suggest to put them all in one place.
@ulfgebhardt this commit is a great example of how tests can speed you
up: Since I can rely on existing tests, I don't have to check the validations
manually. With tests you can refactor with confidence! 👍
2019-05-10 17:13:54 +02:00
82570bef7f
Merge pull request #478 from Human-Connection/2019/kw15/User_can_change_its_username_to_emptystring
...
2019/kw15/user can change its username to emptystring
2019-05-09 15:01:54 +02:00
2cb8d793fb
removed failing test
2019-05-09 14:37:42 +02:00
Robert Schäfer
287a55db9f
Remove test case entirely
...
@ulfgebhardt when I write "Remove test case" I mean indeed removing all
the lines of code of that test case, not only disabling it. Commenting
out code *and pushing it to version control* is a strong anti-pattern. Why?
First, code comments get out of date quickly. "Never trust code comments".
Second: In our example here, it creates anxiety because other contributors might
believe there was a reason why the commented code exists.
Read:
* https://blog.codinghorror.com/coding-without-comments/
* https://www.nayuki.io/page/dont-share-commented-out-code
* https://softwareengineering.stackexchange.com/questions/1/comments-are-a-code-smell
2019-05-07 14:10:12 +02:00
Robert Schäfer
0637d97648
Merge remote-tracking branch 'origin/master' into 2019/kw15/User_can_change_its_username_to_emptystring
2019-05-07 14:09:10 +02:00
3d2ce3960c
added url of conversation
2019-05-07 14:01:43 +02:00
140ba848c7
removed testcase, added todo
2019-05-07 14:00:02 +02:00
Robert Schäfer
ad111f5701
Double-check changed expectations, fix tests
...
See:
https://github.com/Human-Connection/Human-Connection/pull/478/files#r281267486
> We found the reason for it: If you have an exclamation mark in the schema e.g.
> email! and the response would e.g. expect the email for each User object, and
> the server does not have an email for the client, then the entire User object
> gets nullified.
2019-05-06 19:26:53 +02:00
9004e923af
removed unnecessary comment block
2019-05-06 13:02:09 +02:00
a71b421933
removed console log
2019-05-06 12:39:53 +02:00
ad05dcf735
frontend tests, backend tests
2019-05-02 17:47:34 +02:00
Wolfgang Huß
b03cbb212a
First Vue design of delete SocialMedia, custom mutation DeleteSocialMedia
...
Backend Jest tests for DeleteSocialMedia
New backend Jest tests for CreateSocialMedia
2019-05-02 17:41:54 +02:00
0be2891858
make email a required field for user, tests for front- & backend
2019-05-02 16:17:16 +02:00
10ef0ab1c4
started backend test, fixed uniqueSlug
2019-04-30 19:05:03 +02:00
6de253fd32
Merge branch 'master' into 2019/kw15/User_can_change_its_username_to_emptystring
...
# Conflicts:
# webapp/components/_mixins/seo.js
# webapp/components/mixins/seo.js
# webapp/layouts/blank.vue
# webapp/layouts/default.vue
# webapp/mixins/seo.js
2019-04-19 12:09:24 +02:00
Matt Rider
fc496aec51
Merge github.com:Human-Connection/Human-Connection into 260-add-comment-form
2019-04-18 19:00:05 -03:00
Matt Rider
0149f30f5f
Fix failing tests, refactor
...
- due to changes made to comments factories, which caused failures
- to use new custom CreateComment resolver syntax to relate a comment to post by passing in the postId
2019-04-17 20:27:35 -03:00
2efc77097f
match specification of Dennis - minimum 3 characters for username, no hint for user to change the username to "Anonymous", Toast error if userdata cannot be changed due to username restrictions, display "Anonymous" if no username is found in database (even tho this is against implemented rules)
2019-04-17 14:49:03 +02:00
e5f98f2cee
Merge branch 'master' into 2019/kw15/User_can_change_its_username_to_emptystring
...
# Conflicts:
# webapp/locales/de.json
# webapp/locales/en.json
# webapp/pages/profile/_id/_slug.vue
2019-04-17 13:59:30 +02:00
Matt Rider
9bc0c0f92c
Add tests, create comments only when authenticated
2019-04-16 20:31:34 -03:00
Robert Schäfer
65f96c2b28
Create notifications on UpdatePost, too
...
Note that we don't create duplicate notifications. I made use of the behaviour
of XSS-middleware: It removes all css classes from `<a>` anchors. Because
notifications rely on a css class `mention` which gets removed in a later
middleware, this gives us a nice behaviour for re-notifications without creating
duplicates. The downside is that it creates dependencies between middlewares and
it's not that obvious at all.
cc @mattwr18 @ulfgebhardt @appinteractive @Tirokk
2019-04-16 22:11:07 +02:00
Robert Schäfer
aa3762a095
Implement right order of notifications middleware
2019-04-16 17:48:42 +02:00
Robert Schäfer
b2d72ae74a
Implement parsing of mention links
2019-04-16 16:05:09 +02:00
Robert Schäfer
f30da038d9
Change backend test to parse html not plain text
2019-04-16 11:21:38 +02:00
Robert Schäfer
23a461d16e
Follow component directory strucutre in backend
2019-04-16 11:13:40 +02:00
Robert Schäfer
73f2ff59e4
Merge pull request #237 from Human-Connection/236-list-social-media-accounts
...
List socialMedia links
2019-04-15 12:07:10 +02:00
Robert Schäfer
0c8b478ce2
Update backend/src/middleware/passwordMiddleware.js
...
Co-Authored-By: Tirokk <wolle.huss@pjannto.com>
2019-04-12 17:32:20 +02:00
Matt Rider
366c5d776b
Fix lint
2019-04-11 22:28:18 -03:00
Wolfgang Huß
95a0567e69
Query of users "publicKey" 'throws "Not Authorised!"'
...
Changes password and permission middleware.
Thanks for your big help @roschaefer !
2019-04-11 20:01:20 +02:00
Wolfgang Huß
6794156c86
Merge branch 'master' of https://github.com/Human-Connection/Human-Connection into keep_private_rsa_key_secret_TirNew
2019-04-11 10:54:12 +02:00
Robert Schäfer
102a03f552
Merge remote-tracking branch 'origin/master' into 236-list-social-media-accounts
2019-04-10 15:17:18 +02:00
c70e6227ba
first implementation - unclear if specifications are correct
2019-04-10 13:35:24 +02:00
Robert Schäfer
b63200ac8e
Authorize and whitelist Notifications
2019-04-10 01:58:18 +02:00
Robert Schäfer
26caff5a9b
Fix lint
2019-04-10 01:58:18 +02:00
Robert Schäfer
0476c15163
Remove dots from matched @mention regex
2019-04-10 01:58:18 +02:00
Robert Schäfer
58019c8975
Avoid to send out notifications for email adresses
2019-04-10 01:58:18 +02:00
Robert Schäfer
771779348a
Fix test
2019-04-10 01:58:18 +02:00
Robert Schäfer
bab748e506
Create notifications on CreatePost
2019-04-10 01:58:18 +02:00
Robert Schäfer
4dead6e6f7
Sketch test to create a notificaion for a mention
2019-04-10 01:58:18 +02:00
Wolfgang Huß
a995c84ddf
Merge branch 'keep_private_rsa_key_secret' of https://github.com/Human-Connection/Human-Connection into keep_private_rsa_key_secret_TirNew
2019-04-05 18:43:47 +02:00
Wolfgang Huß
8713f61734
Added Tests to "user_management.spec.js"
...
Implemented suppression of "publicKey", now commented out for testing approach.
Use port 4001 for querying, but forgot that I have to generate the user on the same port, before I can query it with generated "publicKey".
Do this in next commit.
2019-04-05 17:44:43 +02:00
Matt Rider
24d4259510
Add validURLMiddleware, remove unused package, extract tests
2019-04-05 09:15:22 -03:00
Matt Rider
4d4978c0f2
Merge github.com:Human-Connection/Human-Connection into 236-list-social-media-accounts
2019-04-05 07:29:44 -03:00
Robert Schäfer
bb3a8525db
Only admins are allowed to query all notifications
2019-04-05 02:35:33 +02:00
Robert Schäfer
03d4c93f96
Add Notification type
2019-04-05 02:35:33 +02:00
Matt Rider
a51190d4e9
Add custom resolver for createSocialMedia
2019-04-04 15:43:06 -03:00
Robert Schäfer
8627d57906
Don't expose private RSA key
...
cc @Tirokk
2019-04-04 18:02:48 +02:00
Matt Rider
3f9916404e
Merge branch 'master' of github.com:Human-Connection/Human-Connection into 236-list-social-media-accounts
2019-03-27 08:33:16 -03:00
