roschaefer
8e129c6001
fix: update counter when notification is read
...
@mattwr18 vue-apollo rocks! Taking the time to study the docs is a
rewarding investment.
My first idea was to cache the `unreadNotificationsCount` with Vuex.
But the docs of apollo even suggest to use apollo's local state as a
complete replacement of Vuex:
https://vue-apollo.netlify.com/guide/local-state.html
Then I further investigated why the updated `NOTIFIED` objects won't
update the notification counter. Turns out: They don't have an ID and
the computed property didn't fire when the notifications array would
change. I fixed both in this commit and yes, it works as expected.
No additional code required 💪
2019-11-11 08:52:04 +01:00
roschaefer
8ca2445a25
Fix data of NotificationsTable.story.js
...
@mattwr18 probably you wanted to override the `author` of the
comment/post, right? If you use the { ... desctructuring } operator,
whatever comes last takes precedence. So you probaby want to put your
override last?
2019-11-11 08:52:04 +01:00
mattwr18
6fca753c1f
Add component test for Empty.vue
2019-11-11 08:52:04 +01:00
mattwr18
1d8e328a47
Clean up
...
- remove unused data variable
- avoid scoped scss
2019-11-11 08:52:04 +01:00
mattwr18
7564908456
Refactor to follow @alina-beck suggestions
...
- Update CSS
- Use design tokens where possible
- Update spec description
- Avoid scoped scss as it's more expensive
- did not change the next and back button as they weren't really visible
without the primary class
- Fix German translation
2019-11-11 08:52:04 +01:00
mattwr18
44ed462db2
Add NotificationsTable story, refactor code
...
- Use percentages for width on all columns to help with resonsiveness
- export constants from other stories to dry code out
2019-11-11 08:52:04 +01:00
mattwr18
542647f418
Add NotificationsDropdownFilter story, refactor
...
- rename incorrectly named varaibles
- use filterOptions to remove unneccessary computed routes
Co-authored-by: @alina-beck
2019-11-11 08:52:04 +01:00
mattwr18
3ae71544d6
Add story for Empty component
...
Co-authored-by: @alina-beck
2019-11-11 08:52:04 +01:00
mattwr18
aabaa2e637
Fix typo
...
Co-authored-by: Alina Beck <alina.beck@mail.com>
2019-11-11 08:50:35 +01:00
mattwr18
cb2cc37556
Extract components following @alina-beck suggestion
...
- see https://github.com/Human-Connection/Human-Connection/pull/2075/files
2019-11-11 08:50:35 +01:00
mattwr18
7007b1c444
Paginate notifications, reusable component w/ test
2019-11-11 08:50:35 +01:00
mattwr18
084388a21e
Follow new file structure
...
- avoid nested directories
2019-11-11 08:50:35 +01:00
mattwr18
4448c12f2e
Add componenet test for AvatarMenu
...
Co-authored-by: mindcodemediator
<mindcodemediator@users.noreply.github.com>
Co-authored-by: Mike Aono <aonomike@gmail.com>
2019-11-11 08:50:35 +01:00
mattwr18
d83a424513
Add styling
...
- to link in NotificationMenu
- make table more mobile responsive
- remove unneccessary props
Co-authored-by: Alina Beck <alina.beck@mail.com>
2019-11-11 08:50:35 +01:00
mattwr18
994a0b049d
Extract AvatarMenu into its own component
2019-11-11 08:50:35 +01:00
mattwr18
58b1f7948c
Follow @alina-beck and @Tirokk suggestions
...
- following PR reviews
2019-11-11 08:50:35 +01:00
mattwr18
e8cf51095a
Add back missing translation
2019-11-11 08:50:35 +01:00
mattwr18
cf8124fb2d
Clean up/add german translations
2019-11-11 08:50:35 +01:00
mattwr18
b79770469f
Update notifications page
...
- display more notifications by simplifying the table
- get sorting working
2019-11-11 08:50:35 +01:00
mattwr18
7cdc12f4b9
Add notifications page with Notifications in table
...
- At the moment, the notifications are displayed in a table, and have
the same functionality as the NotificationMenu where you can click on
the title of the Post and visit the Post
- Unsure about the styling, it would kind of be nice to have a more
condensed list to see more notifications per page, but still be able to
click on a row and visit the Post
2019-11-11 08:50:35 +01:00
roschaefer
6c947f782d
Fix CSS classes
2019-11-08 17:30:05 +01:00
roschaefer
4108bb7d71
Merge remote-tracking branch 'origin/2119_Create_Post_consistent_form_input_validation' into 2119_Create_Post_consistent_form_input_validation-improvements
2019-11-08 16:32:16 +01:00
roschaefer
a2dbe47f1f
Fix tests
2019-11-08 00:50:20 +01:00
roschaefer
62b393b0f0
Refactoring of Categories Select component
2019-11-07 23:23:47 +01:00
ogerly
dd03f4b7f0
Fix Add Language check for form submit
2019-11-07 15:40:58 +01:00
roschaefer
c83a808825
Refactor content length validation with transform
2019-11-07 14:22:05 +01:00
roschaefer
253032468f
Refactor: Re-use validation via error slot
2019-11-07 14:17:22 +01:00
ogerly
e4cbf9246b
better style and dom
2019-11-07 13:00:28 +01:00
ogerly
f739dd8f11
fix css - checkbutton cursor: default
2019-11-07 11:39:07 +01:00
Alexander Friedland
377b0eb2b3
Merge pull request #2118 from Human-Connection/fix-2057
...
Fix: Email is Case-Sensitive
2019-11-07 09:52:47 +01:00
ogerly
32c5ea1d52
fix category if fail, fix lint
2019-11-07 09:23:00 +01:00
ogerly
b76354d95d
2119-Fix consistent form input validation
2019-11-07 09:12:13 +01:00
Marco Bomfim
96801bb54f
fix(editor): Fix embed thumbnail height
2019-11-06 16:49:34 -03:00
Marco Bomfim
f921244661
fix(editor): Fix hashtags not working after embeded content
...
Up to this point, once you've inserted a given URL to the editor, and it renders a new embeded content, if you hit Return, and try using a tag, or mention, it would not work since the paragraph was never closed, causing a sintatic error that rendered the mentions unable to be used unless you explicitly hit return again, to escape the given text block you were in. See the PR/Issue for further info.
2019-11-06 16:24:48 -03:00
mattwr18
558f0b7485
Merge pull request #2091 from Human-Connection/1851-tags-clickable
...
1851 tags clickable
2019-11-06 09:59:11 +01:00
roschaefer
2a53eb2e6c
refactor: use email of backend response in Signup
2019-11-05 14:24:02 +01:00
roschaefer
0cf59743ab
refactor: replace 'isemail' with 'validator'
...
..and use `normalizeEmail` everywhere in the webapp.
2019-11-05 00:24:12 +01:00
roschaefer
1d15176500
Write a test for #2057
2019-11-05 00:06:15 +01:00
Stephen Hogsten
3f7a7913c0
convert email to lowercase before submitting
2019-11-05 00:06:15 +01:00
mattwr18
abbd090eb7
Merge pull request #1956 from Human-Connection/cropper-enhancements
...
Refactor and tidy up crop image implementation
2019-11-04 11:13:21 +01:00
mattwr18
d3922a8149
Merge pull request #2059 from Human-Connection/2045-filter-posts-by-language
...
🍰 First Implementation Of Filtering Posts By Language
2019-11-04 10:20:13 +01:00
Tomas Bednarik
c3d28af321
Clickable tags by nuxt-link
2019-11-03 12:34:56 +01:00
mattwr18
a78a58ad8d
Mock $t in TeaserImage test
2019-11-02 17:02:19 +01:00
Brent Vardy
99816f1c21
update cancel crop to keep previous image
...
- Also refactor to split into more methods
Co-Authored-By: mattwr18 <mattwr18@gmail.com>
2019-11-02 12:09:28 +00:00
Brent Vardy
dfb59516d0
Add abiltiy to cancel out of cropper and remove image
...
Co-Authored-By: mattwr18 <mattwr18@gmail.com>
2019-11-02 11:48:56 +00:00
Brent Vardy
2670b48694
removed unused code and refactor cropper
...
- Removed unused code
- updated confirm button to be ds-button component
- split into multiple functions
Co-Authored-By: mattwr18 <mattwr18@gmail.com>
2019-11-02 11:07:06 +00:00
Brent Vardy
daf40bbb7c
Merge branch 'master' into cropper-enhancements
2019-11-02 09:42:38 +00:00
ogerly
4cb46b6178
Fix: Poll Interval
2019-11-01 12:11:54 +01:00
roschaefer
5715d3e9d5
Add vuex store tests for language filter
2019-10-31 17:32:18 +01:00
Moriz Wahl
3c8a35d371
Language Code As Buttons Instead Of Flag Icon
2019-10-31 14:35:36 +01:00