1022 Commits

Author SHA1 Message Date
3adb8d0f64
lint fixes 2019-06-03 19:29:14 +02:00
Robert Schäfer
7272c5002d
Merge pull request #725 from Human-Connection/fix_terrible_middleware_bug_in_production
Don't remove middlewares in production
2019-06-03 19:27:33 +02:00
Wolfgang Huß
62993cc3e9 Clean up 2019-06-03 19:05:59 +02:00
Wolfgang Huß
25999a6dfd Bug fix for User can delete Comments of others
Wrote a Jest test for this.
2019-06-03 19:04:40 +02:00
caa6a65f99
removed dotenv.config calls 2019-06-03 18:47:00 +02:00
Robert Schäfer
5866804fd3 Don't remove middlewares in production
@ulfgebhardt thank you for pointing out! That was a terrible bug.
2019-06-03 14:14:57 +02:00
4fd2885b26
reference global config 2019-06-03 13:19:08 +02:00
f78c54a3e8
refactored backend structure 2019-05-31 19:31:39 +02:00
Wolfgang Huß
92ae6375e1 Merge remote-tracking branch 'origin/master' into 553-delete-comment 2019-05-31 17:42:19 +02:00
Wolfgang Huß
e63e4ad890 Written custom mutation and Jest tests for DeleteComment 2019-05-31 17:42:04 +02:00
b51b8423e7
fixed fileloader pattern to actually load smth 2019-05-31 16:40:35 +02:00
754decd308
also wildcard include resolvers 2019-05-31 16:04:17 +02:00
4c758a9083
fixed filename extension check 2019-05-31 15:46:37 +02:00
Wolfgang Huß
5bec0f1d72 Refined list deletion functions and started writing custom mutation for DeleteComment and their tests 2019-05-31 15:46:34 +02:00
ALau2088
a5f6390f97 552-update_comment 2019-05-30 15:47:55 -07:00
630e895f6c
Merge remote-tracking branch 'origin/master' into 2019/kw22/alpha_data_import_status_schema_split 2019-05-29 20:44:14 +02:00
816fbdf7cd
fixed slug required - it was not in Nitro 2019-05-29 16:41:27 +02:00
6f0447515a
- fixed several errors handling import
- split graphql schema into parts
- which data is imported which is not - a list
2019-05-29 15:37:28 +02:00
Robert Schäfer
ffd584ded1 Fix prettier 2019-05-29 12:36:26 +02:00
ALau2088
8a8ed5131e refactor backend and add UI 2019-05-24 08:03:39 -07:00
Matt Rider
1c1d1a67ea Merge in master 2019-05-23 15:31:05 -03:00
Matt Rider
758bf215ac Merge branch 'master' of github.com:Human-Connection/Human-Connection into uploads-on-server 2019-05-23 15:26:19 -03:00
cfd0975b24
backend linting 2019-05-23 19:23:03 +02:00
Robert Schäfer
3c22a432e6 Fix lint 2019-05-21 03:08:32 +02:00
Robert Schäfer
9dd35a887a Fix test 2019-05-21 02:07:43 +02:00
Robert Schäfer
2a22aaa907 Fix edge case bug in extractIds 2019-05-21 02:01:00 +02:00
Robert Schäfer
2b03b515e2 Implement image upload for posts 2019-05-21 02:01:00 +02:00
Robert Schäfer
d624a3f232 Write tests for fileUpload 2019-05-21 02:01:00 +02:00
Robert Schäfer
4dbf1b2a2c UpdateUser with avatarUpload
This is a curl request from a folder where I have a file `avatar.jpg`:

```
curl localhost:4000/ \
  -F operations='{ "query": "mutation($id: ID!, $file: Upload) { UpdateUser(id: $id, avatarUpload: $file) { id name avatar } }", "variables": { "id": "u3", "file": null } }' \
  -F map='{ "0": ["variables.file"] }' \
  -F 0=@avatar.jpg
```

It uploads the avatar to the public folder. We should

* Write tests
* Change the `user.avatar` url and send it to `/api` in the frontend
2019-05-20 20:35:33 +02:00
ALau2088
3fe8e9a288 552-update_comment 2019-05-18 23:42:17 -07:00
ALau2088
7ddbab83e9 552-update_comment 2019-05-18 23:32:24 -07:00
ALau2088
f7ef09acbf add UpdateComment mutation 2019-05-18 18:20:43 -07:00
Robert Schäfer
2d1daee23a Don't document that we can set IDs in mutations 2019-05-13 12:44:47 +02:00
Robert Schäfer
81a26e14ff Fix test case, move spec to the right location
@ulfgebhardt: The reason why the test case was failing is pretty
obvious. You forgot to create a user that you want to update. If there
is no user to update, then you get an empty response.

@ulfgebhardt: I moved the spec also in the right directory. You're
testing resolvers, so that's where I moved the `.spec` file.
2019-05-10 17:34:05 +02:00
Robert Schäfer
47d7c615a5 Refactoring: Put all data validations in one place
@ulfgebhardt @mattwr18 @tirokk

Here's how I imagined the data validation middleware. If we roll our own
input validations I would suggest to put them all in one place.

@ulfgebhardt this commit is a great example of how tests can speed you
up: Since I can rely on existing tests, I don't have to check the validations
manually. With tests you can refactor with confidence! 👍
2019-05-10 17:13:54 +02:00
82570bef7f
Merge pull request #478 from Human-Connection/2019/kw15/User_can_change_its_username_to_emptystring
2019/kw15/user can change its username to emptystring
2019-05-09 15:01:54 +02:00
2cb8d793fb
removed failing test 2019-05-09 14:37:42 +02:00
Wolfgang Huß
0ffbe567c7 Merge branch 'master' of https://github.com/Human-Connection/Human-Connection into 463-delete-socialMedia 2019-05-08 08:54:11 +02:00
Robert Schäfer
287a55db9f Remove test case entirely
@ulfgebhardt when I write "Remove test case" I mean indeed removing all
the lines of code of that test case, not only disabling it. Commenting
out code *and pushing it to version control* is a strong anti-pattern. Why?
First, code comments get out of date quickly. "Never trust code comments".
Second: In our example here, it creates anxiety because other contributors might
believe there was a reason why the commented code exists.

Read:
* https://blog.codinghorror.com/coding-without-comments/
* https://www.nayuki.io/page/dont-share-commented-out-code
* https://softwareengineering.stackexchange.com/questions/1/comments-are-a-code-smell
2019-05-07 14:10:12 +02:00
Robert Schäfer
0637d97648 Merge remote-tracking branch 'origin/master' into 2019/kw15/User_can_change_its_username_to_emptystring 2019-05-07 14:09:10 +02:00
3d2ce3960c
added url of conversation 2019-05-07 14:01:43 +02:00
140ba848c7
removed testcase, added todo 2019-05-07 14:00:02 +02:00
Robert Schäfer
ad111f5701 Double-check changed expectations, fix tests
See:
https://github.com/Human-Connection/Human-Connection/pull/478/files#r281267486

> We found the reason for it: If you have an exclamation mark in the schema e.g.
> email! and the response would e.g. expect the email for each User object, and
> the server does not have an email for the client, then the entire User object
> gets nullified.
2019-05-06 19:26:53 +02:00
Wolfgang Huß
41711c316a Get delete SocialMedia to work, refactored Frontend Jest tests, written Cypress tests
Optimised tests and Vue for add Social Media a bit.
Added localisation.

Finished this commit together with @mattwr18 !!!
Thank you so much dude! You did great stuff …
2019-05-06 17:31:02 +02:00
9004e923af
removed unnecessary comment block 2019-05-06 13:02:09 +02:00
a71b421933
removed console log 2019-05-06 12:39:53 +02:00
Matt Rider
4c09268f49 Update tests after backend validations
- Now a comment cannot be created without a post to associate it with
2019-05-05 13:57:12 -03:00
Matt Rider
4d631c452d Add more unit tests, add back postId deletion 2019-05-04 17:42:42 -03:00
Matt Rider
31c8b6e35d Use single cypher query in CreateComments
- to create relation between post, comment, author
- fix test to create a post so said cypher query doesn't silently fail
2019-05-03 13:41:20 -03:00
Matt Rider
346158da7f Update to use autogenerated Comment Query
- using the custom CommentByPost Query was not returning the author of the Post, therefore the users avatar was not showing up
- there are some weird bugs with the comments, if you dblclick on the button, two comments with the same content are created
- sometimes the comments appear as the bottom of the list, sometimes they appear three comments from the bottom(?)
2019-05-02 19:59:35 -03:00