Robert Schäfer
df22f2a5b4
Update backend/src/middleware/hashtags/hashtagsMiddleware.spec.js
...
Co-Authored-By: mattwr18 <mattwr18@gmail.com>
2019-12-06 12:34:24 +01:00
roschaefer
8f0ce19f09
Implement getDriver() and getNeode() the same way
...
I want to introduce `neode` and `neo4j-graphql-js` to my students and
saw this.
2019-12-05 21:00:24 +01:00
Robert Schäfer
b7be0f100b
Merge pull request #2424 from Human-Connection/update-test-description
...
Update test description
2019-12-05 20:55:59 +01:00
mattwr18
7116f31cf2
Merge pull request #2428 from Human-Connection/dependabot/npm_and_yarn/backend/sentry/node-5.10.0
...
build(deps): bump @sentry/node from 5.9.0 to 5.10.0 in /backend
2019-12-05 11:21:11 +01:00
dependabot-preview[bot]
2d510ebd1e
build(deps): bump @sentry/node from 5.9.0 to 5.10.0 in /backend
...
Bumps [@sentry/node](https://github.com/getsentry/sentry-javascript ) from 5.9.0 to 5.10.0.
- [Release notes](https://github.com/getsentry/sentry-javascript/releases )
- [Changelog](https://github.com/getsentry/sentry-javascript/blob/master/CHANGELOG.md )
- [Commits](https://github.com/getsentry/sentry-javascript/compare/5.9.0...5.10.0 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-12-05 04:21:13 +00:00
dependabot-preview[bot]
3f4d8a8d15
build(deps): bump nodemailer from 6.3.1 to 6.4.0 in /backend
...
Bumps [nodemailer](https://github.com/nodemailer/nodemailer ) from 6.3.1 to 6.4.0.
- [Release notes](https://github.com/nodemailer/nodemailer/releases )
- [Changelog](https://github.com/nodemailer/nodemailer/blob/master/CHANGELOG.md )
- [Commits](https://github.com/nodemailer/nodemailer/compare/v6.3.1...v6.4.0 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-12-05 04:20:21 +00:00
mattwr18
ace7818eac
Update test description
...
- the test clearly tests that the createdAt doesn't change, we changed
the implementation, but didn't change the test description
2019-12-04 19:56:49 +01:00
mattwr18
42540eb909
Remove dead code, code creep
2019-12-04 19:55:48 +01:00
mattwr18
085b59bf4d
Merge branch 'master' of github.com:Human-Connection/Human-Connection into 1710-list-and-protocol-moderation
2019-12-04 13:23:06 +01:00
Robert Schäfer
faefe75fe6
Merge pull request #2335 from Human-Connection/webfinger
...
fix: Re-enable webfinger feature
2019-12-03 22:49:03 +01:00
roschaefer
a6dd6b4f3a
Follow @mattwr18's suggestions
2019-12-03 21:49:17 +01:00
Robert Schäfer
148016e2bf
Update backend/src/activitypub/routes/webfinger.spec.js
...
Co-Authored-By: mattwr18 <mattwr18@gmail.com>
2019-12-03 21:43:47 +01:00
mattwr18
b3640659bb
Add missing unit tests/refactor code
...
- Refactoring without tests makes it riskier
- Move some tests from resolver to middleware unit tests to live closer
to where the validation happens, remove duplicate tests
- DRY out code
2019-12-03 17:59:59 +01:00
roschaefer
132c12a7d3
Close neo4j driver sessions
...
We had this error in our neo4j pod recently:
```
2019-12-02 08:29:42.680+0000 ERROR Unable to schedule bolt session 'bolt-1018230' for execution since there are no available threads to serve it at the moment. You can retry at a later time or consider increasing max thread pool size for bolt connector(s).
2019-12-02 08:29:42.680+0000 ERROR Unable to schedule bolt session 'bolt-1018224' for execution since there are no available threads to serve it at the moment. You can retry at a later time or consider increasing max thread pool size for bolt connector(s).
2019-12-02 08:29:42.681+0000 ERROR Unable to schedule bolt session 'bolt-1018352' for execution since there are no available threads to serve it at the moment. You can retry at a later time or consider increasing max thread pool size for bolt connector(s).
2019-12-02 08:29:42.682+0000 ERROR Unable to schedule bolt session 'bolt-1018243' for execution since there are no available threads to serve it at the moment. You can retry at a later time or consider increasing max thread pool size for bolt connector(s).
```
Apparently the default is 400 threads. So we must have a leak somewhere.
2019-12-02 18:12:11 +01:00
roschaefer
7c6d5b5129
fix: Re-enable webfinger feature
...
Ok, so here is the plan. Let's give both our cucumber features and your
cypress tests a prominent place to live. That would be the root level
folder of our application. Second, let's revive formerly dead code step
by step.
Ie. move code from the former location `backend/features/` to `features/`
when it is ready. All edge cases should be tested with unit tests in
`backend/`, see my `webfinger.spec.js` as an example.
2019-12-02 17:31:56 +01:00
mattwr18
4ac3f92989
Fix lint
2019-12-02 15:54:51 +01:00
mattwr18
e4aba5d4df
Add test case/Fix message
...
- Test that the rule is automatically created for new reviews
- Improve English message
2019-12-02 13:56:44 +01:00
mattwr18
c05065f684
Refactor backend
...
- update script
- use readTxResult for validateReview
- favor more verbose variables
- do not set review.closed as we close the report and the rule at the
moment is set to 'latestReviewUpdatedAtRules' rule, so it's clear the
last review must have been the one that closed the report
2019-12-02 13:38:35 +01:00
mattwr18
14a689d955
Remove comments
2019-12-02 12:02:15 +01:00
mattwr18
08227d3f86
Merge pull request #2390 from Human-Connection/dependabot/npm_and_yarn/backend/eslint-plugin-jest-23.1.1
...
build(deps-dev): bump eslint-plugin-jest from 23.0.5 to 23.1.1 in /backend
2019-12-02 11:47:43 +01:00
mattwr18
b6accd8d15
Merge pull request #2388 from Human-Connection/dependabot/npm_and_yarn/backend/eslint-6.7.2
...
build(deps-dev): bump eslint from 6.7.1 to 6.7.2 in /backend
2019-12-02 11:47:17 +01:00
mattwr18
b3bb8ac0e4
Merge pull request #2366 from Human-Connection/dependabot/npm_and_yarn/backend/babel/cli-7.7.4
...
build(deps-dev): bump @babel/cli from 7.7.0 to 7.7.4 in /backend
2019-12-02 11:37:58 +01:00
dependabot-preview[bot]
393d2dec02
build(deps-dev): bump eslint-plugin-jest in /backend
...
Bumps [eslint-plugin-jest](https://github.com/jest-community/eslint-plugin-jest ) from 23.0.5 to 23.1.1.
- [Release notes](https://github.com/jest-community/eslint-plugin-jest/releases )
- [Changelog](https://github.com/jest-community/eslint-plugin-jest/blob/master/CHANGELOG.md )
- [Commits](https://github.com/jest-community/eslint-plugin-jest/compare/v23.0.5...v23.1.1 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-12-02 04:19:00 +00:00
dependabot-preview[bot]
dd71c80f34
build(deps-dev): bump eslint from 6.7.1 to 6.7.2 in /backend
...
Bumps [eslint](https://github.com/eslint/eslint ) from 6.7.1 to 6.7.2.
- [Release notes](https://github.com/eslint/eslint/releases )
- [Changelog](https://github.com/eslint/eslint/blob/master/CHANGELOG.md )
- [Commits](https://github.com/eslint/eslint/compare/v6.7.1...v6.7.2 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-12-02 04:18:25 +00:00
mattwr18
c088c6eac4
Refactor test to avoid unneccessary http request
...
- Set up/tear down should not needlessly run http requests. These tests
are not designed to test that the report/review process works as
expected. that is the job of their respective unit tests/e2e tests.
2019-11-29 20:48:11 +01:00
mattwr18
7441dbf28c
Merge branch 'master' of github.com:Human-Connection/Human-Connection into 1710-list-and-protocol-moderation
2019-11-29 20:43:09 +01:00
mattwr18
bbd80fbc23
Add test cases for review workflow
2019-11-29 19:45:52 +01:00
mattwr18
f5545e3976
Fix middleware/spec
2019-11-29 19:45:34 +01:00
mattwr18
5d63dda6ee
Refactor validateReport/Review
...
- Don't throw error if a report already exists since we use MERGE and
that does not create a new resource if it exists. That is tested at the
neo4j(database) level.
- We also have a test to make in reports.spec.js that no duplicate is
created to ensure we didn't make some error on our part.
- Fix some faulty logic in validateReview
2019-11-29 18:47:41 +01:00
mattwr18
c0d9fe5257
Test validationMiddleware validateReport/Review
2019-11-29 18:43:24 +01:00
mattwr18
b7f0bc7164
Merge pull request #2375 from Human-Connection/keep_dots_in_emails
...
Don't remove sub-addresses in emails
2019-11-29 14:14:25 +01:00
mattwr18
2e54a43417
Merge pull request #2333 from Human-Connection/remove_obsolete_invitation_code
...
refactor: Remove obsolete code about invitation codes
2019-11-29 13:45:46 +01:00
roschaefer
76414dbec7
Fix lint
2019-11-28 18:07:00 +01:00
mattwr18
9990fe2cb2
Merge branch 'master' of github.com:Human-Connection/Human-Connection into 1710-list-and-protocol-moderation
2019-11-28 16:14:23 +01:00
mattwr18
89daa3356c
Return reviews with reports, rename variables
...
- Instead of just returning the moderator who reviewed, we return the
review as well
2019-11-28 16:10:33 +01:00
roschaefer
973d3f899a
Remove dots of gmail addresses
...
I had a chat with our moderator Daniel. He asks us to remove dots from
gmail accounts. He finds it more consistent and he has no problem to
write a mail to a gmail address without dots. He is OK to save the
email address different from how a user memorizes it.
2019-11-28 14:02:11 +01:00
roschaefer
7146e0a9b2
Fix lint
2019-11-28 13:48:09 +01:00
mattwr18
21be2c08ba
Update to return resource instead of to
...
- more verbose makes it easier to understand
2019-11-28 13:44:00 +01:00
mattwr18
595236ac53
Merge pull request #2372 from Human-Connection/dependabot/npm_and_yarn/backend/graphql-shield-7.0.4
...
build(deps): bump graphql-shield from 7.0.2 to 7.0.4 in /backend
2019-11-28 11:46:49 +01:00
dependabot-preview[bot]
a1a68a36ce
build(deps-dev): bump @babel/cli from 7.7.0 to 7.7.4 in /backend
...
Bumps [@babel/cli](https://github.com/babel/babel ) from 7.7.0 to 7.7.4.
- [Release notes](https://github.com/babel/babel/releases )
- [Changelog](https://github.com/babel/babel/blob/master/CHANGELOG.md )
- [Commits](https://github.com/babel/babel/compare/v7.7.0...v7.7.4 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-11-28 10:40:27 +00:00
mattwr18
fc31aae181
Merge pull request #2359 from Human-Connection/dependabot/npm_and_yarn/backend/babel/core-7.7.4
...
build(deps-dev): bump @babel/core from 7.7.2 to 7.7.4 in /backend
2019-11-28 11:38:26 +01:00
roschaefer
9e2baf25d2
Don't remove dots in emails
2019-11-28 11:22:09 +01:00
dependabot-preview[bot]
98623133fe
build(deps): bump graphql-shield from 7.0.2 to 7.0.4 in /backend
...
Bumps [graphql-shield](https://github.com/maticzav/graphql-shield ) from 7.0.2 to 7.0.4.
- [Release notes](https://github.com/maticzav/graphql-shield/releases )
- [Commits](https://github.com/maticzav/graphql-shield/compare/v7.0.2...v7.0.4 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-11-28 04:18:22 +00:00
dependabot-preview[bot]
3c4a3a8a32
build(deps): bump apollo-server from 2.9.11 to 2.9.12 in /backend
...
Bumps [apollo-server](https://github.com/apollographql/apollo-server ) from 2.9.11 to 2.9.12.
- [Release notes](https://github.com/apollographql/apollo-server/releases )
- [Changelog](https://github.com/apollographql/apollo-server/blob/master/CHANGELOG.md )
- [Commits](https://github.com/apollographql/apollo-server/compare/apollo-server@2.9.11...apollo-server@2.9.12 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-11-27 17:17:58 +00:00
dependabot-preview[bot]
1f52c73324
build(deps-dev): bump @babel/core from 7.7.2 to 7.7.4 in /backend
...
Bumps [@babel/core](https://github.com/babel/babel ) from 7.7.2 to 7.7.4.
- [Release notes](https://github.com/babel/babel/releases )
- [Changelog](https://github.com/babel/babel/blob/master/CHANGELOG.md )
- [Commits](https://github.com/babel/babel/compare/v7.7.2...v7.7.4 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-11-27 17:16:21 +00:00
mattwr18
ff1ba9ea21
Merge pull request #2368 from Human-Connection/dependabot/npm_and_yarn/backend/hapi/joi-16.1.8
...
build(deps): bump @hapi/joi from 16.1.7 to 16.1.8 in /backend
2019-11-27 18:15:31 +01:00
mattwr18
943693f9ed
Merge pull request #2365 from Human-Connection/dependabot/npm_and_yarn/backend/eslint-plugin-jest-23.0.5
...
build(deps-dev): bump eslint-plugin-jest from 23.0.4 to 23.0.5 in /backend
2019-11-27 18:15:11 +01:00
mattwr18
46c16e9060
Merge pull request #2339 from Human-Connection/dependabot/npm_and_yarn/backend/babel/plugin-proposal-throw-expressions-7.7.4
...
build(deps-dev): bump @babel/plugin-proposal-throw-expressions from 7.2.0 to 7.7.4 in /backend
2019-11-27 18:14:15 +01:00
mattwr18
6865709210
Merge pull request #2334 from Human-Connection/refactor_is_author_permission
...
refactor: Close session in isAuthor permission
2019-11-27 18:13:48 +01:00
mattwr18
e6fdb70a07
Merge branch 'master' of github.com:Human-Connection/Human-Connection into 1710-list-and-protocol-moderation
2019-11-27 18:09:24 +01:00