From 00a6d15b5127c2093aa363cae26cb6c8c629bbdf Mon Sep 17 00:00:00 2001
From: ogerly <fridolin@tutanota.com>
Date: Thu, 27 Apr 2023 10:06:54 +0200
Subject: [PATCH] error message for incorrect redemption link

---
 .../LinkInformations/RedeemInformation.vue         |  5 +++--
 .../components/LinkInformations/RedeemValid.vue    |  8 +++++++-
 frontend/src/locales/de.json                       |  1 +
 frontend/src/locales/en.json                       |  1 +
 frontend/src/pages/TransactionLink.vue             | 14 +++++++++-----
 5 files changed, 21 insertions(+), 8 deletions(-)

diff --git a/frontend/src/components/LinkInformations/RedeemInformation.vue b/frontend/src/components/LinkInformations/RedeemInformation.vue
index d287605a4..7a55c5c01 100644
--- a/frontend/src/components/LinkInformations/RedeemInformation.vue
+++ b/frontend/src/components/LinkInformations/RedeemInformation.vue
@@ -1,11 +1,12 @@
 <template>
   <div class="redeem-information">
     <b-jumbotron bg-variant="muted" text-variant="dark" border-variant="info">
-      <h1 v-if="isContributionLink">
+      <h1 v-if="amount === ''">{{ $t('gdd_per_link.redeemlink-error') }}</h1>
+      <h1 v-if="isContributionLink && amount !== ''">
         {{ CONFIG.COMMUNITY_NAME }}
         {{ $t('contribution-link.thanksYouWith') }} {{ amount | GDD }}
       </h1>
-      <h1 v-else>
+      <h1 v-if="!isContributionLink && amount !== ''">
         {{ user.firstName }}
         {{ $t('transaction-link.send_you') }} {{ amount | GDD }}
       </h1>
diff --git a/frontend/src/components/LinkInformations/RedeemValid.vue b/frontend/src/components/LinkInformations/RedeemValid.vue
index a3bf5bf42..fdc2a5157 100644
--- a/frontend/src/components/LinkInformations/RedeemValid.vue
+++ b/frontend/src/components/LinkInformations/RedeemValid.vue
@@ -3,7 +3,12 @@
     <redeem-information v-bind="linkData" :isContributionLink="isContributionLink" />
     <b-jumbotron>
       <div class="mb-3 text-center">
-        <b-button variant="gradido" @click="$emit('mutation-link', linkData.amount)" size="lg">
+        <b-button
+          variant="gradido"
+          @click="$emit('mutation-link', linkData.amount)"
+          size="lg"
+          :disabled="!validLink"
+        >
           {{ $t('gdd_per_link.redeem') }}
         </b-button>
       </div>
@@ -21,6 +26,7 @@ export default {
   props: {
     linkData: { type: Object, required: true },
     isContributionLink: { type: Boolean, default: false },
+    validLink: { type: Boolean, default: false },
   },
 }
 </script>
diff --git a/frontend/src/locales/de.json b/frontend/src/locales/de.json
index a5357e6d9..18024d2fd 100644
--- a/frontend/src/locales/de.json
+++ b/frontend/src/locales/de.json
@@ -204,6 +204,7 @@
     "redeemed": "Erfolgreich eingelöst! Deinem Konto wurden {n} GDD gutgeschrieben.",
     "redeemed-at": "Der Link wurde bereits am {date} eingelöst.",
     "redeemed-title": "eingelöst",
+    "redeemlink-error":"Dieser Einlöse-Link ist nicht vollständig.",
     "to-login": "Log dich ein",
     "to-register": "Registriere ein neues Konto.",
     "validUntil": "Gültig bis",
diff --git a/frontend/src/locales/en.json b/frontend/src/locales/en.json
index 42f22f709..260d09343 100644
--- a/frontend/src/locales/en.json
+++ b/frontend/src/locales/en.json
@@ -204,6 +204,7 @@
     "redeemed": "Successfully redeemed! Your account has been credited with {n} GDD.",
     "redeemed-at": "The link was already redeemed on {date}.",
     "redeemed-title": "redeemed",
+    "redeemlink-error":"This redemption link is not complete.",
     "to-login": "Log in",
     "to-register": "Register a new account.",
     "validUntil": "Valid until",
diff --git a/frontend/src/pages/TransactionLink.vue b/frontend/src/pages/TransactionLink.vue
index 0aa4cfa7d..dfe590b7b 100644
--- a/frontend/src/pages/TransactionLink.vue
+++ b/frontend/src/pages/TransactionLink.vue
@@ -14,6 +14,7 @@
           <redeem-valid
             :linkData="linkData"
             :isContributionLink="isContributionLink"
+            :validLink="validLink"
             @mutation-link="mutationLink"
           />
         </template>
@@ -47,12 +48,13 @@ export default {
     return {
       linkData: {
         __typename: 'TransactionLink',
-        amount: '123.45',
-        memo: 'memo',
+        amount: '',
+        memo: '',
         user: {
-          firstName: 'Bibi',
+          firstName: '',
         },
         deletedAt: null,
+        validLink: false,
       },
     }
   },
@@ -67,13 +69,15 @@ export default {
           },
         })
         .then((result) => {
+          this.validLink = true
           this.linkData = result.data.queryTransactionLink
           if (this.linkData.__typename === 'ContributionLink' && this.$store.state.token) {
             this.mutationLink(this.linkData.amount)
           }
         })
-        .catch((err) => {
-          this.toastError(err.message)
+        .catch(() => {
+          this.toastError(this.$t('gdd_per_link.redeemlink-error'))
+          // this.$router.push('/overview')
         })
     },
     mutationLink(amount) {