From 55ee3a0b6bda7298c10f1c40cf23c8e5d419c013 Mon Sep 17 00:00:00 2001
From: Moriz Wahl <moriz.wahl@gmx.de>
Date: Tue, 21 Feb 2023 17:14:09 +0100
Subject: [PATCH 01/58] feat(backend): alias in update user info

---
 .../src/graphql/arg/UpdateUserInfosArgs.ts    |   5 +
 .../src/graphql/resolver/UserResolver.test.ts | 123 ++++++++++++++++++
 backend/src/graphql/resolver/UserResolver.ts  |  18 +++
 backend/src/seeds/graphql/mutations.ts        |   2 +
 4 files changed, 148 insertions(+)

diff --git a/backend/src/graphql/arg/UpdateUserInfosArgs.ts b/backend/src/graphql/arg/UpdateUserInfosArgs.ts
index b45539487..cde5f7732 100644
--- a/backend/src/graphql/arg/UpdateUserInfosArgs.ts
+++ b/backend/src/graphql/arg/UpdateUserInfosArgs.ts
@@ -1,4 +1,5 @@
 import { ArgsType, Field } from 'type-graphql'
+// import { Length } from 'class-validator'
 
 @ArgsType()
 export default class UpdateUserInfosArgs {
@@ -8,6 +9,10 @@ export default class UpdateUserInfosArgs {
   @Field({ nullable: true })
   lastName?: string
 
+  @Field({ nullable: true })
+  //  @Length(5, 20)
+  alias?: string
+
   @Field({ nullable: true })
   language?: string
 
diff --git a/backend/src/graphql/resolver/UserResolver.test.ts b/backend/src/graphql/resolver/UserResolver.test.ts
index 19eb04b34..89042ebdc 100644
--- a/backend/src/graphql/resolver/UserResolver.test.ts
+++ b/backend/src/graphql/resolver/UserResolver.test.ts
@@ -1134,6 +1134,129 @@ describe('UserResolver', () => {
         })
       })
 
+      describe('alias', () => {
+        beforeEach(() => {
+          jest.clearAllMocks()
+        })
+
+        describe('too short', () => {
+          it('throws and logs an error', async () => {
+            await expect(
+              mutate({
+                mutation: updateUserInfos,
+                variables: {
+                  alias: 'bibi',
+                },
+              }),
+            ).resolves.toMatchObject({
+              errors: [new GraphQLError('Given alias is too short')],
+              data: null,
+            })
+            expect(logger.error).toBeCalledWith('Given alias is too short', 'bibi')
+          })
+        })
+
+        describe('too long', () => {
+          it('throws and logs an error', async () => {
+            await expect(
+              mutate({
+                mutation: updateUserInfos,
+                variables: {
+                  alias: 'bibis_alias_far_too_long',
+                },
+              }),
+            ).resolves.toMatchObject({
+              errors: [new GraphQLError('Given alias is too long')],
+              data: null,
+            })
+            expect(logger.error).toBeCalledWith(
+              'Given alias is too long',
+              'bibis_alias_far_too_long',
+            )
+          })
+        })
+
+        describe('invalid characters', () => {
+          it('throws and logs an error', async () => {
+            await expect(
+              mutate({
+                mutation: updateUserInfos,
+                variables: {
+                  alias: 'no_underscore',
+                },
+              }),
+            ).resolves.toMatchObject({
+              errors: [new GraphQLError('Invalid characters in alias')],
+              data: null,
+            })
+            expect(logger.error).toBeCalledWith('Invalid characters in alias', 'no_underscore')
+          })
+        })
+
+        describe('alias exists', () => {
+          let peter: User
+          beforeAll(async () => {
+            peter = await userFactory(testEnv, peterLustig)
+            await mutate({
+              mutation: login,
+              variables: {
+                email: 'peter@lustig.de',
+                password: 'Aa12345_',
+              },
+            })
+            await mutate({
+              mutation: updateUserInfos,
+              variables: {
+                alias: 'bibiBloxberg',
+              },
+            })
+            await mutate({
+              mutation: login,
+              variables: {
+                email: 'bibi@bloxberg.de',
+                password: 'Aa12345_',
+              },
+            })
+          })
+
+          afterAll(async () => {
+            const [user] = await User.find({ id: peter.id })
+            await user.remove()
+          })
+
+          it('throws and logs an error', async () => {
+            await expect(
+              mutate({
+                mutation: updateUserInfos,
+                variables: {
+                  alias: 'bibiBloxberg',
+                },
+              }),
+            ).resolves.toMatchObject({
+              errors: [new GraphQLError('Alias already in use')],
+              data: null,
+            })
+            expect(logger.error).toBeCalledWith('Alias already in use', 'bibiBloxberg')
+          })
+        })
+
+        describe('valid alias', () => {
+          it('updates the user in DB', async () => {
+            await mutate({
+              mutation: updateUserInfos,
+              variables: {
+                alias: 'bibiBloxberg',
+              },
+            })
+            await expect(User.findOne()).resolves.toEqual(
+              expect.objectContaining({
+                alias: 'bibiBloxberg',
+              }),
+            )
+          })
+        })
+      })
+
       describe('language is not valid', () => {
         it('throws an error', async () => {
           jest.clearAllMocks()
diff --git a/backend/src/graphql/resolver/UserResolver.ts b/backend/src/graphql/resolver/UserResolver.ts
index f9617b0df..0c7ca79cb 100644
--- a/backend/src/graphql/resolver/UserResolver.ts
+++ b/backend/src/graphql/resolver/UserResolver.ts
@@ -517,6 +517,7 @@ export class UserResolver {
     {
       firstName,
       lastName,
+      alias,
       language,
       password,
       passwordNew,
@@ -536,6 +537,23 @@ export class UserResolver {
       userEntity.lastName = lastName
     }
 
+    if (alias) {
+      if (alias.length < 5) {
+        throw new LogError('Given alias is too short', alias)
+      }
+      if (alias.length > 20) {
+        throw new LogError('Given alias is too long', alias)
+      }
+      if (!alias.match(/^[0-9A-Za-z]+$/)) {
+        throw new LogError('Invalid characters in alias', alias)
+      }
+      const aliasInUse = await DbUser.find({ alias })
+      if (aliasInUse.length !== 0) {
+        throw new LogError('Alias already in use', alias)
+      }
+      userEntity.alias = alias
+    }
+
     if (language) {
       if (!isLanguage(language)) {
         throw new LogError('Given language is not a valid language', language)
diff --git a/backend/src/seeds/graphql/mutations.ts b/backend/src/seeds/graphql/mutations.ts
index 4f9cbdeff..e0141b752 100644
--- a/backend/src/seeds/graphql/mutations.ts
+++ b/backend/src/seeds/graphql/mutations.ts
@@ -28,6 +28,7 @@ export const updateUserInfos = gql`
   mutation (
     $firstName: String
     $lastName: String
+    $alias: String
     $password: String
     $passwordNew: String
     $locale: String
@@ -37,6 +38,7 @@ export const updateUserInfos = gql`
     updateUserInfos(
       firstName: $firstName
       lastName: $lastName
+      alias: $alias
       password: $password
       passwordNew: $passwordNew
       language: $locale

From 22f77459aab73fd34f17793a4e0ecaf3da1e84a4 Mon Sep 17 00:00:00 2001
From: Moriz Wahl <moriz.wahl@gmx.de>
Date: Fri, 24 Feb 2023 14:03:12 +0100
Subject: [PATCH 02/58] remove class validator comments

---
 backend/src/graphql/arg/UpdateUserInfosArgs.ts | 2 --
 1 file changed, 2 deletions(-)

diff --git a/backend/src/graphql/arg/UpdateUserInfosArgs.ts b/backend/src/graphql/arg/UpdateUserInfosArgs.ts
index cde5f7732..dbf68c43c 100644
--- a/backend/src/graphql/arg/UpdateUserInfosArgs.ts
+++ b/backend/src/graphql/arg/UpdateUserInfosArgs.ts
@@ -1,5 +1,4 @@
 import { ArgsType, Field } from 'type-graphql'
-// import { Length } from 'class-validator'
 
 @ArgsType()
 export default class UpdateUserInfosArgs {
@@ -10,7 +9,6 @@ export default class UpdateUserInfosArgs {
   lastName?: string
 
   @Field({ nullable: true })
-  //  @Length(5, 20)
   alias?: string
 
   @Field({ nullable: true })

From 3afc7b08fa7264246862110c31a1b72de7c8b7db Mon Sep 17 00:00:00 2001
From: Moriz Wahl <moriz.wahl@gmx.de>
Date: Fri, 24 Feb 2023 14:15:52 +0100
Subject: [PATCH 03/58] update regex

---
 backend/src/graphql/resolver/UserResolver.test.ts | 8 ++++----
 backend/src/graphql/resolver/UserResolver.ts      | 2 +-
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/backend/src/graphql/resolver/UserResolver.test.ts b/backend/src/graphql/resolver/UserResolver.test.ts
index 89042ebdc..bbfbd1ddc 100644
--- a/backend/src/graphql/resolver/UserResolver.test.ts
+++ b/backend/src/graphql/resolver/UserResolver.test.ts
@@ -1182,14 +1182,14 @@ describe('UserResolver', () => {
               mutate({
                 mutation: updateUserInfos,
                 variables: {
-                  alias: 'no_underscore',
+                  alias: 'no+äöllll',
                 },
               }),
             ).resolves.toMatchObject({
               errors: [new GraphQLError('Invalid characters in alias')],
               data: null,
             })
-            expect(logger.error).toBeCalledWith('Invalid characters in alias', 'no_underscore')
+            expect(logger.error).toBeCalledWith('Invalid characters in alias', 'no+äöllll')
           })
         })
 
@@ -1245,12 +1245,12 @@ describe('UserResolver', () => {
             await mutate({
               mutation: updateUserInfos,
               variables: {
-                alias: 'bibiBloxberg',
+                alias: 'bibi_Bloxberg',
               },
             })
             await expect(User.findOne()).resolves.toEqual(
               expect.objectContaining({
-                alias: 'bibiBloxberg',
+                alias: 'bibi_Bloxberg',
               }),
             )
           })
diff --git a/backend/src/graphql/resolver/UserResolver.ts b/backend/src/graphql/resolver/UserResolver.ts
index 0c7ca79cb..2a13ee037 100644
--- a/backend/src/graphql/resolver/UserResolver.ts
+++ b/backend/src/graphql/resolver/UserResolver.ts
@@ -544,7 +544,7 @@ export class UserResolver {
       if (alias.length > 20) {
         throw new LogError('Given alias is too long', alias)
       }
-      if (!alias.match(/^[0-9A-Za-z]+$/)) {
+      if (!alias.match(/^[0-9A-Za-z]([_-]?[A-Za-z0-9])+$/)) {
         throw new LogError('Invalid characters in alias', alias)
       }
       const aliasInUse = await DbUser.find({ alias })

From 19a980b47bb9cf219e2fca81bab6ad6e86465ac6 Mon Sep 17 00:00:00 2001
From: Moriz Wahl <moriz.wahl@gmx.de>
Date: Fri, 24 Feb 2023 14:16:41 +0100
Subject: [PATCH 04/58] Update
 backend/src/graphql/resolver/UserResolver.test.ts

Co-authored-by: Ulf Gebhardt <ulf.gebhardt@webcraft-media.de>
---
 backend/src/graphql/resolver/UserResolver.test.ts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/backend/src/graphql/resolver/UserResolver.test.ts b/backend/src/graphql/resolver/UserResolver.test.ts
index bbfbd1ddc..b6b24949b 100644
--- a/backend/src/graphql/resolver/UserResolver.test.ts
+++ b/backend/src/graphql/resolver/UserResolver.test.ts
@@ -1220,7 +1220,7 @@ describe('UserResolver', () => {
           })
 
           afterAll(async () => {
-            const [user] = await User.find({ id: peter.id })
+            const user = await User.findOne({ id: peter.id })
             await user.remove()
           })
 

From dc9efdae6713f14ae4d91d657c8babf40cc00e57 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Claus-Peter=20H=C3=BCbner?= <claus-peter.huebner@email.de>
Date: Fri, 31 Mar 2023 20:12:59 +0200
Subject: [PATCH 05/58] first migration step

---
 ...-community-sendcoins-transactions_table.ts | 134 ++++++++++++++++++
 1 file changed, 134 insertions(+)
 create mode 100644 database/migrations/0065-x-community-sendcoins-transactions_table.ts

diff --git a/database/migrations/0065-x-community-sendcoins-transactions_table.ts b/database/migrations/0065-x-community-sendcoins-transactions_table.ts
new file mode 100644
index 000000000..73b854d70
--- /dev/null
+++ b/database/migrations/0065-x-community-sendcoins-transactions_table.ts
@@ -0,0 +1,134 @@
+/* MIGRATION TO add users that have a transaction but do not exist */
+
+/* eslint-disable @typescript-eslint/explicit-module-boundary-types */
+/* eslint-disable @typescript-eslint/no-explicit-any */
+
+export async function upgrade(queryFn: (query: string, values?: any[]) => Promise<Array<any>>) {
+  await queryFn(
+    'ALTER TABLE `transactions` MODIFY COLUMN `previous` int(10) unsigned DEFAULT NULL NULL AFTER `id`;',
+  )
+  await queryFn(
+    'ALTER TABLE `transactions` MODIFY COLUMN `type_id` int(10) DEFAULT NULL NULL AFTER `previous`;',
+  )
+  await queryFn(
+    'ALTER TABLE `transactions` MODIFY COLUMN `transaction_link_id` int(10) unsigned DEFAULT NULL NULL AFTER `type_id`;',
+  )
+  await queryFn(
+    'ALTER TABLE `transactions` MODIFY COLUMN `amount` decimal(40,20) DEFAULT NULL NULL AFTER `transaction_link_id`;',
+  )
+  await queryFn(
+    'ALTER TABLE `transactions` MODIFY COLUMN `balance` decimal(40,20) DEFAULT NULL NULL AFTER `amount`;',
+  )
+  await queryFn(
+    'ALTER TABLE `transactions` MODIFY COLUMN `balance_date` datetime(3) DEFAULT current_timestamp(3) NOT NULL AFTER `balance`;',
+  )
+  await queryFn(
+    'ALTER TABLE `transactions` MODIFY COLUMN `decay` decimal(40,20) DEFAULT NULL NULL AFTER `balance_date`;',
+  )
+  await queryFn(
+    'ALTER TABLE `transactions` MODIFY COLUMN `decay_start` datetime(3) DEFAULT NULL NULL AFTER `decay`;',
+  )
+  await queryFn(
+    'ALTER TABLE `transactions` MODIFY COLUMN `memo` varchar(255) CHARACTER SET utf8mb4 COLLATE utf8mb4_unicode_ci NOT NULL AFTER `decay_start`;',
+  )
+  await queryFn(
+    'ALTER TABLE `transactions` MODIFY COLUMN `creation_date` datetime(3) DEFAULT NULL NULL AFTER `memo`;',
+  )
+  await queryFn(
+    'ALTER TABLE `transactions` MODIFY COLUMN `user_id` int(10) unsigned NOT NULL AFTER `creation_date`;',
+  )
+  await queryFn(
+    'ALTER TABLE `transactions` ADD COLUMN `user_gradido_id` char(36) DEFAULT NULL NULL AFTER `user_id`;',
+  )
+  await queryFn(
+    'ALTER TABLE `transactions` ADD COLUMN `user_community_uuid` char(36) DEFAULT NULL NULL AFTER `user_gradido_id`;',
+  )
+  await queryFn(
+    'ALTER TABLE `transactions` ADD COLUMN `user_name` varchar(512) COLLATE utf8mb4_unicode_ci DEFAULT NULL NULL AFTER `user_community_uuid`;',
+  )
+  await queryFn(
+    'ALTER TABLE `transactions` MODIFY COLUMN `linked_user_id` int(10) unsigned DEFAULT NULL NULL AFTER `user_name`;',
+  )
+  await queryFn(
+    'ALTER TABLE `transactions` ADD COLUMN `linked_user_gradido_id` char(36) DEFAULT NULL NULL AFTER `linked_user_id`;',
+  )
+  await queryFn(
+    'ALTER TABLE `transactions` ADD COLUMN `linked_user_community_uuid` char(36) DEFAULT NULL NULL AFTER `linked_user_gradido_id`;',
+  )
+  await queryFn(
+    'ALTER TABLE `transactions` ADD COLUMN `linked_user_name` varchar(512) COLLATE utf8mb4_unicode_ci DEFAULT NULL NULL AFTER `linked_user_community_uuid`;',
+  )
+  await queryFn(
+    'ALTER TABLE `transactions` MODIFY COLUMN `linked_transaction_id` int(10) DEFAULT NULL NULL AFTER `linked_user_name`;',
+  )
+
+  await queryFn(`
+      CREATE TABLE IF NOT EXISTS \`pending_transactions\` (
+        \`id\` int(10) unsigned NOT NULL AUTO_INCREMENT,
+        \`previous\` int(10) unsigned DEFAULT NULL NULL,
+        \`type_id\` int(10) DEFAULT NULL NULL,
+        \`transaction_link_id\` int(10) unsigned DEFAULT NULL NULL,
+        \`amount\` decimal(40,20) DEFAULT NULL NULL,
+        \`balance\` decimal(40,20) DEFAULT NULL NULL,
+        \`balance_date\` datetime(3) DEFAULT current_timestamp(3) NOT NULL,
+        \`decay\` decimal(40,20) DEFAULT NULL NULL,
+        \`decay_start\` datetime(3) DEFAULT NULL NULL,
+        \`memo\` varchar(255) CHARACTER SET utf8mb4 COLLATE utf8mb4_unicode_ci NOT NULL,
+        \`creation_date\` datetime(3) DEFAULT NULL NULL,
+        \`user_id\` int(10) unsigned NOT NULL,
+        \`user_gradido_id\` char(36) NOT NULL,
+        \`user_community_uuid\` char(36) NOT NULL,
+        \`user_name\` varchar(512) COLLATE utf8mb4_unicode_ci NOT NULL,
+        \`linked_user_id\` int(10) unsigned DEFAULT NULL NULL,
+        \`linked_user_gradido_id\` char(36) NOT NULL,
+        \`linked_user_community_uuid\` char(36) NOT NULL,
+        \`linked_user_name\` varchar(512) NULL,
+        \`linked_transaction_id\` int(10) DEFAULT NULL NULL,
+        \`x_transaction_state\` varchar(100) NOT NULL COMMENT 'States to handle 2-Phase-Commit handshake',
+        \`created_at\` datetime(3) NOT NULL DEFAULT CURRENT_TIMESTAMP(3),
+        \`updated_at\` datetime(3) NULL DEFAULT NULL ON UPDATE CURRENT_TIMESTAMP(3),
+        \`deleted_at\` datetime(3) NULL DEFAULT NULL,
+        PRIMARY KEY (\`id\`)
+      ) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4;`)
+
+  /*
+  const userIds = await queryFn(`
+    SELECT user_id FROM transactions
+    WHERE NOT EXISTS (SELECT id FROM users WHERE id = user_id) GROUP BY user_id;`)
+
+  for (let i = 0; i < missingUserIds.length; i++) {
+    let gradidoId = ''
+    let countIds: any[] = []
+    do {
+      gradidoId = uuidv4()
+      countIds = await queryFn(
+        `SELECT COUNT(*) FROM \`users\` WHERE \`gradido_id\` = "${gradidoId}"`,
+      )
+    } while (countIds[0] > 0)
+
+    const userContact = (await queryFn(`
+      INSERT INTO user_contacts
+      (type, user_id, email, email_checked, created_at, deleted_at)
+      VALUES
+      ('EMAIL', ${missingUserIds[i].user_id}, 'deleted.user${missingUserIds[i].user_id}@gradido.net', 0, NOW(), NOW());`)) as unknown as OkPacket
+
+    await queryFn(`
+      INSERT INTO users
+      (id, gradido_id, email_id, first_name, last_name, deleted_at, password_encryption_type, created_at, language)
+      VALUES
+      (${missingUserIds[i].user_id}, '${gradidoId}', ${userContact.insertId}, 'DELETED', 'USER', NOW(), 0, NOW(), 'de');`)
+  }
+  */
+}
+
+/* eslint-disable @typescript-eslint/no-empty-function */
+/* eslint-disable-next-line @typescript-eslint/no-unused-vars */
+export async function downgrade(queryFn: (query: string, values?: any[]) => Promise<Array<any>>) {
+  await queryFn('ALTER TABLE `transactions` DROP COLUMN `user_gradido_id`;')
+  await queryFn('ALTER TABLE `transactions` DROP COLUMN `user_community_uuid`;')
+  await queryFn('ALTER TABLE `transactions` DROP COLUMN `user_name`;')
+  await queryFn('ALTER TABLE `transactions` DROP COLUMN `linked_user_gradido_id`;')
+  await queryFn('ALTER TABLE `transactions` DROP COLUMN `linked_user_community_uuid`;')
+  await queryFn('ALTER TABLE `transactions` DROP COLUMN `linked_user_name`;')
+  await queryFn(`DROP TABLE IF EXISTS pending_transactions;`)
+}

From 588afdb8d7e122930f0f5f67b6b8a30d76d2af70 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Claus-Peter=20H=C3=BCbner?= <claus-peter.huebner@email.de>
Date: Tue, 4 Apr 2023 01:56:34 +0200
Subject: [PATCH 06/58] add new attributes for x-community-sendCoins

---
 backend/src/config/index.ts                   |   2 +-
 .../graphql/resolver/ContributionResolver.ts  |   2 +
 .../graphql/resolver/TransactionResolver.ts   |   8 +
 backend/src/util/virtualTransactions.ts       |  70 +++++----
 .../Transaction.ts                            | 147 ++++++++++++++++++
 database/entity/Transaction.ts                |   2 +-
 ...-community-sendcoins-transactions_table.ts |  42 ++---
 7 files changed, 214 insertions(+), 59 deletions(-)
 create mode 100644 database/entity/0065-x-community-sendcoins-transactions_table/Transaction.ts

diff --git a/backend/src/config/index.ts b/backend/src/config/index.ts
index 23ede1f27..959700814 100644
--- a/backend/src/config/index.ts
+++ b/backend/src/config/index.ts
@@ -12,7 +12,7 @@ Decimal.set({
 })
 
 const constants = {
-  DB_VERSION: '0064-event_rename',
+  DB_VERSION: '0065-x-community-sendcoins-transactions_table',
   DECAY_START_TIME: new Date('2021-05-13 17:46:31-0000'), // GMT+0
   LOG4JS_CONFIG: 'log4js-config.json',
   // default log level on production should be info
diff --git a/backend/src/graphql/resolver/ContributionResolver.ts b/backend/src/graphql/resolver/ContributionResolver.ts
index 5969eaef2..7068fd4ab 100644
--- a/backend/src/graphql/resolver/ContributionResolver.ts
+++ b/backend/src/graphql/resolver/ContributionResolver.ts
@@ -501,6 +501,8 @@ export class ContributionResolver {
         transaction.typeId = TransactionTypeId.CREATION
         transaction.memo = contribution.memo
         transaction.userId = contribution.userId
+        transaction.userGradidoID = user.gradidoID
+        transaction.userName = user.firstName + ' ' + user.lastName
         transaction.previous = lastTransaction ? lastTransaction.id : null
         transaction.amount = contribution.amount
         transaction.creationDate = contribution.contributionDate
diff --git a/backend/src/graphql/resolver/TransactionResolver.ts b/backend/src/graphql/resolver/TransactionResolver.ts
index 430cdb363..4706df794 100644
--- a/backend/src/graphql/resolver/TransactionResolver.ts
+++ b/backend/src/graphql/resolver/TransactionResolver.ts
@@ -87,7 +87,11 @@ export const executeTransaction = async (
       transactionSend.typeId = TransactionTypeId.SEND
       transactionSend.memo = memo
       transactionSend.userId = sender.id
+      transactionSend.userGradidoID = sender.gradidoID
+      transactionSend.userName = sender.firstName + ' ' + sender.lastName
       transactionSend.linkedUserId = recipient.id
+      transactionSend.linkedUserGradidoID = recipient.gradidoID
+      transactionSend.linkedUserName = recipient.firstName + ' ' + recipient.lastName
       transactionSend.amount = amount.mul(-1)
       transactionSend.balance = sendBalance.balance
       transactionSend.balanceDate = receivedCallDate
@@ -103,7 +107,11 @@ export const executeTransaction = async (
       transactionReceive.typeId = TransactionTypeId.RECEIVE
       transactionReceive.memo = memo
       transactionReceive.userId = recipient.id
+      transactionReceive.userGradidoID = recipient.gradidoID
+      transactionReceive.userName = recipient.firstName + ' ' + recipient.lastName
       transactionReceive.linkedUserId = sender.id
+      transactionReceive.linkedUserGradidoID = sender.gradidoID
+      transactionReceive.linkedUserName = sender.firstName + ' ' + sender.lastName
       transactionReceive.amount = amount
       const receiveBalance = await calculateBalance(recipient.id, amount, receivedCallDate)
       transactionReceive.balance = receiveBalance ? receiveBalance.balance : amount
diff --git a/backend/src/util/virtualTransactions.ts b/backend/src/util/virtualTransactions.ts
index 68a37746b..cd73f9feb 100644
--- a/backend/src/util/virtualTransactions.ts
+++ b/backend/src/util/virtualTransactions.ts
@@ -40,19 +40,25 @@ const virtualLinkTransaction = (
   user: User,
 ): Transaction => {
   const linkDbTransaction: dbTransaction = {
-    id: -2,
-    userId: -1,
-    previous: -1,
-    typeId: TransactionTypeId.LINK_SUMMARY,
-    amount: amount.toDecimalPlaces(2, Decimal.ROUND_FLOOR),
-    balance: balance.toDecimalPlaces(2, Decimal.ROUND_DOWN),
-    balanceDate: validUntil,
-    decayStart: createdAt,
-    decay: decay.toDecimalPlaces(2, Decimal.ROUND_FLOOR),
-    memo: '',
-    creationDate: null,
-    contribution: null,
-    ...defaultModelFunctions,
+      id: -2,
+      userId: -1,
+      previous: -1,
+      typeId: TransactionTypeId.LINK_SUMMARY,
+      amount: amount.toDecimalPlaces(2, Decimal.ROUND_FLOOR),
+      balance: balance.toDecimalPlaces(2, Decimal.ROUND_DOWN),
+      balanceDate: validUntil,
+      decayStart: createdAt,
+      decay: decay.toDecimalPlaces(2, Decimal.ROUND_FLOOR),
+      memo: '',
+      creationDate: null,
+      contribution: null,
+      ...defaultModelFunctions,
+      userGradidoID: '',
+      userCommunityUuid: '',
+      userName: '',
+      linkedUserGradidoID: '',
+      linkedUserCommunityUuid: '',
+      linkedUserName: ''
   }
   return new Transaction(linkDbTransaction, user)
 }
@@ -67,22 +73,28 @@ const virtualDecayTransaction = (
   const decay = calculateDecay(balance, balanceDate, time)
   // const balance = decay.balance.minus(lastTransaction.balance)
   const decayDbTransaction: dbTransaction = {
-    id: -1,
-    userId: -1,
-    previous: -1,
-    typeId: TransactionTypeId.DECAY,
-    amount: decay.decay ? decay.roundedDecay : new Decimal(0),
-    balance: decay.balance
-      .toDecimalPlaces(2, Decimal.ROUND_DOWN)
-      .minus(holdAvailabeAmount.toString())
-      .toDecimalPlaces(2, Decimal.ROUND_DOWN),
-    balanceDate: time,
-    decay: decay.decay ? decay.roundedDecay : new Decimal(0),
-    decayStart: decay.start,
-    memo: '',
-    creationDate: null,
-    contribution: null,
-    ...defaultModelFunctions,
+      id: -1,
+      userId: -1,
+      previous: -1,
+      typeId: TransactionTypeId.DECAY,
+      amount: decay.decay ? decay.roundedDecay : new Decimal(0),
+      balance: decay.balance
+          .toDecimalPlaces(2, Decimal.ROUND_DOWN)
+          .minus(holdAvailabeAmount.toString())
+          .toDecimalPlaces(2, Decimal.ROUND_DOWN),
+      balanceDate: time,
+      decay: decay.decay ? decay.roundedDecay : new Decimal(0),
+      decayStart: decay.start,
+      memo: '',
+      creationDate: null,
+      contribution: null,
+      ...defaultModelFunctions,
+      userGradidoID: '',
+      userCommunityUuid: '',
+      userName: '',
+      linkedUserGradidoID: '',
+      linkedUserCommunityUuid: '',
+      linkedUserName: ''
   }
   return new Transaction(decayDbTransaction, user)
 }
diff --git a/database/entity/0065-x-community-sendcoins-transactions_table/Transaction.ts b/database/entity/0065-x-community-sendcoins-transactions_table/Transaction.ts
new file mode 100644
index 000000000..b3f88f0d1
--- /dev/null
+++ b/database/entity/0065-x-community-sendcoins-transactions_table/Transaction.ts
@@ -0,0 +1,147 @@
+import Decimal from 'decimal.js-light'
+import { BaseEntity, Entity, PrimaryGeneratedColumn, Column, OneToOne, JoinColumn } from 'typeorm'
+import { DecimalTransformer } from '../../src/typeorm/DecimalTransformer'
+import { Contribution } from '../Contribution'
+
+@Entity('transactions')
+export class Transaction extends BaseEntity {
+  @PrimaryGeneratedColumn('increment', { unsigned: true })
+  id: number
+
+  @Column({ type: 'int', unsigned: true, unique: true, nullable: true, default: null })
+  previous: number | null
+
+  @Column({ name: 'type_id', unsigned: true, nullable: false })
+  typeId: number
+
+  @Column({
+    name: 'transaction_link_id',
+    type: 'int',
+    unsigned: true,
+    nullable: true,
+    default: null,
+  })
+  transactionLinkId?: number | null
+
+  @Column({
+    type: 'decimal',
+    precision: 40,
+    scale: 20,
+    nullable: false,
+    transformer: DecimalTransformer,
+  })
+  amount: Decimal
+
+  @Column({
+    type: 'decimal',
+    precision: 40,
+    scale: 20,
+    nullable: false,
+    transformer: DecimalTransformer,
+  })
+  balance: Decimal
+
+  @Column({
+    name: 'balance_date',
+    type: 'datetime',
+    default: () => 'CURRENT_TIMESTAMP',
+    nullable: false,
+  })
+  balanceDate: Date
+
+  @Column({
+    type: 'decimal',
+    precision: 40,
+    scale: 20,
+    nullable: false,
+    transformer: DecimalTransformer,
+  })
+  decay: Decimal
+
+  @Column({
+    name: 'decay_start',
+    type: 'datetime',
+    nullable: true,
+    default: null,
+  })
+  decayStart: Date | null
+
+  @Column({ length: 255, nullable: false, collation: 'utf8mb4_unicode_ci' })
+  memo: string
+
+  @Column({ name: 'creation_date', type: 'datetime', nullable: true, default: null })
+  creationDate: Date | null
+
+  @Column({ name: 'user_id', unsigned: true, nullable: false })
+  userId: number
+
+  @Column({
+    name: 'user_gradido_id',
+    length: 36,
+    nullable: false,
+    collation: 'utf8mb4_unicode_ci',
+  })
+  userGradidoID: string
+
+  @Column({
+    name: 'user_community_uuid',
+    length: 36,
+    nullable: false,
+    collation: 'utf8mb4_unicode_ci',
+  })
+  userCommunityUuid: string
+
+  @Column({
+    name: 'user_name',
+    length: 512,
+    nullable: false,
+    collation: 'utf8mb4_unicode_ci',
+  })
+  userName: string
+
+  @Column({
+    name: 'linked_user_id',
+    type: 'int',
+    unsigned: true,
+    nullable: true,
+    default: null,
+  })
+  linkedUserId?: number | null
+
+  @Column({
+    name: 'linked_user_gradido_id',
+    length: 36,
+    nullable: false,
+    collation: 'utf8mb4_unicode_ci',
+  })
+  linkedUserGradidoID: string
+
+  @Column({
+    name: 'linked_user_community_uuid',
+    length: 36,
+    nullable: false,
+    collation: 'utf8mb4_unicode_ci',
+  })
+  linkedUserCommunityUuid: string
+
+  @Column({
+    name: 'linked_user_name',
+    length: 512,
+    nullable: false,
+    collation: 'utf8mb4_unicode_ci',
+  })
+  linkedUserName: string
+
+  @Column({
+    name: 'linked_transaction_id',
+    type: 'int',
+    unsigned: true,
+    nullable: true,
+    default: null,
+  })
+  linkedTransactionId?: number | null
+
+  @OneToOne(() => Contribution, (contribution) => contribution.transaction)
+  @JoinColumn({ name: 'id', referencedColumnName: 'transactionId' })
+  contribution?: Contribution | null
+}
diff --git a/database/entity/Transaction.ts b/database/entity/Transaction.ts
index 5365b0f70..3e3355b13 100644
--- a/database/entity/Transaction.ts
+++ b/database/entity/Transaction.ts
@@ -1 +1 @@
-export { Transaction } from './0036-unique_previous_in_transactions/Transaction'
+export { Transaction } from './0065-x-community-sendcoins-transactions_table/Transaction'
diff --git a/database/migrations/0065-x-community-sendcoins-transactions_table.ts b/database/migrations/0065-x-community-sendcoins-transactions_table.ts
index 73b854d70..d3228b8d9 100644
--- a/database/migrations/0065-x-community-sendcoins-transactions_table.ts
+++ b/database/migrations/0065-x-community-sendcoins-transactions_table.ts
@@ -62,6 +62,20 @@ export async function upgrade(queryFn: (query: string, values?: any[]) => Promis
     'ALTER TABLE `transactions` MODIFY COLUMN `linked_transaction_id` int(10) DEFAULT NULL NULL AFTER `linked_user_name`;',
   )
 
+  await queryFn(
+    `UPDATE transactions t, users u SET t.user_gradido_id = u.gradido_id, t.user_name = concat(u.first_name, ' ', u.last_name) WHERE t.user_id = u.id and t.user_gradido_id is null;`,
+  )
+  await queryFn(
+    'ALTER TABLE `transactions` MODIFY COLUMN `user_gradido_id` char(36) NOT NULL AFTER `user_id`;',
+  )
+  await queryFn(
+    'ALTER TABLE `transactions` MODIFY COLUMN `user_name` varchar(512) COLLATE utf8mb4_unicode_ci NOT NULL AFTER `user_community_uuid`;',
+  )
+
+  await queryFn(
+    `UPDATE transactions t, users u SET t.linked_user_gradido_id = u.gradido_id, t.linked_user_name = concat(u.first_name, ' ', u.last_name) WHERE t.linked_user_id = u.id and t.linked_user_id is null and t.linked_user_gradido_id is null;`,
+  )
+
   await queryFn(`
       CREATE TABLE IF NOT EXISTS \`pending_transactions\` (
         \`id\` int(10) unsigned NOT NULL AUTO_INCREMENT,
@@ -91,34 +105,6 @@ export async function upgrade(queryFn: (query: string, values?: any[]) => Promis
         PRIMARY KEY (\`id\`)
       ) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4;`)
 
-  /*
-  const userIds = await queryFn(`
-    SELECT user_id FROM transactions
-    WHERE NOT EXISTS (SELECT id FROM users WHERE id = user_id) GROUP BY user_id;`)
-
-  for (let i = 0; i < missingUserIds.length; i++) {
-    let gradidoId = ''
-    let countIds: any[] = []
-    do {
-      gradidoId = uuidv4()
-      countIds = await queryFn(
-        `SELECT COUNT(*) FROM \`users\` WHERE \`gradido_id\` = "${gradidoId}"`,
-      )
-    } while (countIds[0] > 0)
-
-    const userContact = (await queryFn(`
-      INSERT INTO user_contacts
-      (type, user_id, email, email_checked, created_at, deleted_at)
-      VALUES
-      ('EMAIL', ${missingUserIds[i].user_id}, 'deleted.user${missingUserIds[i].user_id}@gradido.net', 0, NOW(), NOW());`)) as unknown as OkPacket
-
-    await queryFn(`
-      INSERT INTO users
-      (id, gradido_id, email_id, first_name, last_name, deleted_at, password_encryption_type, created_at, language)
-      VALUES
-      (${missingUserIds[i].user_id}, '${gradidoId}', ${userContact.insertId}, 'DELETED', 'USER', NOW(), 0, NOW(), 'de');`)
-  }
-  */
 }
 
 /* eslint-disable @typescript-eslint/no-empty-function */

From a900c163e3a62d2028fed9825f5d5d77402ccd1a Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Claus-Peter=20H=C3=BCbner?= <claus-peter.huebner@email.de>
Date: Tue, 4 Apr 2023 01:58:29 +0200
Subject: [PATCH 07/58] update cypress

---
 e2e-tests/yarn.lock | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/e2e-tests/yarn.lock b/e2e-tests/yarn.lock
index c0f623e47..20956c5d0 100644
--- a/e2e-tests/yarn.lock
+++ b/e2e-tests/yarn.lock
@@ -2193,10 +2193,10 @@ crypto-browserify@^3.0.0:
     randombytes "^2.0.0"
     randomfill "^1.0.3"
 
-cypress@^10.4.0:
-  version "10.8.0"
-  resolved "https://registry.yarnpkg.com/cypress/-/cypress-10.8.0.tgz#12a681f2642b6f13d636bab65d5b71abdb1497a5"
-  integrity sha512-QVse0dnLm018hgti2enKMVZR9qbIO488YGX06nH5j3Dg1isL38DwrBtyrax02CANU6y8F4EJUuyW6HJKw1jsFA==
+cypress@^12.7.0:
+  version "12.9.0"
+  resolved "https://registry.yarnpkg.com/cypress/-/cypress-12.9.0.tgz#e6ab43cf329fd7c821ef7645517649d72ccf0a12"
+  integrity sha512-Ofe09LbHKgSqX89Iy1xen2WvpgbvNxDzsWx3mgU1mfILouELeXYGwIib3ItCwoRrRifoQwcBFmY54Vs0zw7QCg==
   dependencies:
     "@cypress/request" "^2.88.10"
     "@cypress/xvfb" "^1.2.4"
@@ -2215,7 +2215,7 @@ cypress@^10.4.0:
     commander "^5.1.0"
     common-tags "^1.8.0"
     dayjs "^1.10.4"
-    debug "^4.3.2"
+    debug "^4.3.4"
     enquirer "^2.3.6"
     eventemitter2 "6.4.7"
     execa "4.1.0"

From c9631f0028dfa38daa063b377a8bf02dc7c86870 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Claus-Peter=20H=C3=BCbner?= <claus-peter.huebner@email.de>
Date: Tue, 4 Apr 2023 02:20:59 +0200
Subject: [PATCH 08/58] init new tx-attributes

---
 backend/src/graphql/resolver/TransactionLinkResolver.ts | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/backend/src/graphql/resolver/TransactionLinkResolver.ts b/backend/src/graphql/resolver/TransactionLinkResolver.ts
index a5f8c0ee6..d10a81c51 100644
--- a/backend/src/graphql/resolver/TransactionLinkResolver.ts
+++ b/backend/src/graphql/resolver/TransactionLinkResolver.ts
@@ -266,6 +266,8 @@ export class TransactionLinkResolver {
           transaction.typeId = TransactionTypeId.CREATION
           transaction.memo = contribution.memo
           transaction.userId = contribution.userId
+          transaction.userGradidoID = user.gradidoID
+          transaction.userName = user.firstName + ' ' + user.lastName
           transaction.previous = lastTransaction ? lastTransaction.id : null
           transaction.amount = contribution.amount
           transaction.creationDate = contribution.contributionDate

From 6bedba53c48d1c7ef0ab2b5919b0b13fe07af279 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Claus-Peter=20H=C3=BCbner?= <claus-peter.huebner@email.de>
Date: Tue, 4 Apr 2023 23:12:05 +0200
Subject: [PATCH 09/58] linting

---
 backend/src/util/virtualTransactions.ts | 82 ++++++++++++-------------
 1 file changed, 41 insertions(+), 41 deletions(-)

diff --git a/backend/src/util/virtualTransactions.ts b/backend/src/util/virtualTransactions.ts
index cd73f9feb..d06d85908 100644
--- a/backend/src/util/virtualTransactions.ts
+++ b/backend/src/util/virtualTransactions.ts
@@ -40,25 +40,25 @@ const virtualLinkTransaction = (
   user: User,
 ): Transaction => {
   const linkDbTransaction: dbTransaction = {
-      id: -2,
-      userId: -1,
-      previous: -1,
-      typeId: TransactionTypeId.LINK_SUMMARY,
-      amount: amount.toDecimalPlaces(2, Decimal.ROUND_FLOOR),
-      balance: balance.toDecimalPlaces(2, Decimal.ROUND_DOWN),
-      balanceDate: validUntil,
-      decayStart: createdAt,
-      decay: decay.toDecimalPlaces(2, Decimal.ROUND_FLOOR),
-      memo: '',
-      creationDate: null,
-      contribution: null,
-      ...defaultModelFunctions,
-      userGradidoID: '',
-      userCommunityUuid: '',
-      userName: '',
-      linkedUserGradidoID: '',
-      linkedUserCommunityUuid: '',
-      linkedUserName: ''
+    id: -2,
+    userId: -1,
+    previous: -1,
+    typeId: TransactionTypeId.LINK_SUMMARY,
+    amount: amount.toDecimalPlaces(2, Decimal.ROUND_FLOOR),
+    balance: balance.toDecimalPlaces(2, Decimal.ROUND_DOWN),
+    balanceDate: validUntil,
+    decayStart: createdAt,
+    decay: decay.toDecimalPlaces(2, Decimal.ROUND_FLOOR),
+    memo: '',
+    creationDate: null,
+    contribution: null,
+    ...defaultModelFunctions,
+    userGradidoID: '',
+    userCommunityUuid: '',
+    userName: '',
+    linkedUserGradidoID: '',
+    linkedUserCommunityUuid: '',
+    linkedUserName: '',
   }
   return new Transaction(linkDbTransaction, user)
 }
@@ -73,28 +73,28 @@ const virtualDecayTransaction = (
   const decay = calculateDecay(balance, balanceDate, time)
   // const balance = decay.balance.minus(lastTransaction.balance)
   const decayDbTransaction: dbTransaction = {
-      id: -1,
-      userId: -1,
-      previous: -1,
-      typeId: TransactionTypeId.DECAY,
-      amount: decay.decay ? decay.roundedDecay : new Decimal(0),
-      balance: decay.balance
-          .toDecimalPlaces(2, Decimal.ROUND_DOWN)
-          .minus(holdAvailabeAmount.toString())
-          .toDecimalPlaces(2, Decimal.ROUND_DOWN),
-      balanceDate: time,
-      decay: decay.decay ? decay.roundedDecay : new Decimal(0),
-      decayStart: decay.start,
-      memo: '',
-      creationDate: null,
-      contribution: null,
-      ...defaultModelFunctions,
-      userGradidoID: '',
-      userCommunityUuid: '',
-      userName: '',
-      linkedUserGradidoID: '',
-      linkedUserCommunityUuid: '',
-      linkedUserName: ''
+    id: -1,
+    userId: -1,
+    previous: -1,
+    typeId: TransactionTypeId.DECAY,
+    amount: decay.decay ? decay.roundedDecay : new Decimal(0),
+    balance: decay.balance
+      .toDecimalPlaces(2, Decimal.ROUND_DOWN)
+      .minus(holdAvailabeAmount.toString())
+      .toDecimalPlaces(2, Decimal.ROUND_DOWN),
+    balanceDate: time,
+    decay: decay.decay ? decay.roundedDecay : new Decimal(0),
+    decayStart: decay.start,
+    memo: '',
+    creationDate: null,
+    contribution: null,
+    ...defaultModelFunctions,
+    userGradidoID: '',
+    userCommunityUuid: '',
+    userName: '',
+    linkedUserGradidoID: '',
+    linkedUserCommunityUuid: '',
+    linkedUserName: '',
   }
   return new Transaction(decayDbTransaction, user)
 }

From 71f0f6c7f99cca6106c02a8825f76f2f56c1785f Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Claus-Peter=20H=C3=BCbner?= <claus-peter.huebner@email.de>
Date: Thu, 6 Apr 2023 15:59:59 +0200
Subject: [PATCH 10/58] rework PR-comments

---
 .../graphql/resolver/ContributionResolver.ts  |  3 ++-
 .../resolver/TransactionLinkResolver.ts       |  3 ++-
 .../graphql/resolver/TransactionResolver.ts   |  9 +++++----
 backend/src/util/utilities.ts                 | 19 ++++++++++++++++++
 backend/src/util/virtualTransactions.ts       | 20 +++++++++----------
 .../Transaction.ts                            | 20 +++++++++----------
 ...-community-sendcoins-transactions_table.ts |  3 ++-
 7 files changed, 50 insertions(+), 27 deletions(-)

diff --git a/backend/src/graphql/resolver/ContributionResolver.ts b/backend/src/graphql/resolver/ContributionResolver.ts
index 741ed2a83..2bb2e0faf 100644
--- a/backend/src/graphql/resolver/ContributionResolver.ts
+++ b/backend/src/graphql/resolver/ContributionResolver.ts
@@ -55,6 +55,7 @@ import {
 } from './util/creations'
 import { findContributions } from './util/findContributions'
 import { getLastTransaction } from './util/getLastTransaction'
+import { fullName } from '@/util/utilities'
 
 @Resolver()
 export class ContributionResolver {
@@ -502,7 +503,7 @@ export class ContributionResolver {
         transaction.memo = contribution.memo
         transaction.userId = contribution.userId
         transaction.userGradidoID = user.gradidoID
-        transaction.userName = user.firstName + ' ' + user.lastName
+        transaction.userName = fullName(user.firstName, user.lastName)
         transaction.previous = lastTransaction ? lastTransaction.id : null
         transaction.amount = contribution.amount
         transaction.creationDate = contribution.contributionDate
diff --git a/backend/src/graphql/resolver/TransactionLinkResolver.ts b/backend/src/graphql/resolver/TransactionLinkResolver.ts
index 856fc5c28..6490b8c9d 100644
--- a/backend/src/graphql/resolver/TransactionLinkResolver.ts
+++ b/backend/src/graphql/resolver/TransactionLinkResolver.ts
@@ -40,6 +40,7 @@ import { executeTransaction } from './TransactionResolver'
 import { getUserCreation, validateContribution } from './util/creations'
 import { getLastTransaction } from './util/getLastTransaction'
 import transactionLinkList from './util/transactionLinkList'
+import { fullName } from '@/util/utilities'
 
 // TODO: do not export, test it inside the resolver
 export const transactionLinkCode = (date: Date): string => {
@@ -267,7 +268,7 @@ export class TransactionLinkResolver {
           transaction.memo = contribution.memo
           transaction.userId = contribution.userId
           transaction.userGradidoID = user.gradidoID
-          transaction.userName = user.firstName + ' ' + user.lastName
+          transaction.userName = fullName(user.firstName, user.lastName)
           transaction.previous = lastTransaction ? lastTransaction.id : null
           transaction.amount = contribution.amount
           transaction.creationDate = contribution.contributionDate
diff --git a/backend/src/graphql/resolver/TransactionResolver.ts b/backend/src/graphql/resolver/TransactionResolver.ts
index 5414de413..44cf35f7d 100644
--- a/backend/src/graphql/resolver/TransactionResolver.ts
+++ b/backend/src/graphql/resolver/TransactionResolver.ts
@@ -37,6 +37,7 @@ import { MEMO_MAX_CHARS, MEMO_MIN_CHARS } from './const/const'
 import { findUserByIdentifier } from './util/findUserByIdentifier'
 import { getLastTransaction } from './util/getLastTransaction'
 import { getTransactionList } from './util/getTransactionList'
+import { fullName } from '@/util/utilities'
 
 export const executeTransaction = async (
   amount: Decimal,
@@ -88,10 +89,10 @@ export const executeTransaction = async (
       transactionSend.memo = memo
       transactionSend.userId = sender.id
       transactionSend.userGradidoID = sender.gradidoID
-      transactionSend.userName = sender.firstName + ' ' + sender.lastName
+      transactionSend.userName = fullName(sender.firstName, sender.lastName)
       transactionSend.linkedUserId = recipient.id
       transactionSend.linkedUserGradidoID = recipient.gradidoID
-      transactionSend.linkedUserName = recipient.firstName + ' ' + recipient.lastName
+      transactionSend.linkedUserName = fullName(recipient.firstName, recipient.lastName)
       transactionSend.amount = amount.mul(-1)
       transactionSend.balance = sendBalance.balance
       transactionSend.balanceDate = receivedCallDate
@@ -108,10 +109,10 @@ export const executeTransaction = async (
       transactionReceive.memo = memo
       transactionReceive.userId = recipient.id
       transactionReceive.userGradidoID = recipient.gradidoID
-      transactionReceive.userName = recipient.firstName + ' ' + recipient.lastName
+      transactionReceive.userName = fullName(recipient.firstName, recipient.lastName)
       transactionReceive.linkedUserId = sender.id
       transactionReceive.linkedUserGradidoID = sender.gradidoID
-      transactionReceive.linkedUserName = sender.firstName + ' ' + sender.lastName
+      transactionReceive.linkedUserName = fullName(sender.firstName, sender.lastName)
       transactionReceive.amount = amount
       const receiveBalance = await calculateBalance(recipient.id, amount, receivedCallDate)
       transactionReceive.balance = receiveBalance ? receiveBalance.balance : amount
diff --git a/backend/src/util/utilities.ts b/backend/src/util/utilities.ts
index 2cf53f1e4..9a318f576 100644
--- a/backend/src/util/utilities.ts
+++ b/backend/src/util/utilities.ts
@@ -14,3 +14,22 @@ export const decimalSeparatorByLanguage = (a: Decimal, language: string): string
   i18n.setLocale(rememberLocaleToRestore)
   return result
 }
+
+export const fullName = (firstName: string, lastName: string): string => {
+   return [firstName, lastName].filter(Boolean).join(' ')
+}
+
+export const userName = (f?: string, l?: string): string | null => {
+  let name: string | null
+  if(f && l) {
+    name = f + ' ' + l
+  } else if (f && !l) {
+    name = f
+  } else if (!f && l) {
+    name = l
+  } else {
+    name = null
+  }
+  
+  return name
+}
\ No newline at end of file
diff --git a/backend/src/util/virtualTransactions.ts b/backend/src/util/virtualTransactions.ts
index a953552b2..2bc2a591e 100644
--- a/backend/src/util/virtualTransactions.ts
+++ b/backend/src/util/virtualTransactions.ts
@@ -55,11 +55,11 @@ const virtualLinkTransaction = (
     contribution: null,
     ...defaultModelFunctions,
     userGradidoID: '',
-    userCommunityUuid: '',
-    userName: '',
-    linkedUserGradidoID: '',
-    linkedUserCommunityUuid: '',
-    linkedUserName: '',
+    userCommunityUuid: null,
+    userName: null,
+    linkedUserGradidoID: null,
+    linkedUserCommunityUuid: null,
+    linkedUserName: null,
   }
   return new Transaction(linkDbTransaction, user)
 }
@@ -91,11 +91,11 @@ const virtualDecayTransaction = (
     contribution: null,
     ...defaultModelFunctions,
     userGradidoID: '',
-    userCommunityUuid: '',
-    userName: '',
-    linkedUserGradidoID: '',
-    linkedUserCommunityUuid: '',
-    linkedUserName: '',
+    userCommunityUuid: null,
+    userName: null,
+    linkedUserGradidoID: null,
+    linkedUserCommunityUuid: null,
+    linkedUserName: null,
   }
   return new Transaction(decayDbTransaction, user)
 }
diff --git a/database/entity/0065-x-community-sendcoins-transactions_table/Transaction.ts b/database/entity/0065-x-community-sendcoins-transactions_table/Transaction.ts
index b3f88f0d1..050661824 100644
--- a/database/entity/0065-x-community-sendcoins-transactions_table/Transaction.ts
+++ b/database/entity/0065-x-community-sendcoins-transactions_table/Transaction.ts
@@ -86,18 +86,18 @@ export class Transaction extends BaseEntity {
   @Column({
     name: 'user_community_uuid',
     length: 36,
-    nullable: false,
+    nullable: true,
     collation: 'utf8mb4_unicode_ci',
   })
-  userCommunityUuid: string
+  userCommunityUuid: string | null
 
   @Column({
     name: 'user_name',
     length: 512,
-    nullable: false,
+    nullable: true,
     collation: 'utf8mb4_unicode_ci',
   })
-  userName: string
+  userName: string | null
 
   @Column({
     name: 'linked_user_id',
@@ -111,26 +111,26 @@ export class Transaction extends BaseEntity {
   @Column({
     name: 'linked_user_gradido_id',
     length: 36,
-    nullable: false,
+    nullable: true,
     collation: 'utf8mb4_unicode_ci',
   })
-  linkedUserGradidoID: string
+  linkedUserGradidoID: string | null
 
   @Column({
     name: 'linked_user_community_uuid',
     length: 36,
-    nullable: false,
+    nullable: true,
     collation: 'utf8mb4_unicode_ci',
   })
-  linkedUserCommunityUuid: string
+  linkedUserCommunityUuid: string | null
 
   @Column({
     name: 'linked_user_name',
     length: 512,
-    nullable: false,
+    nullable: true,
     collation: 'utf8mb4_unicode_ci',
   })
-  linkedUserName: string
+  linkedUserName: string | null
 
   @Column({
     name: 'linked_transaction_id',
diff --git a/database/migrations/0065-x-community-sendcoins-transactions_table.ts b/database/migrations/0065-x-community-sendcoins-transactions_table.ts
index d3228b8d9..a09d416a7 100644
--- a/database/migrations/0065-x-community-sendcoins-transactions_table.ts
+++ b/database/migrations/0065-x-community-sendcoins-transactions_table.ts
@@ -68,10 +68,11 @@ export async function upgrade(queryFn: (query: string, values?: any[]) => Promis
   await queryFn(
     'ALTER TABLE `transactions` MODIFY COLUMN `user_gradido_id` char(36) NOT NULL AFTER `user_id`;',
   )
+  /*
   await queryFn(
     'ALTER TABLE `transactions` MODIFY COLUMN `user_name` varchar(512) COLLATE utf8mb4_unicode_ci NOT NULL AFTER `user_community_uuid`;',
   )
-
+  */
   await queryFn(
     `UPDATE transactions t, users u SET t.linked_user_gradido_id = u.gradido_id, t.linked_user_name = concat(u.first_name, ' ', u.last_name) WHERE t.linked_user_id = u.id and t.linked_user_id is null and t.linked_user_gradido_id is null;`,
   )

From c62532c89ae2acf7beef94c4127e2ca6bc8884b8 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Claus-Peter=20H=C3=BCbner?= <claus-peter.huebner@email.de>
Date: Mon, 17 Apr 2023 12:45:20 +0200
Subject: [PATCH 11/58] linting

---
 backend/src/graphql/resolver/ContributionResolver.ts      | 2 +-
 backend/src/graphql/resolver/TransactionLinkResolver.ts   | 2 +-
 backend/src/graphql/resolver/TransactionResolver.ts       | 2 +-
 backend/src/util/utilities.ts                             | 8 ++++----
 .../Transaction.ts                                        | 4 ++++
 5 files changed, 11 insertions(+), 7 deletions(-)

diff --git a/backend/src/graphql/resolver/ContributionResolver.ts b/backend/src/graphql/resolver/ContributionResolver.ts
index 357908bdc..696ed9ea7 100644
--- a/backend/src/graphql/resolver/ContributionResolver.ts
+++ b/backend/src/graphql/resolver/ContributionResolver.ts
@@ -44,6 +44,7 @@ import { LogError } from '@/server/LogError'
 import { backendLogger as logger } from '@/server/logger'
 import { calculateDecay } from '@/util/decay'
 import { TRANSACTIONS_LOCK } from '@/util/TRANSACTIONS_LOCK'
+import { fullName } from '@/util/utilities'
 
 import { MEMO_MAX_CHARS, MEMO_MIN_CHARS } from './const/const'
 import {
@@ -55,7 +56,6 @@ import {
 } from './util/creations'
 import { findContributions } from './util/findContributions'
 import { getLastTransaction } from './util/getLastTransaction'
-import { fullName } from '@/util/utilities'
 
 @Resolver()
 export class ContributionResolver {
diff --git a/backend/src/graphql/resolver/TransactionLinkResolver.ts b/backend/src/graphql/resolver/TransactionLinkResolver.ts
index 914b2c081..a97078f66 100644
--- a/backend/src/graphql/resolver/TransactionLinkResolver.ts
+++ b/backend/src/graphql/resolver/TransactionLinkResolver.ts
@@ -34,13 +34,13 @@ import { LogError } from '@/server/LogError'
 import { backendLogger as logger } from '@/server/logger'
 import { calculateDecay } from '@/util/decay'
 import { TRANSACTIONS_LOCK } from '@/util/TRANSACTIONS_LOCK'
+import { fullName } from '@/util/utilities'
 import { calculateBalance } from '@/util/validate'
 
 import { executeTransaction } from './TransactionResolver'
 import { getUserCreation, validateContribution } from './util/creations'
 import { getLastTransaction } from './util/getLastTransaction'
 import { transactionLinkList } from './util/transactionLinkList'
-import { fullName } from '@/util/utilities'
 
 // TODO: do not export, test it inside the resolver
 export const transactionLinkCode = (date: Date): string => {
diff --git a/backend/src/graphql/resolver/TransactionResolver.ts b/backend/src/graphql/resolver/TransactionResolver.ts
index 65aa29435..7e2a10404 100644
--- a/backend/src/graphql/resolver/TransactionResolver.ts
+++ b/backend/src/graphql/resolver/TransactionResolver.ts
@@ -29,6 +29,7 @@ import { LogError } from '@/server/LogError'
 import { backendLogger as logger } from '@/server/logger'
 import { communityUser } from '@/util/communityUser'
 import { TRANSACTIONS_LOCK } from '@/util/TRANSACTIONS_LOCK'
+import { fullName } from '@/util/utilities'
 import { calculateBalance } from '@/util/validate'
 import { virtualLinkTransaction, virtualDecayTransaction } from '@/util/virtualTransactions'
 
@@ -37,7 +38,6 @@ import { MEMO_MAX_CHARS, MEMO_MIN_CHARS } from './const/const'
 import { findUserByIdentifier } from './util/findUserByIdentifier'
 import { getLastTransaction } from './util/getLastTransaction'
 import { getTransactionList } from './util/getTransactionList'
-import { fullName } from '@/util/utilities'
 
 export const executeTransaction = async (
   amount: Decimal,
diff --git a/backend/src/util/utilities.ts b/backend/src/util/utilities.ts
index 9a318f576..4dc71ff7f 100644
--- a/backend/src/util/utilities.ts
+++ b/backend/src/util/utilities.ts
@@ -16,12 +16,12 @@ export const decimalSeparatorByLanguage = (a: Decimal, language: string): string
 }
 
 export const fullName = (firstName: string, lastName: string): string => {
-   return [firstName, lastName].filter(Boolean).join(' ')
+  return [firstName, lastName].filter(Boolean).join(' ')
 }
 
 export const userName = (f?: string, l?: string): string | null => {
   let name: string | null
-  if(f && l) {
+  if (f && l) {
     name = f + ' ' + l
   } else if (f && !l) {
     name = f
@@ -30,6 +30,6 @@ export const userName = (f?: string, l?: string): string | null => {
   } else {
     name = null
   }
-  
+
   return name
-}
\ No newline at end of file
+}
diff --git a/database/entity/0065-x-community-sendcoins-transactions_table/Transaction.ts b/database/entity/0065-x-community-sendcoins-transactions_table/Transaction.ts
index 050661824..0da9a2265 100644
--- a/database/entity/0065-x-community-sendcoins-transactions_table/Transaction.ts
+++ b/database/entity/0065-x-community-sendcoins-transactions_table/Transaction.ts
@@ -144,4 +144,8 @@ export class Transaction extends BaseEntity {
   @OneToOne(() => Contribution, (contribution) => contribution.transaction)
   @JoinColumn({ name: 'id', referencedColumnName: 'transactionId' })
   contribution?: Contribution | null
+
+  @OneToOne(() => Transaction)
+  @JoinColumn({ name: 'previous' })
+  previousTransaction?: Transaction | null
 }

From 4a33703f054853d6cf8d410d3f5d5afd6d050714 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Claus-Peter=20H=C3=BCbner?= <claus-peter.huebner@email.de>
Date: Wed, 19 Apr 2023 01:50:53 +0200
Subject: [PATCH 12/58] linting

---
 .../migrations/0065-x-community-sendcoins-transactions_table.ts  | 1 -
 1 file changed, 1 deletion(-)

diff --git a/database/migrations/0065-x-community-sendcoins-transactions_table.ts b/database/migrations/0065-x-community-sendcoins-transactions_table.ts
index a09d416a7..9f80460ed 100644
--- a/database/migrations/0065-x-community-sendcoins-transactions_table.ts
+++ b/database/migrations/0065-x-community-sendcoins-transactions_table.ts
@@ -105,7 +105,6 @@ export async function upgrade(queryFn: (query: string, values?: any[]) => Promis
         \`deleted_at\` datetime(3) NULL DEFAULT NULL,
         PRIMARY KEY (\`id\`)
       ) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4;`)
-
 }
 
 /* eslint-disable @typescript-eslint/no-empty-function */

From 9c6296610963623f8c5bf122e2b481848fb47688 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Claus-Peter=20H=C3=BCbner?= <claus-peter.huebner@email.de>
Date: Wed, 19 Apr 2023 23:03:27 +0200
Subject: [PATCH 13/58] add explicit type: 'varchar' for string columns in
 transaction entity

---
 .../Transaction.ts                                          | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/database/entity/0065-x-community-sendcoins-transactions_table/Transaction.ts b/database/entity/0065-x-community-sendcoins-transactions_table/Transaction.ts
index 0da9a2265..9202f9fd3 100644
--- a/database/entity/0065-x-community-sendcoins-transactions_table/Transaction.ts
+++ b/database/entity/0065-x-community-sendcoins-transactions_table/Transaction.ts
@@ -77,6 +77,7 @@ export class Transaction extends BaseEntity {
 
   @Column({
     name: 'user_gradido_id',
+    type: 'varchar',
     length: 36,
     nullable: false,
     collation: 'utf8mb4_unicode_ci',
@@ -85,6 +86,7 @@ export class Transaction extends BaseEntity {
 
   @Column({
     name: 'user_community_uuid',
+    type: 'varchar',
     length: 36,
     nullable: true,
     collation: 'utf8mb4_unicode_ci',
@@ -93,6 +95,7 @@ export class Transaction extends BaseEntity {
 
   @Column({
     name: 'user_name',
+    type: 'varchar',
     length: 512,
     nullable: true,
     collation: 'utf8mb4_unicode_ci',
@@ -110,6 +113,7 @@ export class Transaction extends BaseEntity {
 
   @Column({
     name: 'linked_user_gradido_id',
+    type: 'varchar',
     length: 36,
     nullable: true,
     collation: 'utf8mb4_unicode_ci',
@@ -118,6 +122,7 @@ export class Transaction extends BaseEntity {
 
   @Column({
     name: 'linked_user_community_uuid',
+    type: 'varchar',
     length: 36,
     nullable: true,
     collation: 'utf8mb4_unicode_ci',
@@ -126,6 +131,7 @@ export class Transaction extends BaseEntity {
 
   @Column({
     name: 'linked_user_name',
+    type: 'varchar',
     length: 512,
     nullable: true,
     collation: 'utf8mb4_unicode_ci',

From 870c97ce71231febd4ab4781eb51c8b6271a6f90 Mon Sep 17 00:00:00 2001
From: Ulf Gebhardt <ulf.gebhardt@webcraft-media.de>
Date: Wed, 3 May 2023 13:02:32 +0200
Subject: [PATCH 14/58] rfactor federation clients

---
 .../federation/client/1_0/FederationClient.ts | 42 --------------
 .../federation/client/1_1/FederationClient.ts | 42 --------------
 backend/src/federation/client/Client.ts       | 57 +++++++++++++++++++
 backend/src/federation/client/Client_1_0.ts   | 54 ++++++++++++++++++
 backend/src/federation/client/Client_1_1.ts   |  5 ++
 .../src/federation/client/GraphQLGetClient.ts | 43 --------------
 backend/src/federation/validateCommunities.ts | 18 +-----
 7 files changed, 118 insertions(+), 143 deletions(-)
 delete mode 100644 backend/src/federation/client/1_0/FederationClient.ts
 delete mode 100644 backend/src/federation/client/1_1/FederationClient.ts
 create mode 100644 backend/src/federation/client/Client.ts
 create mode 100644 backend/src/federation/client/Client_1_0.ts
 create mode 100644 backend/src/federation/client/Client_1_1.ts
 delete mode 100644 backend/src/federation/client/GraphQLGetClient.ts

diff --git a/backend/src/federation/client/1_0/FederationClient.ts b/backend/src/federation/client/1_0/FederationClient.ts
deleted file mode 100644
index 13f05e761..000000000
--- a/backend/src/federation/client/1_0/FederationClient.ts
+++ /dev/null
@@ -1,42 +0,0 @@
-/* eslint-disable @typescript-eslint/no-unsafe-member-access */
-/* eslint-disable @typescript-eslint/no-unsafe-return */
-/* eslint-disable @typescript-eslint/no-unsafe-assignment */
-import { Community as DbCommunity } from '@entity/Community'
-import { gql } from 'graphql-request'
-
-import { GraphQLGetClient } from '@/federation/client/GraphQLGetClient'
-import { LogError } from '@/server/LogError'
-import { backendLogger as logger } from '@/server/logger'
-
-export async function requestGetPublicKey(dbCom: DbCommunity): Promise<string | undefined> {
-  let endpoint = dbCom.endPoint.endsWith('/') ? dbCom.endPoint : dbCom.endPoint + '/'
-  endpoint = `${endpoint}${dbCom.apiVersion}/`
-  logger.info(`requestGetPublicKey with endpoint='${endpoint}'...`)
-
-  const graphQLClient = GraphQLGetClient.getInstance(endpoint)
-  logger.debug(`graphQLClient=${JSON.stringify(graphQLClient)}`)
-  const query = gql`
-    query {
-      getPublicKey {
-        publicKey
-      }
-    }
-  `
-  const variables = {}
-
-  try {
-    const { data, errors, extensions, headers, status } = await graphQLClient.rawRequest(
-      query,
-      variables,
-    )
-    logger.debug(`Response-Data:`, data, errors, extensions, headers, status)
-    if (data) {
-      logger.debug(`Response-PublicKey:`, data.getPublicKey.publicKey)
-      logger.info(`requestGetPublicKey processed successfully`)
-      return data.getPublicKey.publicKey
-    }
-    logger.warn(`requestGetPublicKey processed without response data`)
-  } catch (err) {
-    throw new LogError(`Request-Error:`, err)
-  }
-}
diff --git a/backend/src/federation/client/1_1/FederationClient.ts b/backend/src/federation/client/1_1/FederationClient.ts
deleted file mode 100644
index bda185fba..000000000
--- a/backend/src/federation/client/1_1/FederationClient.ts
+++ /dev/null
@@ -1,42 +0,0 @@
-/* eslint-disable @typescript-eslint/no-unsafe-return */
-/* eslint-disable @typescript-eslint/no-unsafe-assignment */
-/* eslint-disable @typescript-eslint/no-unsafe-member-access */
-import { Community as DbCommunity } from '@entity/Community'
-import { gql } from 'graphql-request'
-
-import { GraphQLGetClient } from '@/federation/client/GraphQLGetClient'
-import { LogError } from '@/server/LogError'
-import { backendLogger as logger } from '@/server/logger'
-
-export async function requestGetPublicKey(dbCom: DbCommunity): Promise<string | undefined> {
-  let endpoint = dbCom.endPoint.endsWith('/') ? dbCom.endPoint : dbCom.endPoint + '/'
-  endpoint = `${endpoint}${dbCom.apiVersion}/`
-  logger.info(`requestGetPublicKey with endpoint='${endpoint}'...`)
-
-  const graphQLClient = GraphQLGetClient.getInstance(endpoint)
-  logger.debug(`graphQLClient=${JSON.stringify(graphQLClient)}`)
-  const query = gql`
-    query {
-      getPublicKey {
-        publicKey
-      }
-    }
-  `
-  const variables = {}
-
-  try {
-    const { data, errors, extensions, headers, status } = await graphQLClient.rawRequest(
-      query,
-      variables,
-    )
-    logger.debug(`Response-Data:`, data, errors, extensions, headers, status)
-    if (data) {
-      logger.debug(`Response-PublicKey:`, data.getPublicKey.publicKey)
-      logger.info(`requestGetPublicKey processed successfully`)
-      return data.getPublicKey.publicKey
-    }
-    logger.warn(`requestGetPublicKey processed without response data`)
-  } catch (err) {
-    throw new LogError(`Request-Error:`, err)
-  }
-}
diff --git a/backend/src/federation/client/Client.ts b/backend/src/federation/client/Client.ts
new file mode 100644
index 000000000..e285b591c
--- /dev/null
+++ b/backend/src/federation/client/Client.ts
@@ -0,0 +1,57 @@
+import { Community as DbCommunity } from '@entity/Community'
+
+import { ApiVersionType } from '@/federation/enum/apiVersionType'
+
+// eslint-disable-next-line camelcase
+import { Client_1_0 } from './Client_1_0'
+// eslint-disable-next-line camelcase
+import { Client_1_1 } from './Client_1_1'
+
+// eslint-disable-next-line camelcase
+type FederationClient = Client_1_0 | Client_1_1
+
+type ClientInstance = {
+  dbCom: DbCommunity
+  // eslint-disable-next-line no-use-before-define
+  client: FederationClient
+}
+
+export class Client {
+  private static instanceArray: ClientInstance[] = []
+
+  /**
+   * The Singleton's constructor should always be private to prevent direct
+   * construction calls with the `new` operator.
+   */
+  // eslint-disable-next-line no-useless-constructor, @typescript-eslint/no-empty-function
+  private constructor() {}
+
+  private static createFederationClient = (dbCom: DbCommunity) => {
+    switch (dbCom.apiVersion) {
+      case ApiVersionType.V1_0:
+        return new Client_1_0(dbCom)
+      case ApiVersionType.V1_1:
+        return new Client_1_1(dbCom)
+      default:
+        return null
+    }
+  }
+
+  /**
+   * The static method that controls the access to the singleton instance.
+   *
+   * This implementation let you subclass the Singleton class while keeping
+   * just one instance of each subclass around.
+   */
+  public static getInstance(dbCom: DbCommunity): FederationClient | null {
+    const instance = Client.instanceArray.find((instance) => instance.dbCom === dbCom)
+    if (instance) {
+      return instance.client
+    }
+    const client = Client.createFederationClient(dbCom)
+    if (client) {
+      Client.instanceArray.push({ dbCom, client } as ClientInstance)
+    }
+    return client
+  }
+}
diff --git a/backend/src/federation/client/Client_1_0.ts b/backend/src/federation/client/Client_1_0.ts
new file mode 100644
index 000000000..6adfaa48c
--- /dev/null
+++ b/backend/src/federation/client/Client_1_0.ts
@@ -0,0 +1,54 @@
+import { Community as DbCommunity } from '@entity/Community'
+import { GraphQLClient, gql } from 'graphql-request'
+
+import { LogError } from '@/server/LogError'
+import { backendLogger as logger } from '@/server/logger'
+
+// eslint-disable-next-line camelcase
+export class Client_1_0 {
+  dbCom: DbCommunity
+  endpoint: string
+  client: GraphQLClient
+
+  constructor(dbCom: DbCommunity) {
+    this.dbCom = dbCom
+    this.endpoint = `${dbCom.endPoint.endsWith('/') ? dbCom.endPoint : dbCom.endPoint + '/'}${
+      dbCom.apiVersion
+    }/`
+    this.client = new GraphQLClient(this.endpoint, {
+      method: 'GET',
+      jsonSerializer: {
+        parse: JSON.parse,
+        stringify: JSON.stringify,
+      },
+    })
+  }
+
+  requestGetPublicKey = async (): Promise<string | undefined> => {
+    logger.info(`requestGetPublicKey with endpoint='${this.endpoint}'...`)
+
+    const query = gql`
+      query {
+        getPublicKey {
+          publicKey
+        }
+      }
+    `
+
+    try {
+      // eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
+      const { data, errors, headers, status } = await this.client.rawRequest(query)
+      logger.debug(`Response-Data:`, data, errors, headers, status)
+      if (data) {
+        // eslint-disable-next-line @typescript-eslint/no-unsafe-member-access
+        logger.debug(`Response-PublicKey:`, data.getPublicKey.publicKey)
+        logger.info(`requestGetPublicKey processed successfully`)
+        // eslint-disable-next-line @typescript-eslint/no-unsafe-return, @typescript-eslint/no-unsafe-member-access
+        return data.getPublicKey.publicKey
+      }
+      logger.warn(`requestGetPublicKey processed without response data`)
+    } catch (err) {
+      throw new LogError(`Request-Error:`, err)
+    }
+  }
+}
diff --git a/backend/src/federation/client/Client_1_1.ts b/backend/src/federation/client/Client_1_1.ts
new file mode 100644
index 000000000..8525acc5d
--- /dev/null
+++ b/backend/src/federation/client/Client_1_1.ts
@@ -0,0 +1,5 @@
+// eslint-disable-next-line camelcase
+import { Client_1_0 } from './Client_1_0'
+
+// eslint-disable-next-line camelcase
+export class Client_1_1 extends Client_1_0 {}
diff --git a/backend/src/federation/client/GraphQLGetClient.ts b/backend/src/federation/client/GraphQLGetClient.ts
deleted file mode 100644
index 2f5281532..000000000
--- a/backend/src/federation/client/GraphQLGetClient.ts
+++ /dev/null
@@ -1,43 +0,0 @@
-import { GraphQLClient } from 'graphql-request'
-import { PatchedRequestInit } from 'graphql-request/dist/types'
-
-type ClientInstance = {
-  url: string
-  // eslint-disable-next-line no-use-before-define
-  client: GraphQLGetClient
-}
-
-export class GraphQLGetClient extends GraphQLClient {
-  private static instanceArray: ClientInstance[] = []
-
-  /**
-   * The Singleton's constructor should always be private to prevent direct
-   * construction calls with the `new` operator.
-   */
-  // eslint-disable-next-line no-useless-constructor
-  private constructor(url: string, options?: PatchedRequestInit) {
-    super(url, options)
-  }
-
-  /**
-   * The static method that controls the access to the singleton instance.
-   *
-   * This implementation let you subclass the Singleton class while keeping
-   * just one instance of each subclass around.
-   */
-  public static getInstance(url: string): GraphQLGetClient {
-    const instance = GraphQLGetClient.instanceArray.find((instance) => instance.url === url)
-    if (instance) {
-      return instance.client
-    }
-    const client = new GraphQLGetClient(url, {
-      method: 'GET',
-      jsonSerializer: {
-        parse: JSON.parse,
-        stringify: JSON.stringify,
-      },
-    })
-    GraphQLGetClient.instanceArray.push({ url, client } as ClientInstance)
-    return client
-  }
-}
diff --git a/backend/src/federation/validateCommunities.ts b/backend/src/federation/validateCommunities.ts
index 0e8c7cb12..11406199d 100644
--- a/backend/src/federation/validateCommunities.ts
+++ b/backend/src/federation/validateCommunities.ts
@@ -4,10 +4,7 @@ import { Community as DbCommunity } from '@entity/Community'
 import { LogError } from '@/server/LogError'
 import { backendLogger as logger } from '@/server/logger'
 
-// eslint-disable-next-line camelcase
-import { requestGetPublicKey as v1_0_requestGetPublicKey } from './client/1_0/FederationClient'
-// eslint-disable-next-line camelcase
-import { requestGetPublicKey as v1_1_requestGetPublicKey } from './client/1_1/FederationClient'
+import { Client } from './client/Client'
 import { ApiVersionType } from './enum/apiVersionType'
 
 export function startValidateCommunities(timerInterval: number): void {
@@ -38,7 +35,7 @@ export async function validateCommunities(): Promise<void> {
         `Federation: validate publicKey for dbCom: ${dbCom.id} with apiVersion=${dbCom.apiVersion}`,
       )
       try {
-        const pubKey = await invokeVersionedRequestGetPublicKey(dbCom)
+        const pubKey = await Client.getInstance(dbCom)?.requestGetPublicKey()
         logger.info(
           'Federation: received publicKey from endpoint',
           pubKey,
@@ -73,14 +70,3 @@ export async function validateCommunities(): Promise<void> {
 function isLogError(err: unknown) {
   return err instanceof LogError
 }
-
-async function invokeVersionedRequestGetPublicKey(dbCom: DbCommunity): Promise<string | undefined> {
-  switch (dbCom.apiVersion) {
-    case ApiVersionType.V1_0:
-      return v1_0_requestGetPublicKey(dbCom)
-    case ApiVersionType.V1_1:
-      return v1_1_requestGetPublicKey(dbCom)
-    default:
-      return undefined
-  }
-}

From d3a2df2878d9f2ebdcce8c8018672f08a76ac133 Mon Sep 17 00:00:00 2001
From: Ulf Gebhardt <ulf.gebhardt@webcraft-media.de>
Date: Wed, 3 May 2023 13:03:27 +0200
Subject: [PATCH 15/58] remove obsolete function

---
 backend/src/federation/validateCommunities.ts | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/backend/src/federation/validateCommunities.ts b/backend/src/federation/validateCommunities.ts
index 11406199d..dfd14bdac 100644
--- a/backend/src/federation/validateCommunities.ts
+++ b/backend/src/federation/validateCommunities.ts
@@ -54,7 +54,7 @@ export async function validateCommunities(): Promise<void> {
           // DbCommunity.delete({ id: dbCom.id })
         }
       } catch (err) {
-        if (!isLogError(err)) {
+        if (!(err instanceof LogError)) {
           logger.error(`Error:`, err)
         }
       }
@@ -66,7 +66,3 @@ export async function validateCommunities(): Promise<void> {
     }
   }
 }
-
-function isLogError(err: unknown) {
-  return err instanceof LogError
-}

From 4850923f17078a81d31ffee2b35dfda14e706751 Mon Sep 17 00:00:00 2001
From: Ulf Gebhardt <ulf.gebhardt@webcraft-media.de>
Date: Wed, 3 May 2023 13:29:56 +0200
Subject: [PATCH 16/58] variables must be defined

---
 backend/src/federation/client/Client_1_0.ts | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/backend/src/federation/client/Client_1_0.ts b/backend/src/federation/client/Client_1_0.ts
index 6adfaa48c..efbe497c8 100644
--- a/backend/src/federation/client/Client_1_0.ts
+++ b/backend/src/federation/client/Client_1_0.ts
@@ -35,9 +35,11 @@ export class Client_1_0 {
       }
     `
 
+    const variables = {}
+
     try {
       // eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
-      const { data, errors, headers, status } = await this.client.rawRequest(query)
+      const { data, errors, headers, status } = await this.client.rawRequest(query, variables)
       logger.debug(`Response-Data:`, data, errors, headers, status)
       if (data) {
         // eslint-disable-next-line @typescript-eslint/no-unsafe-member-access

From 1c6142220f5b86a23fc35cbee2631f9855e07730 Mon Sep 17 00:00:00 2001
From: Ulf Gebhardt <ulf.gebhardt@webcraft-media.de>
Date: Thu, 4 May 2023 01:40:50 +0200
Subject: [PATCH 17/58] rename getPublicKey function

---
 backend/src/federation/client/Client_1_0.ts   | 2 +-
 backend/src/federation/validateCommunities.ts | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/backend/src/federation/client/Client_1_0.ts b/backend/src/federation/client/Client_1_0.ts
index efbe497c8..9ce3b6b12 100644
--- a/backend/src/federation/client/Client_1_0.ts
+++ b/backend/src/federation/client/Client_1_0.ts
@@ -24,7 +24,7 @@ export class Client_1_0 {
     })
   }
 
-  requestGetPublicKey = async (): Promise<string | undefined> => {
+  getPublicKey = async (): Promise<string | undefined> => {
     logger.info(`requestGetPublicKey with endpoint='${this.endpoint}'...`)
 
     const query = gql`
diff --git a/backend/src/federation/validateCommunities.ts b/backend/src/federation/validateCommunities.ts
index dfd14bdac..14bf4dd3d 100644
--- a/backend/src/federation/validateCommunities.ts
+++ b/backend/src/federation/validateCommunities.ts
@@ -35,7 +35,7 @@ export async function validateCommunities(): Promise<void> {
         `Federation: validate publicKey for dbCom: ${dbCom.id} with apiVersion=${dbCom.apiVersion}`,
       )
       try {
-        const pubKey = await Client.getInstance(dbCom)?.requestGetPublicKey()
+        const pubKey = await Client.getInstance(dbCom)?.getPublicKey()
         logger.info(
           'Federation: received publicKey from endpoint',
           pubKey,

From 81552e51ddd50949ffa26efb7470e721a9d93c26 Mon Sep 17 00:00:00 2001
From: Ulf Gebhardt <ulf.gebhardt@webcraft-media.de>
Date: Thu, 4 May 2023 01:51:36 +0200
Subject: [PATCH 18/58] properly reuse graphql client

---
 backend/src/federation/client/Client.ts | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/backend/src/federation/client/Client.ts b/backend/src/federation/client/Client.ts
index e285b591c..a33cb4832 100644
--- a/backend/src/federation/client/Client.ts
+++ b/backend/src/federation/client/Client.ts
@@ -11,7 +11,7 @@ import { Client_1_1 } from './Client_1_1'
 type FederationClient = Client_1_0 | Client_1_1
 
 type ClientInstance = {
-  dbCom: DbCommunity
+  id: number
   // eslint-disable-next-line no-use-before-define
   client: FederationClient
 }
@@ -44,13 +44,13 @@ export class Client {
    * just one instance of each subclass around.
    */
   public static getInstance(dbCom: DbCommunity): FederationClient | null {
-    const instance = Client.instanceArray.find((instance) => instance.dbCom === dbCom)
+    const instance = Client.instanceArray.find((instance) => instance.id === dbCom.id)
     if (instance) {
       return instance.client
     }
     const client = Client.createFederationClient(dbCom)
     if (client) {
-      Client.instanceArray.push({ dbCom, client } as ClientInstance)
+      Client.instanceArray.push({ id: dbCom.id, client } as ClientInstance)
     }
     return client
   }

From 1fa33963966fbb0185e5e530242d544ac883410c Mon Sep 17 00:00:00 2001
From: Ulf Gebhardt <ulf.gebhardt@webcraft-media.de>
Date: Thu, 4 May 2023 01:55:14 +0200
Subject: [PATCH 19/58] externalize the graphql query

---
 backend/src/federation/client/Client_1_0.ts  | 16 ++++++----------
 backend/src/federation/query/getPublicKey.ts |  9 +++++++++
 2 files changed, 15 insertions(+), 10 deletions(-)
 create mode 100644 backend/src/federation/query/getPublicKey.ts

diff --git a/backend/src/federation/client/Client_1_0.ts b/backend/src/federation/client/Client_1_0.ts
index 9ce3b6b12..b0fb825ee 100644
--- a/backend/src/federation/client/Client_1_0.ts
+++ b/backend/src/federation/client/Client_1_0.ts
@@ -1,6 +1,7 @@
 import { Community as DbCommunity } from '@entity/Community'
-import { GraphQLClient, gql } from 'graphql-request'
+import { GraphQLClient } from 'graphql-request'
 
+import { getPublicKey } from '@/federation/query/getPublicKey'
 import { LogError } from '@/server/LogError'
 import { backendLogger as logger } from '@/server/logger'
 
@@ -27,19 +28,14 @@ export class Client_1_0 {
   getPublicKey = async (): Promise<string | undefined> => {
     logger.info(`requestGetPublicKey with endpoint='${this.endpoint}'...`)
 
-    const query = gql`
-      query {
-        getPublicKey {
-          publicKey
-        }
-      }
-    `
-
     const variables = {}
 
     try {
       // eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
-      const { data, errors, headers, status } = await this.client.rawRequest(query, variables)
+      const { data, errors, headers, status } = await this.client.rawRequest(
+        getPublicKey,
+        variables,
+      )
       logger.debug(`Response-Data:`, data, errors, headers, status)
       if (data) {
         // eslint-disable-next-line @typescript-eslint/no-unsafe-member-access
diff --git a/backend/src/federation/query/getPublicKey.ts b/backend/src/federation/query/getPublicKey.ts
new file mode 100644
index 000000000..a772a0cf1
--- /dev/null
+++ b/backend/src/federation/query/getPublicKey.ts
@@ -0,0 +1,9 @@
+import { gql } from 'graphql-request'
+
+export const getPublicKey = gql`
+  query {
+    getPublicKey {
+      publicKey
+    }
+  }
+`

From d636f922618b62bc352806a08cbbc1153566a164 Mon Sep 17 00:00:00 2001
From: Ulf Gebhardt <ulf.gebhardt@webcraft-media.de>
Date: Thu, 4 May 2023 01:57:43 +0200
Subject: [PATCH 20/58] fix problem in federation when variables are not
 defined

---
 backend/src/federation/client/Client_1_0.ts | 6 +-----
 federation/src/server/plugins.ts            | 4 ++--
 2 files changed, 3 insertions(+), 7 deletions(-)

diff --git a/backend/src/federation/client/Client_1_0.ts b/backend/src/federation/client/Client_1_0.ts
index b0fb825ee..df239db92 100644
--- a/backend/src/federation/client/Client_1_0.ts
+++ b/backend/src/federation/client/Client_1_0.ts
@@ -27,14 +27,10 @@ export class Client_1_0 {
 
   getPublicKey = async (): Promise<string | undefined> => {
     logger.info(`requestGetPublicKey with endpoint='${this.endpoint}'...`)
-
-    const variables = {}
-
     try {
       // eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
       const { data, errors, headers, status } = await this.client.rawRequest(
-        getPublicKey,
-        variables,
+        getPublicKey
       )
       logger.debug(`Response-Data:`, data, errors, headers, status)
       if (data) {
diff --git a/federation/src/server/plugins.ts b/federation/src/server/plugins.ts
index 541c68ca2..38fdfbe9f 100644
--- a/federation/src/server/plugins.ts
+++ b/federation/src/server/plugins.ts
@@ -23,8 +23,8 @@ const setHeadersPlugin = {
 
 const filterVariables = (variables: any) => {
   const vars = clonedeep(variables)
-  if (vars.password) vars.password = '***'
-  if (vars.passwordNew) vars.passwordNew = '***'
+  if (vars && vars.password) vars.password = '***'
+  if (vars && vars.passwordNew) vars.passwordNew = '***'
   return vars
 }
 

From 950ff2f9b680e29e79c5d4a8e415e2e212f3be23 Mon Sep 17 00:00:00 2001
From: Ulf Gebhardt <ulf.gebhardt@webcraft-media.de>
Date: Thu, 4 May 2023 02:01:45 +0200
Subject: [PATCH 21/58] lint

---
 backend/src/federation/client/Client_1_0.ts | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/backend/src/federation/client/Client_1_0.ts b/backend/src/federation/client/Client_1_0.ts
index df239db92..317306048 100644
--- a/backend/src/federation/client/Client_1_0.ts
+++ b/backend/src/federation/client/Client_1_0.ts
@@ -29,9 +29,7 @@ export class Client_1_0 {
     logger.info(`requestGetPublicKey with endpoint='${this.endpoint}'...`)
     try {
       // eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
-      const { data, errors, headers, status } = await this.client.rawRequest(
-        getPublicKey
-      )
+      const { data, errors, headers, status } = await this.client.rawRequest(getPublicKey)
       logger.debug(`Response-Data:`, data, errors, headers, status)
       if (data) {
         // eslint-disable-next-line @typescript-eslint/no-unsafe-member-access

From 0a6c29bca3012f5e763cd69bd24fb2b67db64e8e Mon Sep 17 00:00:00 2001
From: Ulf Gebhardt <ulf.gebhardt@webcraft-media.de>
Date: Thu, 4 May 2023 11:28:53 +0200
Subject: [PATCH 22/58] variables must be transmitted due to backward
 compatibility

---
 backend/src/federation/client/Client_1_0.ts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/backend/src/federation/client/Client_1_0.ts b/backend/src/federation/client/Client_1_0.ts
index 317306048..d425ccea1 100644
--- a/backend/src/federation/client/Client_1_0.ts
+++ b/backend/src/federation/client/Client_1_0.ts
@@ -29,7 +29,7 @@ export class Client_1_0 {
     logger.info(`requestGetPublicKey with endpoint='${this.endpoint}'...`)
     try {
       // eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
-      const { data, errors, headers, status } = await this.client.rawRequest(getPublicKey)
+      const { data, errors, headers, status } = await this.client.rawRequest(getPublicKey, {})
       logger.debug(`Response-Data:`, data, errors, headers, status)
       if (data) {
         // eslint-disable-next-line @typescript-eslint/no-unsafe-member-access

From 6a63e5956d3641a0bd3ea17cc903a1392a209757 Mon Sep 17 00:00:00 2001
From: Claus-Peter Huebner <claus-peter.huebner@email.de>
Date: Thu, 4 May 2023 20:48:43 +0200
Subject: [PATCH 23/58] adaptions after master-merge

---
 .../Transaction.ts                                              | 0
 database/entity/Transaction.ts                                  | 2 +-
 ...able.ts => 0066-x-community-sendcoins-transactions_table.ts} | 0
 dht-node/src/config/index.ts                                    | 2 +-
 federation/src/config/index.ts                                  | 2 +-
 5 files changed, 3 insertions(+), 3 deletions(-)
 rename database/entity/{0065-x-community-sendcoins-transactions_table => 0066-x-community-sendcoins-transactions_table}/Transaction.ts (100%)
 rename database/migrations/{0065-x-community-sendcoins-transactions_table.ts => 0066-x-community-sendcoins-transactions_table.ts} (100%)

diff --git a/database/entity/0065-x-community-sendcoins-transactions_table/Transaction.ts b/database/entity/0066-x-community-sendcoins-transactions_table/Transaction.ts
similarity index 100%
rename from database/entity/0065-x-community-sendcoins-transactions_table/Transaction.ts
rename to database/entity/0066-x-community-sendcoins-transactions_table/Transaction.ts
diff --git a/database/entity/Transaction.ts b/database/entity/Transaction.ts
index 3e3355b13..4000e3c85 100644
--- a/database/entity/Transaction.ts
+++ b/database/entity/Transaction.ts
@@ -1 +1 @@
-export { Transaction } from './0065-x-community-sendcoins-transactions_table/Transaction'
+export { Transaction } from './0066-x-community-sendcoins-transactions_table/Transaction'
diff --git a/database/migrations/0065-x-community-sendcoins-transactions_table.ts b/database/migrations/0066-x-community-sendcoins-transactions_table.ts
similarity index 100%
rename from database/migrations/0065-x-community-sendcoins-transactions_table.ts
rename to database/migrations/0066-x-community-sendcoins-transactions_table.ts
diff --git a/dht-node/src/config/index.ts b/dht-node/src/config/index.ts
index 5c4676337..eca5dbbb5 100644
--- a/dht-node/src/config/index.ts
+++ b/dht-node/src/config/index.ts
@@ -3,7 +3,7 @@ import dotenv from 'dotenv'
 dotenv.config()
 
 const constants = {
-  DB_VERSION: '0065-refactor_communities_table',
+  DB_VERSION: '0066-x-community-sendcoins-transactions_table',
   LOG4JS_CONFIG: 'log4js-config.json',
   // default log level on production should be info
   LOG_LEVEL: process.env.LOG_LEVEL || 'info',
diff --git a/federation/src/config/index.ts b/federation/src/config/index.ts
index 70a155d63..66d8a056c 100644
--- a/federation/src/config/index.ts
+++ b/federation/src/config/index.ts
@@ -11,7 +11,7 @@ Decimal.set({
 */
 
 const constants = {
-  DB_VERSION: '0065-refactor_communities_table',
+  DB_VERSION: '0066-x-community-sendcoins-transactions_table',
   // DECAY_START_TIME: new Date('2021-05-13 17:46:31-0000'), // GMT+0
   LOG4JS_CONFIG: 'log4js-config.json',
   // default log level on production should be info

From 2d03ae938ab7d05dfa449b09f0cd376481a08ad5 Mon Sep 17 00:00:00 2001
From: Ulf Gebhardt <ulf.gebhardt@webcraft-media.de>
Date: Thu, 4 May 2023 22:50:06 +0200
Subject: [PATCH 24/58] merge conflict

---
 backend/src/federation/client/Client.ts       |  6 +++---
 backend/src/federation/client/Client_1_0.ts   |  6 +++---
 backend/src/federation/validateCommunities.ts | 13 -------------
 3 files changed, 6 insertions(+), 19 deletions(-)

diff --git a/backend/src/federation/client/Client.ts b/backend/src/federation/client/Client.ts
index a33cb4832..515945eb5 100644
--- a/backend/src/federation/client/Client.ts
+++ b/backend/src/federation/client/Client.ts
@@ -1,4 +1,4 @@
-import { Community as DbCommunity } from '@entity/Community'
+import { FederatedCommunity as DbFederatedCommunity } from '@entity/FederatedCommunity'
 
 import { ApiVersionType } from '@/federation/enum/apiVersionType'
 
@@ -26,7 +26,7 @@ export class Client {
   // eslint-disable-next-line no-useless-constructor, @typescript-eslint/no-empty-function
   private constructor() {}
 
-  private static createFederationClient = (dbCom: DbCommunity) => {
+  private static createFederationClient = (dbCom: DbFederatedCommunity) => {
     switch (dbCom.apiVersion) {
       case ApiVersionType.V1_0:
         return new Client_1_0(dbCom)
@@ -43,7 +43,7 @@ export class Client {
    * This implementation let you subclass the Singleton class while keeping
    * just one instance of each subclass around.
    */
-  public static getInstance(dbCom: DbCommunity): FederationClient | null {
+  public static getInstance(dbCom: DbFederatedCommunity): FederationClient | null {
     const instance = Client.instanceArray.find((instance) => instance.id === dbCom.id)
     if (instance) {
       return instance.client
diff --git a/backend/src/federation/client/Client_1_0.ts b/backend/src/federation/client/Client_1_0.ts
index d425ccea1..456196bcb 100644
--- a/backend/src/federation/client/Client_1_0.ts
+++ b/backend/src/federation/client/Client_1_0.ts
@@ -1,4 +1,4 @@
-import { Community as DbCommunity } from '@entity/Community'
+import { FederatedCommunity as DbFederatedCommunity } from '@entity/FederatedCommunity'
 import { GraphQLClient } from 'graphql-request'
 
 import { getPublicKey } from '@/federation/query/getPublicKey'
@@ -7,11 +7,11 @@ import { backendLogger as logger } from '@/server/logger'
 
 // eslint-disable-next-line camelcase
 export class Client_1_0 {
-  dbCom: DbCommunity
+  dbCom: DbFederatedCommunity
   endpoint: string
   client: GraphQLClient
 
-  constructor(dbCom: DbCommunity) {
+  constructor(dbCom: DbFederatedCommunity) {
     this.dbCom = dbCom
     this.endpoint = `${dbCom.endPoint.endsWith('/') ? dbCom.endPoint : dbCom.endPoint + '/'}${
       dbCom.apiVersion
diff --git a/backend/src/federation/validateCommunities.ts b/backend/src/federation/validateCommunities.ts
index 2bc531eaf..6879f98e7 100644
--- a/backend/src/federation/validateCommunities.ts
+++ b/backend/src/federation/validateCommunities.ts
@@ -69,16 +69,3 @@ export async function validateCommunities(): Promise<void> {
     }
   }
 }
-
-async function invokeVersionedRequestGetPublicKey(
-  dbCom: DbFederatedCommunity,
-): Promise<string | undefined> {
-  switch (dbCom.apiVersion) {
-    case ApiVersionType.V1_0:
-      return v1_0_requestGetPublicKey(dbCom)
-    case ApiVersionType.V1_1:
-      return v1_1_requestGetPublicKey(dbCom)
-    default:
-      return undefined
-  }
-}

From 2abf228ca9f943f9f3e73c748f9526ffe7d651a3 Mon Sep 17 00:00:00 2001
From: Ulf Gebhardt <ulf.gebhardt@webcraft-media.de>
Date: Thu, 4 May 2023 22:53:55 +0200
Subject: [PATCH 25/58] merge

---
 backend/src/federation/client/Client_1_0.ts   | 26 ++++++-----
 backend/src/federation/validateCommunities.ts | 46 ++++++-------------
 2 files changed, 30 insertions(+), 42 deletions(-)

diff --git a/backend/src/federation/client/Client_1_0.ts b/backend/src/federation/client/Client_1_0.ts
index 456196bcb..77a72cce8 100644
--- a/backend/src/federation/client/Client_1_0.ts
+++ b/backend/src/federation/client/Client_1_0.ts
@@ -26,21 +26,25 @@ export class Client_1_0 {
   }
 
   getPublicKey = async (): Promise<string | undefined> => {
-    logger.info(`requestGetPublicKey with endpoint='${this.endpoint}'...`)
+    logger.info('Federation: getPublicKey from endpoint', this.endpoint)
     try {
       // eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
-      const { data, errors, headers, status } = await this.client.rawRequest(getPublicKey, {})
-      logger.debug(`Response-Data:`, data, errors, headers, status)
-      if (data) {
-        // eslint-disable-next-line @typescript-eslint/no-unsafe-member-access
-        logger.debug(`Response-PublicKey:`, data.getPublicKey.publicKey)
-        logger.info(`requestGetPublicKey processed successfully`)
-        // eslint-disable-next-line @typescript-eslint/no-unsafe-return, @typescript-eslint/no-unsafe-member-access
-        return data.getPublicKey.publicKey
+      const { data } = await this.client.rawRequest(getPublicKey, {})
+      // eslint-disable-next-line @typescript-eslint/no-unsafe-member-access
+      if (!data?.getPublicKey?.publicKey) {
+        logger.warn('Federation: getPublicKey without response data from endpoint', this.endpoint)
+        return
       }
-      logger.warn(`requestGetPublicKey processed without response data`)
+      logger.info(
+        'Federation: getPublicKey successfull from endpoint',
+        this.endpoint,
+        // eslint-disable-next-line @typescript-eslint/no-unsafe-member-access
+        data.getPublicKey.publicKey,
+      )
+      // eslint-disable-next-line @typescript-eslint/no-unsafe-return, @typescript-eslint/no-unsafe-member-access
+      return data.getPublicKey.publicKey
     } catch (err) {
-      throw new LogError(`Request-Error:`, err)
+      logger.warn('Federation: getPublicKey failed for endpoint', this.endpoint)
     }
   }
 }
diff --git a/backend/src/federation/validateCommunities.ts b/backend/src/federation/validateCommunities.ts
index 6879f98e7..fcce9d0d8 100644
--- a/backend/src/federation/validateCommunities.ts
+++ b/backend/src/federation/validateCommunities.ts
@@ -3,7 +3,6 @@
 import { IsNull } from '@dbTools/typeorm'
 import { FederatedCommunity as DbFederatedCommunity } from '@entity/FederatedCommunity'
 
-import { LogError } from '@/server/LogError'
 import { backendLogger as logger } from '@/server/logger'
 
 import { Client } from './client/Client'
@@ -33,39 +32,24 @@ export async function validateCommunities(): Promise<void> {
     logger.debug('Federation: dbCom', dbCom)
     const apiValueStrings: string[] = Object.values(ApiVersionType)
     logger.debug(`suppported ApiVersions=`, apiValueStrings)
-    if (apiValueStrings.includes(dbCom.apiVersion)) {
-      logger.debug(
-        `Federation: validate publicKey for dbCom: ${dbCom.id} with apiVersion=${dbCom.apiVersion}`,
-      )
-      try {
-        const pubKey = await Client.getInstance(dbCom)?.getPublicKey()
-        logger.info(
-          'Federation: received publicKey from endpoint',
+    if (!apiValueStrings.includes(dbCom.apiVersion)) {
+      logger.warn('Federation: dbCom with unsupported apiVersion', dbCom.endPoint, dbCom.apiVersion)
+      continue
+    }
+    try {
+      const client = Client.getInstance(dbCom)
+      const pubKey = await client?.getPublicKey()
+      if (pubKey && pubKey === dbCom.publicKey.toString()) {
+        await DbFederatedCommunity.update({ id: dbCom.id }, { verifiedAt: new Date() })
+      } else {
+        logger.warn(
+          'Federation: received not matching publicKey:',
           pubKey,
-          `${dbCom.endPoint}/${dbCom.apiVersion}`,
+          dbCom.publicKey.toString(),
         )
-        if (pubKey && pubKey === dbCom.publicKey.toString()) {
-          logger.info(`Federation: matching publicKey:  ${pubKey}`)
-          await DbFederatedCommunity.update({ id: dbCom.id }, { verifiedAt: new Date() })
-          logger.debug(`Federation: updated dbCom:  ${JSON.stringify(dbCom)}`)
-        } else {
-          logger.warn(
-            `Federation: received not matching publicKey -> received: ${
-              pubKey || 'null'
-            }, expected: ${dbCom.publicKey.toString()} `,
-          )
-          // DbCommunity.delete({ id: dbCom.id })
-        }
-      } catch (err) {
-        if (!(err instanceof LogError)) {
-          logger.error(`Error:`, err)
-        }
       }
-    } else {
-      logger.warn(
-        `Federation: dbCom: ${dbCom.id} with unsupported apiVersion=${dbCom.apiVersion}; supported versions`,
-        apiValueStrings,
-      )
+    } catch (err) {
+      logger.error(`Error:`, err)
     }
   }
 }

From cd7cef4fbf0f022db1d7e7ac11099ddc176dc6a5 Mon Sep 17 00:00:00 2001
From: Ulf Gebhardt <ulf.gebhardt@webcraft-media.de>
Date: Thu, 4 May 2023 12:09:12 +0200
Subject: [PATCH 26/58] typo

---
 backend/src/federation/client/Client_1_0.ts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/backend/src/federation/client/Client_1_0.ts b/backend/src/federation/client/Client_1_0.ts
index 77a72cce8..ad6641f1c 100644
--- a/backend/src/federation/client/Client_1_0.ts
+++ b/backend/src/federation/client/Client_1_0.ts
@@ -36,7 +36,7 @@ export class Client_1_0 {
         return
       }
       logger.info(
-        'Federation: getPublicKey successfull from endpoint',
+        'Federation: getPublicKey successful from endpoint',
         this.endpoint,
         // eslint-disable-next-line @typescript-eslint/no-unsafe-member-access
         data.getPublicKey.publicKey,

From 6c7243758f885282be5786ea851dfbedb9d64832 Mon Sep 17 00:00:00 2001
From: Ulf Gebhardt <ulf.gebhardt@webcraft-media.de>
Date: Thu, 4 May 2023 12:26:11 +0200
Subject: [PATCH 27/58] fix tests

---
 .../federation/validateCommunities.test.ts    | 20 ++++++++++++-------
 1 file changed, 13 insertions(+), 7 deletions(-)

diff --git a/backend/src/federation/validateCommunities.test.ts b/backend/src/federation/validateCommunities.test.ts
index ed4897e09..77d0cc2ad 100644
--- a/backend/src/federation/validateCommunities.test.ts
+++ b/backend/src/federation/validateCommunities.test.ts
@@ -84,7 +84,8 @@ describe('validate Communities', () => {
       })
       it('logs requestGetPublicKey for community api 1_0 ', () => {
         expect(logger.info).toBeCalledWith(
-          `requestGetPublicKey with endpoint='http//localhost:5001/api/1_0/'...`,
+          'Federation: getPublicKey from endpoint',
+          'http//localhost:5001/api/1_0/',
         )
       })
     })
@@ -114,12 +115,14 @@ describe('validate Communities', () => {
       })
       it('logs requestGetPublicKey for community api 1_0 ', () => {
         expect(logger.info).toBeCalledWith(
-          `requestGetPublicKey with endpoint='http//localhost:5001/api/1_0/'...`,
+          'Federation: getPublicKey from endpoint',
+          'http//localhost:5001/api/1_0/',
         )
       })
       it('logs requestGetPublicKey for community api 1_1 ', () => {
         expect(logger.info).toBeCalledWith(
-          `requestGetPublicKey with endpoint='http//localhost:5001/api/1_1/'...`,
+          'Federation: getPublicKey from endpoint',
+          'http//localhost:5001/api/1_1/',
         )
       })
     })
@@ -152,18 +155,21 @@ describe('validate Communities', () => {
       })
       it('logs requestGetPublicKey for community api 1_0 ', () => {
         expect(logger.info).toBeCalledWith(
-          `requestGetPublicKey with endpoint='http//localhost:5001/api/1_0/'...`,
+          'Federation: getPublicKey from endpoint',
+          'http//localhost:5001/api/1_0/',
         )
       })
       it('logs requestGetPublicKey for community api 1_1 ', () => {
         expect(logger.info).toBeCalledWith(
-          `requestGetPublicKey with endpoint='http//localhost:5001/api/1_1/'...`,
+          'Federation: getPublicKey from endpoint',
+          'http//localhost:5001/api/1_1/',
         )
       })
       it('logs unsupported api for community with api 2_0 ', () => {
         expect(logger.warn).toBeCalledWith(
-          `Federation: dbCom: ${dbCom.id} with unsupported apiVersion=2_0; supported versions`,
-          ['1_0', '1_1'],
+          'Federation: dbCom with unsupported apiVersion',
+          dbCom.endPoint,
+          '2_0',
         )
       })
     })

From 97b3a88065c6f7d899e745b309d991e664451eaa Mon Sep 17 00:00:00 2001
From: Ulf Gebhardt <ulf.gebhardt@webcraft-media.de>
Date: Thu, 4 May 2023 12:27:41 +0200
Subject: [PATCH 28/58] 86% line coverage

---
 backend/jest.config.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/backend/jest.config.js b/backend/jest.config.js
index ca12668fa..3b251916a 100644
--- a/backend/jest.config.js
+++ b/backend/jest.config.js
@@ -7,7 +7,7 @@ module.exports = {
   collectCoverageFrom: ['src/**/*.ts', '!**/node_modules/**', '!src/seeds/**', '!build/**'],
   coverageThreshold: {
     global: {
-      lines: 85,
+      lines: 86,
     },
   },
   setupFiles: ['<rootDir>/test/testSetup.ts'],

From d3ba23e1e4c5da32cde11a39bea2070ffaf20f4a Mon Sep 17 00:00:00 2001
From: Ulf Gebhardt <ulf.gebhardt@webcraft-media.de>
Date: Thu, 4 May 2023 12:56:46 +0200
Subject: [PATCH 29/58] fix lint

---
 backend/src/federation/client/Client_1_0.ts | 1 -
 1 file changed, 1 deletion(-)

diff --git a/backend/src/federation/client/Client_1_0.ts b/backend/src/federation/client/Client_1_0.ts
index ad6641f1c..0c0d458c8 100644
--- a/backend/src/federation/client/Client_1_0.ts
+++ b/backend/src/federation/client/Client_1_0.ts
@@ -2,7 +2,6 @@ import { FederatedCommunity as DbFederatedCommunity } from '@entity/FederatedCom
 import { GraphQLClient } from 'graphql-request'
 
 import { getPublicKey } from '@/federation/query/getPublicKey'
-import { LogError } from '@/server/LogError'
 import { backendLogger as logger } from '@/server/logger'
 
 // eslint-disable-next-line camelcase

From 2bf839f36212216dc970f32381247c890b09e082 Mon Sep 17 00:00:00 2001
From: Ulf Gebhardt <ulf.gebhardt@webcraft-media.de>
Date: Thu, 4 May 2023 13:51:08 +0200
Subject: [PATCH 30/58] lint fixes


From 0cd2b7646d1190825612f5637db1abe78ea5e354 Mon Sep 17 00:00:00 2001
From: Claus-Peter Huebner <claus-peter.huebner@email.de>
Date: Mon, 8 May 2023 11:03:01 +0200
Subject: [PATCH 31/58] rework PR-comments

---
 backend/src/util/utilities.ts | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/backend/src/util/utilities.ts b/backend/src/util/utilities.ts
index 4dc71ff7f..30c1effdb 100644
--- a/backend/src/util/utilities.ts
+++ b/backend/src/util/utilities.ts
@@ -19,14 +19,14 @@ export const fullName = (firstName: string, lastName: string): string => {
   return [firstName, lastName].filter(Boolean).join(' ')
 }
 
-export const userName = (f?: string, l?: string): string | null => {
+export const userName = (firstName?: string, lastName?: string): string | null => {
   let name: string | null
-  if (f && l) {
-    name = f + ' ' + l
-  } else if (f && !l) {
-    name = f
-  } else if (!f && l) {
-    name = l
+  if (firstName && lastName) {
+    name = firstName + ' ' + lastName
+  } else if (firstName && !lastName) {
+    name = firstName
+  } else if (!firstName && lastName) {
+    name = lastName
   } else {
     name = null
   }

From 03246bb54a4f7169fd86a162b8572202e14390a7 Mon Sep 17 00:00:00 2001
From: clauspeterhuebner <86960882+clauspeterhuebner@users.noreply.github.com>
Date: Mon, 8 May 2023 17:03:37 +0200
Subject: [PATCH 32/58] Update backend/src/util/utilities.ts

Co-authored-by: Hannes Heine <heine.hannes@gmail.com>
---
 backend/src/util/utilities.ts | 14 --------------
 1 file changed, 14 deletions(-)

diff --git a/backend/src/util/utilities.ts b/backend/src/util/utilities.ts
index 30c1effdb..df2166cfd 100644
--- a/backend/src/util/utilities.ts
+++ b/backend/src/util/utilities.ts
@@ -19,17 +19,3 @@ export const fullName = (firstName: string, lastName: string): string => {
   return [firstName, lastName].filter(Boolean).join(' ')
 }
 
-export const userName = (firstName?: string, lastName?: string): string | null => {
-  let name: string | null
-  if (firstName && lastName) {
-    name = firstName + ' ' + lastName
-  } else if (firstName && !lastName) {
-    name = firstName
-  } else if (!firstName && lastName) {
-    name = lastName
-  } else {
-    name = null
-  }
-
-  return name
-}

From 20daf80c44d5694d5d7c71fd1f508911114385d6 Mon Sep 17 00:00:00 2001
From: clauspeterhuebner <86960882+clauspeterhuebner@users.noreply.github.com>
Date: Mon, 8 May 2023 17:14:55 +0200
Subject: [PATCH 33/58] Update
 database/migrations/0066-x-community-sendcoins-transactions_table.ts

Co-authored-by: Hannes Heine <heine.hannes@gmail.com>
---
 ...-community-sendcoins-transactions_table.ts | 28 -------------------
 1 file changed, 28 deletions(-)

diff --git a/database/migrations/0066-x-community-sendcoins-transactions_table.ts b/database/migrations/0066-x-community-sendcoins-transactions_table.ts
index 9f80460ed..a56c6df00 100644
--- a/database/migrations/0066-x-community-sendcoins-transactions_table.ts
+++ b/database/migrations/0066-x-community-sendcoins-transactions_table.ts
@@ -77,34 +77,6 @@ export async function upgrade(queryFn: (query: string, values?: any[]) => Promis
     `UPDATE transactions t, users u SET t.linked_user_gradido_id = u.gradido_id, t.linked_user_name = concat(u.first_name, ' ', u.last_name) WHERE t.linked_user_id = u.id and t.linked_user_id is null and t.linked_user_gradido_id is null;`,
   )
 
-  await queryFn(`
-      CREATE TABLE IF NOT EXISTS \`pending_transactions\` (
-        \`id\` int(10) unsigned NOT NULL AUTO_INCREMENT,
-        \`previous\` int(10) unsigned DEFAULT NULL NULL,
-        \`type_id\` int(10) DEFAULT NULL NULL,
-        \`transaction_link_id\` int(10) unsigned DEFAULT NULL NULL,
-        \`amount\` decimal(40,20) DEFAULT NULL NULL,
-        \`balance\` decimal(40,20) DEFAULT NULL NULL,
-        \`balance_date\` datetime(3) DEFAULT current_timestamp(3) NOT NULL,
-        \`decay\` decimal(40,20) DEFAULT NULL NULL,
-        \`decay_start\` datetime(3) DEFAULT NULL NULL,
-        \`memo\` varchar(255) CHARACTER SET utf8mb4 COLLATE utf8mb4_unicode_ci NOT NULL,
-        \`creation_date\` datetime(3) DEFAULT NULL NULL,
-        \`user_id\` int(10) unsigned NOT NULL,
-        \`user_gradido_id\` char(36) NOT NULL,
-        \`user_community_uuid\` char(36) NOT NULL,
-        \`user_name\` varchar(512) COLLATE utf8mb4_unicode_ci NOT NULL,
-        \`linked_user_id\` int(10) unsigned DEFAULT NULL NULL,
-        \`linked_user_gradido_id\` char(36) NOT NULL,
-        \`linked_user_community_uuid\` char(36) NOT NULL,
-        \`linked_user_name\` varchar(512) NULL,
-        \`linked_transaction_id\` int(10) DEFAULT NULL NULL,
-        \`x_transaction_state\` varchar(100) NOT NULL COMMENT 'States to handle 2-Phase-Commit handshake',
-        \`created_at\` datetime(3) NOT NULL DEFAULT CURRENT_TIMESTAMP(3),
-        \`updated_at\` datetime(3) NULL DEFAULT NULL ON UPDATE CURRENT_TIMESTAMP(3),
-        \`deleted_at\` datetime(3) NULL DEFAULT NULL,
-        PRIMARY KEY (\`id\`)
-      ) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4;`)
 }
 
 /* eslint-disable @typescript-eslint/no-empty-function */

From 920b0f6d027a5fb362765a3044327741d1b80ed3 Mon Sep 17 00:00:00 2001
From: clauspeterhuebner <86960882+clauspeterhuebner@users.noreply.github.com>
Date: Mon, 8 May 2023 17:15:06 +0200
Subject: [PATCH 34/58] Update
 database/migrations/0066-x-community-sendcoins-transactions_table.ts

Co-authored-by: Hannes Heine <heine.hannes@gmail.com>
---
 .../migrations/0066-x-community-sendcoins-transactions_table.ts  | 1 -
 1 file changed, 1 deletion(-)

diff --git a/database/migrations/0066-x-community-sendcoins-transactions_table.ts b/database/migrations/0066-x-community-sendcoins-transactions_table.ts
index a56c6df00..10693bdba 100644
--- a/database/migrations/0066-x-community-sendcoins-transactions_table.ts
+++ b/database/migrations/0066-x-community-sendcoins-transactions_table.ts
@@ -88,5 +88,4 @@ export async function downgrade(queryFn: (query: string, values?: any[]) => Prom
   await queryFn('ALTER TABLE `transactions` DROP COLUMN `linked_user_gradido_id`;')
   await queryFn('ALTER TABLE `transactions` DROP COLUMN `linked_user_community_uuid`;')
   await queryFn('ALTER TABLE `transactions` DROP COLUMN `linked_user_name`;')
-  await queryFn(`DROP TABLE IF EXISTS pending_transactions;`)
 }

From b87373947adbd7b047afbc9a80fc8a12e5770457 Mon Sep 17 00:00:00 2001
From: Claus-Peter Huebner <claus-peter.huebner@email.de>
Date: Tue, 9 May 2023 01:27:13 +0200
Subject: [PATCH 35/58] linting

---
 backend/src/util/utilities.ts | 1 -
 1 file changed, 1 deletion(-)

diff --git a/backend/src/util/utilities.ts b/backend/src/util/utilities.ts
index df2166cfd..6bd70b941 100644
--- a/backend/src/util/utilities.ts
+++ b/backend/src/util/utilities.ts
@@ -18,4 +18,3 @@ export const decimalSeparatorByLanguage = (a: Decimal, language: string): string
 export const fullName = (firstName: string, lastName: string): string => {
   return [firstName, lastName].filter(Boolean).join(' ')
 }
-

From 6519b4b75e9c9f37eab79e26b44655e54c8a6c1f Mon Sep 17 00:00:00 2001
From: Ulf Gebhardt <ulf.gebhardt@webcraft-media.de>
Date: Tue, 9 May 2023 10:18:01 +0200
Subject: [PATCH 36/58] Update backend/src/federation/client/Client_1_0.ts

Co-authored-by: Hannes Heine <heine.hannes@gmail.com>
---
 backend/src/federation/client/Client_1_0.ts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/backend/src/federation/client/Client_1_0.ts b/backend/src/federation/client/Client_1_0.ts
index 456196bcb..19d58de89 100644
--- a/backend/src/federation/client/Client_1_0.ts
+++ b/backend/src/federation/client/Client_1_0.ts
@@ -30,7 +30,7 @@ export class Client_1_0 {
     try {
       // eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
       const { data, errors, headers, status } = await this.client.rawRequest(getPublicKey, {})
-      logger.debug(`Response-Data:`, data, errors, headers, status)
+      logger.debug('Response-Data:', data, errors, headers, status)
       if (data) {
         // eslint-disable-next-line @typescript-eslint/no-unsafe-member-access
         logger.debug(`Response-PublicKey:`, data.getPublicKey.publicKey)

From f8a63f9b71c2830d7d09905d634adb7c6aa898bf Mon Sep 17 00:00:00 2001
From: Ulf Gebhardt <ulf.gebhardt@webcraft-media.de>
Date: Tue, 9 May 2023 10:18:43 +0200
Subject: [PATCH 37/58] Update backend/src/federation/client/Client_1_0.ts

Co-authored-by: Hannes Heine <heine.hannes@gmail.com>
---
 backend/src/federation/client/Client_1_0.ts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/backend/src/federation/client/Client_1_0.ts b/backend/src/federation/client/Client_1_0.ts
index 19d58de89..fd2f941a3 100644
--- a/backend/src/federation/client/Client_1_0.ts
+++ b/backend/src/federation/client/Client_1_0.ts
@@ -33,7 +33,7 @@ export class Client_1_0 {
       logger.debug('Response-Data:', data, errors, headers, status)
       if (data) {
         // eslint-disable-next-line @typescript-eslint/no-unsafe-member-access
-        logger.debug(`Response-PublicKey:`, data.getPublicKey.publicKey)
+        logger.debug('Response-PublicKey:', data.getPublicKey.publicKey)
         logger.info(`requestGetPublicKey processed successfully`)
         // eslint-disable-next-line @typescript-eslint/no-unsafe-return, @typescript-eslint/no-unsafe-member-access
         return data.getPublicKey.publicKey

From b7ce0e277ccc04d0c673fba87d3aa6df09dd4eb9 Mon Sep 17 00:00:00 2001
From: Moriz Wahl <moriz.wahl@gmx.de>
Date: Tue, 9 May 2023 13:58:53 +0200
Subject: [PATCH 38/58] fix variable name

---
 backend/src/graphql/resolver/UserResolver.ts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/backend/src/graphql/resolver/UserResolver.ts b/backend/src/graphql/resolver/UserResolver.ts
index 3674f6602..7198a3bdc 100644
--- a/backend/src/graphql/resolver/UserResolver.ts
+++ b/backend/src/graphql/resolver/UserResolver.ts
@@ -538,7 +538,7 @@ export class UserResolver {
       if (aliasInUse.length !== 0) {
         throw new LogError('Alias already in use', alias)
       }
-      userEntity.alias = alias
+      user.alias = alias
     }
 
     if (language) {

From 864beb7914b7ab93fb0aa6aa6be89f60a7667b2e Mon Sep 17 00:00:00 2001
From: Claus-Peter Huebner <claus-peter.huebner@email.de>
Date: Tue, 9 May 2023 18:23:21 +0200
Subject: [PATCH 39/58] linting

---
 .../migrations/0066-x-community-sendcoins-transactions_table.ts  | 1 -
 1 file changed, 1 deletion(-)

diff --git a/database/migrations/0066-x-community-sendcoins-transactions_table.ts b/database/migrations/0066-x-community-sendcoins-transactions_table.ts
index 10693bdba..62dd95f62 100644
--- a/database/migrations/0066-x-community-sendcoins-transactions_table.ts
+++ b/database/migrations/0066-x-community-sendcoins-transactions_table.ts
@@ -76,7 +76,6 @@ export async function upgrade(queryFn: (query: string, values?: any[]) => Promis
   await queryFn(
     `UPDATE transactions t, users u SET t.linked_user_gradido_id = u.gradido_id, t.linked_user_name = concat(u.first_name, ' ', u.last_name) WHERE t.linked_user_id = u.id and t.linked_user_id is null and t.linked_user_gradido_id is null;`,
   )
-
 }
 
 /* eslint-disable @typescript-eslint/no-empty-function */

From bcb08fc0fb222b38e59964f4014e79cb0be26a43 Mon Sep 17 00:00:00 2001
From: Claus-Peter Huebner <claus-peter.huebner@email.de>
Date: Tue, 9 May 2023 20:06:50 +0200
Subject: [PATCH 40/58] correct migration after test with production data

---
 .../migrations/0066-x-community-sendcoins-transactions_table.ts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/database/migrations/0066-x-community-sendcoins-transactions_table.ts b/database/migrations/0066-x-community-sendcoins-transactions_table.ts
index 62dd95f62..65c21e0b5 100644
--- a/database/migrations/0066-x-community-sendcoins-transactions_table.ts
+++ b/database/migrations/0066-x-community-sendcoins-transactions_table.ts
@@ -74,7 +74,7 @@ export async function upgrade(queryFn: (query: string, values?: any[]) => Promis
   )
   */
   await queryFn(
-    `UPDATE transactions t, users u SET t.linked_user_gradido_id = u.gradido_id, t.linked_user_name = concat(u.first_name, ' ', u.last_name) WHERE t.linked_user_id = u.id and t.linked_user_id is null and t.linked_user_gradido_id is null;`,
+    `UPDATE transactions t, users u SET t.linked_user_gradido_id = u.gradido_id, t.linked_user_name = concat(u.first_name, ' ', u.last_name) WHERE t.linked_user_id = u.id and t.linked_user_gradido_id is null;`,
   )
 }
 

From 15f0d062ee45a2d96c0e0135cde2083a1a2f383d Mon Sep 17 00:00:00 2001
From: Claus-Peter Huebner <claus-peter.huebner@email.de>
Date: Wed, 10 May 2023 00:29:33 +0200
Subject: [PATCH 41/58] remove commented code

---
 .../0066-x-community-sendcoins-transactions_table.ts         | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/database/migrations/0066-x-community-sendcoins-transactions_table.ts b/database/migrations/0066-x-community-sendcoins-transactions_table.ts
index 65c21e0b5..2a3b3973a 100644
--- a/database/migrations/0066-x-community-sendcoins-transactions_table.ts
+++ b/database/migrations/0066-x-community-sendcoins-transactions_table.ts
@@ -68,11 +68,6 @@ export async function upgrade(queryFn: (query: string, values?: any[]) => Promis
   await queryFn(
     'ALTER TABLE `transactions` MODIFY COLUMN `user_gradido_id` char(36) NOT NULL AFTER `user_id`;',
   )
-  /*
-  await queryFn(
-    'ALTER TABLE `transactions` MODIFY COLUMN `user_name` varchar(512) COLLATE utf8mb4_unicode_ci NOT NULL AFTER `user_community_uuid`;',
-  )
-  */
   await queryFn(
     `UPDATE transactions t, users u SET t.linked_user_gradido_id = u.gradido_id, t.linked_user_name = concat(u.first_name, ' ', u.last_name) WHERE t.linked_user_id = u.id and t.linked_user_gradido_id is null;`,
   )

From d69afa7e9f2c4b57ae8c1153928172c441c2245a Mon Sep 17 00:00:00 2001
From: Ulf Gebhardt <ulf.gebhardt@webcraft-media.de>
Date: Wed, 10 May 2023 12:13:51 +0200
Subject: [PATCH 42/58] eslint security

---
 backend/.eslintrc.js |  1 +
 backend/package.json |  1 +
 backend/yarn.lock    | 21 ++++++++++++++++++++-
 3 files changed, 22 insertions(+), 1 deletion(-)

diff --git a/backend/.eslintrc.js b/backend/.eslintrc.js
index 6a7d74b38..7f2ecd578 100644
--- a/backend/.eslintrc.js
+++ b/backend/.eslintrc.js
@@ -12,6 +12,7 @@ module.exports = {
     'plugin:prettier/recommended',
     'plugin:import/recommended',
     'plugin:import/typescript',
+    'plugin:security/recommended',
   ],
   settings: {
     'import/parsers': {
diff --git a/backend/package.json b/backend/package.json
index c5e0df3c5..c6e852841 100644
--- a/backend/package.json
+++ b/backend/package.json
@@ -68,6 +68,7 @@
     "eslint-plugin-n": "^15.7.0",
     "eslint-plugin-prettier": "^4.2.1",
     "eslint-plugin-promise": "^6.1.1",
+    "eslint-plugin-security": "^1.7.1",
     "eslint-plugin-type-graphql": "^1.0.0",
     "faker": "^5.5.3",
     "graphql-tag": "^2.12.6",
diff --git a/backend/yarn.lock b/backend/yarn.lock
index 1bc8c64fd..4a283e482 100644
--- a/backend/yarn.lock
+++ b/backend/yarn.lock
@@ -3005,6 +3005,13 @@ eslint-plugin-promise@^6.1.1:
   resolved "https://registry.yarnpkg.com/eslint-plugin-promise/-/eslint-plugin-promise-6.1.1.tgz#269a3e2772f62875661220631bd4dafcb4083816"
   integrity sha512-tjqWDwVZQo7UIPMeDReOpUgHCmCiH+ePnVT+5zVapL0uuHnegBUs2smM13CzOs2Xb5+MHMRFTs9v24yjba4Oig==
 
+eslint-plugin-security@^1.7.1:
+  version "1.7.1"
+  resolved "https://registry.yarnpkg.com/eslint-plugin-security/-/eslint-plugin-security-1.7.1.tgz#0e9c4a471f6e4d3ca16413c7a4a51f3966ba16e4"
+  integrity sha512-sMStceig8AFglhhT2LqlU5r+/fn9OwsA72O5bBuQVTssPCdQAOQzL+oMn/ZcpeUY6KcNfLJArgcrsSULNjYYdQ==
+  dependencies:
+    safe-regex "^2.1.1"
+
 eslint-plugin-type-graphql@^1.0.0:
   version "1.0.0"
   resolved "https://registry.yarnpkg.com/eslint-plugin-type-graphql/-/eslint-plugin-type-graphql-1.0.0.tgz#d348560ed628d6ca1dfcea35a02891432daafe6b"
@@ -3649,7 +3656,7 @@ graceful-fs@^4.1.6, graceful-fs@^4.2.0:
   integrity sha512-9ByhssR2fPVsNZj478qUUbKfmL0+t5BDVyjShtyZZLiK7ZDAArFFfopyOTj0M05wE2tJPisA4iTnnXl2YoPvOA==
 
 "gradido-database@file:../database":
-  version "1.19.1"
+  version "1.20.0"
   dependencies:
     "@types/uuid" "^8.3.4"
     cross-env "^7.0.3"
@@ -6140,6 +6147,11 @@ reflect-metadata@^0.1.13:
   resolved "https://registry.yarnpkg.com/reflect-metadata/-/reflect-metadata-0.1.13.tgz#67ae3ca57c972a2aa1642b10fe363fe32d49dc08"
   integrity sha512-Ts1Y/anZELhSsjMcU605fU9RE4Oi3p5ORujwbIKXfWa+0Zxs510Qrmrce5/Jowq3cHSZSJqBjypxmHarc+vEWg==
 
+regexp-tree@~0.1.1:
+  version "0.1.27"
+  resolved "https://registry.yarnpkg.com/regexp-tree/-/regexp-tree-0.1.27.tgz#2198f0ef54518ffa743fe74d983b56ffd631b6cd"
+  integrity sha512-iETxpjK6YoRWJG5o6hXLwvjYAoW+FEZn9os0PD/b6AP6xQwsa/Y7lCVgIixBbUPMfhu+i2LtdeAqVTgGlQarfA==
+
 regexp.prototype.flags@^1.4.3:
   version "1.4.3"
   resolved "https://registry.yarnpkg.com/regexp.prototype.flags/-/regexp.prototype.flags-1.4.3.tgz#87cab30f80f66660181a3bb7bf5981a872b367ac"
@@ -6279,6 +6291,13 @@ safe-regex-test@^1.0.0:
     get-intrinsic "^1.1.3"
     is-regex "^1.1.4"
 
+safe-regex@^2.1.1:
+  version "2.1.1"
+  resolved "https://registry.yarnpkg.com/safe-regex/-/safe-regex-2.1.1.tgz#f7128f00d056e2fe5c11e81a1324dd974aadced2"
+  integrity sha512-rx+x8AMzKb5Q5lQ95Zoi6ZbJqwCLkqi3XuJXp5P3rT8OEc6sZCJG5AE5dU3lsgRr/F4Bs31jSlVN+j5KrsGu9A==
+  dependencies:
+    regexp-tree "~0.1.1"
+
 "safer-buffer@>= 2.1.2 < 3", "safer-buffer@>= 2.1.2 < 3.0.0":
   version "2.1.2"
   resolved "https://registry.yarnpkg.com/safer-buffer/-/safer-buffer-2.1.2.tgz#44fa161b0187b9549dd84bb91802f9bd8385cd6a"

From 2545f1342e9a6147923bab9d8b7664a9c66ee2ee Mon Sep 17 00:00:00 2001
From: Ulf Gebhardt <ulf.gebhardt@webcraft-media.de>
Date: Wed, 10 May 2023 12:14:13 +0200
Subject: [PATCH 43/58] fix security issue

---
 backend/src/seeds/index.ts | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/backend/src/seeds/index.ts b/backend/src/seeds/index.ts
index fab81eb95..77fa51990 100644
--- a/backend/src/seeds/index.ts
+++ b/backend/src/seeds/index.ts
@@ -54,9 +54,8 @@ const run = async () => {
   logger.info('##seed## clean database successful...')
 
   // seed the standard users
-  for (let i = 0; i < users.length; i++) {
-    const dbUser = await userFactory(seedClient, users[i])
-    logger.info(`##seed## seed standard users[ ${i} ]= ${JSON.stringify(dbUser, null, 2)}`)
+  for (const user of users) {
+    await userFactory(seedClient, user)
   }
   logger.info('##seed## seeding all standard users successful...')
 

From a319bc2f034afa0d29dcc754cc5efbfc0afc8e9c Mon Sep 17 00:00:00 2001
From: Ulf Gebhardt <ulf.gebhardt@webcraft-media.de>
Date: Wed, 10 May 2023 12:14:47 +0200
Subject: [PATCH 44/58] refactor utilies function, explicitly ignore security
 warning

---
 backend/src/util/utilities.ts | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/backend/src/util/utilities.ts b/backend/src/util/utilities.ts
index e9935bbd4..d5da55aed 100644
--- a/backend/src/util/utilities.ts
+++ b/backend/src/util/utilities.ts
@@ -1,11 +1,9 @@
 import { Decimal } from 'decimal.js-light'
 import i18n from 'i18n'
 
-export const objectValuesToArray = (obj: Record<string, string>): string[] => {
-  return Object.keys(obj).map(function (key) {
-    return obj[key]
-  })
-}
+export const objectValuesToArray = (obj: Record<string, string>): string[] =>
+  // eslint-disable-next-line security/detect-object-injection
+  Object.keys(obj).map((key) => obj[key])
 
 export const decimalSeparatorByLanguage = (a: Decimal, language: string): string => {
   const rememberLocaleToRestore = i18n.getLocale()

From e01ef9ad100f82f67d3448f34d1d8f050aad238b Mon Sep 17 00:00:00 2001
From: Ulf Gebhardt <ulf.gebhardt@webcraft-media.de>
Date: Wed, 10 May 2023 12:15:12 +0200
Subject: [PATCH 45/58] ignore security warning where not applicable or
 unfixable for now

---
 backend/src/graphql/resolver/TransactionLinkResolver.test.ts | 1 +
 backend/src/graphql/resolver/util/creations.ts               | 4 ++++
 backend/src/server/logger.ts                                 | 1 +
 backend/src/webhook/elopage.ts                               | 1 +
 4 files changed, 7 insertions(+)

diff --git a/backend/src/graphql/resolver/TransactionLinkResolver.test.ts b/backend/src/graphql/resolver/TransactionLinkResolver.test.ts
index 9d39a80ae..3c6ba31ab 100644
--- a/backend/src/graphql/resolver/TransactionLinkResolver.test.ts
+++ b/backend/src/graphql/resolver/TransactionLinkResolver.test.ts
@@ -1040,6 +1040,7 @@ describe('TransactionLinkResolver', () => {
     })
 
     it('returns a string that ends with the hex value of date', () => {
+      // eslint-disable-next-line security/detect-non-literal-regexp
       const regexp = new RegExp(date.getTime().toString(16) + '$')
       expect(transactionLinkCode(date)).toEqual(expect.stringMatching(regexp))
     })
diff --git a/backend/src/graphql/resolver/util/creations.ts b/backend/src/graphql/resolver/util/creations.ts
index 1c0c0735e..d6f0e9af4 100644
--- a/backend/src/graphql/resolver/util/creations.ts
+++ b/backend/src/graphql/resolver/util/creations.ts
@@ -29,10 +29,12 @@ export const validateContribution = (
     throw new LogError('No information for available creations for the given date', creationDate)
   }
 
+  // eslint-disable-next-line security/detect-object-injection
   if (amount.greaterThan(creations[index].toString())) {
     throw new LogError(
       'The amount to be created exceeds the amount still available for this month',
       amount,
+      // eslint-disable-next-line security/detect-object-injection
       creations[index],
     )
   }
@@ -151,6 +153,7 @@ export const updateCreations = (
   if (index < 0) {
     throw new LogError('You cannot create GDD for a month older than the last three months')
   }
+  // eslint-disable-next-line security/detect-object-injection
   creations[index] = creations[index].plus(contribution.amount.toString())
   return creations
 }
@@ -169,6 +172,7 @@ export const getOpenCreations = async (
     return {
       month: date.getMonth(),
       year: date.getFullYear(),
+      // eslint-disable-next-line security/detect-object-injection
       amount: creations[index],
     }
   })
diff --git a/backend/src/server/logger.ts b/backend/src/server/logger.ts
index d1edbd8fb..0f146b7f7 100644
--- a/backend/src/server/logger.ts
+++ b/backend/src/server/logger.ts
@@ -7,6 +7,7 @@ import { configure, getLogger } from 'log4js'
 
 import { CONFIG } from '@/config'
 
+// eslint-disable-next-line security/detect-non-literal-fs-filename
 const options = JSON.parse(readFileSync(CONFIG.LOG4JS_CONFIG, 'utf-8'))
 
 options.categories.backend.level = CONFIG.LOG_LEVEL
diff --git a/backend/src/webhook/elopage.ts b/backend/src/webhook/elopage.ts
index 7a779fadd..07e7d4ecf 100644
--- a/backend/src/webhook/elopage.ts
+++ b/backend/src/webhook/elopage.ts
@@ -115,6 +115,7 @@ export const elopageWebhook = async (req: any, res: any): Promise<void> => {
   ) {
     const email = loginElopageBuy.payerEmail
 
+    // eslint-disable-next-line security/detect-unsafe-regex
     const VALIDATE_EMAIL = /^[a-zA-Z0-9.!#$%&?*+/=?^_`{|}~-]+@[a-zA-Z0-9-]+(?:\.[a-zA-Z0-9-]+)*$/
     const VALIDATE_NAME = /^<>&;]{2,}$/
 

From 4ac1988b34d3ca4361aef4e1938f7e8bab9c6fbd Mon Sep 17 00:00:00 2001
From: Ulf Gebhardt <ulf.gebhardt@webcraft-media.de>
Date: Wed, 10 May 2023 13:03:02 +0200
Subject: [PATCH 46/58] lint eslint comments

---
 backend/.eslintrc.js |  3 +++
 backend/package.json |  1 +
 backend/yarn.lock    | 10 +++++++++-
 3 files changed, 13 insertions(+), 1 deletion(-)

diff --git a/backend/.eslintrc.js b/backend/.eslintrc.js
index 7f2ecd578..158d1a0bb 100644
--- a/backend/.eslintrc.js
+++ b/backend/.eslintrc.js
@@ -13,6 +13,7 @@ module.exports = {
     'plugin:import/recommended',
     'plugin:import/typescript',
     'plugin:security/recommended',
+    'plugin:@eslint-community/eslint-comments/recommended',
   ],
   settings: {
     'import/parsers': {
@@ -152,6 +153,8 @@ module.exports = {
     'promise/valid-params': 'warn',
     'promise/prefer-await-to-callbacks': 'error',
     'promise/no-multiple-resolved': 'error',
+    // eslint comments
+    '@eslint-community/eslint-comments/disable-enable-pair': ['error', { allowWholeFile: true }],
   },
   overrides: [
     // only for ts files
diff --git a/backend/package.json b/backend/package.json
index c6e852841..8a8d14e00 100644
--- a/backend/package.json
+++ b/backend/package.json
@@ -46,6 +46,7 @@
     "uuid": "^8.3.2"
   },
   "devDependencies": {
+    "@eslint-community/eslint-plugin-eslint-comments": "^3.2.1",
     "@types/email-templates": "^10.0.1",
     "@types/express": "^4.17.12",
     "@types/faker": "^5.5.9",
diff --git a/backend/yarn.lock b/backend/yarn.lock
index 4a283e482..237a265e3 100644
--- a/backend/yarn.lock
+++ b/backend/yarn.lock
@@ -382,6 +382,14 @@
   dependencies:
     "@cspotcode/source-map-consumer" "0.8.0"
 
+"@eslint-community/eslint-plugin-eslint-comments@^3.2.1":
+  version "3.2.1"
+  resolved "https://registry.yarnpkg.com/@eslint-community/eslint-plugin-eslint-comments/-/eslint-plugin-eslint-comments-3.2.1.tgz#3c65061e27f155eae3744c3b30c5a8253a959040"
+  integrity sha512-/HZbjIGaVO2zLlWX3gRgiHmKRVvvqrC0zVu3eXnIj1ORxoyfGSj50l0PfDfqihyZAqrDYzSMdJesXzFjvAoiLQ==
+  dependencies:
+    escape-string-regexp "^1.0.5"
+    ignore "^5.2.4"
+
 "@eslint-community/eslint-utils@^4.2.0":
   version "4.2.0"
   resolved "https://registry.yarnpkg.com/@eslint-community/eslint-utils/-/eslint-utils-4.2.0.tgz#a831e6e468b4b2b5ae42bf658bea015bf10bc518"
@@ -3984,7 +3992,7 @@ ignore@^5.1.1:
   resolved "https://registry.yarnpkg.com/ignore/-/ignore-5.1.8.tgz#f150a8b50a34289b33e22f5889abd4d8016f0e57"
   integrity sha512-BMpfD7PpiETpBl/A6S498BaIJ6Y/ABT93ETbby2fP00v4EbvPBXWEoaR1UBPKs3iR53pJY7EtZk5KACI57i1Uw==
 
-ignore@^5.2.0:
+ignore@^5.2.0, ignore@^5.2.4:
   version "5.2.4"
   resolved "https://registry.yarnpkg.com/ignore/-/ignore-5.2.4.tgz#a291c0c6178ff1b960befe47fcdec301674a6324"
   integrity sha512-MAb38BcSbH0eHNBxn7ql2NH/kX33OkB3lZ1BNdh7ENeRChHTYsTvWrMubiIAMNS2llXEEgZ1MUOBtXChP3kaFQ==

From 7483cef63419f2d9bab099d1ebaa4f95b0ff2298 Mon Sep 17 00:00:00 2001
From: Ulf Gebhardt <ulf.gebhardt@webcraft-media.de>
Date: Wed, 10 May 2023 13:03:13 +0200
Subject: [PATCH 47/58] ignore coverage folder for linting

---
 backend/.eslintignore | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/backend/.eslintignore b/backend/.eslintignore
index f6b255e92..1ae86fe5e 100644
--- a/backend/.eslintignore
+++ b/backend/.eslintignore
@@ -1,3 +1,4 @@
 node_modules
 **/*.min.js
-build
\ No newline at end of file
+build
+coverage
\ No newline at end of file

From ab5aac5c6ba9bb26998d0b5f4748690b4f6af20e Mon Sep 17 00:00:00 2001
From: Ulf Gebhardt <ulf.gebhardt@webcraft-media.de>
Date: Wed, 10 May 2023 13:03:23 +0200
Subject: [PATCH 48/58] remove duplicate ignore

---
 backend/src/apis/HttpRequest.ts | 2 --
 1 file changed, 2 deletions(-)

diff --git a/backend/src/apis/HttpRequest.ts b/backend/src/apis/HttpRequest.ts
index f40d577bd..27578463a 100644
--- a/backend/src/apis/HttpRequest.ts
+++ b/backend/src/apis/HttpRequest.ts
@@ -7,7 +7,6 @@ import axios from 'axios'
 import { LogError } from '@/server/LogError'
 import { backendLogger as logger } from '@/server/logger'
 
-// eslint-disable-next-line @typescript-eslint/no-explicit-any
 export const apiPost = async (url: string, payload: unknown): Promise<any> => {
   logger.trace('POST', url, payload)
   try {
@@ -25,7 +24,6 @@ export const apiPost = async (url: string, payload: unknown): Promise<any> => {
   }
 }
 
-// eslint-disable-next-line @typescript-eslint/no-explicit-any
 export const apiGet = async (url: string): Promise<any> => {
   logger.trace('GET: url=' + url)
   try {

From ac89b845edb6b9cdb6ff35690336051581c8ad89 Mon Sep 17 00:00:00 2001
From: Ulf Gebhardt <ulf.gebhardt@webcraft-media.de>
Date: Wed, 10 May 2023 13:08:31 +0200
Subject: [PATCH 49/58] enable and document optional rules

---
 backend/.eslintrc.js | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/backend/.eslintrc.js b/backend/.eslintrc.js
index 158d1a0bb..798bef1e6 100644
--- a/backend/.eslintrc.js
+++ b/backend/.eslintrc.js
@@ -155,6 +155,9 @@ module.exports = {
     'promise/no-multiple-resolved': 'error',
     // eslint comments
     '@eslint-community/eslint-comments/disable-enable-pair': ['error', { allowWholeFile: true }],
+    '@eslint-community/eslint-comments/no-restricted-disable': 'error',
+    '@eslint-community/eslint-comments/no-use': 'off',
+    '@eslint-community/eslint-comments/require-description': 'off',
   },
   overrides: [
     // only for ts files

From a82f0cb2845d0d2649d8177b2e41265d52294a88 Mon Sep 17 00:00:00 2001
From: Moriz Wahl <moriz.wahl@gmx.de>
Date: Wed, 10 May 2023 17:37:01 +0200
Subject: [PATCH 50/58] separate validation function for alias, tested

---
 .../src/graphql/resolver/UserResolver.test.ts | 101 --------------
 backend/src/graphql/resolver/UserResolver.ts  |  15 +--
 .../resolver/util/validateAlias.test.ts       | 125 ++++++++++++++++++
 .../graphql/resolver/util/validateAlias.ts    |  36 +++++
 4 files changed, 163 insertions(+), 114 deletions(-)
 create mode 100644 backend/src/graphql/resolver/util/validateAlias.test.ts
 create mode 100644 backend/src/graphql/resolver/util/validateAlias.ts

diff --git a/backend/src/graphql/resolver/UserResolver.test.ts b/backend/src/graphql/resolver/UserResolver.test.ts
index 8ebe3e7af..5e39ae2ff 100644
--- a/backend/src/graphql/resolver/UserResolver.test.ts
+++ b/backend/src/graphql/resolver/UserResolver.test.ts
@@ -1208,107 +1208,6 @@ describe('UserResolver', () => {
           jest.clearAllMocks()
         })
 
-        describe('too short', () => {
-          it('throws and logs an error', async () => {
-            await expect(
-              mutate({
-                mutation: updateUserInfos,
-                variables: {
-                  alias: 'bibi',
-                },
-              }),
-            ).resolves.toMatchObject({
-              errors: [new GraphQLError('Given alias is too short')],
-              data: null,
-            })
-            expect(logger.error).toBeCalledWith('Given alias is too short', 'bibi')
-          })
-        })
-
-        describe('too long', () => {
-          it('throws and logs an error', async () => {
-            await expect(
-              mutate({
-                mutation: updateUserInfos,
-                variables: {
-                  alias: 'bibis_alias_far_too_long',
-                },
-              }),
-            ).resolves.toMatchObject({
-              errors: [new GraphQLError('Given alias is too long')],
-              data: null,
-            })
-            expect(logger.error).toBeCalledWith(
-              'Given alias is too long',
-              'bibis_alias_far_too_long',
-            )
-          })
-        })
-
-        describe('invalid characters', () => {
-          it('throws and logs an error', async () => {
-            await expect(
-              mutate({
-                mutation: updateUserInfos,
-                variables: {
-                  alias: 'no+äöllll',
-                },
-              }),
-            ).resolves.toMatchObject({
-              errors: [new GraphQLError('Invalid characters in alias')],
-              data: null,
-            })
-            expect(logger.error).toBeCalledWith('Invalid characters in alias', 'no+äöllll')
-          })
-        })
-
-        describe('alias exists', () => {
-          let peter: User
-          beforeAll(async () => {
-            peter = await userFactory(testEnv, peterLustig)
-            await mutate({
-              mutation: login,
-              variables: {
-                email: 'peter@lustig.de',
-                password: 'Aa12345_',
-              },
-            })
-            await mutate({
-              mutation: updateUserInfos,
-              variables: {
-                alias: 'bibiBloxberg',
-              },
-            })
-            await mutate({
-              mutation: login,
-              variables: {
-                email: 'bibi@bloxberg.de',
-                password: 'Aa12345_',
-              },
-            })
-          })
-
-          afterAll(async () => {
-            const user = await User.findOne({ id: peter.id })
-            await user.remove()
-          })
-
-          it('throws and logs an error', async () => {
-            await expect(
-              mutate({
-                mutation: updateUserInfos,
-                variables: {
-                  alias: 'bibiBloxberg',
-                },
-              }),
-            ).resolves.toMatchObject({
-              errors: [new GraphQLError('Alias already in use')],
-              data: null,
-            })
-            expect(logger.error).toBeCalledWith('Alias already in use', 'bibiBloxberg')
-          })
-        })
-
         describe('valid alias', () => {
           it('updates the user in DB', async () => {
             await mutate({
diff --git a/backend/src/graphql/resolver/UserResolver.ts b/backend/src/graphql/resolver/UserResolver.ts
index 7198a3bdc..6b4844154 100644
--- a/backend/src/graphql/resolver/UserResolver.ts
+++ b/backend/src/graphql/resolver/UserResolver.ts
@@ -73,6 +73,7 @@ import { getTimeDurationObject, printTimeDuration } from '@/util/time'
 import { FULL_CREATION_AVAILABLE } from './const/const'
 import { getUserCreations } from './util/creations'
 import { findUserByIdentifier } from './util/findUserByIdentifier'
+import { validateAlias } from './util/validateAlias'
 
 // eslint-disable-next-line @typescript-eslint/no-var-requires, import/no-commonjs
 const random = require('random-bigint')
@@ -525,19 +526,7 @@ export class UserResolver {
     }
 
     if (alias) {
-      if (alias.length < 5) {
-        throw new LogError('Given alias is too short', alias)
-      }
-      if (alias.length > 20) {
-        throw new LogError('Given alias is too long', alias)
-      }
-      if (!alias.match(/^[0-9A-Za-z]([_-]?[A-Za-z0-9])+$/)) {
-        throw new LogError('Invalid characters in alias', alias)
-      }
-      const aliasInUse = await DbUser.find({ alias })
-      if (aliasInUse.length !== 0) {
-        throw new LogError('Alias already in use', alias)
-      }
+      await validateAlias(alias)
       user.alias = alias
     }
 
diff --git a/backend/src/graphql/resolver/util/validateAlias.test.ts b/backend/src/graphql/resolver/util/validateAlias.test.ts
new file mode 100644
index 000000000..733a09ffe
--- /dev/null
+++ b/backend/src/graphql/resolver/util/validateAlias.test.ts
@@ -0,0 +1,125 @@
+import { Connection } from '@dbTools/typeorm'
+import { User } from '@entity/User'
+import { ApolloServerTestClient } from 'apollo-server-testing'
+
+import { testEnvironment, cleanDB } from '@test/helpers'
+import { logger, i18n as localization } from '@test/testSetup'
+
+import { userFactory } from '@/seeds/factory/user'
+import { bibiBloxberg } from '@/seeds/users/bibi-bloxberg'
+
+import { validateAlias } from './validateAlias'
+
+let con: Connection
+let testEnv: {
+  mutate: ApolloServerTestClient['mutate']
+  query: ApolloServerTestClient['query']
+  con: Connection
+}
+
+beforeAll(async () => {
+  testEnv = await testEnvironment(logger, localization)
+  con = testEnv.con
+  await cleanDB()
+})
+
+afterAll(async () => {
+  await cleanDB()
+  await con.close()
+})
+
+describe('validate alias', () => {
+  beforeAll(() => {
+    jest.clearAllMocks()
+  })
+
+  describe('alias too short', () => {
+    it('throws and logs an error', async () => {
+      await expect(validateAlias('Bi')).rejects.toEqual(new Error('Given alias is too short'))
+      expect(logger.error).toBeCalledWith('Given alias is too short', 'Bi')
+    })
+  })
+
+  describe('alias too long', () => {
+    it('throws and logs an error', async () => {
+      await expect(validateAlias('BibiBloxbergHexHexHex')).rejects.toEqual(
+        new Error('Given alias is too long'),
+      )
+      expect(logger.error).toBeCalledWith('Given alias is too long', 'BibiBloxbergHexHexHex')
+    })
+  })
+
+  describe('alias contains invalid characters', () => {
+    it('throws and logs an error', async () => {
+      await expect(validateAlias('Bibi.Bloxberg')).rejects.toEqual(
+        new Error('Invalid characters in alias'),
+      )
+      expect(logger.error).toBeCalledWith('Invalid characters in alias', 'Bibi.Bloxberg')
+    })
+  })
+
+  describe('alias is a reserved word', () => {
+    it('throws and logs an error', async () => {
+      await expect(validateAlias('admin')).rejects.toEqual(new Error('Alias is not allowed'))
+      expect(logger.error).toBeCalledWith('Alias is not allowed', 'admin')
+    })
+  })
+
+  describe('alias is a reserved word with uppercase characters', () => {
+    it('throws and logs an error', async () => {
+      await expect(validateAlias('Admin')).rejects.toEqual(new Error('Alias is not allowed'))
+      expect(logger.error).toBeCalledWith('Alias is not allowed', 'Admin')
+    })
+  })
+
+  describe('hyphens and underscore', () => {
+    describe('alias starts with underscore', () => {
+      it('throws and logs an error', async () => {
+        await expect(validateAlias('_bibi')).rejects.toEqual(
+          new Error('Invalid characters in alias'),
+        )
+        expect(logger.error).toBeCalledWith('Invalid characters in alias', '_bibi')
+      })
+    })
+
+    describe('alias contains two following hyphens', () => {
+      it('throws and logs an error', async () => {
+        await expect(validateAlias('bi--bi')).rejects.toEqual(
+          new Error('Invalid characters in alias'),
+        )
+        expect(logger.error).toBeCalledWith('Invalid characters in alias', 'bi--bi')
+      })
+    })
+  })
+
+  describe('test against existing alias in database', () => {
+    beforeAll(async () => {
+      const bibi = await userFactory(testEnv, bibiBloxberg)
+      const user = await User.findOne({ id: bibi.id })
+      if (user) {
+        user.alias = 'b-b'
+        await user.save()
+      }
+    })
+
+    describe('alias exists in database', () => {
+      it('throws and logs an error', async () => {
+        await expect(validateAlias('b-b')).rejects.toEqual(new Error('Alias already in use'))
+        expect(logger.error).toBeCalledWith('Alias already in use', 'b-b')
+      })
+    })
+
+    describe('alias exists in database with in lower-case', () => {
+      it('throws and logs an error', async () => {
+        await expect(validateAlias('b-B')).rejects.toEqual(new Error('Alias already in use'))
+        expect(logger.error).toBeCalledWith('Alias already in use', 'b-B')
+      })
+    })
+
+    describe('valid alias', () => {
+      it('resolves to void', async () => {
+        await expect(validateAlias('bibi')).resolves.toEqual(undefined)
+      })
+    })
+  })
+})
diff --git a/backend/src/graphql/resolver/util/validateAlias.ts b/backend/src/graphql/resolver/util/validateAlias.ts
new file mode 100644
index 000000000..d35b9e363
--- /dev/null
+++ b/backend/src/graphql/resolver/util/validateAlias.ts
@@ -0,0 +1,36 @@
+import { Raw } from '@dbTools/typeorm'
+import { User as DbUser } from '@entity/User'
+
+import { LogError } from '@/server/LogError'
+
+const reservedAlias = [
+  'admin',
+  'email',
+  'gast',
+  'gdd',
+  'gradido',
+  'guest',
+  'home',
+  'root',
+  'support',
+  'temp',
+  'tmp',
+  'tmp',
+  'user',
+  'usr',
+  'var',
+]
+
+export const validateAlias = async (alias: string): Promise<void> => {
+  if (alias.length < 3) throw new LogError('Given alias is too short', alias)
+  if (alias.length > 20) throw new LogError('Given alias is too long', alias)
+  if (!alias.match(/^[0-9A-Za-z]([_-]?[A-Za-z0-9])+$/))
+    throw new LogError('Invalid characters in alias', alias)
+  if (reservedAlias.includes(alias.toLowerCase())) throw new LogError('Alias is not allowed', alias)
+  const aliasInUse = await DbUser.find({
+    where: { alias: Raw((a) => `LOWER(${a}) = "${alias.toLowerCase()}"`) },
+  })
+  if (aliasInUse.length !== 0) {
+    throw new LogError('Alias already in use', alias)
+  }
+}

From c78691c87c3e9ea2df0ee145993c70485b5948b1 Mon Sep 17 00:00:00 2001
From: Moriz Wahl <moriz.wahl@gmx.de>
Date: Wed, 10 May 2023 18:00:29 +0200
Subject: [PATCH 51/58] ignore unsage regex lint

---
 backend/src/graphql/resolver/util/validateAlias.ts | 1 +
 1 file changed, 1 insertion(+)

diff --git a/backend/src/graphql/resolver/util/validateAlias.ts b/backend/src/graphql/resolver/util/validateAlias.ts
index d35b9e363..8528bf617 100644
--- a/backend/src/graphql/resolver/util/validateAlias.ts
+++ b/backend/src/graphql/resolver/util/validateAlias.ts
@@ -24,6 +24,7 @@ const reservedAlias = [
 export const validateAlias = async (alias: string): Promise<void> => {
   if (alias.length < 3) throw new LogError('Given alias is too short', alias)
   if (alias.length > 20) throw new LogError('Given alias is too long', alias)
+  /* eslint-disable-next-line security/detect-unsafe-regex */
   if (!alias.match(/^[0-9A-Za-z]([_-]?[A-Za-z0-9])+$/))
     throw new LogError('Invalid characters in alias', alias)
   if (reservedAlias.includes(alias.toLowerCase())) throw new LogError('Alias is not allowed', alias)

From dbe752563be36565b39de1cc812fcaa9c4246a30 Mon Sep 17 00:00:00 2001
From: Moriz Wahl <moriz.wahl@gmx.de>
Date: Wed, 10 May 2023 18:39:41 +0200
Subject: [PATCH 52/58] Update
 backend/src/graphql/resolver/util/validateAlias.ts

Co-authored-by: Ulf Gebhardt <ulf.gebhardt@webcraft-media.de>
---
 backend/src/graphql/resolver/util/validateAlias.ts | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/backend/src/graphql/resolver/util/validateAlias.ts b/backend/src/graphql/resolver/util/validateAlias.ts
index 8528bf617..dcea7824c 100644
--- a/backend/src/graphql/resolver/util/validateAlias.ts
+++ b/backend/src/graphql/resolver/util/validateAlias.ts
@@ -21,7 +21,7 @@ const reservedAlias = [
   'var',
 ]
 
-export const validateAlias = async (alias: string): Promise<void> => {
+export const validateAlias = async (alias: string): Promise<boolean> => {
   if (alias.length < 3) throw new LogError('Given alias is too short', alias)
   if (alias.length > 20) throw new LogError('Given alias is too long', alias)
   /* eslint-disable-next-line security/detect-unsafe-regex */
@@ -34,4 +34,5 @@ export const validateAlias = async (alias: string): Promise<void> => {
   if (aliasInUse.length !== 0) {
     throw new LogError('Alias already in use', alias)
   }
+  return true
 }

From 1c924900199feeb4482e1a338aa1d6c4ceeecfd1 Mon Sep 17 00:00:00 2001
From: Moriz Wahl <moriz.wahl@gmx.de>
Date: Wed, 10 May 2023 18:39:52 +0200
Subject: [PATCH 53/58] Update backend/src/graphql/resolver/UserResolver.ts

Co-authored-by: Ulf Gebhardt <ulf.gebhardt@webcraft-media.de>
---
 backend/src/graphql/resolver/UserResolver.ts | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/backend/src/graphql/resolver/UserResolver.ts b/backend/src/graphql/resolver/UserResolver.ts
index bbd33f3ab..cc712e308 100644
--- a/backend/src/graphql/resolver/UserResolver.ts
+++ b/backend/src/graphql/resolver/UserResolver.ts
@@ -525,8 +525,7 @@ export class UserResolver {
       user.lastName = lastName
     }
 
-    if (alias) {
-      await validateAlias(alias)
+    if (alias && await validateAlias(alias)) {
       user.alias = alias
     }
 

From d94543c1d9811e13fe84c315163d759dc6a9ead5 Mon Sep 17 00:00:00 2001
From: Moriz Wahl <moriz.wahl@gmx.de>
Date: Wed, 10 May 2023 20:47:28 +0200
Subject: [PATCH 54/58] fixes after merging suggestions

---
 backend/src/graphql/resolver/UserResolver.ts            | 2 +-
 backend/src/graphql/resolver/util/validateAlias.test.ts | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/backend/src/graphql/resolver/UserResolver.ts b/backend/src/graphql/resolver/UserResolver.ts
index cc712e308..0afbfcc5a 100644
--- a/backend/src/graphql/resolver/UserResolver.ts
+++ b/backend/src/graphql/resolver/UserResolver.ts
@@ -525,7 +525,7 @@ export class UserResolver {
       user.lastName = lastName
     }
 
-    if (alias && await validateAlias(alias)) {
+    if (alias && (await validateAlias(alias))) {
       user.alias = alias
     }
 
diff --git a/backend/src/graphql/resolver/util/validateAlias.test.ts b/backend/src/graphql/resolver/util/validateAlias.test.ts
index 733a09ffe..0cb790edb 100644
--- a/backend/src/graphql/resolver/util/validateAlias.test.ts
+++ b/backend/src/graphql/resolver/util/validateAlias.test.ts
@@ -117,8 +117,8 @@ describe('validate alias', () => {
     })
 
     describe('valid alias', () => {
-      it('resolves to void', async () => {
-        await expect(validateAlias('bibi')).resolves.toEqual(undefined)
+      it('resolves to true', async () => {
+        await expect(validateAlias('bibi')).resolves.toEqual(true)
       })
     })
   })

From 8c62dd1a4f2883a44d640320e379d8e8a0c23389 Mon Sep 17 00:00:00 2001
From: Ulf Gebhardt <ulf.gebhardt@webcraft-media.de>
Date: Thu, 11 May 2023 10:27:43 +0200
Subject: [PATCH 55/58] lint fixes

---
 backend/src/federation/client/Client.ts | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/backend/src/federation/client/Client.ts b/backend/src/federation/client/Client.ts
index 515945eb5..98f63c127 100644
--- a/backend/src/federation/client/Client.ts
+++ b/backend/src/federation/client/Client.ts
@@ -10,12 +10,13 @@ import { Client_1_1 } from './Client_1_1'
 // eslint-disable-next-line camelcase
 type FederationClient = Client_1_0 | Client_1_1
 
-type ClientInstance = {
+interface ClientInstance {
   id: number
   // eslint-disable-next-line no-use-before-define
   client: FederationClient
 }
 
+// eslint-disable-next-line @typescript-eslint/no-extraneous-class
 export class Client {
   private static instanceArray: ClientInstance[] = []
 

From 3c0dbe02f60860d0a240c83d4b4c9a984cea9392 Mon Sep 17 00:00:00 2001
From: clauspeterhuebner <86960882+clauspeterhuebner@users.noreply.github.com>
Date: Thu, 11 May 2023 22:21:24 +0200
Subject: [PATCH 56/58] Update backend/src/util/utilities.ts

Co-authored-by: Ulf Gebhardt <ulf.gebhardt@webcraft-media.de>
---
 backend/src/util/utilities.ts | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/backend/src/util/utilities.ts b/backend/src/util/utilities.ts
index 6bd70b941..64d92e981 100644
--- a/backend/src/util/utilities.ts
+++ b/backend/src/util/utilities.ts
@@ -15,6 +15,5 @@ export const decimalSeparatorByLanguage = (a: Decimal, language: string): string
   return result
 }
 
-export const fullName = (firstName: string, lastName: string): string => {
-  return [firstName, lastName].filter(Boolean).join(' ')
-}
+export const fullName = (firstName: string, lastName: string): string =>
+  [firstName, lastName].filter(Boolean).join(' ')

From a380f385bdcefe22540a02e2caf15fff0f5c1592 Mon Sep 17 00:00:00 2001
From: Claus-Peter Huebner <claus-peter.huebner@email.de>
Date: Thu, 11 May 2023 22:52:21 +0200
Subject: [PATCH 57/58] remove community_uuids

---
 backend/src/util/virtualTransactions.ts        |  4 ----
 .../Transaction.ts                             | 18 ------------------
 ...x-community-sendcoins-transactions_table.ts | 13 ++-----------
 3 files changed, 2 insertions(+), 33 deletions(-)

diff --git a/backend/src/util/virtualTransactions.ts b/backend/src/util/virtualTransactions.ts
index 2bc2a591e..a10e566d1 100644
--- a/backend/src/util/virtualTransactions.ts
+++ b/backend/src/util/virtualTransactions.ts
@@ -55,10 +55,8 @@ const virtualLinkTransaction = (
     contribution: null,
     ...defaultModelFunctions,
     userGradidoID: '',
-    userCommunityUuid: null,
     userName: null,
     linkedUserGradidoID: null,
-    linkedUserCommunityUuid: null,
     linkedUserName: null,
   }
   return new Transaction(linkDbTransaction, user)
@@ -91,10 +89,8 @@ const virtualDecayTransaction = (
     contribution: null,
     ...defaultModelFunctions,
     userGradidoID: '',
-    userCommunityUuid: null,
     userName: null,
     linkedUserGradidoID: null,
-    linkedUserCommunityUuid: null,
     linkedUserName: null,
   }
   return new Transaction(decayDbTransaction, user)
diff --git a/database/entity/0066-x-community-sendcoins-transactions_table/Transaction.ts b/database/entity/0066-x-community-sendcoins-transactions_table/Transaction.ts
index 9202f9fd3..4220cfadc 100644
--- a/database/entity/0066-x-community-sendcoins-transactions_table/Transaction.ts
+++ b/database/entity/0066-x-community-sendcoins-transactions_table/Transaction.ts
@@ -84,15 +84,6 @@ export class Transaction extends BaseEntity {
   })
   userGradidoID: string
 
-  @Column({
-    name: 'user_community_uuid',
-    type: 'varchar',
-    length: 36,
-    nullable: true,
-    collation: 'utf8mb4_unicode_ci',
-  })
-  userCommunityUuid: string | null
-
   @Column({
     name: 'user_name',
     type: 'varchar',
@@ -120,15 +111,6 @@ export class Transaction extends BaseEntity {
   })
   linkedUserGradidoID: string | null
 
-  @Column({
-    name: 'linked_user_community_uuid',
-    type: 'varchar',
-    length: 36,
-    nullable: true,
-    collation: 'utf8mb4_unicode_ci',
-  })
-  linkedUserCommunityUuid: string | null
-
   @Column({
     name: 'linked_user_name',
     type: 'varchar',
diff --git a/database/migrations/0066-x-community-sendcoins-transactions_table.ts b/database/migrations/0066-x-community-sendcoins-transactions_table.ts
index 2a3b3973a..2a90f297a 100644
--- a/database/migrations/0066-x-community-sendcoins-transactions_table.ts
+++ b/database/migrations/0066-x-community-sendcoins-transactions_table.ts
@@ -41,10 +41,7 @@ export async function upgrade(queryFn: (query: string, values?: any[]) => Promis
     'ALTER TABLE `transactions` ADD COLUMN `user_gradido_id` char(36) DEFAULT NULL NULL AFTER `user_id`;',
   )
   await queryFn(
-    'ALTER TABLE `transactions` ADD COLUMN `user_community_uuid` char(36) DEFAULT NULL NULL AFTER `user_gradido_id`;',
-  )
-  await queryFn(
-    'ALTER TABLE `transactions` ADD COLUMN `user_name` varchar(512) COLLATE utf8mb4_unicode_ci DEFAULT NULL NULL AFTER `user_community_uuid`;',
+    'ALTER TABLE `transactions` ADD COLUMN `user_name` varchar(512) COLLATE utf8mb4_unicode_ci DEFAULT NULL NULL AFTER `user_gradido_id`;',
   )
   await queryFn(
     'ALTER TABLE `transactions` MODIFY COLUMN `linked_user_id` int(10) unsigned DEFAULT NULL NULL AFTER `user_name`;',
@@ -53,15 +50,11 @@ export async function upgrade(queryFn: (query: string, values?: any[]) => Promis
     'ALTER TABLE `transactions` ADD COLUMN `linked_user_gradido_id` char(36) DEFAULT NULL NULL AFTER `linked_user_id`;',
   )
   await queryFn(
-    'ALTER TABLE `transactions` ADD COLUMN `linked_user_community_uuid` char(36) DEFAULT NULL NULL AFTER `linked_user_gradido_id`;',
-  )
-  await queryFn(
-    'ALTER TABLE `transactions` ADD COLUMN `linked_user_name` varchar(512) COLLATE utf8mb4_unicode_ci DEFAULT NULL NULL AFTER `linked_user_community_uuid`;',
+    'ALTER TABLE `transactions` ADD COLUMN `linked_user_name` varchar(512) COLLATE utf8mb4_unicode_ci DEFAULT NULL NULL AFTER `linked_user_gradido_id`;',
   )
   await queryFn(
     'ALTER TABLE `transactions` MODIFY COLUMN `linked_transaction_id` int(10) DEFAULT NULL NULL AFTER `linked_user_name`;',
   )
-
   await queryFn(
     `UPDATE transactions t, users u SET t.user_gradido_id = u.gradido_id, t.user_name = concat(u.first_name, ' ', u.last_name) WHERE t.user_id = u.id and t.user_gradido_id is null;`,
   )
@@ -77,9 +70,7 @@ export async function upgrade(queryFn: (query: string, values?: any[]) => Promis
 /* eslint-disable-next-line @typescript-eslint/no-unused-vars */
 export async function downgrade(queryFn: (query: string, values?: any[]) => Promise<Array<any>>) {
   await queryFn('ALTER TABLE `transactions` DROP COLUMN `user_gradido_id`;')
-  await queryFn('ALTER TABLE `transactions` DROP COLUMN `user_community_uuid`;')
   await queryFn('ALTER TABLE `transactions` DROP COLUMN `user_name`;')
   await queryFn('ALTER TABLE `transactions` DROP COLUMN `linked_user_gradido_id`;')
-  await queryFn('ALTER TABLE `transactions` DROP COLUMN `linked_user_community_uuid`;')
   await queryFn('ALTER TABLE `transactions` DROP COLUMN `linked_user_name`;')
 }

From e924d0bb97c67ae5b1e3192192149319aca11f7e Mon Sep 17 00:00:00 2001
From: Ulf Gebhardt <ulf.gebhardt@webcraft-media.de>
Date: Fri, 12 May 2023 15:35:22 +0200
Subject: [PATCH 58/58] log when a community is verified successfully

---
 backend/src/federation/validateCommunities.ts | 1 +
 1 file changed, 1 insertion(+)

diff --git a/backend/src/federation/validateCommunities.ts b/backend/src/federation/validateCommunities.ts
index fcce9d0d8..4b337eda9 100644
--- a/backend/src/federation/validateCommunities.ts
+++ b/backend/src/federation/validateCommunities.ts
@@ -41,6 +41,7 @@ export async function validateCommunities(): Promise<void> {
       const pubKey = await client?.getPublicKey()
       if (pubKey && pubKey === dbCom.publicKey.toString()) {
         await DbFederatedCommunity.update({ id: dbCom.id }, { verifiedAt: new Date() })
+        logger.info('Federation: verified community', dbCom)
       } else {
         logger.warn(
           'Federation: received not matching publicKey:',