From 80fa01f000dd50a8a6d2e21a2ae9fc747310abf4 Mon Sep 17 00:00:00 2001 From: Ulf Gebhardt Date: Tue, 4 Apr 2023 15:04:05 +0200 Subject: [PATCH 1/5] log stack trace included --- backend/src/server/LogError.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/backend/src/server/LogError.ts b/backend/src/server/LogError.ts index b753d204e..1ee4585cd 100644 --- a/backend/src/server/LogError.ts +++ b/backend/src/server/LogError.ts @@ -4,6 +4,6 @@ export default class LogError extends Error { // eslint-disable-next-line @typescript-eslint/no-explicit-any constructor(msg: string, ...details: any[]) { super(msg) - logger.error(msg, ...details) + logger.error(this.stack, ...details) } } From 30b7501a6e217605217050647e672e53b6fb9919 Mon Sep 17 00:00:00 2001 From: Ulf Gebhardt Date: Tue, 4 Apr 2023 15:31:47 +0200 Subject: [PATCH 2/5] log stack trace --- backend/log4js-config.json | 14 +++++++------- backend/src/server/LogError.ts | 4 +++- 2 files changed, 10 insertions(+), 8 deletions(-) diff --git a/backend/log4js-config.json b/backend/log4js-config.json index e595e7c52..81b4c174b 100644 --- a/backend/log4js-config.json +++ b/backend/log4js-config.json @@ -8,7 +8,7 @@ "pattern": "yyyy-MM-dd", "layout": { - "type": "pattern", "pattern": "%d{ISO8601} %p %c [%X{user}] [%f : %l] - %m" + "type": "pattern", "pattern": "%d{ISO8601} %p %c [%X{user}] [%f : %l] - %m %s" }, "keepFileExt" : true, "fileNameSep" : "_", @@ -21,7 +21,7 @@ "pattern": "yyyy-MM-dd", "layout": { - "type": "pattern", "pattern": "%d{ISO8601} %p %c [%X{user}] [%f : %l] - %m" + "type": "pattern", "pattern": "%d{ISO8601} %p %c [%X{user}] [%f : %l] - %m %s" }, "keepFileExt" : true, "fileNameSep" : "_", @@ -34,7 +34,7 @@ "pattern": "yyyy-MM-dd", "layout": { - "type": "pattern", "pattern": "%d{ISO8601} %p %c [%X{user}] [%f : %l] - %m" + "type": "pattern", "pattern": "%d{ISO8601} %p %c [%X{user}] [%f : %l] - %m %s" }, "keepFileExt" : true, "fileNameSep" : "_", @@ -47,7 +47,7 @@ "pattern": "yyyy-MM-dd", "layout": { - "type": "pattern", "pattern": "%d{ISO8601} %p %c [%X{user}] [%f : %l] - %m" + "type": "pattern", "pattern": "%d{ISO8601} %p %c [%X{user}] [%f : %l] - %m %s" }, "keepFileExt" : true, "fileNameSep" : "_", @@ -60,7 +60,7 @@ "pattern": "yyyy-MM-dd", "layout": { - "type": "pattern", "pattern": "%d{ISO8601} %p %c [%X{user}] [%f : %l] - %m" + "type": "pattern", "pattern": "%d{ISO8601} %p %c [%X{user}] [%f : %l] - %m %s" }, "keepFileExt" : true, "fileNameSep" : "_", @@ -77,7 +77,7 @@ "type": "stdout", "layout": { - "type": "pattern", "pattern": "%d{ISO8601} %p %c [%X{user}] [%f : %l] - %m" + "type": "pattern", "pattern": "%d{ISO8601} %p %c [%X{user}] [%f : %l] - %m %s" } }, "apolloOut": @@ -85,7 +85,7 @@ "type": "stdout", "layout": { - "type": "pattern", "pattern": "%d{ISO8601} %p %c [%X{user}] [%f : %l] - %m" + "type": "pattern", "pattern": "%d{ISO8601} %p %c [%X{user}] [%f : %l] - %m %s" } } }, diff --git a/backend/src/server/LogError.ts b/backend/src/server/LogError.ts index 1ee4585cd..8aa2d7d1a 100644 --- a/backend/src/server/LogError.ts +++ b/backend/src/server/LogError.ts @@ -1,9 +1,11 @@ +import { LockNotSupportedOnGivenDriverError } from '@dbTools/typeorm' import { backendLogger as logger } from './logger' export default class LogError extends Error { // eslint-disable-next-line @typescript-eslint/no-explicit-any constructor(msg: string, ...details: any[]) { super(msg) - logger.error(this.stack, ...details) + // logger.setStack(this.stack) + logger.error(msg, ...details) } } From 550e35cb784ba31c48abaab0e255ae1500918003 Mon Sep 17 00:00:00 2001 From: Ulf Gebhardt Date: Tue, 4 Apr 2023 15:33:32 +0200 Subject: [PATCH 3/5] remove unused configs --- backend/src/server/LogError.ts | 2 -- 1 file changed, 2 deletions(-) diff --git a/backend/src/server/LogError.ts b/backend/src/server/LogError.ts index 8aa2d7d1a..b753d204e 100644 --- a/backend/src/server/LogError.ts +++ b/backend/src/server/LogError.ts @@ -1,11 +1,9 @@ -import { LockNotSupportedOnGivenDriverError } from '@dbTools/typeorm' import { backendLogger as logger } from './logger' export default class LogError extends Error { // eslint-disable-next-line @typescript-eslint/no-explicit-any constructor(msg: string, ...details: any[]) { super(msg) - // logger.setStack(this.stack) logger.error(msg, ...details) } } From 4ca989a3daf33c657cbb76327c28413c5750ee17 Mon Sep 17 00:00:00 2001 From: Ulf Gebhardt Date: Thu, 6 Apr 2023 15:20:36 +0200 Subject: [PATCH 4/5] stack traces only for errors --- backend/log4js-config.json | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/backend/log4js-config.json b/backend/log4js-config.json index 81b4c174b..9ab0cec50 100644 --- a/backend/log4js-config.json +++ b/backend/log4js-config.json @@ -8,7 +8,7 @@ "pattern": "yyyy-MM-dd", "layout": { - "type": "pattern", "pattern": "%d{ISO8601} %p %c [%X{user}] [%f : %l] - %m %s" + "type": "pattern", "pattern": "%d{ISO8601} %p %c [%X{user}] [%f : %l] - %m" }, "keepFileExt" : true, "fileNameSep" : "_", @@ -21,7 +21,7 @@ "pattern": "yyyy-MM-dd", "layout": { - "type": "pattern", "pattern": "%d{ISO8601} %p %c [%X{user}] [%f : %l] - %m %s" + "type": "pattern", "pattern": "%d{ISO8601} %p %c [%X{user}] [%f : %l] - %m" }, "keepFileExt" : true, "fileNameSep" : "_", @@ -34,7 +34,7 @@ "pattern": "yyyy-MM-dd", "layout": { - "type": "pattern", "pattern": "%d{ISO8601} %p %c [%X{user}] [%f : %l] - %m %s" + "type": "pattern", "pattern": "%d{ISO8601} %p %c [%X{user}] [%f : %l] - %m" }, "keepFileExt" : true, "fileNameSep" : "_", @@ -47,7 +47,7 @@ "pattern": "yyyy-MM-dd", "layout": { - "type": "pattern", "pattern": "%d{ISO8601} %p %c [%X{user}] [%f : %l] - %m %s" + "type": "pattern", "pattern": "%d{ISO8601} %p %c [%X{user}] [%f : %l] - %m" }, "keepFileExt" : true, "fileNameSep" : "_", From a1aa4fad63bf0aa83c9b3fff378f19f682a2c12a Mon Sep 17 00:00:00 2001 From: Ulf Gebhardt Date: Fri, 21 Apr 2023 09:57:50 +0200 Subject: [PATCH 5/5] stacktrace only for errorfile --- backend/log4js-config.json | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/backend/log4js-config.json b/backend/log4js-config.json index 9ab0cec50..160883eb3 100644 --- a/backend/log4js-config.json +++ b/backend/log4js-config.json @@ -47,7 +47,7 @@ "pattern": "yyyy-MM-dd", "layout": { - "type": "pattern", "pattern": "%d{ISO8601} %p %c [%X{user}] [%f : %l] - %m" + "type": "pattern", "pattern": "%d{ISO8601} %p %c [%X{user}] [%f : %l] - %m" }, "keepFileExt" : true, "fileNameSep" : "_", @@ -60,7 +60,7 @@ "pattern": "yyyy-MM-dd", "layout": { - "type": "pattern", "pattern": "%d{ISO8601} %p %c [%X{user}] [%f : %l] - %m %s" + "type": "pattern", "pattern": "%d{ISO8601} %p %c [%X{user}] [%f : %l] - %m %s" }, "keepFileExt" : true, "fileNameSep" : "_", @@ -77,7 +77,7 @@ "type": "stdout", "layout": { - "type": "pattern", "pattern": "%d{ISO8601} %p %c [%X{user}] [%f : %l] - %m %s" + "type": "pattern", "pattern": "%d{ISO8601} %p %c [%X{user}] [%f : %l] - %m" } }, "apolloOut": @@ -85,7 +85,7 @@ "type": "stdout", "layout": { - "type": "pattern", "pattern": "%d{ISO8601} %p %c [%X{user}] [%f : %l] - %m %s" + "type": "pattern", "pattern": "%d{ISO8601} %p %c [%X{user}] [%f : %l] - %m" } } },