From 9237f139f28aecb6a30de1a20d5d4cef74daae89 Mon Sep 17 00:00:00 2001
From: elweyn <heine.hannes@gmail.com>
Date: Thu, 9 Dec 2021 11:13:07 +0100
Subject: [PATCH 01/15] Error in UpdatePendingCreationArgs changed export name,
 Added an InputType over the ArgsType for the CreatePendingCreationArgs, added
 a createPendingCreations mutation that creates multiple PendingCreation.

---
 .../graphql/arg/CreatePendingCreationArgs.ts  |  3 +-
 .../graphql/arg/UpdatePendingCreationArgs.ts  |  2 +-
 backend/src/graphql/resolver/AdminResolver.ts | 29 +++++++++----------
 3 files changed, 16 insertions(+), 18 deletions(-)

diff --git a/backend/src/graphql/arg/CreatePendingCreationArgs.ts b/backend/src/graphql/arg/CreatePendingCreationArgs.ts
index d2c17abf1..06a5369ac 100644
--- a/backend/src/graphql/arg/CreatePendingCreationArgs.ts
+++ b/backend/src/graphql/arg/CreatePendingCreationArgs.ts
@@ -1,5 +1,6 @@
-import { ArgsType, Field, Int } from 'type-graphql'
+import { ArgsType, Field, InputType, Int } from 'type-graphql'
 
+@InputType()
 @ArgsType()
 export default class CreatePendingCreationArgs {
   @Field(() => String)
diff --git a/backend/src/graphql/arg/UpdatePendingCreationArgs.ts b/backend/src/graphql/arg/UpdatePendingCreationArgs.ts
index bde7133aa..471519956 100644
--- a/backend/src/graphql/arg/UpdatePendingCreationArgs.ts
+++ b/backend/src/graphql/arg/UpdatePendingCreationArgs.ts
@@ -1,7 +1,7 @@
 import { ArgsType, Field, Int } from 'type-graphql'
 
 @ArgsType()
-export default class CreatePendingCreationArgs {
+export default class UpdatePendingCreationArgs {
   @Field(() => Int)
   id: number
 
diff --git a/backend/src/graphql/resolver/AdminResolver.ts b/backend/src/graphql/resolver/AdminResolver.ts
index 3c03227d5..43ca19aea 100644
--- a/backend/src/graphql/resolver/AdminResolver.ts
+++ b/backend/src/graphql/resolver/AdminResolver.ts
@@ -62,6 +62,19 @@ export class AdminResolver {
     return await getUserCreations(user.id)
   }
 
+  // @Authorized([RIGHTS.SEARCH_USERS])
+  @Mutation(() => Boolean)
+  async createPendingCreations(
+    @Arg('pendingCreations', () => [CreatePendingCreationArgs])
+    pendingCreations: CreatePendingCreationArgs[],
+  ): Promise<boolean> {
+    pendingCreations.forEach((pendingCreation) => {
+      console.log('pendingCreation', pendingCreation)
+      this.createPendingCreation(pendingCreation)
+    })
+    return true
+  }
+
   // @Authorized([RIGHTS.SEARCH_USERS])
   @Mutation(() => UpdatePendingCreation)
   async updatePendingCreation(
@@ -90,22 +103,6 @@ export class AdminResolver {
     result.creation = await getUserCreations(user.id)
 
     return result
-
-    // const creations = await getUserCreations(user.id)
-    // const creationDateObj = new Date(creationDate)
-    // if (isCreationValid(creations, amount, creationDateObj)) {
-    //   const pendingCreationRepository = getCustomRepository(PendingCreationRepository)
-    //   const loginPendingTaskAdmin = pendingCreationRepository.create()
-    //   loginPendingTaskAdmin.userId = user.id
-    //   loginPendingTaskAdmin.amount = BigInt(amount * 10000)
-    //   loginPendingTaskAdmin.created = new Date()
-    //   loginPendingTaskAdmin.date = creationDateObj
-    //   loginPendingTaskAdmin.memo = memo
-    //   loginPendingTaskAdmin.moderator = moderator
-    //
-    //   pendingCreationRepository.save(loginPendingTaskAdmin)
-    // }
-    // return await getUserCreations(user.id)
   }
 
   @Query(() => [PendingCreation])

From 5ca221a0c09f05470083795dc034c73611f3dbc0 Mon Sep 17 00:00:00 2001
From: ogerly <fridolin@tutanota.com>
Date: Thu, 9 Dec 2021 11:53:21 +0100
Subject: [PATCH 02/15] Added the new mutation to the admin, Implemented the
 send massCreation in admin, changed the log entries for not created
 pendingcreation.

---
 admin/src/components/CreationFormular.vue     | 49 ++++++++++++++-----
 admin/src/graphql/createPendingCreations.js   |  7 +++
 backend/src/graphql/resolver/AdminResolver.ts |  5 +-
 3 files changed, 47 insertions(+), 14 deletions(-)
 create mode 100644 admin/src/graphql/createPendingCreations.js

diff --git a/admin/src/components/CreationFormular.vue b/admin/src/components/CreationFormular.vue
index d73ea3c81..d84056f18 100644
--- a/admin/src/components/CreationFormular.vue
+++ b/admin/src/components/CreationFormular.vue
@@ -122,6 +122,7 @@
 <script>
 import { verifyLogin } from '../graphql/verifyLogin'
 import { createPendingCreation } from '../graphql/createPendingCreation'
+import { createPendingCreations } from '../graphql/createPendingCreations'
 export default {
   name: 'CreationFormular',
   props: {
@@ -202,28 +203,52 @@ export default {
     submitCreation() {
       if (this.type === 'massCreation') {
         // Die anzahl der Mitglieder aus der Mehrfachschöpfung
-        const i = Object.keys(this.itemsMassCreation).length
+        const i = Object.keys(this.items).length
         // hinweis das eine Mehrfachschöpfung ausgeführt wird an (Anzahl der MItgleider an die geschöpft wird)
         // eslint-disable-next-line no-console
         console.log('SUBMIT CREATION => ' + this.type + ' >> für VIELE ' + i + ' Mitglieder')
-        this.submitObj = [
-          {
-            item: this.itemsMassCreation,
-            email: this.item.email,
+        this.submitObj = []
+        this.items.forEach((item) => {
+          this.submitObj.push({
+            email: item.email,
             creationDate: this.radioSelected.long,
-            amount: this.value,
+            amount: Number(this.value),
             memo: this.text,
-            moderator: this.$store.state.moderator.id,
-          },
-        ]
+            moderator: Number(this.$store.state.moderator.id),
+          })
+        })
+        console.log('submitObj', this.submitObj)
+        // this.submitObj = [
+        //   {
+        //     item: this.itemsMassCreation,
+        //     email: this.item.email,
+        //     creationDate: this.radioSelected.long,
+        //     amount: this.value,
+        //     memo: this.text,
+        //     moderator: this.$store.state.moderator.id,
+        //   },
+        // ]
         // eslint-disable-next-line no-console
         console.log('MehrfachSCHÖPFUNG ABSENDEN FÜR >> ' + i + ' Mitglieder')
-
+        this.$apollo
+          .mutate({
+            mutation: createPendingCreations,
+            variables: {
+              pendingCreations: this.submitObj,
+            },
+          })
+          .then(() => {
+            this.$store.commit('openCreationsPlus', this.submitObj.length)
+            this.$emit('remove-all-bookmark')
+          })
+          .catch(() => {
+            console.log('Fehler bei der mehrfach Schöpfung')
+          })
         // $store - offene Schöpfungen hochzählen
-        this.$store.commit('openCreationsPlus', i)
+        // this.$store.commit('openCreationsPlus', i)
 
         // lösche alle Mitglieder aus der MehrfachSchöpfungsListe nach dem alle Mehrfachschpfungen zum bestätigen gesendet wurden.
-        this.$emit('remove-all-bookmark')
+        // this.$emit('remove-all-bookmark')
       } else if (this.type === 'singleCreation') {
         this.submitObj = {
           email: this.item.email,
diff --git a/admin/src/graphql/createPendingCreations.js b/admin/src/graphql/createPendingCreations.js
new file mode 100644
index 000000000..50a2b049c
--- /dev/null
+++ b/admin/src/graphql/createPendingCreations.js
@@ -0,0 +1,7 @@
+import gql from 'graphql-tag'
+
+export const createPendingCreations = gql`
+  mutation ($pendingCreations: [CreatePendingCreationArgs!]!) {
+    createPendingCreations(pendingCreations: $pendingCreations)
+  }
+`
diff --git a/backend/src/graphql/resolver/AdminResolver.ts b/backend/src/graphql/resolver/AdminResolver.ts
index 43ca19aea..bfab633b9 100644
--- a/backend/src/graphql/resolver/AdminResolver.ts
+++ b/backend/src/graphql/resolver/AdminResolver.ts
@@ -69,8 +69,9 @@ export class AdminResolver {
     pendingCreations: CreatePendingCreationArgs[],
   ): Promise<boolean> {
     pendingCreations.forEach((pendingCreation) => {
-      console.log('pendingCreation', pendingCreation)
-      this.createPendingCreation(pendingCreation)
+      this.createPendingCreation(pendingCreation).catch((error) => {
+        console.log('pendingCreation ' + JSON.stringify(pendingCreation) + ' had an error ' + error)
+      })
     })
     return true
   }

From 79fb25d51ecc9f3a81d9053292aebd14c33e2a1b Mon Sep 17 00:00:00 2001
From: ogerly <fridolin@tutanota.com>
Date: Thu, 9 Dec 2021 14:14:49 +0100
Subject: [PATCH 03/15] Finalizing the mass creation.

---
 admin/src/components/CreationFormular.vue     | 17 ++++--
 admin/src/graphql/createPendingCreations.js   |  6 +-
 .../graphql/model/CreatePendingCreations.ts   | 19 ++++++
 backend/src/graphql/resolver/AdminResolver.ts | 60 ++++++++++++++++---
 4 files changed, 89 insertions(+), 13 deletions(-)
 create mode 100644 backend/src/graphql/model/CreatePendingCreations.ts

diff --git a/admin/src/components/CreationFormular.vue b/admin/src/components/CreationFormular.vue
index d84056f18..02b8f1ad8 100644
--- a/admin/src/components/CreationFormular.vue
+++ b/admin/src/components/CreationFormular.vue
@@ -236,14 +236,21 @@ export default {
             variables: {
               pendingCreations: this.submitObj,
             },
+            fetchPolicy: 'no-cache',
           })
-          .then(() => {
-            this.$store.commit('openCreationsPlus', this.submitObj.length)
+          .then((result) => {
+            console.log('result', result)
+            this.$store.commit(
+              'openCreationsPlus',
+              result.data.createPendingCreations.successfulCreation.length,
+            )
+            if (result.data.createPendingCreations.failedCreation.length > 0) {
+              result.data.createPendingCreations.failedCreation.forEach((failed) => {
+                this.$toasted.error('Could not created PendingCreation for ' + failed)
+              })
+            }
             this.$emit('remove-all-bookmark')
           })
-          .catch(() => {
-            console.log('Fehler bei der mehrfach Schöpfung')
-          })
         // $store - offene Schöpfungen hochzählen
         // this.$store.commit('openCreationsPlus', i)
 
diff --git a/admin/src/graphql/createPendingCreations.js b/admin/src/graphql/createPendingCreations.js
index 50a2b049c..95d60bc9a 100644
--- a/admin/src/graphql/createPendingCreations.js
+++ b/admin/src/graphql/createPendingCreations.js
@@ -2,6 +2,10 @@ import gql from 'graphql-tag'
 
 export const createPendingCreations = gql`
   mutation ($pendingCreations: [CreatePendingCreationArgs!]!) {
-    createPendingCreations(pendingCreations: $pendingCreations)
+    createPendingCreations(pendingCreations: $pendingCreations) {
+      success
+      successfulCreation
+      failedCreation
+    }
   }
 `
diff --git a/backend/src/graphql/model/CreatePendingCreations.ts b/backend/src/graphql/model/CreatePendingCreations.ts
new file mode 100644
index 000000000..eeb6b13d3
--- /dev/null
+++ b/backend/src/graphql/model/CreatePendingCreations.ts
@@ -0,0 +1,19 @@
+import { ObjectType, Field, Int } from 'type-graphql'
+
+@ObjectType()
+export class CreatePendingCreations {
+  constructor() {
+    this.success = false
+    this.successfulCreation = []
+    this.failedCreation = []
+  }
+
+  @Field(() => Boolean)
+  success: boolean
+
+  @Field(() => [String])
+  successfulCreation: string[]
+
+  @Field(() => [String])
+  failedCreation: string[]
+}
diff --git a/backend/src/graphql/resolver/AdminResolver.ts b/backend/src/graphql/resolver/AdminResolver.ts
index bfab633b9..a08552844 100644
--- a/backend/src/graphql/resolver/AdminResolver.ts
+++ b/backend/src/graphql/resolver/AdminResolver.ts
@@ -2,6 +2,7 @@ import { Resolver, Query, Arg, Args, Authorized, Mutation } from 'type-graphql'
 import { getCustomRepository, Raw } from 'typeorm'
 import { UserAdmin } from '../model/UserAdmin'
 import { PendingCreation } from '../model/PendingCreation'
+import { CreatePendingCreations } from '../model/CreatePendingCreations'
 import { UpdatePendingCreation } from '../model/UpdatePendingCreation'
 import { RIGHTS } from '../../auth/RIGHTS'
 import { TransactionRepository } from '../../typeorm/repository/Transaction'
@@ -63,17 +64,62 @@ export class AdminResolver {
   }
 
   // @Authorized([RIGHTS.SEARCH_USERS])
-  @Mutation(() => Boolean)
+  @Mutation(() => CreatePendingCreations)
   async createPendingCreations(
     @Arg('pendingCreations', () => [CreatePendingCreationArgs])
     pendingCreations: CreatePendingCreationArgs[],
-  ): Promise<boolean> {
-    pendingCreations.forEach((pendingCreation) => {
-      this.createPendingCreation(pendingCreation).catch((error) => {
-        console.log('pendingCreation ' + JSON.stringify(pendingCreation) + ' had an error ' + error)
-      })
+  ): Promise<CreatePendingCreations> {
+    let success = false
+    const successfulCreation: string[] = []
+    const failedCreation: string[] = []
+    for (const pendingCreation of pendingCreations) {
+      await this.createPendingCreation(pendingCreation)
+        .then((result) => {
+          console.log('Successfuly created ' + JSON.stringify(pendingCreation) + ' ' + result)
+          successfulCreation.push(pendingCreation.email)
+          success = true
+        })
+        .catch(() => {
+          console.log('Failed to creat ' + JSON.stringify(pendingCreation))
+          failedCreation.push(pendingCreation.email)
+        })
+    }
+    // await Promise.all(
+    //   pendingCreations.map(async (pendingCreation) => {
+    //     await this.createPendingCreation(pendingCreation)
+    //       .then((result) => {
+    //         console.log('Successfuly created ' + JSON.stringify(pendingCreation) + ' ' + result)
+    //         successfulCreation.push(pendingCreation.email)
+    //         success = true
+    //       })
+    //       .catch(() => {
+    //         console.log('Failed to creat ' + JSON.stringify(pendingCreation))
+    //         failedCreation.push(pendingCreation.email)
+    //       })
+    //   }),
+    // )
+    // await pendingCreations.forEach(async (pendingCreation) => {
+    //   await this.createPendingCreation(pendingCreation)
+    //     .then((result) => {
+    //       console.log('Successfuly created ' + JSON.stringify(pendingCreation) + ' ' + result)
+    //       successfulCreation.push(pendingCreation.email)
+    //       success = true
+    //     })
+    //     .catch(() => {
+    //       console.log('Failed to creat ' + JSON.stringify(pendingCreation))
+    //       failedCreation.push(pendingCreation.email)
+    //     })
+    // })
+    console.log('createPendingCreations', {
+      success,
+      successfulCreation,
+      failedCreation,
     })
-    return true
+    return {
+      success,
+      successfulCreation,
+      failedCreation,
+    }
   }
 
   // @Authorized([RIGHTS.SEARCH_USERS])

From 84b81f6dc4eda7872211ee395132b18fcc4ba64b Mon Sep 17 00:00:00 2001
From: elweyn <heine.hannes@gmail.com>
Date: Tue, 21 Dec 2021 14:38:18 +0100
Subject: [PATCH 04/15] Remove console.log and commented code.

---
 admin/src/components/CreationFormular.vue     | 12 -------
 backend/src/graphql/resolver/AdminResolver.ts | 31 -------------------
 2 files changed, 43 deletions(-)

diff --git a/admin/src/components/CreationFormular.vue b/admin/src/components/CreationFormular.vue
index 02b8f1ad8..0fd8b6055 100644
--- a/admin/src/components/CreationFormular.vue
+++ b/admin/src/components/CreationFormular.vue
@@ -217,17 +217,6 @@ export default {
             moderator: Number(this.$store.state.moderator.id),
           })
         })
-        console.log('submitObj', this.submitObj)
-        // this.submitObj = [
-        //   {
-        //     item: this.itemsMassCreation,
-        //     email: this.item.email,
-        //     creationDate: this.radioSelected.long,
-        //     amount: this.value,
-        //     memo: this.text,
-        //     moderator: this.$store.state.moderator.id,
-        //   },
-        // ]
         // eslint-disable-next-line no-console
         console.log('MehrfachSCHÖPFUNG ABSENDEN FÜR >> ' + i + ' Mitglieder')
         this.$apollo
@@ -239,7 +228,6 @@ export default {
             fetchPolicy: 'no-cache',
           })
           .then((result) => {
-            console.log('result', result)
             this.$store.commit(
               'openCreationsPlus',
               result.data.createPendingCreations.successfulCreation.length,
diff --git a/backend/src/graphql/resolver/AdminResolver.ts b/backend/src/graphql/resolver/AdminResolver.ts
index 5b5b463f0..bd58e4364 100644
--- a/backend/src/graphql/resolver/AdminResolver.ts
+++ b/backend/src/graphql/resolver/AdminResolver.ts
@@ -85,37 +85,6 @@ export class AdminResolver {
           failedCreation.push(pendingCreation.email)
         })
     }
-    // await Promise.all(
-    //   pendingCreations.map(async (pendingCreation) => {
-    //     await this.createPendingCreation(pendingCreation)
-    //       .then((result) => {
-    //         console.log('Successfuly created ' + JSON.stringify(pendingCreation) + ' ' + result)
-    //         successfulCreation.push(pendingCreation.email)
-    //         success = true
-    //       })
-    //       .catch(() => {
-    //         console.log('Failed to creat ' + JSON.stringify(pendingCreation))
-    //         failedCreation.push(pendingCreation.email)
-    //       })
-    //   }),
-    // )
-    // await pendingCreations.forEach(async (pendingCreation) => {
-    //   await this.createPendingCreation(pendingCreation)
-    //     .then((result) => {
-    //       console.log('Successfuly created ' + JSON.stringify(pendingCreation) + ' ' + result)
-    //       successfulCreation.push(pendingCreation.email)
-    //       success = true
-    //     })
-    //     .catch(() => {
-    //       console.log('Failed to creat ' + JSON.stringify(pendingCreation))
-    //       failedCreation.push(pendingCreation.email)
-    //     })
-    // })
-    console.log('createPendingCreations', {
-      success,
-      successfulCreation,
-      failedCreation,
-    })
     return {
       success,
       successfulCreation,

From 967e47908a4a4cca04267ac3c883467db0f62373 Mon Sep 17 00:00:00 2001
From: elweyn <heine.hannes@gmail.com>
Date: Tue, 21 Dec 2021 15:39:53 +0100
Subject: [PATCH 05/15] Remove the console.log, remove unused Int.

---
 backend/src/graphql/model/CreatePendingCreations.ts | 2 +-
 backend/src/graphql/resolver/AdminResolver.ts       | 4 +---
 2 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/backend/src/graphql/model/CreatePendingCreations.ts b/backend/src/graphql/model/CreatePendingCreations.ts
index eeb6b13d3..8d5bcef2c 100644
--- a/backend/src/graphql/model/CreatePendingCreations.ts
+++ b/backend/src/graphql/model/CreatePendingCreations.ts
@@ -1,4 +1,4 @@
-import { ObjectType, Field, Int } from 'type-graphql'
+import { ObjectType, Field } from 'type-graphql'
 
 @ObjectType()
 export class CreatePendingCreations {
diff --git a/backend/src/graphql/resolver/AdminResolver.ts b/backend/src/graphql/resolver/AdminResolver.ts
index bd58e4364..b93dfed79 100644
--- a/backend/src/graphql/resolver/AdminResolver.ts
+++ b/backend/src/graphql/resolver/AdminResolver.ts
@@ -75,13 +75,11 @@ export class AdminResolver {
     const failedCreation: string[] = []
     for (const pendingCreation of pendingCreations) {
       await this.createPendingCreation(pendingCreation)
-        .then((result) => {
-          console.log('Successfuly created ' + JSON.stringify(pendingCreation) + ' ' + result)
+        .then(() => {
           successfulCreation.push(pendingCreation.email)
           success = true
         })
         .catch(() => {
-          console.log('Failed to creat ' + JSON.stringify(pendingCreation))
           failedCreation.push(pendingCreation.email)
         })
     }

From 0d431974bda1307f577489e1c19716c8c9d26e8b Mon Sep 17 00:00:00 2001
From: elweyn <heine.hannes@gmail.com>
Date: Thu, 30 Dec 2021 12:35:52 +0100
Subject: [PATCH 06/15] Adding tests for CreationFormular and
 EditCreationFormular.

---
 admin/src/components/CreationFormular.spec.js |  5 ++-
 .../components/EditCreationFormular.spec.js   | 37 ++++++++++++++++---
 2 files changed, 35 insertions(+), 7 deletions(-)

diff --git a/admin/src/components/CreationFormular.spec.js b/admin/src/components/CreationFormular.spec.js
index 1c7dd40fc..5b733f4e0 100644
--- a/admin/src/components/CreationFormular.spec.js
+++ b/admin/src/components/CreationFormular.spec.js
@@ -98,7 +98,10 @@ describe('CreationFormular', () => {
       describe('with mass creation', () => {
         beforeEach(async () => {
           jest.clearAllMocks()
-          await wrapper.setProps({ type: 'massCreation' })
+          await wrapper.setProps({ type: 'massCreation', creation: [200, 400, 600] })
+          await wrapper.setData({ rangeMin: 180 })
+          await wrapper.setData({ text: 'Test create coins' })
+          await wrapper.setData({ value: 90 })
         })
 
         describe('first radio button', () => {
diff --git a/admin/src/components/EditCreationFormular.spec.js b/admin/src/components/EditCreationFormular.spec.js
index b7b091e32..10aac7648 100644
--- a/admin/src/components/EditCreationFormular.spec.js
+++ b/admin/src/components/EditCreationFormular.spec.js
@@ -16,6 +16,7 @@ const apolloMutateMock = jest.fn().mockResolvedValue({
 
 const stateCommitMock = jest.fn()
 const toastedErrorMock = jest.fn()
+const toastedSuccessMock = jest.fn()
 
 const mocks = {
   $moment: jest.fn(() => {
@@ -42,6 +43,7 @@ const mocks = {
   },
   $toasted: {
     error: toastedErrorMock,
+    success: toastedSuccessMock,
   },
 }
 
@@ -52,6 +54,10 @@ const propsData = {
     amount: 100,
     date: '2021-12-01',
   },
+  item: {
+    id: 0,
+    email: 'bob@baumeister.de',
+  },
 }
 
 describe('EditCreationFormular', () => {
@@ -108,8 +114,8 @@ describe('EditCreationFormular', () => {
                   variables: {
                     amount: 90,
                     creationDate: 'YYYY-MM-01',
-                    email: undefined,
-                    id: undefined,
+                    email: 'bob@baumeister.de',
+                    id: 0,
                     memo: 'Test create coins',
                     moderator: 0,
                   },
@@ -117,6 +123,25 @@ describe('EditCreationFormular', () => {
               )
             })
 
+            it('emits update-user-data', () => {
+              expect(wrapper.emitted('update-user-data')).toBeTruthy()
+              expect(wrapper.emitted('update-user-data')).toEqual([
+                [
+                  {
+                    id: 0,
+                    email: 'bob@baumeister.de',
+                  },
+                  [0, 0, 0],
+                ],
+              ])
+            })
+
+            it('toast success message', () => {
+              expect(toastedSuccessMock).toBeCalledWith(
+                'Offene schöpfung (90 GDD) für bob@baumeister.de wurde geändert, liegt zur Bestätigung bereit',
+              )
+            })
+
             describe('sendForm with error', () => {
               beforeEach(async () => {
                 jest.clearAllMocks()
@@ -163,8 +188,8 @@ describe('EditCreationFormular', () => {
                   variables: {
                     amount: 90,
                     creationDate: 'YYYY-MM-01',
-                    email: undefined,
-                    id: undefined,
+                    email: 'bob@baumeister.de',
+                    id: 0,
                     memo: 'Test create coins',
                     moderator: 0,
                   },
@@ -219,8 +244,8 @@ describe('EditCreationFormular', () => {
                   variables: {
                     amount: 90,
                     creationDate: 'YYYY-MM-DD',
-                    email: undefined,
-                    id: undefined,
+                    email: 'bob@baumeister.de',
+                    id: 0,
                     memo: 'Test create coins',
                     moderator: 0,
                   },

From 6e27c31d3cfaafda353af96ffef07576c20fb0a2 Mon Sep 17 00:00:00 2001
From: elweyn <heine.hannes@gmail.com>
Date: Thu, 30 Dec 2021 13:57:28 +0100
Subject: [PATCH 07/15] Adding right to create pending creation.

---
 backend/src/auth/RIGHTS.ts                    | 1 +
 backend/src/graphql/resolver/AdminResolver.ts | 4 ++--
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/backend/src/auth/RIGHTS.ts b/backend/src/auth/RIGHTS.ts
index 6a2c05025..e23790e0f 100644
--- a/backend/src/auth/RIGHTS.ts
+++ b/backend/src/auth/RIGHTS.ts
@@ -21,4 +21,5 @@ export enum RIGHTS {
   HAS_ELOPAGE = 'HAS_ELOPAGE',
   // Admin
   SEARCH_USERS = 'SEARCH_USERS',
+  CREATE_PENDING_CREATION = 'CREATE_PENDING_CREATION',
 }
diff --git a/backend/src/graphql/resolver/AdminResolver.ts b/backend/src/graphql/resolver/AdminResolver.ts
index 0b82bee2e..76fdb7b65 100644
--- a/backend/src/graphql/resolver/AdminResolver.ts
+++ b/backend/src/graphql/resolver/AdminResolver.ts
@@ -42,7 +42,7 @@ export class AdminResolver {
     return adminUsers
   }
 
-  @Authorized([RIGHTS.SEARCH_USERS])
+  @Authorized([RIGHTS.CREATE_PENDING_CREATION])
   @Mutation(() => [Number])
   async createPendingCreation(
     @Args() { email, amount, memo, creationDate, moderator }: CreatePendingCreationArgs,
@@ -67,7 +67,7 @@ export class AdminResolver {
     return await getUserCreations(user.id)
   }
 
-  // @Authorized([RIGHTS.SEARCH_USERS])
+  @Authorized([RIGHTS.CREATE_PENDING_CREATION])
   @Mutation(() => CreatePendingCreations)
   async createPendingCreations(
     @Arg('pendingCreations', () => [CreatePendingCreationArgs])

From 56021489f89e9b4f5ddb7f0694c359bdf3b5e70a Mon Sep 17 00:00:00 2001
From: elweyn <heine.hannes@gmail.com>
Date: Thu, 30 Dec 2021 13:58:47 +0100
Subject: [PATCH 08/15] Adding right to update pending creation.

---
 backend/src/auth/RIGHTS.ts                    | 1 +
 backend/src/graphql/resolver/AdminResolver.ts | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/backend/src/auth/RIGHTS.ts b/backend/src/auth/RIGHTS.ts
index e23790e0f..b9b143146 100644
--- a/backend/src/auth/RIGHTS.ts
+++ b/backend/src/auth/RIGHTS.ts
@@ -22,4 +22,5 @@ export enum RIGHTS {
   // Admin
   SEARCH_USERS = 'SEARCH_USERS',
   CREATE_PENDING_CREATION = 'CREATE_PENDING_CREATION',
+  UPDATE_PENDING_CREATION = 'UPDATE_PENDING_CREATION',
 }
diff --git a/backend/src/graphql/resolver/AdminResolver.ts b/backend/src/graphql/resolver/AdminResolver.ts
index 76fdb7b65..f357968f9 100644
--- a/backend/src/graphql/resolver/AdminResolver.ts
+++ b/backend/src/graphql/resolver/AdminResolver.ts
@@ -93,7 +93,7 @@ export class AdminResolver {
     }
   }
 
-  // @Authorized([RIGHTS.SEARCH_USERS])
+  @Authorized([RIGHTS.UPDATE_PENDING_CREATION])
   @Mutation(() => UpdatePendingCreation)
   async updatePendingCreation(
     @Args() { id, email, amount, memo, creationDate, moderator }: UpdatePendingCreationArgs,

From e440bb10b7c35fcced62c7d29283a603e3e80a7e Mon Sep 17 00:00:00 2001
From: elweyn <heine.hannes@gmail.com>
Date: Thu, 30 Dec 2021 13:59:39 +0100
Subject: [PATCH 09/15] Adding right to search pending creation.

---
 backend/src/auth/RIGHTS.ts                    | 1 +
 backend/src/graphql/resolver/AdminResolver.ts | 1 +
 2 files changed, 2 insertions(+)

diff --git a/backend/src/auth/RIGHTS.ts b/backend/src/auth/RIGHTS.ts
index b9b143146..fe91a6167 100644
--- a/backend/src/auth/RIGHTS.ts
+++ b/backend/src/auth/RIGHTS.ts
@@ -23,4 +23,5 @@ export enum RIGHTS {
   SEARCH_USERS = 'SEARCH_USERS',
   CREATE_PENDING_CREATION = 'CREATE_PENDING_CREATION',
   UPDATE_PENDING_CREATION = 'UPDATE_PENDING_CREATION',
+  SEARCH_PENDING_CREATION = 'SEARCH_PENDING_CREATION',
 }
diff --git a/backend/src/graphql/resolver/AdminResolver.ts b/backend/src/graphql/resolver/AdminResolver.ts
index f357968f9..c68e6009e 100644
--- a/backend/src/graphql/resolver/AdminResolver.ts
+++ b/backend/src/graphql/resolver/AdminResolver.ts
@@ -123,6 +123,7 @@ export class AdminResolver {
     return result
   }
 
+  @Authorized([RIGHTS.SEARCH_PENDING_CREATION])
   @Query(() => [PendingCreation])
   async getPendingCreations(): Promise<PendingCreation[]> {
     const loginPendingTasksAdminRepository = getCustomRepository(LoginPendingTasksAdminRepository)

From 2f59ecae502ac298e1bf79fccf7c31c199d50f28 Mon Sep 17 00:00:00 2001
From: elweyn <heine.hannes@gmail.com>
Date: Thu, 30 Dec 2021 14:00:53 +0100
Subject: [PATCH 10/15] Adding right to delete pending creation.

---
 backend/src/auth/RIGHTS.ts                    | 1 +
 backend/src/graphql/resolver/AdminResolver.ts | 1 +
 2 files changed, 2 insertions(+)

diff --git a/backend/src/auth/RIGHTS.ts b/backend/src/auth/RIGHTS.ts
index fe91a6167..d0070402f 100644
--- a/backend/src/auth/RIGHTS.ts
+++ b/backend/src/auth/RIGHTS.ts
@@ -24,4 +24,5 @@ export enum RIGHTS {
   CREATE_PENDING_CREATION = 'CREATE_PENDING_CREATION',
   UPDATE_PENDING_CREATION = 'UPDATE_PENDING_CREATION',
   SEARCH_PENDING_CREATION = 'SEARCH_PENDING_CREATION',
+  DELETE_PENDING_CREATION = 'DELETE_PENDING_CREATION',
 }
diff --git a/backend/src/graphql/resolver/AdminResolver.ts b/backend/src/graphql/resolver/AdminResolver.ts
index c68e6009e..2c3c14b17 100644
--- a/backend/src/graphql/resolver/AdminResolver.ts
+++ b/backend/src/graphql/resolver/AdminResolver.ts
@@ -151,6 +151,7 @@ export class AdminResolver {
     return pendingCreationsPromise.reverse()
   }
 
+  @Authorized([RIGHTS.DELETE_PENDING_CREATION])
   @Mutation(() => Boolean)
   async deletePendingCreation(@Arg('id') id: number): Promise<boolean> {
     const loginPendingTasksAdminRepository = getCustomRepository(LoginPendingTasksAdminRepository)

From c31c8b28f2b69e857a99fcc19a226d3f9a3426d9 Mon Sep 17 00:00:00 2001
From: elweyn <heine.hannes@gmail.com>
Date: Thu, 30 Dec 2021 14:01:34 +0100
Subject: [PATCH 11/15] Adding right to confirm pending creation.

---
 backend/src/auth/RIGHTS.ts                    | 1 +
 backend/src/graphql/resolver/AdminResolver.ts | 1 +
 2 files changed, 2 insertions(+)

diff --git a/backend/src/auth/RIGHTS.ts b/backend/src/auth/RIGHTS.ts
index d0070402f..8988620d7 100644
--- a/backend/src/auth/RIGHTS.ts
+++ b/backend/src/auth/RIGHTS.ts
@@ -25,4 +25,5 @@ export enum RIGHTS {
   UPDATE_PENDING_CREATION = 'UPDATE_PENDING_CREATION',
   SEARCH_PENDING_CREATION = 'SEARCH_PENDING_CREATION',
   DELETE_PENDING_CREATION = 'DELETE_PENDING_CREATION',
+  CONFIRM_PENDING_CREATION = 'CONFIRM_PENDING_CREATION',
 }
diff --git a/backend/src/graphql/resolver/AdminResolver.ts b/backend/src/graphql/resolver/AdminResolver.ts
index 2c3c14b17..f441e5383 100644
--- a/backend/src/graphql/resolver/AdminResolver.ts
+++ b/backend/src/graphql/resolver/AdminResolver.ts
@@ -160,6 +160,7 @@ export class AdminResolver {
     return !!res
   }
 
+  @Authorized([RIGHTS.CONFIRM_PENDING_CREATION])
   @Mutation(() => Boolean)
   async confirmPendingCreation(@Arg('id') id: number): Promise<boolean> {
     const loginPendingTasksAdminRepository = getCustomRepository(LoginPendingTasksAdminRepository)

From 75bc2a94c17a71fc96b8fda984486f75dc5afc75 Mon Sep 17 00:00:00 2001
From: elweyn <heine.hannes@gmail.com>
Date: Thu, 30 Dec 2021 14:37:51 +0100
Subject: [PATCH 12/15] Remove lint problems and adding catch block to
 createPendingCreations.

---
 admin/src/components/CreationFormular.vue     | 8 +++-----
 backend/src/graphql/resolver/AdminResolver.ts | 2 --
 2 files changed, 3 insertions(+), 7 deletions(-)

diff --git a/admin/src/components/CreationFormular.vue b/admin/src/components/CreationFormular.vue
index 6a4bcc619..ede7c51df 100644
--- a/admin/src/components/CreationFormular.vue
+++ b/admin/src/components/CreationFormular.vue
@@ -244,11 +244,9 @@ export default {
             }
             this.$emit('remove-all-bookmark')
           })
-        // $store - offene Schöpfungen hochzählen
-        // this.$store.commit('openCreationsPlus', i)
-
-        // lösche alle Mitglieder aus der MehrfachSchöpfungsListe nach dem alle Mehrfachschpfungen zum bestätigen gesendet wurden.
-        // this.$emit('remove-all-bookmark')
+          .catch((error) => {
+            this.$toasted.error(error.message)
+          })
       } else if (this.type === 'singleCreation') {
         this.submitObj = {
           email: this.item.email,
diff --git a/backend/src/graphql/resolver/AdminResolver.ts b/backend/src/graphql/resolver/AdminResolver.ts
index f441e5383..f7d675aaa 100644
--- a/backend/src/graphql/resolver/AdminResolver.ts
+++ b/backend/src/graphql/resolver/AdminResolver.ts
@@ -335,7 +335,5 @@ function isCreationValid(creations: number[], amount: number, creationDate: Date
 async function hasActivatedEmail(email: string): Promise<boolean> {
   const repository = getCustomRepository(LoginUserRepository)
   const user = await repository.findByEmail(email)
-  let emailActivate = false
-  if (user) emailActivate = user.emailChecked
   return user ? user.emailChecked : false
 }

From 8053033c52624d27e1a44c4df8e4f933db5c3bdc Mon Sep 17 00:00:00 2001
From: elweyn <heine.hannes@gmail.com>
Date: Mon, 3 Jan 2022 08:24:14 +0100
Subject: [PATCH 13/15] Fix linting.

---
 backend/src/graphql/resolver/AdminResolver.ts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/backend/src/graphql/resolver/AdminResolver.ts b/backend/src/graphql/resolver/AdminResolver.ts
index fff84686f..12a07d51d 100644
--- a/backend/src/graphql/resolver/AdminResolver.ts
+++ b/backend/src/graphql/resolver/AdminResolver.ts
@@ -160,7 +160,6 @@ export class AdminResolver {
     return !!res
   }
 
-
   @Authorized([RIGHTS.CONFIRM_PENDING_CREATION])
   @Mutation(() => Boolean)
   async confirmPendingCreation(@Arg('id') id: number, @Ctx() context: any): Promise<boolean> {
@@ -338,6 +337,7 @@ function isCreationValid(creations: number[], amount: number, creationDate: Date
   }
   return true
 }
+
 async function hasActivatedEmail(email: string): Promise<boolean> {
   const repository = getCustomRepository(LoginUserRepository)
   const user = await repository.findByEmail(email)

From 8521ff311f5a933362fabc1ef4f774e225a1ef8b Mon Sep 17 00:00:00 2001
From: elweyn <heine.hannes@gmail.com>
Date: Mon, 3 Jan 2022 08:24:40 +0100
Subject: [PATCH 14/15] Update toast is now international.

---
 admin/src/components/EditCreationFormular.spec.js | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/admin/src/components/EditCreationFormular.spec.js b/admin/src/components/EditCreationFormular.spec.js
index 5ee784761..ed0f412ba 100644
--- a/admin/src/components/EditCreationFormular.spec.js
+++ b/admin/src/components/EditCreationFormular.spec.js
@@ -138,9 +138,7 @@ describe('EditCreationFormular', () => {
             })
 
             it('toast success message', () => {
-              expect(toastedSuccessMock).toBeCalledWith(
-                'Offene schöpfung (90 GDD) für bob@baumeister.de wurde geändert, liegt zur Bestätigung bereit',
-              )
+              expect(toastedSuccessMock).toBeCalledWith('creation_form.toasted_update')
             })
 
             describe('sendForm with error', () => {

From f811ec079640a646e6195d48662201b273e0c3e4 Mon Sep 17 00:00:00 2001
From: elweyn <heine.hannes@gmail.com>
Date: Mon, 3 Jan 2022 08:38:22 +0100
Subject: [PATCH 15/15] Withdrew optional on fields that have to be filled.

---
 admin/src/components/EditCreationFormular.vue | 10 ++--------
 1 file changed, 2 insertions(+), 8 deletions(-)

diff --git a/admin/src/components/EditCreationFormular.vue b/admin/src/components/EditCreationFormular.vue
index b255a5662..172ae5509 100644
--- a/admin/src/components/EditCreationFormular.vue
+++ b/admin/src/components/EditCreationFormular.vue
@@ -129,10 +129,7 @@ export default {
   props: {
     item: {
       type: Object,
-      required: false,
-      default() {
-        return {}
-      },
+      required: true,
     },
     row: {
       type: Object,
@@ -143,10 +140,7 @@ export default {
     },
     creationUserData: {
       type: Object,
-      required: false,
-      default() {
-        return {}
-      },
+      required: true,
     },
     creation: {
       type: Array,