From c0138b3811826f68b52e7e38b5a453bb2a5f0ca8 Mon Sep 17 00:00:00 2001
From: Moriz Wahl <moriz.wahl@gmx.de>
Date: Thu, 20 Jan 2022 17:17:22 +0100
Subject: [PATCH 1/4] fix: Set Locale after Login

---
 frontend/src/views/Pages/Login.vue | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/frontend/src/views/Pages/Login.vue b/frontend/src/views/Pages/Login.vue
index 4d2b75d2a..1c2f4c8d0 100755
--- a/frontend/src/views/Pages/Login.vue
+++ b/frontend/src/views/Pages/Login.vue
@@ -64,6 +64,7 @@ import InputPassword from '../../components/Inputs/InputPassword'
 import InputEmail from '../../components/Inputs/InputEmail'
 import { login } from '../../graphql/queries'
 import { getCommunityInfoMixin } from '../../mixins/getCommunityInfo'
+import { localeChanged } from 'vee-validate'
 
 export default {
   name: 'login',
@@ -101,6 +102,8 @@ export default {
             data: { login },
           } = result
           this.$store.dispatch('login', login)
+          this.$i18n.locale = login.language
+          localeChanged(login.language)
           this.$router.push('/overview')
           loader.hide()
         })

From 6d6cdb1e647d005d3e18a33a1c43934c2c9cf6ad Mon Sep 17 00:00:00 2001
From: Moriz Wahl <moriz.wahl@gmx.de>
Date: Mon, 24 Jan 2022 17:26:47 +0100
Subject: [PATCH 2/4] set i18n.locale and localeChanged from vee-validate
 inside the language mutation of the store

---
 frontend/src/store/store.js        |  4 ++++
 frontend/src/store/store.test.js   | 18 ++++++++++++++++++
 frontend/src/views/Pages/Login.vue |  3 ---
 3 files changed, 22 insertions(+), 3 deletions(-)

diff --git a/frontend/src/store/store.js b/frontend/src/store/store.js
index d219ecacd..1a6521cd7 100644
--- a/frontend/src/store/store.js
+++ b/frontend/src/store/store.js
@@ -1,11 +1,15 @@
 import Vue from 'vue'
 import Vuex from 'vuex'
 import createPersistedState from 'vuex-persistedstate'
+import { localeChanged } from 'vee-validate'
+import i18n from '../i18n.js'
 
 Vue.use(Vuex)
 
 export const mutations = {
   language: (state, language) => {
+    i18n.locale = language
+    localeChanged(language)
     state.language = language
   },
   email: (state, email) => {
diff --git a/frontend/src/store/store.test.js b/frontend/src/store/store.test.js
index da108b9ff..4c0c03178 100644
--- a/frontend/src/store/store.test.js
+++ b/frontend/src/store/store.test.js
@@ -1,8 +1,18 @@
 import { mutations, actions } from './store'
 import Vuex from 'vuex'
 import Vue from 'vue'
+import i18n from '../i18n.js'
+import { localeChanged } from 'vee-validate'
 
 jest.mock('vuex')
+jest.mock('../i18n.js')
+jest.mock('vee-validate', () => {
+  return {
+    localeChanged: jest.fn(),
+  }
+})
+
+i18n.locale = 'blubb'
 
 const {
   language,
@@ -29,6 +39,14 @@ describe('Vuex store', () => {
         language(state, 'de')
         expect(state.language).toEqual('de')
       })
+
+      it('sets the i18n locale', () => {
+        expect(i18n.locale).toBe('de')
+      })
+
+      it('calls localChanged of vee-validate', () => {
+        expect(localeChanged).toBeCalledWith('de')
+      })
     })
 
     describe('email', () => {
diff --git a/frontend/src/views/Pages/Login.vue b/frontend/src/views/Pages/Login.vue
index 1c2f4c8d0..4d2b75d2a 100755
--- a/frontend/src/views/Pages/Login.vue
+++ b/frontend/src/views/Pages/Login.vue
@@ -64,7 +64,6 @@ import InputPassword from '../../components/Inputs/InputPassword'
 import InputEmail from '../../components/Inputs/InputEmail'
 import { login } from '../../graphql/queries'
 import { getCommunityInfoMixin } from '../../mixins/getCommunityInfo'
-import { localeChanged } from 'vee-validate'
 
 export default {
   name: 'login',
@@ -102,8 +101,6 @@ export default {
             data: { login },
           } = result
           this.$store.dispatch('login', login)
-          this.$i18n.locale = login.language
-          localeChanged(login.language)
           this.$router.push('/overview')
           loader.hide()
         })

From e8920f4c35de6cd6dbd7ec14722438089a9a4ad2 Mon Sep 17 00:00:00 2001
From: Moriz Wahl <moriz.wahl@gmx.de>
Date: Mon, 24 Jan 2022 17:39:42 +0100
Subject: [PATCH 3/4] all locale handling is done by store, so that commit the
 language to store on change is enough. Note that dispatch login calls commit
 language

---
 .../src/components/#LanguageSwitchSelect.vue# | 39 +++++++++++++++++++
 .../src/components/.#LanguageSwitchSelect.vue |  1 +
 frontend/src/components/LanguageSwitch.vue    |  5 +--
 frontend/src/main.js                          |  2 +-
 frontend/src/routes/guards.js                 |  3 +-
 frontend/src/views/Pages/Register.vue         |  3 --
 .../UserProfile/UserCard_Language.spec.js     |  4 --
 .../Pages/UserProfile/UserCard_Language.vue   |  3 --
 8 files changed, 43 insertions(+), 17 deletions(-)
 create mode 100644 frontend/src/components/#LanguageSwitchSelect.vue#
 create mode 120000 frontend/src/components/.#LanguageSwitchSelect.vue

diff --git a/frontend/src/components/#LanguageSwitchSelect.vue# b/frontend/src/components/#LanguageSwitchSelect.vue#
new file mode 100644
index 000000000..545cef4e9
--- /dev/null
+++ b/frontend/src/components/#LanguageSwitchSelect.vue#
@@ -0,0 +1,39 @@
+<template>
+  <div class="language-switch-select">
+    <b-form-select
+      v-model="selected"
+      :options="options"
+      class="selectedLanguage mb-3"
+    ></b-form-select>
+  </div>
+</template>
+<script>
+export default {
+  name: 'LanguageSwitch',
+  data() {
+    return {
+      selected: null,
+      options: [
+        { value: 'de', text: this.$t('settings.language.de') },
+        { value: 'en', text: this.$t('settings.language.en') },
+      ],
+    }
+  },
+  props: {
+    language: { type: String },
+  },
+  created() {
+    this.selected = this.$store.state.language
+  },
+  computed: {
+    languageObject() {
+      return this.selected
+    },
+  },
+  watch: {
+    selected() {
+      this.$emit('update-language', this.languageObject)
+    },
+  },
+}
+</script>
diff --git a/frontend/src/components/.#LanguageSwitchSelect.vue b/frontend/src/components/.#LanguageSwitchSelect.vue
new file mode 120000
index 000000000..8a9d4d991
--- /dev/null
+++ b/frontend/src/components/.#LanguageSwitchSelect.vue
@@ -0,0 +1 @@
+moriz@bluestar.2222:1642854724
\ No newline at end of file
diff --git a/frontend/src/components/LanguageSwitch.vue b/frontend/src/components/LanguageSwitch.vue
index 5e4c71287..2678883c3 100644
--- a/frontend/src/components/LanguageSwitch.vue
+++ b/frontend/src/components/LanguageSwitch.vue
@@ -12,7 +12,6 @@
   </div>
 </template>
 <script>
-import { localeChanged } from 'vee-validate'
 import locales from '../locales/'
 import { updateUserInfos } from '../graphql/mutations'
 
@@ -26,10 +25,8 @@ export default {
   },
   methods: {
     setLocale(locale) {
-      this.$i18n.locale = locale
-      this.$store.commit('language', this.$i18n.locale)
+      this.$store.commit('language', locale)
       this.currentLanguage = this.getLocaleObject(locale)
-      localeChanged(locale)
     },
     async saveLocale(locale) {
       // if (this.$i18n.locale === locale) return
diff --git a/frontend/src/main.js b/frontend/src/main.js
index 544dff66d..edc9e575e 100755
--- a/frontend/src/main.js
+++ b/frontend/src/main.js
@@ -28,7 +28,7 @@ Vue.toasted.register(
 
 loadAllRules(i18n)
 
-addNavigationGuards(router, store, apolloProvider.defaultClient, i18n)
+addNavigationGuards(router, store, apolloProvider.defaultClient)
 
 if (!store) {
   setTimeout(
diff --git a/frontend/src/routes/guards.js b/frontend/src/routes/guards.js
index 15d1eb5a1..1838fa0fc 100644
--- a/frontend/src/routes/guards.js
+++ b/frontend/src/routes/guards.js
@@ -1,6 +1,6 @@
 import { verifyLogin } from '../graphql/queries'
 
-const addNavigationGuards = (router, store, apollo, i18n) => {
+const addNavigationGuards = (router, store, apollo) => {
   // handle publisherId
   router.beforeEach((to, from, next) => {
     const publisherId = to.query.pid
@@ -21,7 +21,6 @@ const addNavigationGuards = (router, store, apollo, i18n) => {
           fetchPolicy: 'network-only',
         })
         .then((result) => {
-          i18n.locale = result.data.verifyLogin.language
           store.dispatch('login', result.data.verifyLogin)
           next({ path: '/overview' })
         })
diff --git a/frontend/src/views/Pages/Register.vue b/frontend/src/views/Pages/Register.vue
index 389efc68a..05cf61c46 100755
--- a/frontend/src/views/Pages/Register.vue
+++ b/frontend/src/views/Pages/Register.vue
@@ -191,7 +191,6 @@
 import InputEmail from '../../components/Inputs/InputEmail.vue'
 import LanguageSwitchSelect from '../../components/LanguageSwitchSelect.vue'
 import { createUser } from '../../graphql/mutations'
-import { localeChanged } from 'vee-validate'
 import { getCommunityInfoMixin } from '../../mixins/getCommunityInfo'
 
 export default {
@@ -218,8 +217,6 @@ export default {
     updateLanguage(e) {
       this.language = e
       this.$store.commit('language', this.language)
-      this.$i18n.locale = this.language
-      localeChanged(this.language)
     },
     getValidationState({ dirty, validated, valid = null }) {
       return dirty || validated ? valid : null
diff --git a/frontend/src/views/Pages/UserProfile/UserCard_Language.spec.js b/frontend/src/views/Pages/UserProfile/UserCard_Language.spec.js
index e13d4a1d1..dab5a4945 100644
--- a/frontend/src/views/Pages/UserProfile/UserCard_Language.spec.js
+++ b/frontend/src/views/Pages/UserProfile/UserCard_Language.spec.js
@@ -138,10 +138,6 @@ describe('UserCard_Language', () => {
               expect(storeCommitMock).toBeCalledWith('language', 'en')
             })
 
-            it('changes the i18n locale', () => {
-              expect(mocks.$i18n.locale).toBe('en')
-            })
-
             it('has no select field anymore', () => {
               expect(wrapper.find('select').exists()).toBeFalsy()
             })
diff --git a/frontend/src/views/Pages/UserProfile/UserCard_Language.vue b/frontend/src/views/Pages/UserProfile/UserCard_Language.vue
index dfaf6cf55..a7b9d7f70 100644
--- a/frontend/src/views/Pages/UserProfile/UserCard_Language.vue
+++ b/frontend/src/views/Pages/UserProfile/UserCard_Language.vue
@@ -60,7 +60,6 @@
   </b-card>
 </template>
 <script>
-import { localeChanged } from 'vee-validate'
 import LanguageSwitchSelect from '../../../components/LanguageSwitchSelect.vue'
 import { updateUserInfos } from '../../../graphql/mutations'
 
@@ -97,8 +96,6 @@ export default {
         })
         .then(() => {
           this.$store.commit('language', this.language)
-          this.$i18n.locale = this.language
-          localeChanged(this.language)
           this.cancelEdit()
           this.$toasted.success(this.$t('settings.language.success'))
         })

From a7aa5dca3a69b1a7e08a9537ad466998842574a5 Mon Sep 17 00:00:00 2001
From: Moriz Wahl <moriz.wahl@gmx.de>
Date: Mon, 24 Jan 2022 17:45:39 +0100
Subject: [PATCH 4/4] remove emacs backup files

---
 .../src/components/#LanguageSwitchSelect.vue# | 39 -------------------
 .../src/components/.#LanguageSwitchSelect.vue |  1 -
 2 files changed, 40 deletions(-)
 delete mode 100644 frontend/src/components/#LanguageSwitchSelect.vue#
 delete mode 120000 frontend/src/components/.#LanguageSwitchSelect.vue

diff --git a/frontend/src/components/#LanguageSwitchSelect.vue# b/frontend/src/components/#LanguageSwitchSelect.vue#
deleted file mode 100644
index 545cef4e9..000000000
--- a/frontend/src/components/#LanguageSwitchSelect.vue#
+++ /dev/null
@@ -1,39 +0,0 @@
-<template>
-  <div class="language-switch-select">
-    <b-form-select
-      v-model="selected"
-      :options="options"
-      class="selectedLanguage mb-3"
-    ></b-form-select>
-  </div>
-</template>
-<script>
-export default {
-  name: 'LanguageSwitch',
-  data() {
-    return {
-      selected: null,
-      options: [
-        { value: 'de', text: this.$t('settings.language.de') },
-        { value: 'en', text: this.$t('settings.language.en') },
-      ],
-    }
-  },
-  props: {
-    language: { type: String },
-  },
-  created() {
-    this.selected = this.$store.state.language
-  },
-  computed: {
-    languageObject() {
-      return this.selected
-    },
-  },
-  watch: {
-    selected() {
-      this.$emit('update-language', this.languageObject)
-    },
-  },
-}
-</script>
diff --git a/frontend/src/components/.#LanguageSwitchSelect.vue b/frontend/src/components/.#LanguageSwitchSelect.vue
deleted file mode 120000
index 8a9d4d991..000000000
--- a/frontend/src/components/.#LanguageSwitchSelect.vue
+++ /dev/null
@@ -1 +0,0 @@
-moriz@bluestar.2222:1642854724
\ No newline at end of file