From 2b27e6aaa8ceae94abf9f57bf1b7c5ffc8adc3b1 Mon Sep 17 00:00:00 2001
From: Moriz Wahl <moriz.wahl@gmx.de>
Date: Thu, 10 Nov 2022 19:18:01 +0100
Subject: [PATCH] test for valid date string for creation date

---
 backend/src/graphql/resolver/AdminResolver.test.ts | 8 ++++----
 backend/src/graphql/resolver/AdminResolver.ts      | 5 +++++
 backend/src/graphql/resolver/util/creations.ts     | 4 ++++
 3 files changed, 13 insertions(+), 4 deletions(-)

diff --git a/backend/src/graphql/resolver/AdminResolver.test.ts b/backend/src/graphql/resolver/AdminResolver.test.ts
index 6eaec1547..c253d7bb0 100644
--- a/backend/src/graphql/resolver/AdminResolver.test.ts
+++ b/backend/src/graphql/resolver/AdminResolver.test.ts
@@ -1066,7 +1066,7 @@ describe('AdminResolver', () => {
               it('logs the error thrown', () => {
                 expect(logger.error).toBeCalledWith(
                   'No information for available creations with the given creationDate=',
-                  new Date(variables.creationDate).toISOString(),
+                  new Date(variables.creationDate).toString(),
                 )
               })
             })
@@ -1091,7 +1091,7 @@ describe('AdminResolver', () => {
               it('logs the error thrown', () => {
                 expect(logger.error).toBeCalledWith(
                   'No information for available creations with the given creationDate=',
-                  new Date(variables.creationDate).toISOString(),
+                  new Date(variables.creationDate).toString(),
                 )
               })
             })
@@ -1353,7 +1353,7 @@ describe('AdminResolver', () => {
                 expect.objectContaining({
                   errors: [
                     new GraphQLError(
-                      'The amount (1900 GDD) to be created exceeds the amount (600 GDD) still available for this month.',
+                      'The amount (1900 GDD) to be created exceeds the amount (1000 GDD) still available for this month.',
                     ),
                   ],
                 }),
@@ -1362,7 +1362,7 @@ describe('AdminResolver', () => {
 
             it('logs the error thrown', () => {
               expect(logger.error).toBeCalledWith(
-                'The amount (1900 GDD) to be created exceeds the amount (600 GDD) still available for this month.',
+                'The amount (1900 GDD) to be created exceeds the amount (1000 GDD) still available for this month.',
               )
             })
           })
diff --git a/backend/src/graphql/resolver/AdminResolver.ts b/backend/src/graphql/resolver/AdminResolver.ts
index 479d020ea..d4a5e6cf6 100644
--- a/backend/src/graphql/resolver/AdminResolver.ts
+++ b/backend/src/graphql/resolver/AdminResolver.ts
@@ -49,6 +49,7 @@ import {
   validateContribution,
   isStartEndDateValid,
   updateCreations,
+  isValidDateString,
 } from './util/creations'
 import {
   CONTRIBUTIONLINK_NAME_MAX_CHARS,
@@ -237,6 +238,10 @@ export class AdminResolver {
     logger.info(
       `adminCreateContribution(email=${email}, amount=${amount}, memo=${memo}, creationDate=${creationDate})`,
     )
+    if (!isValidDateString(creationDate)) {
+      logger.error(`invalid Date for creationDate=${creationDate}`)
+      throw new Error(`invalid Date for creationDate=${creationDate}`)
+    }
     const emailContact = await UserContact.findOne({
       where: { email },
       withDeleted: true,
diff --git a/backend/src/graphql/resolver/util/creations.ts b/backend/src/graphql/resolver/util/creations.ts
index abf4017cb..f56596998 100644
--- a/backend/src/graphql/resolver/util/creations.ts
+++ b/backend/src/graphql/resolver/util/creations.ts
@@ -137,3 +137,7 @@ export const updateCreations = (creations: Decimal[], contribution: Contribution
   creations[index] = creations[index].plus(contribution.amount.toString())
   return creations
 }
+
+export const isValidDateString = (dateString: string): boolean => {
+  return new Date(dateString).toString() !== 'Invalid Date'
+}