From 2ef0fd18fc7cac74a32c443d00a8227da7f3a227 Mon Sep 17 00:00:00 2001 From: Ulf Gebhardt Date: Fri, 4 Mar 2022 12:44:09 +0100 Subject: [PATCH] fix involvedUserIds calculation --- backend/src/graphql/resolver/TransactionResolver.ts | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/backend/src/graphql/resolver/TransactionResolver.ts b/backend/src/graphql/resolver/TransactionResolver.ts index 9ca9f5fd7..c05e0e3d9 100644 --- a/backend/src/graphql/resolver/TransactionResolver.ts +++ b/backend/src/graphql/resolver/TransactionResolver.ts @@ -91,16 +91,13 @@ export class TransactionResolver { onlyCreations, ) - // find involved users - let involvedUserIds: number[] = [] + // find involved users; I am involved + const involvedUserIds: number[] = [user.id] userTransactions.forEach((transaction: dbTransaction) => { - involvedUserIds.push(transaction.userId) - if (transaction.linkedUserId) { + if (transaction.linkedUserId && !involvedUserIds.includes(transaction.linkedUserId)) { involvedUserIds.push(transaction.linkedUserId) } }) - // remove duplicates - involvedUserIds = involvedUserIds.filter((value, index, self) => self.indexOf(value) === index) // We need to show the name for deleted users for old transactions const involvedDbUsers = await dbUser .createQueryBuilder()