From 3521246cf1208f55923178194a36c65d6a3a2e6c Mon Sep 17 00:00:00 2001
From: einhornimmond <info@einhornimmond.de>
Date: Wed, 17 Dec 2025 14:03:02 +0100
Subject: [PATCH] shorten code, position after variable decleration

---
 .../graphql/resolver/ContributionResolver.ts    | 17 ++++++-----------
 1 file changed, 6 insertions(+), 11 deletions(-)

diff --git a/backend/src/graphql/resolver/ContributionResolver.ts b/backend/src/graphql/resolver/ContributionResolver.ts
index 9523e3a9b..643f983e9 100644
--- a/backend/src/graphql/resolver/ContributionResolver.ts
+++ b/backend/src/graphql/resolver/ContributionResolver.ts
@@ -375,17 +375,9 @@ export class ContributionResolver {
     const result = new ContributionListResult(count, dbContributions)
 
     const uniqueUserIds = new Set<number>()
-    const addIfExist = (userId?: number | null) => {
-      if (userId) {
-        uniqueUserIds.add(userId)
-      }
-    }
-    const getNameById = (userId?: number | null) => {
-      if (userId) {
-        return users.get(userId)
-      }
-      return null
-    }
+    const addIfExist = (userId?: number | null) =>
+      userId ? uniqueUserIds.add(userId) : null
+    
     for (const contribution of result.contributionList) {
       addIfExist(contribution.confirmedBy)
       addIfExist(contribution.updatedBy)
@@ -394,6 +386,9 @@ export class ContributionResolver {
       addIfExist(contribution.deniedBy)
     }
     const users = await findUserNamesByIds(Array.from(uniqueUserIds))
+    const getNameById = (userId?: number | null) =>
+      userId ? users.get(userId) ?? null : null
+
     for (const contribution of result.contributionList) {
       contribution.confirmedByUserName = getNameById(contribution.confirmedBy)
       contribution.updatedByUserName = getNameById(contribution.updatedBy)