From 3fda88856ee674437c653f0eb834388f0ff4360f Mon Sep 17 00:00:00 2001
From: einhornimmond <info@einhornimmond.de>
Date: Tue, 18 Mar 2025 14:41:19 +0100
Subject: [PATCH] delete thread from db even if deleteThread api call failed

---
 backend/src/apis/openai/OpenaiClient.ts | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/backend/src/apis/openai/OpenaiClient.ts b/backend/src/apis/openai/OpenaiClient.ts
index 3a58f103e..80a921871 100644
--- a/backend/src/apis/openai/OpenaiClient.ts
+++ b/backend/src/apis/openai/OpenaiClient.ts
@@ -103,13 +103,15 @@ export class OpenaiClient {
   }
 
   public async deleteThread(threadId: string): Promise<boolean> {
-    const result = await this.openai.beta.threads.del(threadId)
+    const [, result] = await Promise.all([
+      OpenaiThreads.delete({ id: threadId }),
+      this.openai.beta.threads.del(threadId),
+    ])
     if (result.deleted) {
-      await OpenaiThreads.delete({ id: threadId })
       logger.info(`Deleted thread: ${threadId}`)
       return true
     } else {
-      logger.warn(`Failed to delete thread: ${threadId}`)
+      logger.warn(`Failed to delete thread: ${threadId}, remove from db anyway`)
       return false
     }
   }