From 489a043aa73dd588d4c04e49618dd7eab6f577c9 Mon Sep 17 00:00:00 2001
From: elweyn <heine.hannes@gmail.com>
Date: Sun, 23 Jul 2023 16:09:58 +0200
Subject: [PATCH] Refactor backend findUsers query to find user roles.

---
 backend/src/graphql/resolver/UserResolver.ts  |   4 +-
 .../src/graphql/resolver/util/findUsers.ts    | 103 +++++++++++-------
 2 files changed, 63 insertions(+), 44 deletions(-)

diff --git a/backend/src/graphql/resolver/UserResolver.ts b/backend/src/graphql/resolver/UserResolver.ts
index 7b64b548e..6408b9dda 100644
--- a/backend/src/graphql/resolver/UserResolver.ts
+++ b/backend/src/graphql/resolver/UserResolver.ts
@@ -655,9 +655,7 @@ export class UserResolver {
     const clientTimezoneOffset = getClientTimezoneOffset(context)
     const userFields = ['id', 'firstName', 'lastName', 'emailId', 'emailContact', 'deletedAt']
     const [users, count] = await findUsers(
-      userFields.map((fieldName) => {
-        return 'user.' + fieldName
-      }),
+      userFields,
       query,
       filters ?? null,
       currentPage,
diff --git a/backend/src/graphql/resolver/util/findUsers.ts b/backend/src/graphql/resolver/util/findUsers.ts
index d01afb904..a7d7d719c 100644
--- a/backend/src/graphql/resolver/util/findUsers.ts
+++ b/backend/src/graphql/resolver/util/findUsers.ts
@@ -1,10 +1,24 @@
-import { getConnection, Brackets, IsNull, Not } from '@dbTools/typeorm'
+import { IsNull, Not, Like } from '@dbTools/typeorm'
 import { User as DbUser } from '@entity/User'
 
 import { SearchUsersFilters } from '@arg/SearchUsersFilters'
 import { Order } from '@enum/Order'
 
-import { LogError } from '@/server/LogError'
+function likeQuery(searchCriteria: string) {
+  return Like(`%${searchCriteria}%`)
+}
+
+function emailCheckedQuery(filters: SearchUsersFilters) {
+  return filters.byActivated ?? undefined
+}
+
+function deletedAtQuery(filters: SearchUsersFilters | null) {
+  return filters?.byDeleted !== undefined && filters?.byDeleted !== null
+    ? filters.byDeleted
+      ? Not(IsNull())
+      : IsNull()
+    : undefined
+}
 
 export const findUsers = async (
   select: string[],
@@ -14,44 +28,51 @@ export const findUsers = async (
   pageSize: number,
   order = Order.ASC,
 ): Promise<[DbUser[], number]> => {
-  const queryRunner = getConnection().createQueryRunner()
-  try {
-    await queryRunner.connect()
-    const query = queryRunner.manager
-      .createQueryBuilder(DbUser, 'user')
-      .select(select)
-      .withDeleted()
-      .leftJoinAndSelect('user.emailContact', 'emailContact')
-      .where(
-        new Brackets((qb) => {
-          qb.where(
-            'user.firstName like :name or user.lastName like :lastName or emailContact.email like :email',
-            {
-              name: `%${searchCriteria}%`,
-              lastName: `%${searchCriteria}%`,
-              email: `%${searchCriteria}%`,
-            },
-          )
-        }),
-      )
-    if (filters) {
-      if (filters.byActivated !== null) {
-        query.andWhere('emailContact.emailChecked = :value', { value: filters.byActivated })
-      }
-
-      if (filters.byDeleted !== null) {
-        query.andWhere({ deletedAt: filters.byDeleted ? Not(IsNull()) : IsNull() })
-      }
-    }
-
-    return await query
-      .orderBy({ 'user.id': order })
-      .take(pageSize)
-      .skip((currentPage - 1) * pageSize)
-      .getManyAndCount()
-  } catch (err) {
-    throw new LogError('Unable to search users', err)
-  } finally {
-    await queryRunner.release()
+  const where = [
+    {
+      firstName: likeQuery(searchCriteria),
+      deletedAt: deletedAtQuery(filters),
+      emailContact: filters
+        ? {
+            emailChecked: emailCheckedQuery(filters),
+          }
+        : undefined,
+    },
+    {
+      lastName: likeQuery(searchCriteria),
+      deletedAt: deletedAtQuery(filters),
+      emailContact: filters
+        ? {
+            emailChecked: emailCheckedQuery(filters),
+          }
+        : undefined,
+    },
+    {
+      emailContact: {
+        // ...(filters ?? emailChecked: filters.byActivated)
+        emailChecked: filters ? emailCheckedQuery(filters) : undefined,
+        email: likeQuery(searchCriteria),
+      },
+      deletedAt: deletedAtQuery(filters),
+    },
+  ]
+  const selectFind = Object.fromEntries(select.map((item) => [item, true]))
+  const relations = ['emailContact', 'userRoles']
+  const orderFind = {
+    id: order,
   }
+  const take = pageSize
+  const skip = (currentPage - 1) * pageSize
+  const withDeleted = true
+
+  const [users, count] = await DbUser.findAndCount({
+    where,
+    withDeleted,
+    select: selectFind,
+    relations,
+    order: orderFind,
+    take,
+    skip,
+  })
+  return [users, count]
 }