From 4de64ea070f0aa8fdd73b3859da59f9dbce85de1 Mon Sep 17 00:00:00 2001 From: clauspeterhuebner Date: Mon, 9 Feb 2026 23:28:31 +0100 Subject: [PATCH] add logger --- core/src/command/BaseCommand.ts | 20 +++++++++----------- 1 file changed, 9 insertions(+), 11 deletions(-) diff --git a/core/src/command/BaseCommand.ts b/core/src/command/BaseCommand.ts index 46590ae48..1bb7b7b90 100644 --- a/core/src/command/BaseCommand.ts +++ b/core/src/command/BaseCommand.ts @@ -13,38 +13,36 @@ export abstract class BaseCommand implements Command { } abstract execute(): Promise; -/* - validate(): boolean { - return true; // Default implementation, override in subclasses - } - protected validateParams(requiredParams: string[]): boolean { - return requiredParams.every(param => this.params[param] !== undefined); - } -*/ private validateRequiredFields(): void { + const methodLogger = createLogger(`validateRequiredFields`) if(!this.requiredFields || this.requiredFields.length === 0) { - const methodLogger = createLogger(`validateRequiredFields`) methodLogger.debug(`validateRequiredFields() no required fields`) return; } + methodLogger.debug(`validateRequiredFields() requiredFields=${JSON.stringify(this.requiredFields)}`) const missingFields = this.requiredFields.filter(field => this.params[field] === undefined || this.params[field] === null || this.params[field] === '' ); + methodLogger.debug(`validateRequiredFields() missingFields=${JSON.stringify(missingFields)}`) if (missingFields.length > 0) { - const methodLogger = createLogger(`validateRequiredFields`) methodLogger.error(`validateRequiredFields() missing fields: ${missingFields.join(', ')}`) throw new Error(`Missing required fields for ${this.constructor.name}: ${missingFields.join(', ')}`); } } validate(): boolean { - return this.requiredFields.every(field => + const methodLogger = createLogger(`validate`) + methodLogger.debug(`validate() params=${JSON.stringify(this.params)}`) + + const isValid = this.requiredFields.every(field => this.params[field] !== undefined && this.params[field] !== null && this.params[field] !== '' ); + methodLogger.debug(`validate() isValid=${isValid}`) + return isValid; } }