IT4Change/gradido
3
0
Fork 0
mirror of https://github.com/IT4Change/gradido.git synced 2026-03-01 12:44:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

correct validRequiredFields

Browse Source
This commit is contained in:
clauspeterhuebner 2026-02-09 22:59:30 +01:00
parent 4a71bec63c
commit 4eef68e334
2 changed files with 15 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
core/src/command/BaseCommand.ts
View File

@ -1,10 +1,15 @@
import { getLogger } from 'log4js';
import { Command } from './Command'; import { Command } from './Command';
import { LOG4JS_BASE_CATEGORY_NAME } from '../config/const';
const createLogger = (method: string) =>
getLogger(`${LOG4JS_BASE_CATEGORY_NAME}.command.CommandExecutor.${method}`)
export abstract class BaseCommand<T = any> implements Command<T> { export abstract class BaseCommand<T = any> implements Command<T> {
protected abstract requiredFields: string[]; protected abstract requiredFields: string[];
protected constructor(protected readonly params: any = {}) { protected constructor(protected readonly params: any = {}) {
this.validateRequiredFields(); // this.validateRequiredFields();
} }
abstract execute(): Promise<T>; abstract execute(): Promise<T>;
@ -18,11 +23,18 @@ export abstract class BaseCommand<T = any> implements Command<T> {
} }
*/ */
private validateRequiredFields(): void { private validateRequiredFields(): void {
if(!this.requiredFields || this.requiredFields.length === 0) {
const methodLogger = createLogger(`validateRequiredFields`)
methodLogger.debug(`validateRequiredFields() no required fields`)
return;
}
const missingFields = this.requiredFields.filter(field => const missingFields = this.requiredFields.filter(field =>
this.params[field] === undefined || this.params[field] === null || this.params[field] === '' this.params[field] === undefined || this.params[field] === null || this.params[field] === ''
); );
if (missingFields.length > 0) { if (missingFields.length > 0) {
const methodLogger = createLogger(`validateRequiredFields`)
methodLogger.error(`validateRequiredFields() missing fields: ${missingFields.join(', ')}`)
throw new Error(`Missing required fields for ${this.constructor.name}: ${missingFields.join(', ')}`); throw new Error(`Missing required fields for ${this.constructor.name}: ${missingFields.join(', ')}`);
} }
} }

2
core/src/command/commands/SendEmailCommand.ts
View File

@ -18,7 +18,7 @@ export interface SendEmailCommandParams {
} }
export class SendEmailCommand extends BaseCommand<{ success: boolean }> { export class SendEmailCommand extends BaseCommand<{ success: boolean }> {
static readonly SEND_MAIL_COMMAND = 'SEND_MAIL_COMMAND'; static readonly SEND_MAIL_COMMAND = 'SEND_MAIL_COMMAND';
requiredFields: string[] = ['mailType', 'senderComUuid', 'senderGradidoId', 'receiverComUuid', 'receiverGradidoId']; protected requiredFields: string[] = ['mailType', 'senderComUuid', 'senderGradidoId', 'receiverComUuid', 'receiverGradidoId'];
constructor(params: SendEmailCommandParams) { constructor(params: SendEmailCommandParams) {
const methodLogger = createLogger(`constructor`) const methodLogger = createLogger(`constructor`)