add biome to dht-node, fix biome linting errors

dht-node/.eslintignore

@@ -1,4 +0,0 @@
-node_modules
-**/*.min.js
-build
-coverage

dht-node/.eslintrc.js

@@ -1,205 +0,0 @@
-// eslint-disable-next-line import/no-commonjs, import/unambiguous
-module.exports = {
-  root: true,
-  env: {
-    node: true,
-  },
-  parser: '@typescript-eslint/parser',
-  plugins: ['prettier', '@typescript-eslint', 'import', 'n', 'promise'],
-  extends: [
-    'standard',
-    'eslint:recommended',
-    'plugin:prettier/recommended',
-    'plugin:import/recommended',
-    'plugin:import/typescript',
-    // 'plugin:security/recommended',
-    'plugin:@eslint-community/eslint-comments/recommended',
-  ],
-  settings: {
-    'import/parsers': {
-      '@typescript-eslint/parser': ['.ts', '.tsx'],
-    },
-    'import/resolver': {
-      typescript: {
-        project: ['./tsconfig.json'],
-      },
-      node: true,
-    },
-  },
-  rules: {
-    'no-console': 'error',
-    camelcase: 'error',
-    'no-debugger': 'error',
-    'prettier/prettier': [
-      'error',
-      {
-        htmlWhitespaceSensitivity: 'ignore',
-      },
-    ],
-    // import
-    'import/export': 'error',
-    // 'import/no-deprecated': 'error',
-    'import/no-empty-named-blocks': 'error',
-    'import/no-extraneous-dependencies': 'error',
-    'import/no-mutable-exports': 'error',
-    'import/no-unused-modules': 'error',
-    'import/no-named-as-default': 'error',
-    'import/no-named-as-default-member': 'error',
-    'import/no-amd': 'error',
-    'import/no-commonjs': 'error',
-    'import/no-import-module-exports': 'error',
-    'import/no-nodejs-modules': 'off',
-    'import/unambiguous': 'error',
-    'import/default': 'error',
-    'import/named': 'error',
-    'import/namespace': 'error',
-    'import/no-absolute-path': 'error',
-    'import/no-cycle': 'error',
-    'import/no-dynamic-require': 'error',
-    'import/no-internal-modules': 'off',
-    'import/no-relative-packages': 'error',
-    'import/no-relative-parent-imports': ['error', { ignore: ['@/*'] }],
-    'import/no-self-import': 'error',
-    'import/no-unresolved': 'error',
-    'import/no-useless-path-segments': 'error',
-    'import/no-webpack-loader-syntax': 'error',
-    'import/consistent-type-specifier-style': 'error',
-    'import/exports-last': 'off',
-    'import/extensions': 'error',
-    'import/first': 'error',
-    'import/group-exports': 'off',
-    'import/newline-after-import': 'error',
-    'import/no-anonymous-default-export': 'error',
-    'import/no-default-export': 'error',
-    'import/no-duplicates': 'error',
-    'import/no-named-default': 'error',
-    'import/no-namespace': 'error',
-    'import/no-unassigned-import': 'error',
-    'import/order': [
-      'error',
-      {
-        groups: ['builtin', 'external', 'internal', 'parent', 'sibling', 'index', 'object', 'type'],
-        'newlines-between': 'always',
-        pathGroups: [
-          {
-            pattern: '@?*/**',
-            group: 'external',
-            position: 'after',
-          },
-          {
-            pattern: '@/**',
-            group: 'external',
-            position: 'after',
-          },
-        ],
-        alphabetize: {
-          order: 'asc' /* sort in ascending order. Options: ['ignore', 'asc', 'desc'] */,
-          caseInsensitive: true /* ignore case. Options: [true, false] */,
-        },
-        distinctGroup: true,
-      },
-    ],
-    'import/prefer-default-export': 'off',
-    // n
-    'n/handle-callback-err': 'error',
-    'n/no-callback-literal': 'error',
-    'n/no-exports-assign': 'error',
-    'n/no-extraneous-import': 'error',
-    'n/no-extraneous-require': 'error',
-    'n/no-hide-core-modules': 'error',
-    'n/no-missing-import': 'off', // not compatible with typescript
-    'n/no-missing-require': 'error',
-    'n/no-new-require': 'error',
-    'n/no-path-concat': 'error',
-    'n/no-process-exit': 'error',
-    'n/no-unpublished-bin': 'error',
-    'n/no-unpublished-import': 'off', // TODO need to exclude seeds
-    'n/no-unpublished-require': 'error',
-    'n/no-unsupported-features': ['error', { ignores: ['modules'] }],
-    'n/no-unsupported-features/es-builtins': 'error',
-    'n/no-unsupported-features/es-syntax': 'error',
-    'n/no-unsupported-features/node-builtins': 'error',
-    'n/process-exit-as-throw': 'error',
-    'n/shebang': 'error',
-    'n/callback-return': 'error',
-    'n/exports-style': 'error',
-    'n/file-extension-in-import': 'off',
-    'n/global-require': 'error',
-    'n/no-mixed-requires': 'error',
-    'n/no-process-env': 'error',
-    'n/no-restricted-import': 'error',
-    'n/no-restricted-require': 'error',
-    'n/no-sync': 'error',
-    'n/prefer-global/buffer': 'error',
-    'n/prefer-global/console': 'error',
-    'n/prefer-global/process': 'error',
-    'n/prefer-global/text-decoder': 'error',
-    'n/prefer-global/text-encoder': 'error',
-    'n/prefer-global/url': 'error',
-    'n/prefer-global/url-search-params': 'error',
-    'n/prefer-promises/dns': 'error',
-    'n/prefer-promises/fs': 'error',
-    // promise
-    // 'promise/catch-or-return': 'error',
-    // 'promise/no-return-wrap': 'error',
-    // 'promise/param-names': 'error',
-    // 'promise/always-return': 'error',
-    // 'promise/no-native': 'off',
-    // 'promise/no-nesting': 'warn',
-    // 'promise/no-promise-in-callback': 'warn',
-    // 'promise/no-callback-in-promise': 'warn',
-    // 'promise/avoid-new': 'warn',
-    // 'promise/no-new-statics': 'error',
-    // 'promise/no-return-in-finally': 'warn',
-    // 'promise/valid-params': 'warn',
-    // 'promise/prefer-await-to-callbacks': 'error',
-    // 'promise/no-multiple-resolved': 'error',
-    // eslint comments
-    '@eslint-community/eslint-comments/disable-enable-pair': ['error', { allowWholeFile: true }],
-    '@eslint-community/eslint-comments/no-restricted-disable': 'error',
-    '@eslint-community/eslint-comments/no-use': 'off',
-    '@eslint-community/eslint-comments/require-description': 'off',
-  },
-  overrides: [
-    // only for ts files
-    {
-      files: ['*.ts', '*.tsx'],
-      extends: [
-        'plugin:@typescript-eslint/recommended',
-        // 'plugin:@typescript-eslint/recommended-requiring-type-checking',
-        // 'plugin:@typescript-eslint/strict',
-      ],
-      rules: {
-        // allow explicitly defined dangling promises
-        // '@typescript-eslint/no-floating-promises': ['error', { ignoreVoid: true }],
-        'no-void': ['error', { allowAsStatement: true }],
-        // ignore prefer-regexp-exec rule to allow string.match(regex)
-        '@typescript-eslint/prefer-regexp-exec': 'off',
-        // this should not run on ts files: https://github.com/import-js/eslint-plugin-import/issues/2215#issuecomment-911245486
-        'import/unambiguous': 'off',
-        // this is not compatible with typeorm, due to joined tables can be null, but are not defined as nullable
-        '@typescript-eslint/no-unnecessary-condition': 'off',
-      },
-      parserOptions: {
-        tsconfigRootDir: __dirname,
-        project: ['./tsconfig.json'],
-        // this is to properly reference the referenced project database without requirement of compiling it
-        // eslint-disable-next-line camelcase
-        EXPERIMENTAL_useSourceOfProjectReferenceRedirect: true,
-      },
-    },
-    {
-      files: ['*.test.ts'],
-      plugins: ['jest'],
-      rules: {
-        'jest/no-disabled-tests': 'error',
-        'jest/no-focused-tests': 'error',
-        'jest/no-identical-title': 'error',
-        'jest/prefer-to-have-length': 'error',
-        'jest/valid-expect': 'error',
-        '@typescript-eslint/unbound-method': 'off',
-        'jest/unbound-method': 'error',
-      },
-    },
-  ],
-}

dht-node/.prettierrc.js

@@ -1,9 +0,0 @@
-module.exports = {
-  semi: false,
-  printWidth: 100,
-  singleQuote: true,
-  trailingComma: "all",
-  tabWidth: 2,
-  bracketSpacing: true,
-  endOfLine: "auto",
-};

dht-node/package.json

@@ -12,7 +12,8 @@
     "clean": "tsc --build --clean",
     "start": "cross-env TZ=UTC TS_NODE_BASEURL=./build node -r tsconfig-paths/register build/src/index.js",
     "dev": "cross-env TZ=UTC nodemon -w src --ext ts --exec ts-node -r dotenv/config -r tsconfig-paths/register src/index.ts",
-    "lint": "eslint --max-warnings=0 --ext .js,.ts .",
+    "lint": "biome check --error-on-warnings .",
+    "lint:fix": "biome check --error-on-warnings . --write",
     "test": "cross-env TZ=UTC NODE_ENV=development jest --runInBand --forceExit --detectOpenHandles"
   },
   "dependencies": {
@@ -28,24 +29,12 @@
     "uuid": "^8.3.2"
   },
   "devDependencies": {
-    "@eslint-community/eslint-plugin-eslint-comments": "^3.2.1",
+    "@biomejs/biome": "1.9.4",
     "@types/dotenv": "^8.2.0",
     "@types/jest": "^27.0.2",
     "@types/joi": "^17.2.3",
     "@types/node": "^18.11.18",
     "@types/uuid": "^8.3.4",
-    "@typescript-eslint/eslint-plugin": "^5.57.1",
-    "@typescript-eslint/parser": "^5.57.1",
-    "eslint": "^8.37.0",
-    "eslint-config-prettier": "^8.8.0",
-    "eslint-config-standard": "^17.0.0",
-    "eslint-import-resolver-typescript": "^3.5.4",
-    "eslint-plugin-import": "^2.27.5",
-    "eslint-plugin-jest": "^27.2.1",
-    "eslint-plugin-n": "^15.7.0",
-    "eslint-plugin-prettier": "^4.2.1",
-    "eslint-plugin-promise": "^6.1.1",
-    "eslint-plugin-security": "^1.7.1",
     "jest": "^27.2.4",
     "prettier": "^2.8.7",
     "ts-jest": "^27.0.5",

dht-node/src/config/schema.ts

@@ -1,6 +1,6 @@
 import {
-  COMMUNITY_NAME,
   COMMUNITY_DESCRIPTION,
+  COMMUNITY_NAME,
   DB_DATABASE,
   DB_HOST,
   DB_PASSWORD,

dht-node/src/dht_node/index.test.ts

@@ -6,7 +6,7 @@ import { FederatedCommunity as DbFederatedCommunity } from '@entity/FederatedCom
 import DHT from '@hyperswarm/dht'
 import { validate as validateUUID, version as versionUUID } from 'uuid'
 
-import { testEnvironment, cleanDB } from '@test/helpers'
+import { cleanDB, testEnvironment } from '@test/helpers'
 import { logger } from '@test/testSetup'
 
 import { CONFIG } from '@/config'

dht-node/src/dht_node/index.ts

@@ -201,18 +201,18 @@ export const startDHT = async (topic: string): Promise<void> => {
 }
 
 async function writeFederatedHomeCommunityEntries(pubKey: string): Promise<CommunityApi[]> {
-  const homeApiVersions: CommunityApi[] = CONFIG.FEDERATION_COMMUNITY_APIS.split(',').map(function (
-    api,
-  ) {
-    if (!Object.values(ApiVersionType).includes(api as ApiVersionType)) {
-      throw new Error(`Federation: unknown api version: ${api}`)
-    }
-    const comApi: CommunityApi = {
-      api,
-      url: CONFIG.FEDERATION_COMMUNITY_URL + '/api/',
-    }
-    return comApi
-  })
+  const homeApiVersions: CommunityApi[] = CONFIG.FEDERATION_COMMUNITY_APIS.split(',').map(
+    function (api) {
+      if (!Object.values(ApiVersionType).includes(api as ApiVersionType)) {
+        throw new Error(`Federation: unknown api version: ${api}`)
+      }
+      const comApi: CommunityApi = {
+        api,
+        url: CONFIG.FEDERATION_COMMUNITY_URL + '/api/',
+      }
+      return comApi
+    },
+  )
   try {
     // first remove previous existing homeCommunity entries
     await DbFederatedCommunity.createQueryBuilder().delete().where({ foreign: false }).execute()

dht-node/src/index.ts

@@ -1,10 +1,9 @@
-/* eslint-disable @typescript-eslint/no-explicit-any */
 import { startDHT } from '@/dht_node/index'
 
 import { CONFIG } from './config'
 import { logger } from './server/logger'
-import { connection } from './typeorm/connection'
 import { checkDBVersion } from './typeorm/DBVersion'
+import { connection } from './typeorm/connection'
 
 async function main() {
   // open mysql connection
@@ -30,7 +29,7 @@ async function main() {
 }
 
 main().catch((e) => {
-  // eslint-disable-next-line no-console
+  // biome-ignore lint/suspicious/noConsole: no logger present
   console.error(e)
   throw e
 })

dht-node/src/typeorm/connection.ts

@@ -1,6 +1,6 @@
 // TODO This is super weird - since the entities are defined in another project they have their own globals.
 //      We cannot use our connection here, but must use the external typeorm installation
-import { Connection, createConnection, FileLogger } from '@dbTools/typeorm'
+import { Connection, FileLogger, createConnection } from '@dbTools/typeorm'
 import { entities } from '@entity/index'
 
 import { CONFIG } from '@/config'
@@ -26,7 +26,7 @@ export const connection = async (): Promise<Connection | null> => {
       },
     })
   } catch (error) {
-    // eslint-disable-next-line no-console
+    // biome-ignore lint/suspicious/noConsole: no logger present
     console.log(error)
     return null
   }

dht-node/yarn.lock

@@ -298,6 +298,60 @@
   resolved "https://registry.yarnpkg.com/@bcoe/v8-coverage/-/v8-coverage-0.2.3.tgz#75a2e8b51cb758a7553d6804a5932d7aace75c39"
   integrity sha512-0hYQ8SB4Db5zvZB4axdMHGwEaQjkZzFjQiN9LVYvIFB2nSUHW9tYpxWriPrWDASIxiaXax83REcLxuSdnGPZtw==
 
+"@biomejs/biome@1.9.4":
+  version "1.9.4"
+  resolved "https://registry.yarnpkg.com/@biomejs/biome/-/biome-1.9.4.tgz#89766281cbc3a0aae865a7ff13d6aaffea2842bf"
+  integrity sha512-1rkd7G70+o9KkTn5KLmDYXihGoTaIGO9PIIN2ZB7UJxFrWw04CZHPYiMRjYsaDvVV7hP1dYNRLxSANLaBFGpog==
+  optionalDependencies:
+    "@biomejs/cli-darwin-arm64" "1.9.4"
+    "@biomejs/cli-darwin-x64" "1.9.4"
+    "@biomejs/cli-linux-arm64" "1.9.4"
+    "@biomejs/cli-linux-arm64-musl" "1.9.4"
+    "@biomejs/cli-linux-x64" "1.9.4"
+    "@biomejs/cli-linux-x64-musl" "1.9.4"
+    "@biomejs/cli-win32-arm64" "1.9.4"
+    "@biomejs/cli-win32-x64" "1.9.4"
+
+"@biomejs/cli-darwin-arm64@1.9.4":
+  version "1.9.4"
+  resolved "https://registry.yarnpkg.com/@biomejs/cli-darwin-arm64/-/cli-darwin-arm64-1.9.4.tgz#dfa376d23a54a2d8f17133c92f23c1bf2e62509f"
+  integrity sha512-bFBsPWrNvkdKrNCYeAp+xo2HecOGPAy9WyNyB/jKnnedgzl4W4Hb9ZMzYNbf8dMCGmUdSavlYHiR01QaYR58cw==
+
+"@biomejs/cli-darwin-x64@1.9.4":
+  version "1.9.4"
+  resolved "https://registry.yarnpkg.com/@biomejs/cli-darwin-x64/-/cli-darwin-x64-1.9.4.tgz#eafc2ce3849d385fc02238aad1ca4a73395a64d9"
+  integrity sha512-ngYBh/+bEedqkSevPVhLP4QfVPCpb+4BBe2p7Xs32dBgs7rh9nY2AIYUL6BgLw1JVXV8GlpKmb/hNiuIxfPfZg==
+
+"@biomejs/cli-linux-arm64-musl@1.9.4":
+  version "1.9.4"
+  resolved "https://registry.yarnpkg.com/@biomejs/cli-linux-arm64-musl/-/cli-linux-arm64-musl-1.9.4.tgz#d780c3e01758fc90f3268357e3f19163d1f84fca"
+  integrity sha512-v665Ct9WCRjGa8+kTr0CzApU0+XXtRgwmzIf1SeKSGAv+2scAlW6JR5PMFo6FzqqZ64Po79cKODKf3/AAmECqA==
+
+"@biomejs/cli-linux-arm64@1.9.4":
+  version "1.9.4"
+  resolved "https://registry.yarnpkg.com/@biomejs/cli-linux-arm64/-/cli-linux-arm64-1.9.4.tgz#8ed1dd0e89419a4b66a47f95aefb8c46ae6041c9"
+  integrity sha512-fJIW0+LYujdjUgJJuwesP4EjIBl/N/TcOX3IvIHJQNsAqvV2CHIogsmA94BPG6jZATS4Hi+xv4SkBBQSt1N4/g==
+
+"@biomejs/cli-linux-x64-musl@1.9.4":
+  version "1.9.4"
+  resolved "https://registry.yarnpkg.com/@biomejs/cli-linux-x64-musl/-/cli-linux-x64-musl-1.9.4.tgz#f36982b966bd671a36671e1de4417963d7db15fb"
+  integrity sha512-gEhi/jSBhZ2m6wjV530Yy8+fNqG8PAinM3oV7CyO+6c3CEh16Eizm21uHVsyVBEB6RIM8JHIl6AGYCv6Q6Q9Tg==
+
+"@biomejs/cli-linux-x64@1.9.4":
+  version "1.9.4"
+  resolved "https://registry.yarnpkg.com/@biomejs/cli-linux-x64/-/cli-linux-x64-1.9.4.tgz#a0a7f56680c76b8034ddc149dbf398bdd3a462e8"
+  integrity sha512-lRCJv/Vi3Vlwmbd6K+oQ0KhLHMAysN8lXoCI7XeHlxaajk06u7G+UsFSO01NAs5iYuWKmVZjmiOzJ0OJmGsMwg==
+
+"@biomejs/cli-win32-arm64@1.9.4":
+  version "1.9.4"
+  resolved "https://registry.yarnpkg.com/@biomejs/cli-win32-arm64/-/cli-win32-arm64-1.9.4.tgz#e2ef4e0084e76b7e26f0fc887c5ef1265ea56200"
+  integrity sha512-tlbhLk+WXZmgwoIKwHIHEBZUwxml7bRJgk0X2sPyNR3S93cdRq6XulAZRQJ17FYGGzWne0fgrXBKpl7l4M87Hg==
+
+"@biomejs/cli-win32-x64@1.9.4":
+  version "1.9.4"
+  resolved "https://registry.yarnpkg.com/@biomejs/cli-win32-x64/-/cli-win32-x64-1.9.4.tgz#4c7afa90e3970213599b4095e62f87e5972b2340"
+  integrity sha512-8Y5wMhVIPaWe6jw2H+KlEm4wP/f7EW3810ZLmDlrEEy5KvBsb9ECEfu/kMWD484ijfQ8+nIi0giMgu9g1UAuuA==
+
 "@cspotcode/source-map-support@^0.8.0":
   version "0.8.1"
   resolved "https://registry.yarnpkg.com/@cspotcode/source-map-support/-/source-map-support-0.8.1.tgz#00629c35a688e05a88b1cda684fb9d5e73f000a1"