From 5119ea1f301c1e310fc410862a6b4eeeceed49f0 Mon Sep 17 00:00:00 2001
From: Ulf Gebhardt <ulf.gebhardt@webcraft-media.de>
Date: Wed, 7 Jun 2023 13:01:52 +0200
Subject: [PATCH] enable most eslint-plugin-n rules

---
 database/.eslintrc.js        | 68 ++++++++++++++++++------------------
 database/package.json        |  3 ++
 database/src/config/index.ts |  2 +-
 3 files changed, 38 insertions(+), 35 deletions(-)

diff --git a/database/.eslintrc.js b/database/.eslintrc.js
index 587506ecc..896a7ed68 100644
--- a/database/.eslintrc.js
+++ b/database/.eslintrc.js
@@ -101,43 +101,43 @@ module.exports = {
     // ],
     // 'import/prefer-default-export': 'off',
     // n
-    // 'n/handle-callback-err': 'error',
-    // 'n/no-callback-literal': 'error',
-    // 'n/no-exports-assign': 'error',
+    'n/handle-callback-err': 'error',
+    'n/no-callback-literal': 'error',
+    'n/no-exports-assign': 'error',
     // 'n/no-extraneous-import': 'error',
-    // 'n/no-extraneous-require': 'error',
-    // 'n/no-hide-core-modules': 'error',
-    // 'n/no-missing-import': 'off', // not compatible with typescript
-    // 'n/no-missing-require': 'error',
-    // 'n/no-new-require': 'error',
-    // 'n/no-path-concat': 'error',
+    'n/no-extraneous-require': 'error',
+    'n/no-hide-core-modules': 'error',
+    'n/no-missing-import': 'off', // not compatible with typescript
+    'n/no-missing-require': 'error',
+    'n/no-new-require': 'error',
+    'n/no-path-concat': 'error',
     // 'n/no-process-exit': 'error',
-    // 'n/no-unpublished-bin': 'error',
-    // 'n/no-unpublished-import': 'off', // TODO need to exclude seeds
-    // 'n/no-unpublished-require': 'error',
-    // 'n/no-unsupported-features': ['error', { ignores: ['modules'] }],
-    // 'n/no-unsupported-features/es-builtins': 'error',
-    // 'n/no-unsupported-features/es-syntax': 'error',
-    // 'n/no-unsupported-features/node-builtins': 'error',
-    // 'n/process-exit-as-throw': 'error',
-    // 'n/shebang': 'error',
-    // 'n/callback-return': 'error',
-    // 'n/exports-style': 'error',
-    // 'n/file-extension-in-import': 'off',
-    // 'n/global-require': 'error',
-    // 'n/no-mixed-requires': 'error',
-    // 'n/no-process-env': 'error',
-    // 'n/no-restricted-import': 'error',
-    // 'n/no-restricted-require': 'error',
+    'n/no-unpublished-bin': 'error',
+    'n/no-unpublished-import': 'off', // TODO need to exclude seeds
+    'n/no-unpublished-require': 'error',
+    'n/no-unsupported-features': ['error', { ignores: ['modules'] }],
+    'n/no-unsupported-features/es-builtins': 'error',
+    'n/no-unsupported-features/es-syntax': 'error',
+    'n/no-unsupported-features/node-builtins': 'error',
+    'n/process-exit-as-throw': 'error',
+    'n/shebang': 'error',
+    'n/callback-return': 'error',
+    'n/exports-style': 'error',
+    'n/file-extension-in-import': 'off',
+    'n/global-require': 'error',
+    'n/no-mixed-requires': 'error',
+    'n/no-process-env': 'error',
+    'n/no-restricted-import': 'error',
+    'n/no-restricted-require': 'error',
     // 'n/no-sync': 'error',
-    // 'n/prefer-global/buffer': 'error',
-    // 'n/prefer-global/console': 'error',
-    // 'n/prefer-global/process': 'error',
-    // 'n/prefer-global/text-decoder': 'error',
-    // 'n/prefer-global/text-encoder': 'error',
-    // 'n/prefer-global/url': 'error',
-    // 'n/prefer-global/url-search-params': 'error',
-    // 'n/prefer-promises/dns': 'error',
+    'n/prefer-global/buffer': 'error',
+    'n/prefer-global/console': 'error',
+    'n/prefer-global/process': 'error',
+    'n/prefer-global/text-decoder': 'error',
+    'n/prefer-global/text-encoder': 'error',
+    'n/prefer-global/url': 'error',
+    'n/prefer-global/url-search-params': 'error',
+    'n/prefer-promises/dns': 'error',
     // 'n/prefer-promises/fs': 'error',
     // promise
     // 'promise/catch-or-return': 'error',
diff --git a/database/package.json b/database/package.json
index 65b76ca14..abc69d21d 100644
--- a/database/package.json
+++ b/database/package.json
@@ -48,5 +48,8 @@
     "ts-mysql-migrate": "^1.0.2",
     "typeorm": "^0.2.38",
     "uuid": "^8.3.2"
+  },
+  "engines": {
+    "node": ">=14"
   }
 }
diff --git a/database/src/config/index.ts b/database/src/config/index.ts
index ba41f11d4..2da46f777 100644
--- a/database/src/config/index.ts
+++ b/database/src/config/index.ts
@@ -1,4 +1,4 @@
-// ATTENTION: DO NOT PUT ANY SECRETS IN HERE (or the .env)
+/* eslint-disable n/no-process-env */
 
 import dotenv from 'dotenv'
 dotenv.config()