diff --git a/admin/src/components/CreationFormular.spec.js b/admin/src/components/CreationFormular.spec.js index f2ce36908..1d3338d93 100644 --- a/admin/src/components/CreationFormular.spec.js +++ b/admin/src/components/CreationFormular.spec.js @@ -422,12 +422,14 @@ describe('CreationFormular', () => { }) it('toasts two errors', () => { - expect(toastErrorSpy).toBeCalledWith( - 'Could not created PendingCreation for bob@baumeister.de', - ) - expect(toastErrorSpy).toBeCalledWith( - 'Could not created PendingCreation for bibi@bloxberg.de', - ) + expect(toastErrorSpy).toBeCalledWith([ + 'creation_form.creation_failed', + { email: 'bob@baumeister.de' }, + ]) + expect(toastErrorSpy).toBeCalledWith([ + 'creation_form.creation_failed', + { email: 'bibi@bloxberg.de' }, + ]) }) }) diff --git a/admin/src/components/CreationFormular.vue b/admin/src/components/CreationFormular.vue index a705bbba8..57361348d 100644 --- a/admin/src/components/CreationFormular.vue +++ b/admin/src/components/CreationFormular.vue @@ -171,9 +171,8 @@ export default { result.data.createPendingCreations.successfulCreation.length, ) if (result.data.createPendingCreations.failedCreation.length > 0) { - result.data.createPendingCreations.failedCreation.forEach((failed) => { - // TODO: Please localize this error message - this.toastError('Could not created PendingCreation for ' + failed) + result.data.createPendingCreations.failedCreation.forEach((email) => { + this.toastError(this.$t('creation_form.creation_failed', { email })) }) } this.$emit('remove-all-bookmark') diff --git a/admin/src/locales/de.json b/admin/src/locales/de.json index feae344c4..4c85db8db 100644 --- a/admin/src/locales/de.json +++ b/admin/src/locales/de.json @@ -5,6 +5,7 @@ "confirmed": "bestätigt", "creation": "Schöpfung", "creation_form": { + "creation_failed": "Ausstehende Schöpfung für {email} konnte nicht erzeugt werden.", "creation_for": "Aktives Grundeinkommen für", "enter_text": "Text eintragen", "form": "Schöpfungsformular", diff --git a/admin/src/locales/en.json b/admin/src/locales/en.json index e9ccec7f8..b7a7b5013 100644 --- a/admin/src/locales/en.json +++ b/admin/src/locales/en.json @@ -5,6 +5,7 @@ "confirmed": "confirmed", "creation": "Creation", "creation_form": { + "creation_failed": "Could not create pending creation for {email}", "creation_for": "Active Basic Income for", "enter_text": "Enter text", "form": "Creation form", diff --git a/admin/src/mixins/toaster.js b/admin/src/mixins/toaster.js index b9ce02db2..9f79b91e8 100644 --- a/admin/src/mixins/toaster.js +++ b/admin/src/mixins/toaster.js @@ -13,7 +13,8 @@ export const toasters = { }) }, toast(message, options) { - message = message.replace(/^GraphQL error: /, '') + // for unit tests, check that replace is present + if (message.replace) message = message.replace(/^GraphQL error: /, '') this.$bvToast.toast(message, { autoHideDelay: 5000, appendToast: true,