From 5f42748358f6db3adb619b12805f4c195c80b54a Mon Sep 17 00:00:00 2001
From: Moriz Wahl <moriz.wahl@gmx.de>
Date: Wed, 9 Mar 2022 18:25:17 +0100
Subject: [PATCH] error message and constant for transaction link duration

---
 backend/src/graphql/resolver/TransactionLinkResolver.ts | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/backend/src/graphql/resolver/TransactionLinkResolver.ts b/backend/src/graphql/resolver/TransactionLinkResolver.ts
index 76ed41308..d60146096 100644
--- a/backend/src/graphql/resolver/TransactionLinkResolver.ts
+++ b/backend/src/graphql/resolver/TransactionLinkResolver.ts
@@ -23,10 +23,11 @@ export const transactionLinkCode = (date: Date): string => {
   )
 }
 
+const CODE_VALID_DAYS_DURATION = 14
+
 const transactionLinkExpireDate = (date: Date): Date => {
   const validUntil = new Date(date)
-  // valid for 14 days
-  return new Date(validUntil.setDate(date.getDate() + 14))
+  return new Date(validUntil.setDate(date.getDate() + CODE_VALID_DAYS_DURATION))
 }
 
 @Resolver()
@@ -60,8 +61,8 @@ export class TransactionLinkResolver {
     transactionLink.createdAt = createdDate
     transactionLink.validUntil = validUntil
     transactionLink.showEmail = showEmail
-    await dbTransactionLink.save(transactionLink).catch((error) => {
-      throw error
+    await dbTransactionLink.save(transactionLink).catch(() => {
+      throw new Error('Unable to save transaction link')
     })
 
     return new TransactionLink(transactionLink, new User(user))