Merge remote-tracking branch 'origin/master' into 2800-feature-backend-read-communities-data-from-database

2025-12-13 07:45:54 +00:00 · 2023-03-09 21:11:16 +01:00 · 2023-03-09 21:11:16 +01:00 · 6f1ce2db23
commit 6f1ce2db23
parent 534e77858f 2f6c5b92a9
6 changed files with 93 additions and 70 deletions
--- a/admin/src/components/ContributionMessages/ContributionMessagesList.spec.js
+++ b/admin/src/components/ContributionMessages/ContributionMessagesList.spec.js
@ -10,6 +10,7 @@ describe('ContributionMessagesList', () => {

  const propsData = {
    contributionId: 42,
+    contributionState: 'PENDING',
  }

  const mocks = {
--- a/admin/src/components/ContributionMessages/ContributionMessagesList.vue
+++ b/admin/src/components/ContributionMessages/ContributionMessagesList.vue
@ -1,17 +1,18 @@
 <template>
  <div class="contribution-messages-list">
    <b-container>
-      {{ messages.lenght }}
      <div v-for="message in messages" v-bind:key="message.id">
        <contribution-messages-list-item :message="message" />
      </div>
    </b-container>

-    <contribution-messages-formular
-      :contributionId="contributionId"
-      @get-list-contribution-messages="getListContributionMessages"
-      @update-state="updateState"
-    />
+    <div v-if="contributionState === 'PENDING' || contributionState === 'IN_PROGRESS'">
+      <contribution-messages-formular
+        :contributionId="contributionId"
+        @get-list-contribution-messages="getListContributionMessages"
+        @update-state="updateState"
+      />
+    </div>
  </div>
 </template>
 <script>
@ -30,6 +31,10 @@ export default {
      type: Number,
      required: true,
    },
+    contributionState: {
+      type: String,
+      required: true,
+    },
  },
  data() {
    return {
--- a/admin/src/components/Tables/OpenCreationsTable.vue
+++ b/admin/src/components/Tables/OpenCreationsTable.vue
@ -13,17 +13,19 @@
        <b-icon :icon="getStatusIcon(row.item.state)"></b-icon>
      </template>
      <template #cell(bookmark)="row">
-        <b-button
-          variant="danger"
-          size="md"
-          @click="$emit('show-overlay', row.item, 'delete')"
-          class="mr-2"
-        >
-          <b-icon icon="trash" variant="light"></b-icon>
-        </b-button>
+        <div v-if="!myself(row.item)">
+          <b-button
+            variant="danger"
+            size="md"
+            @click="$emit('show-overlay', row.item, 'delete')"
+            class="mr-2"
+          >
+            <b-icon icon="trash" variant="light"></b-icon>
+          </b-button>
+        </div>
      </template>
      <template #cell(editCreation)="row">
-        <div v-if="$store.state.moderator.id !== row.item.userId">
+        <div v-if="!myself(row.item)">
          <b-button
            v-if="row.item.moderator"
            variant="info"
@ -36,30 +38,26 @@
          <b-button v-else @click="rowToggleDetails(row, 0)">
            <b-icon icon="chat-dots"></b-icon>
            <b-icon
-              v-if="row.item.state === 'PENDING' && row.item.messageCount > 0"
+              v-if="row.item.state === 'PENDING' && row.item.messagesCount > 0"
              icon="exclamation-circle-fill"
              variant="warning"
            ></b-icon>
            <b-icon
-              v-if="row.item.state === 'IN_PROGRESS' && row.item.messageCount > 0"
+              v-if="row.item.state === 'IN_PROGRESS' && row.item.messagesCount > 0"
              icon="question-diamond"
-              variant="light"
+              variant="warning"
+              class="pl-1"
            ></b-icon>
          </b-button>
        </div>
      </template>
-      <template #cell(reActive)>
-        <b-button variant="warning" size="md" class="mr-2">
-          <b-icon icon="arrow-up" variant="light"></b-icon>
-        </b-button>
-      </template>
      <template #cell(chatCreation)="row">
        <b-button v-if="row.item.messagesCount > 0" @click="rowToggleDetails(row, 0)">
          <b-icon icon="chat-dots"></b-icon>
        </b-button>
      </template>
      <template #cell(deny)="row">
-        <div v-if="$store.state.moderator.id !== row.item.userId">
+        <div v-if="!myself(row.item)">
          <b-button
            variant="warning"
            size="md"
@ -71,7 +69,7 @@
        </div>
      </template>
      <template #cell(confirm)="row">
-        <div v-if="$store.state.moderator.id !== row.item.userId">
+        <div v-if="!myself(row.item)">
          <b-button
            variant="success"
            size="md"
@ -104,6 +102,7 @@
            <div v-else>
              <contribution-messages-list
                :contributionId="row.item.id"
+                :contributionState="row.item.state"
                @update-state="updateState"
                @update-user-data="updateUserData"
              />
@ -158,13 +157,22 @@ export default {
    }
  },
  methods: {
+    myself(item) {
+      return (
+        `${item.firstName} ${item.lastName}` ===
+        `${this.$store.state.moderator.firstName} ${this.$store.state.moderator.lastName}`
+      )
+    },
    getStatusIcon(status) {
      return iconMap[status] ? iconMap[status] : 'default-icon'
    },
    rowClass(item, type) {
      if (!item || type !== 'row') return
      if (item.state === 'CONFIRMED') return 'table-success'
-      if (item.state === 'DENIED') return 'table-info'
+      if (item.state === 'DENIED') return 'table-warning'
+      if (item.state === 'DELETED') return 'table-danger'
+      if (item.state === 'IN_PROGRESS') return 'table-primary'
+      if (item.state === 'PENDING') return 'table-primary'
    },
    updateCreationData(data) {
      const row = data.row
--- a/admin/src/locales/de.json
+++ b/admin/src/locales/de.json
@ -63,7 +63,6 @@
  "deleted_user": "Alle gelöschten Nutzer",
  "delete_user": "Nutzer löschen",
  "deny": "Ablehnen",
-  "edit": "Bearbeiten",
  "enabled": "aktiviert",
  "error": "Fehler",
  "expired": "abgelaufen",
@ -101,7 +100,6 @@
  "message": {
    "request": "Die Anfrage wurde gesendet."
  },
-  "mod": "Mod",
  "moderator": "Moderator",
  "name": "Name",
  "navbar": {
--- a/admin/src/locales/en.json
+++ b/admin/src/locales/en.json
@ -34,12 +34,12 @@
    "all": "All",
    "confirms": "Confirmed",
    "deleted": "Deleted",
-    "denied": "Denied",
+    "denied": "Rejected",
    "open": "Open"
  },
-  "created": "Confirmed",
-  "createdAt": "Created",
-  "creation": "Creation",
+  "created": "Created for",
+  "createdAt": "Created at",
+  "creation": "Amount",
  "creationList": "Creation list",
  "creation_form": {
    "creation_for": "Active Basic Income for",
@ -53,7 +53,7 @@
    "toasted": "Open creation ({value} GDD) for {email} has been saved and is ready for confirmation.",
    "toasted_created": "Creation has been successfully saved",
    "toasted_delete": "Open creation has been deleted",
-    "toasted_denied": "Open creation has been denied",
+    "toasted_denied": "Open creation has been rejected",
    "toasted_update": "Open creation {value} GDD) for {email} has been changed and is ready for confirmation.",
    "update_creation": "Creation update"
  },
@ -63,7 +63,6 @@
  "deleted_user": "All deleted user",
  "delete_user": "Delete user",
  "deny": "Reject",
-  "edit": "Edit",
  "enabled": "enabled",
  "error": "Error",
  "expired": "expired",
@ -87,7 +86,7 @@
    "transactionlist": {
      "confirmed": "When was it confirmed by a moderator / admin.",
      "periods": "For what period was it submitted by the member.",
-      "state": "[PENDING = submitted, DELETED = deleted, IN_PROGRESS = in dialogue with moderator, DENIED = denied, CONFIRMED = confirmed]",
+      "state": "[PENDING = submitted, DELETED = deleted, IN_PROGRESS = in dialogue with moderator, DENIED = rejected, CONFIRMED = confirmed]",
      "submitted": "When was it submitted by the member"
    }
  },
@ -101,7 +100,6 @@
  "message": {
    "request": "Request has been sent."
  },
-  "mod": "Mod",
  "moderator": "Moderator",
  "name": "Name",
  "navbar": {
--- a/admin/src/pages/CreationConfirm.vue
+++ b/admin/src/pages/CreationConfirm.vue
@ -5,25 +5,37 @@
      <b-tabs v-model="tabIndex" content-class="mt-3" fill>
        <b-tab active :title-link-attributes="{ 'data-test': 'open' }">
          <template #title>
+            <b-icon icon="bell-fill" variant="primary"></b-icon>
            {{ $t('contributions.open') }}
            <b-badge v-if="$store.state.openCreations > 0" variant="danger">
              {{ $store.state.openCreations }}
            </b-badge>
          </template>
        </b-tab>
-        <b-tab
-          :title="$t('contributions.confirms')"
-          :title-link-attributes="{ 'data-test': 'confirmed' }"
-        />
-        <b-tab
-          :title="$t('contributions.denied')"
-          :title-link-attributes="{ 'data-test': 'denied' }"
-        />
-        <b-tab
-          :title="$t('contributions.deleted')"
-          :title-link-attributes="{ 'data-test': 'deleted' }"
-        />
-        <b-tab :title="$t('contributions.all')" :title-link-attributes="{ 'data-test': 'all' }" />
+        <b-tab :title-link-attributes="{ 'data-test': 'confirmed' }">
+          <template #title>
+            <b-icon icon="check" variant="success"></b-icon>
+            {{ $t('contributions.confirms') }}
+          </template>
+        </b-tab>
+        <b-tab :title-link-attributes="{ 'data-test': 'denied' }">
+          <template #title>
+            <b-icon icon="x-circle" variant="warning"></b-icon>
+            {{ $t('contributions.denied') }}
+          </template>
+        </b-tab>
+        <b-tab :title-link-attributes="{ 'data-test': 'deleted' }">
+          <template #title>
+            <b-icon icon="trash" variant="danger"></b-icon>
+            {{ $t('contributions.deleted') }}
+          </template>
+        </b-tab>
+        <b-tab :title-link-attributes="{ 'data-test': 'all' }">
+          <template #title>
+            <b-icon icon="list"></b-icon>
+            {{ $t('contributions.all') }}
+          </template>
+        </b-tab>
      </b-tabs>
    </div>
    <open-creations-table
@ -172,6 +184,9 @@ export default {
      this.items.find((obj) => obj.id === id).messagesCount++
      this.items.find((obj) => obj.id === id).state = 'IN_PROGRESS'
    },
+    formatDateOrDash(value) {
+      return value ? this.$d(new Date(value), 'short') : '—'
+    },
  },
  computed: {
    fields() {
@ -180,7 +195,6 @@ export default {
          // open contributions
          { key: 'bookmark', label: this.$t('delete') },
          { key: 'deny', label: this.$t('deny') },
-          { key: 'email', label: this.$t('e_mail') },
          { key: 'firstName', label: this.$t('firstname') },
          { key: 'lastName', label: this.$t('lastname') },
          {
@ -195,11 +209,11 @@ export default {
            key: 'contributionDate',
            label: this.$t('created'),
            formatter: (value) => {
-              return this.$d(new Date(value), 'short')
+              return this.formatDateOrDash(value)
            },
          },
          { key: 'moderator', label: this.$t('moderator') },
-          { key: 'editCreation', label: this.$t('edit') },
+          { key: 'editCreation', label: this.$t('chat') },
          { key: 'confirm', label: this.$t('save') },
        ],
        [
@ -218,28 +232,28 @@ export default {
            key: 'contributionDate',
            label: this.$t('created'),
            formatter: (value) => {
-              return this.$d(new Date(value), 'short')
+              return this.formatDateOrDash(value)
            },
          },
          {
            key: 'createdAt',
            label: this.$t('createdAt'),
            formatter: (value) => {
-              return this.$d(new Date(value), 'short')
+              return this.formatDateOrDash(value)
            },
          },
          {
            key: 'confirmedAt',
            label: this.$t('contributions.confirms'),
            formatter: (value) => {
-              return this.$d(new Date(value), 'short')
+              return this.formatDateOrDash(value)
            },
          },
+          { key: 'confirmedBy', label: this.$t('moderator') },
          { key: 'chatCreation', label: this.$t('chat') },
        ],
        [
          // denied contributions
-          { key: 'reActive', label: 'reActive' },
          { key: 'firstName', label: this.$t('firstname') },
          { key: 'lastName', label: this.$t('lastname') },
          {
@ -254,29 +268,28 @@ export default {
            key: 'contributionDate',
            label: this.$t('created'),
            formatter: (value) => {
-              return this.$d(new Date(value), 'short')
+              return this.formatDateOrDash(value)
            },
          },
          {
            key: 'createdAt',
            label: this.$t('createdAt'),
            formatter: (value) => {
-              return this.$d(new Date(value), 'short')
+              return this.formatDateOrDash(value)
            },
          },
          {
            key: 'deniedAt',
            label: this.$t('contributions.denied'),
            formatter: (value) => {
-              return this.$d(new Date(value), 'short')
+              return this.formatDateOrDash(value)
            },
          },
-          { key: 'deniedBy', label: this.$t('mod') },
+          { key: 'deniedBy', label: this.$t('moderator') },
          { key: 'chatCreation', label: this.$t('chat') },
        ],
        [
          // deleted contributions
-          { key: 'reActive', label: 'reActive' },
          { key: 'firstName', label: this.$t('firstname') },
          { key: 'lastName', label: this.$t('lastname') },
          {
@ -291,29 +304,29 @@ export default {
            key: 'contributionDate',
            label: this.$t('created'),
            formatter: (value) => {
-              return this.$d(new Date(value), 'short')
+              return this.formatDateOrDash(value)
            },
          },
          {
            key: 'createdAt',
            label: this.$t('createdAt'),
            formatter: (value) => {
-              return this.$d(new Date(value), 'short')
+              return this.formatDateOrDash(value)
            },
          },
          {
            key: 'deletedAt',
            label: this.$t('contributions.deleted'),
            formatter: (value) => {
-              return this.$d(new Date(value), 'short')
+              return this.formatDateOrDash(value)
            },
          },
-          { key: 'deletedBy', label: this.$t('mod') },
+          { key: 'deletedBy', label: this.$t('moderator') },
          { key: 'chatCreation', label: this.$t('chat') },
        ],
        [
          // all contributions
-          { key: 'state', label: 'state' },
+          { key: 'state', label: this.$t('status') },
          { key: 'firstName', label: this.$t('firstname') },
          { key: 'lastName', label: this.$t('lastname') },
          {
@ -328,24 +341,24 @@ export default {
            key: 'contributionDate',
            label: this.$t('created'),
            formatter: (value) => {
-              return this.$d(new Date(value), 'short')
+              return this.formatDateOrDash(value)
            },
          },
          {
            key: 'createdAt',
            label: this.$t('createdAt'),
            formatter: (value) => {
-              return this.$d(new Date(value), 'short')
+              return this.formatDateOrDash(value)
            },
          },
          {
            key: 'confirmedAt',
            label: this.$t('contributions.confirms'),
            formatter: (value) => {
-              return this.$d(new Date(value), 'short')
+              return this.formatDateOrDash(value)
            },
          },
-          { key: 'confirmedBy', label: this.$t('mod') },
+          { key: 'confirmedBy', label: this.$t('moderator') },
          { key: 'chatCreation', label: this.$t('chat') },
        ],
      ][this.tabIndex]