From 789188c64fab551a52a4ca9aecee70d3320e7045 Mon Sep 17 00:00:00 2001 From: einhornimmond Date: Fri, 17 Nov 2023 08:29:29 +0100 Subject: [PATCH] add abstract Keyword to Abstract Class --- ...tion.role.ts => AbstractUnconfirmedContribution.role.ts} | 0 .../UnconfirmedContributionAdmin.role.ts | 6 +++--- .../UnconfirmedContributionUser.role.ts | 6 +++--- 3 files changed, 6 insertions(+), 6 deletions(-) rename backend/src/interactions/updateUnconfirmedContribution/{UnconfirmedContribution.role.ts => AbstractUnconfirmedContribution.role.ts} (100%) diff --git a/backend/src/interactions/updateUnconfirmedContribution/UnconfirmedContribution.role.ts b/backend/src/interactions/updateUnconfirmedContribution/AbstractUnconfirmedContribution.role.ts similarity index 100% rename from backend/src/interactions/updateUnconfirmedContribution/UnconfirmedContribution.role.ts rename to backend/src/interactions/updateUnconfirmedContribution/AbstractUnconfirmedContribution.role.ts diff --git a/backend/src/interactions/updateUnconfirmedContribution/UnconfirmedContributionAdmin.role.ts b/backend/src/interactions/updateUnconfirmedContribution/UnconfirmedContributionAdmin.role.ts index c55283272..46325ff3a 100644 --- a/backend/src/interactions/updateUnconfirmedContribution/UnconfirmedContributionAdmin.role.ts +++ b/backend/src/interactions/updateUnconfirmedContribution/UnconfirmedContributionAdmin.role.ts @@ -7,9 +7,9 @@ import { AdminUpdateContributionArgs } from '@/graphql/arg/AdminUpdateContributi import { ContributionStatus } from '@/graphql/enum/ContributionStatus' import { LogError } from '@/server/LogError' -import { UnconfirmedContributionRole } from './UnconfirmedContribution.role' +import { AbstractUnconfirmedContributionRole } from './AbstractUnconfirmedContribution.role' -export class UnconfirmedContributionAdminRole extends UnconfirmedContributionRole { +export class UnconfirmedContributionAdminRole extends AbstractUnconfirmedContributionRole { public constructor( contribution: Contribution, private updateData: AdminUpdateContributionArgs, @@ -32,7 +32,7 @@ export class UnconfirmedContributionAdminRole extends UnconfirmedContributionRol } // eslint-disable-next-line @typescript-eslint/no-unused-vars - protected checkAuthorization(user: User, role: Role): UnconfirmedContributionRole { + protected checkAuthorization(user: User, role: Role): AbstractUnconfirmedContributionRole { if ( !role.hasRight(RIGHTS.MODERATOR_UPDATE_CONTRIBUTION_MEMO) && this.self.moderatorId === null diff --git a/backend/src/interactions/updateUnconfirmedContribution/UnconfirmedContributionUser.role.ts b/backend/src/interactions/updateUnconfirmedContribution/UnconfirmedContributionUser.role.ts index 85374e3e8..8716d0596 100644 --- a/backend/src/interactions/updateUnconfirmedContribution/UnconfirmedContributionUser.role.ts +++ b/backend/src/interactions/updateUnconfirmedContribution/UnconfirmedContributionUser.role.ts @@ -5,9 +5,9 @@ import { ContributionArgs } from '@/graphql/arg/ContributionArgs' import { ContributionStatus } from '@/graphql/enum/ContributionStatus' import { LogError } from '@/server/LogError' -import { UnconfirmedContributionRole } from './UnconfirmedContribution.role' +import { AbstractUnconfirmedContributionRole } from './AbstractUnconfirmedContribution.role' -export class UnconfirmedContributionUserRole extends UnconfirmedContributionRole { +export class UnconfirmedContributionUserRole extends AbstractUnconfirmedContributionRole { public constructor(contribution: Contribution, private updateData: ContributionArgs) { super(contribution, updateData.amount, new Date(updateData.creationDate)) } @@ -22,7 +22,7 @@ export class UnconfirmedContributionUserRole extends UnconfirmedContributionRole this.self.updatedBy = null } - protected checkAuthorization(user: User): UnconfirmedContributionRole { + protected checkAuthorization(user: User): AbstractUnconfirmedContributionRole { if (this.self.userId !== user.id) { throw new LogError('Can not update contribution of another user', this.self, user.id) }