From 79332c58e443a087d609d32b0ff06edf276d50ea Mon Sep 17 00:00:00 2001 From: einhornimmond Date: Thu, 8 Apr 2021 13:58:31 +0200 Subject: [PATCH] fix bug (deleted object but pointer not set to null) --- .../src/cpp/HTTPInterface/LoginPage.cpp | 24 ++++++++++--------- login_server/src/cpsp/login.cpsp | 2 ++ 2 files changed, 15 insertions(+), 11 deletions(-) diff --git a/login_server/src/cpp/HTTPInterface/LoginPage.cpp b/login_server/src/cpp/HTTPInterface/LoginPage.cpp index a617916e5..b7800d411 100644 --- a/login_server/src/cpp/HTTPInterface/LoginPage.cpp +++ b/login_server/src/cpp/HTTPInterface/LoginPage.cpp @@ -187,6 +187,7 @@ void LoginPage::handleRequest(Poco::Net::HTTPServerRequest& request, Poco::Net:: if(mSession) { getErrors(mSession); sm->releaseSession(mSession); + mSession = nullptr; } sm->deleteLoginCookies(request, response); break; @@ -272,6 +273,7 @@ void LoginPage::handleRequest(Poco::Net::HTTPServerRequest& request, Poco::Net:: if(mSession) { getErrors(mSession); sm->releaseSession(mSession); + mSession = nullptr; } sm->deleteLoginCookies(request, response); } @@ -340,11 +342,11 @@ void LoginPage::handleRequest(Poco::Net::HTTPServerRequest& request, Poco::Net:: responseStream << " "; // end include header.cpsp responseStream << "\n"; -#line 266 "F:\\Gradido\\gradido_stage2_local\\login_server\\src\\cpsp\\login.cpsp" +#line 268 "F:\\Gradido\\gradido_stage2_local\\login_server\\src\\cpsp\\login.cpsp" responseStream << ( getErrorsHtml() ); responseStream << "\n"; responseStream << "\n"; responseStream << "
\n"; @@ -378,22 +380,22 @@ void LoginPage::handleRequest(Poco::Net::HTTPServerRequest& request, Poco::Net:: responseStream << "\n"; responseStream << "
\n"; responseStream << "\t\t
\n"; responseStream << "\t\t\tgettext("E-Mail") ); responseStream << "\" value=\""; -#line 272 "F:\\Gradido\\gradido_stage2_local\\login_server\\src\\cpsp\\login.cpsp" +#line 274 "F:\\Gradido\\gradido_stage2_local\\login_server\\src\\cpsp\\login.cpsp" responseStream << ( presetEmail ); responseStream << "\"/>\n"; responseStream << "\t\t\tgettext("Password") ); responseStream << "\" />\n"; responseStream << "\t\t \n"; responseStream << "\t\t
\n"; @@ -401,22 +403,22 @@ void LoginPage::handleRequest(Poco::Net::HTTPServerRequest& request, Poco::Net:: responseStream << "
\n"; responseStream << "
\n"; responseStream << "\t

"; -#line 279 "F:\\Gradido\\gradido_stage2_local\\login_server\\src\\cpsp\\login.cpsp" +#line 281 "F:\\Gradido\\gradido_stage2_local\\login_server\\src\\cpsp\\login.cpsp" responseStream << ( langCatalog->gettext("You haven't any account yet? Please follow the link to create one.") ); responseStream << "

\n"; responseStream << "\t \n"; responseStream << "\t\t\t"; -#line 281 "F:\\Gradido\\gradido_stage2_local\\login_server\\src\\cpsp\\login.cpsp" +#line 283 "F:\\Gradido\\gradido_stage2_local\\login_server\\src\\cpsp\\login.cpsp" responseStream << ( langCatalog->gettext("Create New Account") ); responseStream << "\n"; responseStream << "\t\t \n"; responseStream << "\t
\n"; responseStream << "\t\t\n"; diff --git a/login_server/src/cpsp/login.cpsp b/login_server/src/cpsp/login.cpsp index bf050dd4e..8ee39315e 100644 --- a/login_server/src/cpsp/login.cpsp +++ b/login_server/src/cpsp/login.cpsp @@ -166,6 +166,7 @@ if(mSession) { getErrors(mSession); sm->releaseSession(mSession); + mSession = nullptr; } sm->deleteLoginCookies(request, response); break; @@ -251,6 +252,7 @@ if(mSession) { getErrors(mSession); sm->releaseSession(mSession); + mSession = nullptr; } sm->deleteLoginCookies(request, response); }